[jira] [Updated] (AMQNET-468) Fix misspellings of invalid
[ https://issues.apache.org/jira/browse/AMQNET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christoffer Sawicki updated AMQNET-468: --- Attachment: fix-misspellings-of-invalid.patch Fix misspellings of invalid - Key: AMQNET-468 URL: https://issues.apache.org/jira/browse/AMQNET-468 Project: ActiveMQ .Net Issue Type: Bug Reporter: Christoffer Sawicki Assignee: Jim Gomes Priority: Trivial Attachments: fix-misspellings-of-invalid.patch -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (AMQNET-468) Fix misspellings of invalid
Christoffer Sawicki created AMQNET-468: -- Summary: Fix misspellings of invalid Key: AMQNET-468 URL: https://issues.apache.org/jira/browse/AMQNET-468 Project: ActiveMQ .Net Issue Type: Bug Reporter: Christoffer Sawicki Assignee: Jim Gomes Priority: Trivial Attachments: fix-misspellings-of-invalid.patch -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (AMQNET-469) Add support for self-signed broker certificates
[ https://issues.apache.org/jira/browse/AMQNET-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christoffer Sawicki updated AMQNET-469: --- Attachment: add-support-for-self-signed-broker-certificates.patch Add support for self-signed broker certificates --- Key: AMQNET-469 URL: https://issues.apache.org/jira/browse/AMQNET-469 Project: ActiveMQ .Net Issue Type: Improvement Reporter: Christoffer Sawicki Assignee: Jim Gomes Attachments: add-support-for-self-signed-broker-certificates.patch ActiveMQ NMS does currently not support self-signed broker certificates since doing so requires a custom System.Net.Security.RemoteCertificateValidationCallback AFAIK. The attached patch adds the new configuration option brokerCertFilename to SslTransport(Factory) that when used enables an alternative RemoteCertificateValidationCallback that supports self-signed certificates through direct certificate comparison. Note #1: The patch does currently not include an automated test, but I'm willing to work on that if that's the only obstacle for integration. Note #2: Apache.NMS.Stomp could/should be patched the same way. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (AMQNET-469) Add support for self-signed broker certificates
Christoffer Sawicki created AMQNET-469: -- Summary: Add support for self-signed broker certificates Key: AMQNET-469 URL: https://issues.apache.org/jira/browse/AMQNET-469 Project: ActiveMQ .Net Issue Type: Improvement Reporter: Christoffer Sawicki Assignee: Jim Gomes Attachments: add-support-for-self-signed-broker-certificates.patch ActiveMQ NMS does currently not support self-signed broker certificates since doing so requires a custom System.Net.Security.RemoteCertificateValidationCallback AFAIK. The attached patch adds the new configuration option brokerCertFilename to SslTransport(Factory) that when used enables an alternative RemoteCertificateValidationCallback that supports self-signed certificates through direct certificate comparison. Note #1: The patch does currently not include an automated test, but I'm willing to work on that if that's the only obstacle for integration. Note #2: Apache.NMS.Stomp could/should be patched the same way. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (AMQ-4433) Socket parameters are not validated
[
https://issues.apache.org/jira/browse/AMQ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13714755#comment-13714755
]
Christoffer Sawicki commented on AMQ-4433:
--
Here's a new patch (with tests!) that addresses some of the missing validation:
https://github.com/qerub/activemq/commit/22776a2960231305674c70e795daec80db02ab69
https://github.com/qerub/activemq/commit/22776a2960231305674c70e795daec80db02ab69.patch
What do you think?
(I've forgotten exactly which cases were too hard to validate, but it includes
the transport.* sub-parameters.)
Socket parameters are not validated
---
Key: AMQ-4433
URL: https://issues.apache.org/jira/browse/AMQ-4433
Project: ActiveMQ
Issue Type: Bug
Reporter: Christoffer Sawicki
Priority: Minor
Attachments: 0001-Validate-socket-parameters.patch,
0002-Validate-connector-parameters.patch,
0003-Validate-transport-parameters.patch
Connect parameters are validated in every transport factory with a statement
like this:
{noformat}
if (!options.isEmpty()) {
throw new IllegalArgumentException(Invalid connect parameters: +
options);
}
{noformat}
Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
however never validated.
They are put away at
{noformat}
TcpTransportFactory.compositeConfigure(Transport, WireFormat, Map) line: 85
{noformat}
and then set at
{noformat}
TcpTransport.initialiseSocket(Socket) line: 428
{noformat}
where there is no check that {{socketOptions}} is empty after the call.
I've attached a patch (#1) that rectifies this.
Bonus: I found similar issues in the transport classes. See patch #2 and #3.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4428) Don't swallow errors in IntrospectionSupport.setProperty
[
https://issues.apache.org/jira/browse/AMQ-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13650069#comment-13650069
]
Christoffer Sawicki commented on AMQ-4428:
--
Further, I would suggest catching qualified exceptions rather than Throwable
[...]
I agree. Here's a {{s/Throwable/Exception/}} patch:
https://github.com/qerub/activemq/commit/0e09f1649a4cecb38476262a61f51acf578f64e3.patch
And here's an updated version of the original patch:
https://github.com/qerub/activemq/commit/2442b3311e7f069b93a619dd3a8821571d1d67b6.patch
(Remove .patch from URL for a prettier view.)
I have run the full ActiveMQ test suite with these changes and they generate no
spurious log messages.
Don't swallow errors in IntrospectionSupport.setProperty
Key: AMQ-4428
URL: https://issues.apache.org/jira/browse/AMQ-4428
Project: ActiveMQ
Issue Type: Bug
Reporter: Christoffer Sawicki
Priority: Minor
`setProperty` currently ends with `… catch (Throwable ignore) \{ return
false; \}`. This can make troubleshooting invalid configuration much harder
since the exception (that contains detailed information) is hidden from the
user.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4428) Don't swallow errors in IntrospectionSupport.setProperty
[
https://issues.apache.org/jira/browse/AMQ-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christoffer Sawicki updated AMQ-4428:
-
Attachment: (was:
0001-Log-errors-in-IntrospectionSupport.setProperty.patch)
Don't swallow errors in IntrospectionSupport.setProperty
Key: AMQ-4428
URL: https://issues.apache.org/jira/browse/AMQ-4428
Project: ActiveMQ
Issue Type: Bug
Reporter: Christoffer Sawicki
Priority: Minor
`setProperty` currently ends with `… catch (Throwable ignore) \{ return
false; \}`. This can make troubleshooting invalid configuration much harder
since the exception (that contains detailed information) is hidden from the
user.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4428) Don't swallow errors in IntrospectionSupport.setProperty
[
https://issues.apache.org/jira/browse/AMQ-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621998#comment-13621998
]
Christoffer Sawicki commented on AMQ-4428:
--
(I've found that a couple of those assertions are missing, but I've filed
another issue for that (AMQ-4433). I believe there is a problem even assuming
all assertions are in place.)
In the context of setProperty, properties/parameters can be invalid in two ways:
1. The property is missing on the target object. This situation happens a lot
during normal initialization and works fine as is.
2. The property does exist but calling the setter throws an exception. This is
the situation I believe is exceptional and should be logged. With working
assertions the property/parameter will be flagged as invalid, but the
exception—which contains information about why the property value is invalid—is
hidden from the user, making troubleshooting harder.
For reference:
https://github.com/apache/activemq/blob/trunk/activemq-client/src/main/java/org/apache/activemq/util/IntrospectionSupport.java#L160
I'll do some more research with the unit tests and get back to you.
Thanks for your time!
Don't swallow errors in IntrospectionSupport.setProperty
Key: AMQ-4428
URL: https://issues.apache.org/jira/browse/AMQ-4428
Project: ActiveMQ
Issue Type: Bug
Reporter: Christoffer Sawicki
Priority: Minor
Attachments: 0001-Log-errors-in-IntrospectionSupport.setProperty.patch
`setProperty` currently ends with `… catch (Throwable ignore) \{ return
false; \}`. This is really evil since it can make ActiveMQ ignore invalid
configuration completely silently. I think that errors should at least be
logged. (Is there any case when this isn't wanted?)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4428) Don't swallow errors in IntrospectionSupport.setProperty
[
https://issues.apache.org/jira/browse/AMQ-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christoffer Sawicki updated AMQ-4428:
-
Description: `setProperty` currently ends with `… catch (Throwable ignore)
\{ return false; \}`. This can make troubleshooting invalid configuration much
harder since the exception (that contains detailed information) is hidden from
the user. (was: `setProperty` currently ends with `… catch (Throwable ignore)
\{ return false; \}`. This is really evil since it can make ActiveMQ ignore
invalid configuration completely silently. I think that errors should at least
be logged. (Is there any case when this isn't wanted?))
Don't swallow errors in IntrospectionSupport.setProperty
Key: AMQ-4428
URL: https://issues.apache.org/jira/browse/AMQ-4428
Project: ActiveMQ
Issue Type: Bug
Reporter: Christoffer Sawicki
Priority: Minor
Attachments: 0001-Log-errors-in-IntrospectionSupport.setProperty.patch
`setProperty` currently ends with `… catch (Throwable ignore) \{ return
false; \}`. This can make troubleshooting invalid configuration much harder
since the exception (that contains detailed information) is hidden from the
user.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (AMQ-4433) Socket parameters are not validated
Christoffer Sawicki created AMQ-4433:
Summary: Socket parameters are not validated
Key: AMQ-4433
URL: https://issues.apache.org/jira/browse/AMQ-4433
Project: ActiveMQ
Issue Type: Bug
Reporter: Christoffer Sawicki
Priority: Minor
Connect parameters are validated in every transport factory with a statement
like this:
{noformat}
if (!options.isEmpty()) {
throw new IllegalArgumentException(Invalid connect parameters: + options);
}
{noformat}
Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
however never validated.
They are put away at
{noformat}
SslTransportFactory(TcpTransportFactory).compositeConfigure(Transport,
WireFormat, Map) line: 85
{noformat}
and then set at
{noformat}
SslTransport(TcpTransport).initialiseSocket(Socket) line: 428
{noformat}
where there is no check that {{socketOptions}} is empty after the call.
I've attached a patch that rectifies this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4433) Socket parameters are not validated
[
https://issues.apache.org/jira/browse/AMQ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christoffer Sawicki updated AMQ-4433:
-
Attachment: 0001-Validate-socket-parameters.patch
Socket parameters are not validated
---
Key: AMQ-4433
URL: https://issues.apache.org/jira/browse/AMQ-4433
Project: ActiveMQ
Issue Type: Bug
Reporter: Christoffer Sawicki
Priority: Minor
Attachments: 0001-Validate-socket-parameters.patch
Connect parameters are validated in every transport factory with a statement
like this:
{noformat}
if (!options.isEmpty()) {
throw new IllegalArgumentException(Invalid connect parameters: +
options);
}
{noformat}
Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
however never validated.
They are put away at
{noformat}
SslTransportFactory(TcpTransportFactory).compositeConfigure(Transport,
WireFormat, Map) line: 85
{noformat}
and then set at
{noformat}
SslTransport(TcpTransport).initialiseSocket(Socket) line: 428
{noformat}
where there is no check that {{socketOptions}} is empty after the call.
I've attached a patch that rectifies this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4433) Socket parameters are not validated
[
https://issues.apache.org/jira/browse/AMQ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christoffer Sawicki updated AMQ-4433:
-
Description:
Connect parameters are validated in every transport factory with a statement
like this:
{noformat}
if (!options.isEmpty()) {
throw new IllegalArgumentException(Invalid connect parameters: + options);
}
{noformat}
Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
however never validated.
They are put away at
{noformat}
TcpTransportFactory.compositeConfigure(Transport, WireFormat, Map) line: 85
{noformat}
and then set at
{noformat}
TcpTransport.initialiseSocket(Socket) line: 428
{noformat}
where there is no check that {{socketOptions}} is empty after the call.
I've attached a patch that rectifies this.
was:
Connect parameters are validated in every transport factory with a statement
like this:
{noformat}
if (!options.isEmpty()) {
throw new IllegalArgumentException(Invalid connect parameters: + options);
}
{noformat}
Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
however never validated.
They are put away at
{noformat}
SslTransportFactory(TcpTransportFactory).compositeConfigure(Transport,
WireFormat, Map) line: 85
{noformat}
and then set at
{noformat}
SslTransport(TcpTransport).initialiseSocket(Socket) line: 428
{noformat}
where there is no check that {{socketOptions}} is empty after the call.
I've attached a patch that rectifies this.
Socket parameters are not validated
---
Key: AMQ-4433
URL: https://issues.apache.org/jira/browse/AMQ-4433
Project: ActiveMQ
Issue Type: Bug
Reporter: Christoffer Sawicki
Priority: Minor
Attachments: 0001-Validate-socket-parameters.patch
Connect parameters are validated in every transport factory with a statement
like this:
{noformat}
if (!options.isEmpty()) {
throw new IllegalArgumentException(Invalid connect parameters: +
options);
}
{noformat}
Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
however never validated.
They are put away at
{noformat}
TcpTransportFactory.compositeConfigure(Transport, WireFormat, Map) line: 85
{noformat}
and then set at
{noformat}
TcpTransport.initialiseSocket(Socket) line: 428
{noformat}
where there is no check that {{socketOptions}} is empty after the call.
I've attached a patch that rectifies this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4433) Socket parameters are not validated
[
https://issues.apache.org/jira/browse/AMQ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christoffer Sawicki updated AMQ-4433:
-
Description:
Connect parameters are validated in every transport factory with a statement
like this:
{noformat}
if (!options.isEmpty()) {
throw new IllegalArgumentException(Invalid connect parameters: + options);
}
{noformat}
Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
however never validated.
They are put away at
{noformat}
TcpTransportFactory.compositeConfigure(Transport, WireFormat, Map) line: 85
{noformat}
and then set at
{noformat}
TcpTransport.initialiseSocket(Socket) line: 428
{noformat}
where there is no check that {{socketOptions}} is empty after the call.
I've attached a patch (#1) that rectifies this.
Bonus: I found similar issues in the transport classes. See patch #2 and #3.
was:
Connect parameters are validated in every transport factory with a statement
like this:
{noformat}
if (!options.isEmpty()) {
throw new IllegalArgumentException(Invalid connect parameters: + options);
}
{noformat}
Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
however never validated.
They are put away at
{noformat}
TcpTransportFactory.compositeConfigure(Transport, WireFormat, Map) line: 85
{noformat}
and then set at
{noformat}
TcpTransport.initialiseSocket(Socket) line: 428
{noformat}
where there is no check that {{socketOptions}} is empty after the call.
I've attached a patch that rectifies this.
Socket parameters are not validated
---
Key: AMQ-4433
URL: https://issues.apache.org/jira/browse/AMQ-4433
Project: ActiveMQ
Issue Type: Bug
Reporter: Christoffer Sawicki
Priority: Minor
Attachments: 0001-Validate-socket-parameters.patch,
0002-Validate-connector-parameters.patch,
0003-Validate-transport-parameters.patch
Connect parameters are validated in every transport factory with a statement
like this:
{noformat}
if (!options.isEmpty()) {
throw new IllegalArgumentException(Invalid connect parameters: +
options);
}
{noformat}
Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
however never validated.
They are put away at
{noformat}
TcpTransportFactory.compositeConfigure(Transport, WireFormat, Map) line: 85
{noformat}
and then set at
{noformat}
TcpTransport.initialiseSocket(Socket) line: 428
{noformat}
where there is no check that {{socketOptions}} is empty after the call.
I've attached a patch (#1) that rectifies this.
Bonus: I found similar issues in the transport classes. See patch #2 and #3.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4433) Socket parameters are not validated
[
https://issues.apache.org/jira/browse/AMQ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christoffer Sawicki updated AMQ-4433:
-
Attachment: 0003-Validate-transport-parameters.patch
0002-Validate-connector-parameters.patch
Socket parameters are not validated
---
Key: AMQ-4433
URL: https://issues.apache.org/jira/browse/AMQ-4433
Project: ActiveMQ
Issue Type: Bug
Reporter: Christoffer Sawicki
Priority: Minor
Attachments: 0001-Validate-socket-parameters.patch,
0002-Validate-connector-parameters.patch,
0003-Validate-transport-parameters.patch
Connect parameters are validated in every transport factory with a statement
like this:
{noformat}
if (!options.isEmpty()) {
throw new IllegalArgumentException(Invalid connect parameters: +
options);
}
{noformat}
Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
however never validated.
They are put away at
{noformat}
TcpTransportFactory.compositeConfigure(Transport, WireFormat, Map) line: 85
{noformat}
and then set at
{noformat}
TcpTransport.initialiseSocket(Socket) line: 428
{noformat}
where there is no check that {{socketOptions}} is empty after the call.
I've attached a patch (#1) that rectifies this.
Bonus: I found similar issues in the transport classes. See patch #2 and #3.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (AMQ-4428) Don't swallow errors in IntrospectionSupport.setProperty
Christoffer Sawicki created AMQ-4428:
Summary: Don't swallow errors in IntrospectionSupport.setProperty
Key: AMQ-4428
URL: https://issues.apache.org/jira/browse/AMQ-4428
Project: ActiveMQ
Issue Type: Bug
Reporter: Christoffer Sawicki
Priority: Minor
`setProperty` currently ends with `… catch (Throwable ignore) { return false;
}`. This is really evil since it can make ActiveMQ ignore invalid configuration
completely silently. I think that errors should at least be logged. (Is there
any case when this isn't wanted?)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4428) Don't swallow errors in IntrospectionSupport.setProperty
[
https://issues.apache.org/jira/browse/AMQ-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christoffer Sawicki updated AMQ-4428:
-
Attachment: 0001-Log-errors-in-IntrospectionSupport.setProperty.patch
Don't swallow errors in IntrospectionSupport.setProperty
Key: AMQ-4428
URL: https://issues.apache.org/jira/browse/AMQ-4428
Project: ActiveMQ
Issue Type: Bug
Reporter: Christoffer Sawicki
Priority: Minor
Attachments: 0001-Log-errors-in-IntrospectionSupport.setProperty.patch
`setProperty` currently ends with `… catch (Throwable ignore) { return false;
}`. This is really evil since it can make ActiveMQ ignore invalid
configuration completely silently. I think that errors should at least be
logged. (Is there any case when this isn't wanted?)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4428) Don't swallow errors in IntrospectionSupport.setProperty
[
https://issues.apache.org/jira/browse/AMQ-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christoffer Sawicki updated AMQ-4428:
-
Description: {{setProperty}} currently ends with {{ … catch (Throwable
ignore) \{ return false; \} }}. This is really evil since it can make ActiveMQ
ignore invalid configuration completely silently. I think that errors should at
least be logged. (Is there any case when this isn't wanted?) (was:
`setProperty` currently ends with `… catch (Throwable ignore) { return false;
}`. This is really evil since it can make ActiveMQ ignore invalid configuration
completely silently. I think that errors should at least be logged. (Is there
any case when this isn't wanted?))
Don't swallow errors in IntrospectionSupport.setProperty
Key: AMQ-4428
URL: https://issues.apache.org/jira/browse/AMQ-4428
Project: ActiveMQ
Issue Type: Bug
Reporter: Christoffer Sawicki
Priority: Minor
Attachments: 0001-Log-errors-in-IntrospectionSupport.setProperty.patch
{{setProperty}} currently ends with {{ … catch (Throwable ignore) \{ return
false; \} }}. This is really evil since it can make ActiveMQ ignore invalid
configuration completely silently. I think that errors should at least be
logged. (Is there any case when this isn't wanted?)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4428) Don't swallow errors in IntrospectionSupport.setProperty
[
https://issues.apache.org/jira/browse/AMQ-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christoffer Sawicki updated AMQ-4428:
-
Description: `setProperty` currently ends with `… catch (Throwable ignore)
\{ return false; \}`. This is really evil since it can make ActiveMQ ignore
invalid configuration completely silently. I think that errors should at least
be logged. (Is there any case when this isn't wanted?) (was: {{setProperty}}
currently ends with {{ … catch (Throwable ignore) \{ return false; \} }}. This
is really evil since it can make ActiveMQ ignore invalid configuration
completely silently. I think that errors should at least be logged. (Is there
any case when this isn't wanted?))
Don't swallow errors in IntrospectionSupport.setProperty
Key: AMQ-4428
URL: https://issues.apache.org/jira/browse/AMQ-4428
Project: ActiveMQ
Issue Type: Bug
Reporter: Christoffer Sawicki
Priority: Minor
Attachments: 0001-Log-errors-in-IntrospectionSupport.setProperty.patch
`setProperty` currently ends with `… catch (Throwable ignore) \{ return
false; \}`. This is really evil since it can make ActiveMQ ignore invalid
configuration completely silently. I think that errors should at least be
logged. (Is there any case when this isn't wanted?)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-2127) Allow configuring SSLParameters
[ https://issues.apache.org/jira/browse/AMQ-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619929#comment-13619929 ] Christoffer Sawicki commented on AMQ-2127: -- SSLContext only exposes read-access to its SSLParameters (because it returns a copy). This means that it's still not possible to configure SSLParameters. Please reconsider reopening this issue. Allow configuring SSLParameters --- Key: AMQ-2127 URL: https://issues.apache.org/jira/browse/AMQ-2127 Project: ActiveMQ Issue Type: Improvement Components: Broker Affects Versions: 5.2.0 Reporter: Dejan Bosanac Assignee: Dejan Bosanac Fix For: 5.x Allow configuring http://java.sun.com/javase/6/docs/api/javax/net/ssl/SSLParameters.html inside the sslContext and applying it to the socket -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (AMQ-2127) Allow configuring SSLParameters
[ https://issues.apache.org/jira/browse/AMQ-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619929#comment-13619929 ] Christoffer Sawicki edited comment on AMQ-2127 at 4/2/13 3:35 PM: -- SSLContext only exposes read-access to its SSLParameters (because it returns a copy). This means that it's still not possible to configure SSLParameters. Please consider reopening this issue. was (Author: qerub): SSLContext only exposes read-access to its SSLParameters (because it returns a copy). This means that it's still not possible to configure SSLParameters. Please reconsider reopening this issue. Allow configuring SSLParameters --- Key: AMQ-2127 URL: https://issues.apache.org/jira/browse/AMQ-2127 Project: ActiveMQ Issue Type: Improvement Components: Broker Affects Versions: 5.2.0 Reporter: Dejan Bosanac Assignee: Dejan Bosanac Fix For: 5.x Allow configuring http://java.sun.com/javase/6/docs/api/javax/net/ssl/SSLParameters.html inside the sslContext and applying it to the socket -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (AMQ-4409) Documentation is wrong about default value for wireFormat.tcpNoDelayEnabled
Christoffer Sawicki created AMQ-4409:
Summary: Documentation is wrong about default value for
wireFormat.tcpNoDelayEnabled
Key: AMQ-4409
URL: https://issues.apache.org/jira/browse/AMQ-4409
Project: ActiveMQ
Issue Type: Bug
Affects Versions: 5.8.0
Reporter: Christoffer Sawicki
Priority: Minor
http://activemq.apache.org/configuring-wire-formats.html states that the
default value for {{tcpNoDelayEnabled}} is false.
This contradicts what the debug logs says if I don't change the parameter:
{noformat}
12:10:06.827 DEBUG org.apache.activemq.transport.InactivityMonitor - Using min
of local: WireFormatInfo { version=9,
properties={MaxFrameSize=9223372036854775807, CacheSize=1024,
CacheEnabled=true, SizePrefixDisabled=false,
MaxInactivityDurationInitalDelay=1, TcpNoDelayEnabled=true,
MaxInactivityDuration=3, TightEncodingEnabled=true,
StackTraceEnabled=true}, magic=[A,c,t,i,v,e,M,Q]} and remote: WireFormatInfo {
version=9, properties={CacheSize=1024, MaxFrameSize=31337, CacheEnabled=true,
SizePrefixDisabled=false, TcpNoDelayEnabled=true,
MaxInactivityDurationInitalDelay=1, MaxInactivityDuration=15000,
TightEncodingEnabled=true, StackTraceEnabled=true}, magic=[A,c,t,i,v,e,M,Q]}
{noformat}
Note the {{TcpNoDelayEnabled=true}}!
This default value seems to come from
{{org/apache/activemq/openwire/OpenWireFormatFactory.java}} which states
{noformat}
private boolean tcpNoDelayEnabled = true;
{noformat}
I think that either the documentation or the code should be updated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
