[GitHub] activemq-nms-amqp issue #2: AMQNET-575: NMS AMQP Client Rework
Github user RagnarPaulson commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/2 Thanks Tim, All good feedback. I've cleaned up the comments and white space. Added a new sample, and improved some of the 'toString' methods used in debugging/development. ---
[GitHub] activemq-nms-amqp pull request #1: AMQNET-576: Clean out old code base for N...
Github user RagnarPaulson closed the pull request at: https://github.com/apache/activemq-nms-amqp/pull/1 ---
[GitHub] activemq-nms-amqp issue #1: AMQNET-576: Clean out old code base for NMS AMQP...
Github user RagnarPaulson commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/1 Per the last comment, and because the old repository is gone and a new one ready to replace it, I'm closing this pull request. ---
[GitHub] activemq-nms-amqp issue #2: AMQNET-575: NMS AMQP Client Rework
Github user RagnarPaulson commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/2 Got it. I've just pushed up the latest version. It still passes all the tests using ActiveMQ as a broker, so I believe i got all the namespace changes correct. ---
[GitHub] activemq-nms-amqp issue #2: AMQNET-575: NMS AMQP Client Rework
Github user RagnarPaulson commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/2 Thanks Tim, All good feedback. What is the process now? Should I commit my changes as a new commit, or quash it back into the original commit? Ragnar ---
[GitHub] activemq-nms-amqp issue #2: AMQNET-575: NMS AMQP Client Rework
Github user RagnarPaulson commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/2 Thanks. That seemed to work better. Shows up as one commit now in the pull request. ---
[GitHub] activemq-nms-amqp issue #2: AMQNET-575: NMS AMQP Client Rework
Github user RagnarPaulson commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/2 I've tried to follow the quash and rebase instructions outlined https://github.com/servo/servo/wiki/Beginner's-guide-to-rebasing-and-squashing But it's not clear to me that this made any difference to the pull request, quite possibly made it worse. ---
[GitHub] activemq-nms-amqp issue #2: AMQNET-575: NMS AMQP Client Rework
Github user RagnarPaulson commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/2 Good catch. In my eagerness to compress several commits into one pull request I lost the .gitignore and inadvertently committed all the binaries/output. I've removed them all now. ---
[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework
GitHub user RagnarPaulson opened a pull request: https://github.com/apache/activemq-nms-amqp/pull/2 AMQNET-575: NMS AMQP Client Rework Add an NMS API implememntation that wraps the AMQPnetLite .NET API. Signed-off-by: Ragnar Paulson You can merge this pull request into a Git repository by running: $ git pull https://github.com/RagnarPaulson/activemq-nms-amqp amqnet575 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-nms-amqp/pull/2.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2 commit 504750c831eeac9a80c18194032c78e65de01d35 Author: Ragnar Paulson Date: 2018-07-09T21:34:09Z AMQNET-575: NMS AMQP Client Rework Add an NMS API implememntation that wraps the AMQPnetLite .NET API. Signed-off-by: Ragnar Paulson ---
[GitHub] activemq-nms-amqp pull request #1: AMQNET-576: Clean out old code base for N...
GitHub user RagnarPaulson opened a pull request: https://github.com/apache/activemq-nms-amqp/pull/1 AMQNET-576: Clean out old code base for NMS AMQP client provider. The first step to replacing the NMS AMQP client with a fully managed client based on AMQPNetLite is to remove the old implementation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/RagnarPaulson/activemq-nms-amqp master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-nms-amqp/pull/1.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1 commit 303fcf360c3bf10c186108638ceb9b391b7e34a5 Author: Ragnar Paulson Date: 2018-05-22T18:40:31Z AMQNET-576: Clean out old code base for NMS AMQP client provider. ---
