[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/788#discussion_r79899253
--- Diff:
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis
---
@@ -105,6 +105,16 @@ if [ -z "$LOG_MANAGER" ] ; then
LOG_MANAGER="$ARTEMIS_HOME/lib/${logmanager}"
fi
+# determine which native library version to load
+LIBRARY_PATH="-Djava.library.path=\"$ARTEMIS_HOME/bin/lib"
+if [ "$(uname -m)" = "x86_64" ]; then
+ LIBRARY_PATH="$LIBRARY_PATH/linux-x86_64\""
+elif [ "$(uname -m)" = "i686" ]; then
+ LIBRARY_PATH="$LIBRARY_PATH/linux-i686\""
+else
+ LIBRARY_PATH=""
--- End diff --
If the user is on a Linux system then I would expect `uname -a` to return
`x86_64` or `i686`. My thought here was to avoid setting the library path for
systems where `uname -a` returned something other than what we support
out-of-the-box.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/788 ARTEMIS-732 loading wrong arch lib You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-732 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/788.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #788 commit 1f4a768b1bf58c1e5fd1b9e1df85ac94ae533037 Author: jbertram Date: 2016-09-21T17:41:22Z ARTEMIS-732 loading wrong arch lib --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #756: ARTEMIS-715 In rare circumstances MessageProduc...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/756 The first line of the commit is longer than 50 characters. This doesn't conform to the aforementioned format. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #756: [ARTEMIS-715] In rare circumstances MessageProd...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/756 The commit message should follow the 50/72 format as discussed in the [Hacking Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/code.md#typical-development-cycle). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #752: Fix test race condition
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/752 Fix test race condition You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/752.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #752 commit 4bece40706052b9a279037f92211610bdba4ec8d Author: jbertram Date: 2016-09-02T19:49:40Z Fix test race condition --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #747: ARTEMIS-711 Fix handling of 'bare' heade...
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/747#discussion_r77227583
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/util/Wait.java
---
@@ -41,13 +41,13 @@ public static boolean waitFor(final Condition
condition, final long duration) th
public static boolean waitFor(final Condition condition,
final long duration,
- final int sleepMillis) throws Exception {
--- End diff --
It's used by
org.apache.activemq.artemis.tests.integration.proton.ProtonTestForHeader#testSimpleBytes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #747: ARTEMIS-711 Fix handling of 'bare' heade...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/747 ARTEMIS-711 Fix handling of 'bare' header You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-711 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/747.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #747 commit 46e2197d8b1dab737a3ed0ac41c147bb36e3c99f Author: jbertram Date: 2016-06-13T18:37:24Z ARTEMIS-711 Fix handling of 'bare' header --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #743: ARTEMIS-699 group ID reaper tx bug
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/743 ARTEMIS-699 group ID reaper tx bug You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-699 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/743.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #743 commit 2e907fb8c2725f1a7c90ab258de6f98ea3bca43c Author: jbertram Date: 2016-08-25T21:27:16Z ARTEMIS-699 group ID reaper tx bug --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #736: Remove thread.sleep in JDBCTest
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/736 Is this related to a particular JIRA? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #741: ARTEMIS-702 JMS 2 spec violation for rec...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/741 ARTEMIS-702 JMS 2 spec violation for receiveBody You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-702 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/741.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #741 commit 6cf54ead5647ac72a70809514bef2e6011d041a5 Author: jbertram Date: 2016-08-29T15:42:01Z ARTEMIS-702 JMS 2 spec violation for receiveBody --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #739: Script to help compare old commits
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/739#discussion_r76647463 --- Diff: docs/hacking-guide/en/history.md --- @@ -19,3 +19,13 @@ Credit should be given to those developers who contributed to the HornetQ projec - Adrian Brock For more information please visit the [HornetQ GitHub project](https://github.com/hornetq/hornetq/tree/apache-donation). + + +Rebasing original donation +== + +It may be useful to look at the donation history combined with the artemis history at Artemis. It is the case when eventually looking at old changes. --- End diff -- Are you sure you meant to say, "artemis history at Artemis"? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #729: ARTEMIS-695 fix URI syntax in doc
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/729 ARTEMIS-695 fix URI syntax in doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-695 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/729.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #729 commit 457ae3defaa4f375818f0ffc3029932ee6233e86 Author: jbertram Date: 2016-08-22T17:34:31Z ARTEMIS-695 fix URI syntax in doc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #728: ARTEMIS-690 fix link in JMS doc
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/728 I updated the link and removed the . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #728: ARTEMIS-690 fix link in JMS doc
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/728 ARTEMIS-690 fix link in JMS doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-690 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/728.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #728 commit 109dc833a340b4d60ad0984a9773844624582188 Author: jbertram Date: 2016-08-22T17:11:50Z ARTEMIS-690 fix link in JMS doc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #727: ARTEMIS-686 shutdown external components
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/727 ARTEMIS-686 shutdown external components You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-686 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/727.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #727 commit 3fd9fbe2d0b8e9e1b29c31e6472da192e12329f6 Author: jbertram Date: 2016-08-19T18:58:32Z ARTEMIS-686 shutdown external components --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #724: [ARTEMIS-684] Client connection are not balance...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/724 I'm not sure I agree with this change since it will impact existing load-balancing semantics which users may depend on. Connection load-balancing is done per connection factory. Connection factory objects are meant to be re-used so load-balancing on a per connection factory basis is reasonable. It also gives users the flexibility of creating new connection factories in a single application and getting independent load-balancing from each. With this change that will no longer be possible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #720: SSL improvements
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/720 SSL improvements You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-656 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/720.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #720 commit b59cec6ed5408f097a5a4e3be1f25699fe673e56 Author: jbertram Date: 2016-08-11T19:32:56Z ARTEMIS-656 support host verification for SSL cert commit 8e83d2e0a6a2bfd7538d91d1418a0addb6156fa7 Author: jbertram Date: 2016-08-12T18:57:11Z ARTEMIS-577 log SSLHandshakeException root cause --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #718: just some refactorings
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/718 Also, you have 3 checkstyle violations: [ERROR] src/main/java/org/apache/activemq/artemis/integration/vertx/OutgoingVertxEventHandler.java:[21,8] (imports) UnusedImports: Unused import - java.util.concurrent.ScheduledExecutorService. [ERROR] src/main/java/org/apache/activemq/artemis/integration/vertx/OutgoingVertxEventHandler.java:[26,8] (imports) UnusedImports: Unused import - org.apache.activemq.artemis.core.persistence.StorageManager. [ERROR] src/main/java/org/apache/activemq/artemis/integration/vertx/IncomingVertxEventHandler.java:[20,8] (imports) UnusedImports: Unused import - java.util.concurrent.ScheduledExecutorService. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #718: just some refactorings
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/718 Can you squash those commits together so there's not a commit making the change and another commit undoing it? That's a bit messy. Also, your commit messages should follow the 50/72 format as outlined in the [Hacking Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/code.md#typical-development-cycle). It should also reference the JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #718: just some refactorings
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/718#discussion_r74492945
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/vertx/ActiveMQVertxUnitTest.java
---
@@ -282,19 +280,7 @@ public void testIncomingEvents() throws Exception {
assertEquals(aShort, recvShort);
//send a JsonObject
- String jsonObjectString = "{\n" +
- "\"Image\": {\n" +
- "\"Width\": 800,\n" +
- "\"Height\": 600,\n" +
- "\"Title\": \"View from 15th Floor\",\n" +
- "\"Thumbnail\": {\n" +
- "\"Url\":\"http://www.example.com/image/481989943\",\n"; +
- "\"Height\": 125,\n" +
- "\"Width\": 100\n" +
- "},\n" +
- "\"IDs\": [116, 943, 234, 38793]\n" +
- "}\n" +
- "}";
+ String jsonObjectString = "{\n" + "\"Image\": {\n" + "\"Width\":
800,\n" + "\"Height\": 600,\n" + "\"Title\": \"View from 15th Floor\",\n" +
"\"Thumbnail\": {\n" + "\"Url\":
\"http://www.example.com/image/481989943\",\n"; + "\"Height\": 125,\n" +
"\"Width\": 100\n" + "},\n" + "\"IDs\": [116, 943, 234, 38793]\n" + "}\n" +
"}";
--- End diff --
In my opinion, unwrapping these lines (and other like this) makes it harder
to read/change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #716: ARTEMIS-678 refactor log for expiry opti...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/716 ARTEMIS-678 refactor log for expiry optimization You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/716.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #716 commit ea57bf9c4cc75cf302479a03745ee2869ea17d13 Author: jbertram Date: 2016-08-10T19:12:44Z ARTEMIS-678 refactor log for expiry optimization --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #714: ARTEMIS-677 Support websocket subprotocol hands...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/714 NPE in org.apache.activemq.artemis.tests.unit.core.remoting.impl.netty.NettyAcceptorTest.testStartStop(). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #705: ARTEMIS-670 Adding destination creation and del...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/705 One concern I have is that I can't tell by the names if these commands are operating on JMS resources or core resources. Obviously there's no such thing as a core topic so I assume that the topic-related commands are operating on a JMS topic. However, core has a queue and JMS has a queue. If the commands are dealing with JMS resources then I think the might need to reflect that to avoid confusion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #701: ARTEMIS-592 finer-grained security for queues
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/701 The original use-case was related to Stomp durable subscriptions which in core terms is simply a durable, non-temporary queue. Our Stomp implementation allows individual Stomp clients to connect to the same durable subscription by connecting with the same client-id and durable-subscription-name values, hence "sharing" the subscription. The danger here is that a client which should not be allowed to connect to the durable subscription would in fact connect to it and essentially steal messages from the legitimate client. However, by enforcing security on the individual queue that situation can be avoided. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #701: ARTEMIS-592 finer-grained security for queues
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/701 @clebertsuconic, was your question for me or @mtaylor? If it's for me can you elaborate a bit more. I'm not clear on what you're asking. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #703: ARTEMIS-601 + logger fixes
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/703 ARTEMIS-601 + logger fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-601 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/703.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #703 commit 85857ab8eb1b1eca2498306239740e0e39d2acd4 Author: jbertram Date: 2016-08-04T21:23:59Z Fix improper IDs in logger commit 6d7e1f92aeb807c5234638519fdce456834cc9c3 Author: jbertram Date: 2016-08-03T22:27:26Z ARTEMIS-601 load runtime security cfg file changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #701: ARTEMIS-592 finer-grained security for queues
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/701 There's no way to eliminate the user's need to understand how non-core protocols map to the core implementation. We have addresses and queues and just about all the configuration and management details relate to those two resources. Also, a "subscription" isn't really a core idea. In core, a "subscription" is just a queue. Core and JMS clients can already "share" queues. I understand the need for users to control access to individual queues which are mapped to the same address (which is what this PR is meant to address). I don't understand the whole "shared subscription" use-case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #701: ARTEMIS-529 finer-grained security for q...
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/701
ARTEMIS-529 finer-grained security for queues
This was the simplest way I could think of to implement this feature. It
allows a security-setting to match to a particular queue by using the syntax
"." in the match. For example, if two queues A & B each
mapped to the same address Z each queue could have independent
security-settings by matching "Z.A" and "Z.B".
If people are in favor of this implementation then I will write up some
documentation and squash that with this commit so don't merge this until there
is a satisfactory consensus and docs are written (if necessary).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-592
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/701.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #701
commit 7f59eac04aad997cba1fc1cd6c9fd14527001fd9
Author: jbertram
Date: 2016-07-02T02:18:06Z
ARTEMIS-529 finer-grained security for queues
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #697: Fix ExtraStompTest
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/697 Fix ExtraStompTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/697.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #697 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #696: Fix AcceptorControlUsingCoreTest
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/696 Fix AcceptorControlUsingCoreTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/696.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #696 commit a69ce7bc813631a953b81800c2ce62717356bf18 Author: jbertram Date: 2016-08-02T17:56:01Z Fix AcceptorControlUsingCoreTest --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #692: JSON fixes
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/692 JSON fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis JSONfixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/692.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #692 commit 73e9f09094530df8517da6b10e35e689f156573a Author: jbertram Date: 2016-07-28T18:33:04Z ARTEMIS-565 fix TopicControlUsingJMSTest commit 56132726d3071752ec20d854c3169570a2e5a01e Author: jbertram Date: 2016-08-01T15:07:50Z ARTEMIS-565 fix ManagementHelperTest --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #681: ARTEMIS-565 fix TopicControlUsingJMSTest
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/681 ARTEMIS-565 fix TopicControlUsingJMSTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis JSONfixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/681.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #681 commit 73e9f09094530df8517da6b10e35e689f156573a Author: jbertram Date: 2016-07-28T18:33:04Z ARTEMIS-565 fix TopicControlUsingJMSTest --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #678: ARTEMIS-405 more bits of JMX doc
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/678 ARTEMIS-405 more bits of JMX doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-405 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/678.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #678 commit 52b31f5d1a46132758297c0b89fa94a8e6617f5a Author: jbertram Date: 2016-07-28T14:18:13Z ARTEMIS-405 more bits of JMX doc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #677: ARTEMIS-565 additional JSON fixes
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/677#discussion_r72638984
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/JsonUtil.java
---
@@ -295,6 +295,13 @@ else if (jsonValue == JsonValue.FALSE) {
return jsonValue.toString();
}
}
+ else if (jsonValue instanceof Object[]) {
+ Object[] array = (Object[]) jsonValue;
+ for (int i = 0; i < array.length; i++) {
+array[i] = convertJsonValue(array[i], desiredType);
--- End diff --
Yes, I added this because of a real failure. The method wouldn't handle
Object[] before this so would fail for management methods that returned, e.g.
String[].
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #677: ARTEMIS-595 additional JSON fixes
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/677#discussion_r72633668
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/JsonUtil.java
---
@@ -295,6 +295,13 @@ else if (jsonValue == JsonValue.FALSE) {
return jsonValue.toString();
}
}
+ else if (jsonValue instanceof Object[]) {
+ Object[] array = (Object[]) jsonValue;
+ for (int i = 0; i < array.length; i++) {
+array[i] = convertJsonValue(array[i], desiredType);
--- End diff --
The use case for this that I've seen are management methods that return
stuff like String[]. That said, I see your point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #677: ARTEMIS-595 additional JSON fixes
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/677 ARTEMIS-595 additional JSON fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis JSONfixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/677.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #677 commit aa0d7b6d013763c97b24896ef1164f7ad6271e66 Author: jbertram Date: 2016-07-27T20:07:39Z ARTEMIS-595 additional JSON fixes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #676: ARTEMIS-569 correct method spelling
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/676 ARTEMIS-569 correct method spelling You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/676.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #676 commit 9b40e84c0642a7554ad826db806462cc1fe8b333 Author: jbertram Date: 2016-07-28T13:12:57Z ARTEMIS-569 correct method spelling --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #674: ARTEMIS-647 track 'killed' msg count on ...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/674 ARTEMIS-647 track 'killed' msg count on queue A 'killed' message is one that has been sent to a dead-letter address or otherwise removed from the queue due to exceeding the max delivery attempts. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-647 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/674.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #674 commit 61bce8f583404dbd00c801767eebac0e2522a614 Author: jbertram Date: 2016-07-27T15:04:37Z ARTEMIS-647 track 'killed' msg count on queue A 'killed' message is one that has been sent to a dead-letter address or otherwise removed from the queue due to exceeding the max delivery attempts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #673: ARTEMIS-565 more JSON fixes
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/673 ARTEMIS-565 more JSON fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis JSONfixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/673.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #673 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #671: ARTEMIS-646 track expired msg count on q...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/671 ARTEMIS-646 track expired msg count on queue You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-646 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/671.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #671 commit 32abe61876d388b6d1208de8f74968d86be24872 Author: jbertram Date: 2016-07-26T21:06:01Z ARTEMIS-646 track expired msg count on queue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #669: ARTEMIS-565 fix more broken Json stuff
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/669 ARTEMIS-565 fix more broken Json stuff You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/669.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #669 commit 6a0942cbe83a6f4743b9c362611d36d9560a668b Author: jbertram Date: 2016-07-26T16:11:07Z ARTEMIS-565 fix more broken Json stuff --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #662: ARTEMIS-587 add more JSON JMX mgmt methods to c...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/662 I rebased this on John's recent JSON changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/640 You need to rebase. That issue was resolved last week I believe. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #662: ARTEMIS-587 add more JSON JMX mgmt metho...
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/662#discussion_r72130781
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
---
@@ -1360,6 +1359,130 @@ public String listProducersInfoAsJSON() throws
Exception {
}
@Override
+ public String listConnectionsAsJSON() throws Exception {
+ checkStarted();
+
+ clearIO();
+
+ try {
+ JSONArray array = new JSONArray();
+
+ Set connections =
server.getRemotingService().getConnections();
+
+ for (RemotingConnection connection : connections) {
--- End diff --
That's fine with me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #662: ARTEMIS-587 add more JSON JMX mgmt metho...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/662 ARTEMIS-587 add more JSON JMX mgmt methods to core You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-587 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/662.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #662 commit cc540302ae5fbfe9313806dc2e28421bc4b118f3 Author: jbertram Date: 2016-07-22T22:37:27Z ARTEMIS-587 add more JSON JMX mgmt methods to core --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #661: ARTEMIS-628 Adding back old constructor ...
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/661#discussion_r72120144 --- Diff: README.md --- @@ -44,4 +44,7 @@ If you are trying to copy the examples somewhere else and modifying them. Consid # if trying to modify the 'topic' example: cd examples/jms/topic && mvn dependency:list +### The HornetQ Donation --- End diff -- What's this for? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #657: ARTEMIS-650 clarify doc, use TTL default...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/657 ARTEMIS-650 clarify doc, use TTL default for 0 heartbeat You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-611 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/657.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #657 commit 62922cd263b9a2fefadf84a28364946f48b7efd2 Author: jbertram Date: 2016-07-24T19:44:23Z ARTEMIS-650 clarify doc, use TTL default for 0 heartbeat --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #656: ARTEMIS-650 clarify doc, use TTL default...
Github user jbertram closed the pull request at: https://github.com/apache/activemq-artemis/pull/656 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #656: ARTEMIS-611 clarify doc, use TTL default...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/656 ARTEMIS-611 clarify doc, use TTL default for 0 heartbeat You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-611 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/656.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #656 commit 5b4d979512a1582033f1ae0cd2a27c0108f91348 Author: jbertram Date: 2016-07-24T19:44:23Z ARTEMIS-611 clarify doc, use TTL default for 0 heartbeat --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #641: Update version of netty4
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/641 I sent a PR to deal with the regression. See https://github.com/apache/activemq-artemis/pull/655. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #655: Fix ByteBuffer regression from Netty upg...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/655 Fix ByteBuffer regression from Netty upgrade Using array() is a bit dangerous as it's an optional part of any ByteBuffer implementation. This new method will deal with various ByteBuffer implementations appropriately. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/655.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #655 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #653: ARTEMIS-548 Stomp durable sub unsubscrbe
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/653 There's a handful of Stomp subscriber tests running without issues. Can you clarify a bit on what is broken. If you can outline a specific use-case then I can write a test for it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #641: Update version of netty4
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/641 I think the Netty upgrade may have broken a bunch of the large-message tests. See https://builds.apache.org/job/ActiveMQ-Artemis-Nightly-Regression-Test/582/. I get failures in org.apache.activemq.artemis.tests.integration.client.LargeMessageCompressTest when I run locally as well, but if I put the Netty version back to 4.0.32.Final all the tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #654: ARTEMIS-413 doc for Stomp durable subs
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/654 ARTEMIS-413 doc for Stomp durable subs You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-413 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/654.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #654 commit a6fd65cd9d00e002a0e3a9c5368c39a0b7471ef9 Author: jbertram Date: 2016-07-21T18:45:47Z ARTEMIS-413 doc for Stomp durable subs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #653: ARTEMIS-548 Stomp durable sub unsubscrbe
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/653 ARTEMIS-548 Stomp durable sub unsubscrbe Implement ability for Stomp clients to unsubscribe durable subscriptions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-548 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/653.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #653 commit b6a026bbc5a8df326798bb32ce9f2c5548e1d8cb Author: jbertram Date: 2016-07-21T19:10:04Z ARTEMIS-548 Stomp durable sub unsubscrbe Implement ability for Stomp clients to unsubscribe durable subscriptions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #651: ARTEMIS-405 more docs for JMS destinatio...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/651 ARTEMIS-405 more docs for JMS destinations You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-405 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/651.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #651 commit a5642b5e3481c39d4be862f024e7f359563a60e0 Author: jbertram Date: 2016-07-20T21:44:00Z ARTEMIS-405 more docs for JMS destinations --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #650: ARTEMIS-611 fix logging
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/650 ARTEMIS-611 fix logging You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-611 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/650.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #650 commit 7f3108ec9c9e3bf02aaf5a299a2733d192ccabf2 Author: jbertram Date: 2016-07-20T17:10:34Z ARTEMIS-611 fix logging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #646: ARTEMIS-234 fix content-length for Stomp...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/646 ARTEMIS-234 fix content-length for Stomp 1.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-234 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/646.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #646 commit dc964e1dbd669ccad8224f824c02c2f4e16c0091 Author: jbertram Date: 2016-07-19T21:09:06Z ARTEMIS-234 fix content-length for Stomp 1.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #643: ARTEMIS-611 refactor STOMP cxn TTL + hea...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/643 ARTEMIS-611 refactor STOMP cxn TTL + heart-beat You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-611 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/643.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #643 commit dc76e2a6a00964990fa50ec091d96473616aba87 Author: jbertram Date: 2016-07-18T21:34:22Z ARTEMIS-640 Allow config of cxn TTL check interval Add connection-ttl-check-interval configuration attribute to allow control of how frequently connection TTL checks are performed. commit f66472b1f319f79785649ae5c0bb8faa661da7d0 Author: jbertram Date: 2016-07-15T13:36:24Z ARTEMIS-611 refactor STOMP cxn TTL + heart-beat Adds 3 new URI properties for STOMP acceptors to allow finer grained configuration of heart-beat / connection-TTL behavior. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #639: ARTEMIS-631 log invalid filter trace at ...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/639 ARTEMIS-631 log invalid filter trace at DEBUG You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-631 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/639.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #639 commit fd31e4231dfa801c47bb186be9774c40804c5ee7 Author: jbertram Date: 2016-07-15T13:52:53Z ARTEMIS-631 log invalid filter trace at DEBUG --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #633: ARTEMIS-573 clarify filter documentation
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/633 ARTEMIS-573 clarify filter documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-573 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/633.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #633 commit 9e107f0affd9a49a2eb39cdef24b1257b3fbcd27 Author: jbertram Date: 2016-07-13T20:47:24Z ARTEMIS-573 clarify filter documentation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #630: ARTEMIS-628 add BROWSE role
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/630 Failed PR tests succeed locally. It looks like there's a port conflict on the Apache CI hardware. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #630: ARTEMIS-628 add BROWSE role
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/630 ARTEMIS-628 add BROWSE role You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-628 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/630.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #630 commit a31db6c2f5f85eb9e074b9f0d00271478078e861 Author: jbertram Date: 2016-07-12T19:13:32Z ARTEMIS-628 add BROWSE role --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #629: ARTEMIS-626 re-use context for LDAP
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/629 ARTEMIS-626 re-use context for LDAP You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-626 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/629.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #629 commit f3a8619d7eeabded75f3725f2e77af267e8cb450 Author: jbertram Date: 2016-07-11T18:07:35Z ARTEMIS-626 re-use context for LDAP --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #628: ARTEMIS-620 clean up large messages
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/628 ARTEMIS-620 clean up large messages You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-620 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/628.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #628 commit 6cafaadf64013f5d03de60e51456f8ecd597d73b Author: jbertram Date: 2016-07-11T14:46:08Z ARTEMIS-620 clean up large messages --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #626: ARTEMIS-619 stop components along with s...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/626 ARTEMIS-619 stop components along with server You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-619 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/626.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #626 commit 17cf45ad4f20a82fc251bab291962c607f1b3d15 Author: jbertram Date: 2016-07-08T18:23:04Z ARTEMIS-619 stop components along with server --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #624: ARTEMIS-584 fix test
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/624 ARTEMIS-584 fix test You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/624.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #624 commit ab48c31a2be9de4c0512f0f7e090c6939e1d8c2a Author: jbertram Date: 2016-07-06T21:34:53Z ARTEMIS-584 fix test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #621: ARTEMIS-584 add validated user to msg
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/621#discussion_r69742648 --- Diff: docs/user-manual/en/security.md --- @@ -10,6 +10,13 @@ long. To change this period set the property `security-invalidation-interval`, which is in milliseconds. The default is `1` ms. +To assist in security auditing the `populate-validated-user` option exists. If this is `true` then +the server will add the name of the validated user to the message using the key `_AMQ_VALIDATED_USER`. +For JMS and Stomp clients this is mapped to the key `JMSXUserID`. For users authenticated based on +their SSL certificate this name is the name to which their certificate's DN maps. If `security-enabled` +is `false` and `populate-validated-user` is `true` then the server will simply use whatever user name +(if any) the client provides. This option is `false` by default. + --- End diff -- Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #622: ARTEMIS-578 cert authn/z for STOMP
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/622#discussion_r69647599 --- Diff: artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/v11/StompFrameHandlerV11.java --- @@ -16,6 +16,7 @@ */ package org.apache.activemq.artemis.core.protocol.stomp.v11; +import javax.security.cert.X509Certificate; --- End diff -- This was implemented on core via https://issues.apache.org/jira/browse/ARTEMIS-261. This PR is just for Stomp. I believe other protocols will need to be examined on an individual basis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #622: ARTEMIS-578 cert authn/z for STOMP
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/622 ARTEMIS-578 cert authn/z for STOMP You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-578 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/622.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #622 commit e706fb899631a37e8bf7ef50fd7e6c76f9215eec Author: jbertram Date: 2016-06-21T17:03:16Z ARTEMIS-578 cert authn/z for STOMP --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #621: ARTEMIS-584 add validated user to msg
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/621 ARTEMIS-584 add validated user to msg Implements a new feature to aid in security auditing by adding the name of the validated user to the messages it sends. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-584 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/621.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #621 commit 1a6bd8863c56bd3c6c8817261fa5afa738a444f1 Author: jbertram Date: 2016-06-29T02:33:44Z ARTEMIS-584 add validated user to msg Implements a new feature to aid in security auditing by adding the name of the validated user to the messages it sends. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #621: ARTEMIS-584 add validated user to msg
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/621 I ran the full test-suite. There were no new failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #619: ARTEMIS-610 update clientFailureCheckPer...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/619 ARTEMIS-610 update clientFailureCheckPeriod doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-610 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/619.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #619 commit fd49dc99d193ecab25c54a6dbd96adaecd6f3d7a Author: jbertram Date: 2016-07-05T16:33:16Z ARTEMIS-610 update clientFailureCheckPeriod doc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #617: ARTEMIS-607 Added interceptor support for MQTT ...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/617 Could you squash these two commits together? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #613: ARTEMIS-602 Fix REST examples
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/613#discussion_r69371083 --- Diff: examples/features/standard/rest/dup-send/README.txt --- @@ -1,5 +1,5 @@ System Requirements: -You will need JDK 1.6 and Maven to run this example. This example has been tested with Maven 2.2.1. It may or may not work +You will need JDK 1.8 and Maven to run this example. This example has been tested with Maven 3.3.3. It may or may not work --- End diff -- Are we stuck on 1.7? It's been EOL for over a year now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #615: ARTEMIS-598 fix native logger code
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/615 ARTEMIS-598 fix native logger code You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-598 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/615.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #615 commit 2a144bc4eec59390bc792bcba75992a7db4787b4 Author: jbertram Date: 2016-07-01T20:14:15Z ARTEMIS-598 fix native logger code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #613: ARTEMIS-602 Fix REST examples
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/613 I sorted the dependency issue out, and I also ran the PR check on my local machine since the Apache CI seems to be flaky right now. It passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #613: ARTEMIS-602 Fix REST examples
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/613 The PR test build fails with: [ERROR] Failed to execute goal on project artemis-web: Could not resolve dependencies for project org.apache.activemq:artemis-web:jar:1.4.0-SNAPSHOT: Could not find artifact org.eclipse.jetty.aggregate:jetty-all:jar:9.3.10.v20160621 in central (http://repo.maven.apache.org/maven2) -> [Help 1] However, the dependency is there at http://repo.maven.apache.org/maven2/org/eclipse/jetty/aggregate/jetty-all/9.3.10.v20160621/ so I don't understand what the problem is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #613: ARTEMIS-602 Fix REST examples
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/613 ARTEMIS-602 Fix REST examples You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis restExamples Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/613.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #613 commit 2bd7edacb362ecfe574d0a04baea6f6da056b7f4 Author: jbertram Date: 2016-06-30T18:04:04Z ARTEMIS-602 Fix REST examples --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #611: ARTEMIS-602 fix web.xml examples for RES...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/611 ARTEMIS-602 fix web.xml examples for REST You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/611.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #611 commit 72cf38ae4003004f7fe9e21cd9024155d8eb279c Author: jbertram Date: 2016-06-30T15:29:28Z ARTEMIS-602 fix web.xml examples for REST --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #608: ARTEMIS-602 update pom info for REST WAR
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/608 ARTEMIS-602 update pom info for REST WAR You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/608.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #608 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #605: ARTEMIS-569 add missing method
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/605 ARTEMIS-569 add missing method This should fix the test failing in the test-suite. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-569 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/605.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #605 commit 1f1c43dcc8081a5996263f12a6b5d7dd38f63c07 Author: jbertram Date: 2016-06-27T21:41:59Z ARTEMIS-569 add missing method --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #604: ARTEMIS-593 + small fix for ARTEMIS-322
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/604 ARTEMIS-593 + small fix for ARTEMIS-322 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-593 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/604.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #604 commit 146bce08ccbf713cfbe7aa56632da5d0eafe0c4e Author: jbertram Date: 2016-06-25T03:05:08Z ARTEMIS-593 clarify STOMP websocket support commit aeafc6a974230c4850bea78e863790061e5a6521 Author: jbertram Date: 2016-06-27T19:25:14Z ARTEMIS-322 fix spurious exception --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #603: ARTEMIS-569 fix test failure
Github user jbertram closed the pull request at: https://github.com/apache/activemq-artemis/pull/603 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #601: ARTEMIS-596 fix JMS bridge example
Github user jbertram closed the pull request at: https://github.com/apache/activemq-artemis/pull/601 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #603: ARTEMIS-569 fix test failure
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/603 ARTEMIS-569 fix test failure You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-569 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/603.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #603 commit e693319c74811d9a27308fd79e3ecab0a7033b66 Author: jbertram Date: 2016-06-27T15:56:23Z ARTEMIS-569 fix test failure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #601: ARTEMIS-596 fix JMS bridge example
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/601 ARTEMIS-596 fix JMS bridge example You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/601.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #601 commit dbaf46376b1f550b3fa7bd52ccb0cc39215ff552 Author: jbertram Date: 2016-06-24T19:36:51Z ARTEMIS-596 fix JMS bridge example --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #600: ARTEMIS-569 fix bridge producerWindowSiz...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/600 ARTEMIS-569 fix bridge producerWindowSize Something bizarre happened with commit 8f52a622d0d883ca5e9f60ba7754ed51de38cc5c in April 2015. It reverted the changes from both ccc156684b15938ab3f8e34df9f4b64f57c4 and ada112a6a37dce8ddf48e2238904421b2ca8e0dc. This commit fixes that. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-569 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/600.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #600 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #597: [ARTEMIS-595] When creating JMS bridge manageme...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/597 Go ahead and close this PR please. Tom sent https://github.com/apache/activemq-artemis/pull/599 which has (most of) the appropriate changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #595: [ARTEMIS-591] Wrong XAException return code whe...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/595 Can you add a test to your commit which verifies the proper exception code is returned in the case of a timeout? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #597: [ARTEMIS-595] When creating JMS bridge manageme...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/597 Commit messages should follow the 50/72 pattern as noted in the "Commit Messages" section on http://activemq.apache.org/artemis/docs/1.3.0/hacking-guide/maintainers.html. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #596: ARTEMIS-577 clarify SSL handshake failur...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/596 ARTEMIS-577 clarify SSL handshake failure log You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-577 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/596.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #596 commit 40cbb6448c97002e9b310437fbcbc3871d148bc1 Author: jbertram Date: 2016-06-23T19:51:15Z ARTEMIS-577 clarify SSL handshake failure log --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #594: ARTEMIS-579 document reload for JAAS mod...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/594 ARTEMIS-579 document reload for JAAS modules You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-579 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/594.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #594 commit e1b6393f70732bdadaa9df5058efbedb7883d824 Author: jbertram Date: 2016-06-20T18:40:30Z ARTEMIS-579 document reload for JAAS modules --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #588: ARTEMIS-563 update POODLE message
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/588#discussion_r67690084
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
---
@@ -309,6 +309,12 @@ void slowConsumerDetected(String sessionID,
@Message(id = 221052, value = "trying to deploy topic {0}", format =
Message.Format.MESSAGE_FORMAT)
void deployTopic(SimpleString topicName);
+ @LogMessage(level = Logger.Level.INFO)
--- End diff --
The ID of the message is tied to the "level" of the message per the JavaDoc
on the class. Therefore since the level changed the ID changed as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #589: ARTEMIS-409 clarify STOMP login failure ...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/589 ARTEMIS-409 clarify STOMP login failure response You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-409 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/589.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #589 commit eb785b419495562e0a11f2f668dd96c553457430 Author: jbertram Date: 2016-05-24T15:46:14Z ARTEMIS-409 clarify STOMP login failure response --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #588: ARTEMIS-563 update POODLE message
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/588 ARTEMIS-563 update POODLE message You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-563 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/588.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #588 commit 965033d2029885a596a0501bb8ccc329272d7195 Author: jbertram Date: 2016-06-17T21:20:57Z ARTEMIS-563 update POODLE message --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #585: ARTEMIS-529 support dual auth
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/585 ARTEMIS-529 support dual auth A new feature whereby 2-way SSL connections can be authenticated differently than non-SSL connections. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-529 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/585.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #585 commit b3a554dcf6f108a8aa8211f6a77ed5b64c79ca8d Author: jbertram Date: 2016-05-26T14:18:11Z ARTEMIS-529 support dual auth A new feature whereby 2-way SSL connections can be authenticated differently than non-SSL connections. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #573: Fix possible leaks in LDAP tests
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/573 The issue with the threads is that org.apache.directory.server.core.integ.FrameworkRunner which is being used for @RunWith is managing the LDAP server and I believe by the time the thread check executes the LDAP server hasn't been shutdown completely. If we want to keep the thread checker then I think we'll have to find another way to manage the LDAP server. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #573: Fix possible leaks in LDAP tests
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/573 Fix possible leaks in LDAP tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/573.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #573 commit f68fdb2c4e1e56dfbb6ccbc048f77221844df5d3 Author: jbertram Date: 2016-06-08T19:09:58Z Fix possible leaks in LDAP tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #564: Update embedded docs/example
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/564 Update embedded docs/example You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/564.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #564 commit 1e28b3e7e7f7263744c55e106ae4feed50a5f94c Author: jbertram Date: 2016-06-06T22:00:00Z Update embedded docs/example --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
