[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 Jenkins looking good. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @clebertsuconic @mtaylor turns out I compared a String address with SimpleString, which always return false. Fixed that and added a simple test. Jenkins for the moment seems down, I'll kick off a build when it's back. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @clebertsuconic sure I'll take care of it. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @gaohoward actually, the example managmeent is broken after this. Can you look please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @mtaylor I will let you merge this.. but this PR is +1 from me.. nice job @gaohoward --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 There might be a problem with Jenkins machine, the failure relates to 'memory allocation'. Not related to my PR. @clebertsuconic I ran the whole test suite on my local machine, there are few test failures but none of them related to my PR. They failed both with and without my PR. (I'll investigate those failures further when I got time). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 Please. While the whole testsuite ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 OK, I removed the garbage files and reverted AmqpSendReceiveTest. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 guys please hold on this commit, I found some garbage files need to remove. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @clebertsuconic @mtaylor This is a resubmit of FQQN PR, with all tests fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
