[GitHub] activemq-artemis issue #2228: ARTEMIS-2017 SelectorParser cache not thread-s...

2018-08-09 Thread michaelandrepearce 
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2228
  
LGTM


---

[GitHub] activemq-artemis issue #2228: ARTEMIS-2017 SelectorParser cache not thread-s...

2018-08-08 Thread jbertram 
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/2228
  
@clebertsuconic, I updated to protect `get()` as well.


---

[GitHub] activemq-artemis issue #2228: ARTEMIS-2017 SelectorParser cache not thread-s...

2018-08-08 Thread clebertsuconic 
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2228
  
shouldn't you also protected get? I don't think it's thread safe.



---