[GitHub] activemq-artemis issue #2420: Allow configuration of RMI registry port

2018-11-09 Thread jbertram 
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/2420
  
Just for the record...I opened a JIRA for this, squashed your commits, and 
referenced the JIRA in the commit message.  Thanks for the contribution, 
@jsmucr!


---

[GitHub] activemq-artemis issue #2420: Allow configuration of RMI registry port

2018-11-09 Thread jsmucr 
Github user jsmucr commented on the issue:

https://github.com/apache/activemq-artemis/pull/2420
  
There, it's done. :) The way I had to test the port usage is nasty, sorry 
for that. Maybe someone will come up with something a little more 
straightforward.


---

[GitHub] activemq-artemis issue #2420: Allow configuration of RMI registry port

2018-11-07 Thread jsmucr 
Github user jsmucr commented on the issue:

https://github.com/apache/activemq-artemis/pull/2420
  
Okay. :) 


---

[GitHub] activemq-artemis issue #2420: Allow configuration of RMI registry port

2018-11-07 Thread michaelandrepearce 
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2420
  
@jsmucr maybe then an integration test to prove it, and also to make sure 
if it does work. No one breaks it on you


---

[GitHub] activemq-artemis issue #2420: Allow configuration of RMI registry port

2018-11-07 Thread jsmucr 
Github user jsmucr commented on the issue:

https://github.com/apache/activemq-artemis/pull/2420
  
I think you mean something like this, right?
```JAVA_ARGS="$JAVA_ARGS -Dcom.sun.management.jmxremote"
JAVA_ARGS="$JAVA_ARGS -Dcom.sun.management.jmxremote.authenticate=false"
JAVA_ARGS="$JAVA_ARGS -Dcom.sun.management.jmxremote.ssl=false"
JAVA_ARGS="$JAVA_ARGS -Dcom.sun.management.jmxremote.port=1099"
JAVA_ARGS="$JAVA_ARGS -Dcom.sun.management.jmxremote.rmi.port=1098"
JAVA_ARGS="$JAVA_ARGS 
-Djava.rmi.server.hostname=edimq-broker-master-az1.dc01.clouedi.local"```

This works but it's not how it's meant to be set up. The proper way is to 
set the port in the `management.xml` file and this patch allows you to set the 
RMI port there as well (using the `rmi-registry-port` attribute). It worked for 
me.


---

[GitHub] activemq-artemis issue #2420: Allow configuration of RMI registry port

2018-11-07 Thread michaelandrepearce 
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2420
  
We fix the ports in my org this with using system properties on java 
command line modifiying artemis.profile


---

[GitHub] activemq-artemis issue #2420: Allow configuration of RMI registry port

2018-11-07 Thread andytaylor 
Github user andytaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/2420
  
Im not sure it does, i wrote this code and remember it not working well 
when i did the same thing. Also you can set this as a separate system property 
as per the docs


---

[GitHub] activemq-artemis issue #2420: Allow configuration of RMI registry port

2018-11-07 Thread jbertram 
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/2420
  
Have you confirmed that this change actually sets the RMI registry port as 
expected?


---