[GitHub] activemq-artemis issue #2485: ARTEMIS-2217 ‘MQTTSessionState’ in the ‘...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2485 @onlyMIT, I put the `getSessionState` method back onto #2491, but #2466 will still have conflicts which you'll need to resolve once the merge on #2491 is done. ---
[GitHub] activemq-artemis issue #2485: ARTEMIS-2217 ‘MQTTSessionState’ in the ‘...
Github user onlyMIT commented on the issue: https://github.com/apache/activemq-artemis/pull/2485 @jbertram OKï¼I will close this RPãThere is a small suggestion, can you keep the "getSessionState" methodï¼because the RP #2466 has used this methodã In the case of not sure if other RPs are used in the corresponding method, and it is not necessary to delete the method. Maybe it is better to keep this method. Anyway I will close this RP, #2491 may be more readable ---
[GitHub] activemq-artemis issue #2485: ARTEMIS-2217 ‘MQTTSessionState’ in the ‘...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2485 @onlyMIT, can you close this PR since #2491 is in good shape now? ---
[GitHub] activemq-artemis issue #2485: ARTEMIS-2217 ‘MQTTSessionState’ in the ‘...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2485 After looking at writing a test for this I thought the solution here was not very intuitive so I opened #2491 to address this problem (with a test). ---
[GitHub] activemq-artemis issue #2485: ARTEMIS-2217 ‘MQTTSessionState’ in the ‘...
Github user onlyMIT commented on the issue: https://github.com/apache/activemq-artemis/pull/2485 @jbertram Nice! Really need more specific test ---
[GitHub] activemq-artemis issue #2485: ARTEMIS-2217 ‘MQTTSessionState’ in the ‘...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2485 I'm going to look at writing a test for this. ---
