[GitHub] activemq-artemis issue #579: Remove redundant type arguments, add sevntu-che...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/579 Can you send a PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #579: Remove redundant type arguments, add sevntu-che...
Github user bwzhang2011 commented on the issue: https://github.com/apache/activemq-artemis/pull/579 @clebertsuconic, sevntu checkstyle plugin address was wrong that we could not simply build it right for I could not access the url http://sevntu-checkstyle.github.io/sevntu.checkstyle/maven2. and it's better that the dependency for maven-checkstyle-plugin should be dsm-maven-plugin. so if it was replaced by as follows: org.apache.maven.plugins maven-checkstyle-plugin 2.17 com.github.sevntu-checkstyle dsm-maven-plugin 2.1.4 and comment out the sevntu url . the 1.4 release could be built as expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #579: Remove redundant type arguments, add sevntu-che...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/579 Oh.. wow.. you already did it.. awesome! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #579: Remove redundant type arguments, add sevntu-che...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/579 @scop Here is my PR: https://github.com/sevntu-checkstyle/sevntu.checkstyle/pull/203 it was replaced by another pr: https://github.com/sevntu-checkstyle/sevntu.checkstyle/issues/321 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #579: Remove redundant type arguments, add sevntu-che...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/579 @scop Since you are adding Seventu, can I ask you a favour? I had this on the checkstyle: org.hornetq.checks.annotation.RequiredAnnotation, Which I started as a PR on Seventu. I have written a PR for them, but I couldn't finish it because they had too many requirements, and I didn't have time to finish, so I think someone took over my contribution and finished into Seventu. Can you check on replacing my RequiredAnnotations by the one on Seventu, which I believe my contribution has made into there? if you can't just let me know and I will find some time to do it later this week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #579: Remove redundant type arguments, add sevntu-che...
Github user scop commented on the issue: https://github.com/apache/activemq-artemis/pull/579 The last commit is unrelated to the diamond operator, but depends on the sevntu addition so I thought I'd just bundle it here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
