[GitHub] activemq-artemis issue #630: ARTEMIS-628 add BROWSE role

2016-07-13 Thread andytaylor
Github user andytaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/630
  
The test failures were environmental, I will get this merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis issue #630: ARTEMIS-628 add BROWSE role

2016-07-12 Thread clebertsuconic
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/630
  
I just briefly look now, it looks ok to me +1 from me.. 

I won't be able to merge it.. just take my +1 on this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis issue #630: ARTEMIS-628 add BROWSE role

2016-07-12 Thread jbertram
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/630
  
Failed PR tests succeed locally.  It looks like there's a port conflict on 
the Apache CI hardware.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---