[GitHub] activemq-artemis pull request #1642: NO-JIRA - minor updates to sample, so i...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1642


---

[GitHub] activemq-artemis pull request #1642: NO-JIRA - minor updates to sample, so i...

[pgfox]

Github user pgfox commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1642#discussion_r149118258
  
--- Diff: 
examples/features/standard/large-message/src/main/resources/jndi.properties ---
@@ -16,5 +16,5 @@
 # under the License.
 
 
java.naming.factory.initial=org.apache.activemq.artemis.jndi.ActiveMQInitialContextFactory
-connectionFactory.ConnectionFactory=tcp://localhost:61616

+connectionFactory.ConnectionFactory=tcp://localhost:61616?minLargeMessageSize=10240
--- End diff --

Thanks @clebertsuconic  :)




---

[GitHub] activemq-artemis pull request #1642: NO-JIRA - minor updates to sample, so i...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1642#discussion_r149117663
  
--- Diff: 
examples/features/standard/large-message/src/main/resources/jndi.properties ---
@@ -16,5 +16,5 @@
 # under the License.
 
 
java.naming.factory.initial=org.apache.activemq.artemis.jndi.ActiveMQInitialContextFactory
-connectionFactory.ConnectionFactory=tcp://localhost:61616

+connectionFactory.ConnectionFactory=tcp://localhost:61616?minLargeMessageSize=10240
--- End diff --

ahhh... I was looking for something in the readme for the 10K and missed 
that... 

and you believe I wrote this years ago...  :)


merging it!


---

[GitHub] activemq-artemis pull request #1642: NO-JIRA - minor updates to sample, so i...

[pgfox]

Github user pgfox commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1642#discussion_r149115107
  
--- Diff: 
examples/features/standard/large-message/src/main/resources/jndi.properties ---
@@ -16,5 +16,5 @@
 # under the License.
 
 
java.naming.factory.initial=org.apache.activemq.artemis.jndi.ActiveMQInitialContextFactory
-connectionFactory.ConnectionFactory=tcp://localhost:61616

+connectionFactory.ConnectionFactory=tcp://localhost:61616?minLargeMessageSize=10240
--- End diff --

Thanks @clebertsuconic .

In the comments in LargeMessageExample.java it mentions the following.
``
// Step 3. Perform a lookup on the Connection Factory. This 
ConnectionFactory has a special attribute set on
// it.
// Messages with more than 10K are considered large

``
I think it is good to have a sample of how to set the config on the url to 
show syntax, in case a customer wants to change the default for whatever 
reason. 


---

[GitHub] activemq-artemis pull request #1642: NO-JIRA - minor updates to sample, so i...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1642#discussion_r149106833
  
--- Diff: 
examples/features/standard/large-message/src/main/resources/jndi.properties ---
@@ -16,5 +16,5 @@
 # under the License.
 
 
java.naming.factory.initial=org.apache.activemq.artemis.jndi.ActiveMQInitialContextFactory
-connectionFactory.ConnectionFactory=tcp://localhost:61616

+connectionFactory.ConnectionFactory=tcp://localhost:61616?minLargeMessageSize=10240
--- End diff --

It was an oversight for sure.. nice catch...

Why you set minLargeMessagesize as 10K? the default is 100K.


---

[GitHub] activemq-artemis pull request #1642: NO-JIRA - minor updates to sample, so i...

[pgfox]

GitHub user pgfox opened a pull request:

https://github.com/apache/activemq-artemis/pull/1642

NO-JIRA - minor updates to sample, so it works as described in comments

The LargeMessageExample was not working as described in docs: 

- FILESIZE was set to 1 MiB instead of 2 GiB
I had a look at the previous change to FILE_SIZE and my guess is the change 
was included in a commit as an oversight.  Please let me know if the file size 
was meant to be reduced and I will modify the PR to reflect that.

- ?minLargeMessageSize=10240 was omitted from URL.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pgfox/activemq-artemis large_message_example

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1642.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1642


commit 86b8a92e5fa8fede771ea07a47e186657dad4694
Author: Pat Fox 
Date:   2017-11-04T17:18:30Z

NO-JIRA - minor updates to sample, so it works as described in comments




---