[GitHub] activemq-artemis pull request #2155: ARTEMIS-1949 fix IllegalMonitorStateExc...

2018-12-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2155


---


[GitHub] activemq-artemis pull request #2155: ARTEMIS-1949 fix IllegalMonitorStateExc...

2018-06-21 Thread wy96f
GitHub user wy96f opened a pull request:

https://github.com/apache/activemq-artemis/pull/2155

ARTEMIS-1949 fix IllegalMonitorStateException during shutdown

During server shutdown, the exception occurs as follows:

2018-06-19 16:23:03,503 WARN [org.apache.activemq.artemis.core.client] 
AMQ212063: Unable to handle connection failure : 
java.lang.IllegalMonitorStateException
at 
java.util.concurrent.locks.ReentrantLock$Sync.tryRelease(ReentrantLock.java:151)
 [rt.jar:1.8.0_92]
at 
java.util.concurrent.locks.AbstractQueuedSynchronizer.release(AbstractQueuedSynchronizer.java:1261)
 [rt.jar:1.8.0_92]
at java.util.concurrent.locks.ReentrantLock.unlock(ReentrantLock.java:457) 
[rt.jar:1.8.0_92]
at 
org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQClientProtocolManager.cleanupBeforeFailover(ActiveMQClientProtocolManager.java:373)
 [artemis-core-client-2.4.0.jar:2.4.0]
at 
org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.failoverOrReconnect(ClientSessionFactoryImpl.java:588)
 [artemis-core-client-2.4.0.jar:2.4.0]
at 
org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.handleConnectionFailure(ClientSessionFactoryImpl.java:504)
 [artemis-core-client-2.4.0.jar:2.4.0]
at 
org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.handleConnectionFailure(ClientSessionFactoryImpl.java:497)
 [artemis-core-client-2.4.0.jar:2.4.0]
at 
org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.access$100(ClientSessionFactoryImpl.java:72)
 [artemis-core-client-2.4.0.jar:2.4.0]
at 
org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$1.run(ClientSessionFactoryImpl.java:360)
 [artemis-core-client-2.4.0.jar:2.4.0]
at 
org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
 [artemis-commons-2.4.0.jar:2.4.0]
at 
org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
 [artemis-commons-2.4.0.jar:2.4.0]
at 
org.apache.activemq.artemis.utils.actors.ProcessorBase$ExecutorTask.run(ProcessorBase.java:53)
 [artemis-commons-2.4.0.jar:2.4.0]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) 
[rt.jar:1.8.0_92]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) 
[rt.jar:1.8.0_92]
at java.lang.Thread.run(Thread.java:745) [rt.jar:1.8.0_92]

To fix this, we return null if clientProtocolManager is not alive in 
lockSessionCreation().

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wy96f/activemq-artemis lock_session_creation

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2155


commit 46681495e4b375a49eb92ec87c905d6dbe4e4397
Author: yang wei 
Date:   2018-06-21T07:46:59Z

ARTEMIS-1949 fix IllegalMonitorStateException during shutdown




---