[GitHub] activemq-artemis pull request #2200: ARTEMIS-1997 - un-needed SimpleString c...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2200


---

[GitHub] activemq-artemis pull request #2200: ARTEMIS-1997 - un-needed SimpleString c...

[franz1981]

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2200#discussion_r206141050
  
--- Diff: 
artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/Filterable.java
 ---
@@ -41,7 +43,7 @@
 * @param name
 * @return
 */
-   Object getProperty(String name);
+   Object getProperty(SimpleString name);
--- End diff --

nice!!!


---

[GitHub] activemq-artemis pull request #2200: ARTEMIS-1997 - un-needed SimpleString c...

[michaelandrepearce]

GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/2200

ARTEMIS-1997 - un-needed SimpleString creation on hotpath with Filters

Create the SimpleString on construction of PropertyExpression so it can be 
re-used instead of creating it every time its filtered in the FilterImpl

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1997-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2200.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2200


commit 4fce78f068cc5474e43704e1fa8da2fb435b170d
Author: Michael André Pearce 
Date:   2018-07-22T03:17:50Z

ARTEMIS-1997 - un-needed SimpleString creation on hotpath with Filters

Create the SimpleString on construction of PropertyExpression so it can be 
re-used instead of creating it every time its filtered in the FilterImpl




---