[GitHub] activemq-artemis pull request #601: ARTEMIS-596 fix JMS bridge example

2016-06-27 Thread jbertram 
Github user jbertram closed the pull request at:

https://github.com/apache/activemq-artemis/pull/601


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #601: ARTEMIS-596 fix JMS bridge example

2016-06-27 Thread clebertsuconic 
Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/601#discussion_r68618005
  
--- Diff: 
examples/features/standard/jms-bridge/src/main/java/org/apache/activemq/artemis/jms/example/JMSBridgeExample.java
 ---
@@ -56,7 +56,7 @@ public static void main(final String[] args) throws 
Exception {
   Hashtable targetJndiParams = 
createJndiParams(targetServer);
   // Step 2. Create and start a JMS Bridge
   // Note, the Bridge needs a transaction manager, in this instance we 
will use the JBoss TM
-  JMSBridge jmsBridge = new JMSBridgeImpl(new 
JNDIConnectionFactoryFactory(sourceJndiParams, "ConnectionFactory"), new 
JNDIConnectionFactoryFactory(targetJndiParams, "ConnectionFactory"), new 
JNDIDestinationFactory(sourceJndiParams, "source/topic"), new 
JNDIDestinationFactory(targetJndiParams, "target/queue"), null, null, null, 
null, null, 5000, 10, QualityOfServiceMode.DUPLICATES_OK, 1, -1, null, null, 
true);
--- End diff --

I have actually reverted this constructor due to API changes.

I have added a new property to set the name. This can probably be closed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #601: ARTEMIS-596 fix JMS bridge example

2016-06-24 Thread jbertram 
GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/601

ARTEMIS-596 fix JMS bridge example



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis master_work

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/601.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #601


commit dbaf46376b1f550b3fa7bd52ccb0cc39215ff552
Author: jbertram 
Date:   2016-06-24T19:36:51Z

ARTEMIS-596 fix JMS bridge example




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---