[GitHub] franz1981 commented on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue
franz1981 commented on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue URL: https://github.com/apache/activemq-artemis/pull/2524#issuecomment-458042571 @michaelandrepearce I'm very happy (I hope that perf are nice as well), because it makes much more simple to understand what the code does now This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] franz1981 commented on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue
franz1981 commented on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue URL: https://github.com/apache/activemq-artemis/pull/2524#issuecomment-458041944 @michaelandrepearce nice catch!! you've already measured with your box how the last version is performing? I've run the same bench I'm using and it seems really great: hopefully will scale a lot better too :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] franz1981 commented on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue
franz1981 commented on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue URL: https://github.com/apache/activemq-artemis/pull/2524#issuecomment-458038880 Thanks @michaelandrepearce to have looked into this, I will change it accordingly to the last comment (nice simple and effective, I like it!) and left the PR here for @clebertsuconic :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] franz1981 commented on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue
franz1981 commented on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue URL: https://github.com/apache/activemq-artemis/pull/2524#issuecomment-457884911 @michaelandrepearce @clebertsuconic If any of these commits will improve scalability (LinkedBlockingQueue is using a lock for any of its operations!) I will close this one :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] franz1981 commented on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue
franz1981 commented on issue #2524: ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue URL: https://github.com/apache/activemq-artemis/pull/2524#issuecomment-457884054 On my box I'm getting the same performance of the master version for single producer/single consumer workloads and a better scalability with 8 producers/8 consumers (on different queues) for both the commits I've attached (the second one, in particular). I'm putting this for review and for validation: if anyone has a better machine to validate its behaviour is wellcome. A conservative approach will suggest to just use the first commit ie a simple q replacement, but I the second commit has more to offer given that would allow to use what this q offer out of the box and that seems very similar to what the thread pool was delivering in the implementation on master. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
