[jira] [Commented] (AMQ-4562) SimplePriorityMessageDispatchChannel.clear() needs to reset size attribute

2013-05-30 Thread Timothy Bish (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13670214#comment-13670214
 ] 

Timothy Bish commented on AMQ-4562:
---

Fix looks fine to me.

> SimplePriorityMessageDispatchChannel.clear() needs to reset size attribute
> --
>
> Key: AMQ-4562
> URL: https://issues.apache.org/jira/browse/AMQ-4562
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: JMS client
>Affects Versions: 5.8.0
>Reporter: Torsten Mielke
>Assignee: Torsten Mielke
>
> SimplePriorityMessageDispatchChannel.clear() deletes all prefetched messages 
> but does not reset the size counter. The other method removeAll() does it 
> correctly.
> Propose to fix this as follows:
> {code:title=SimplePriorityMessageDispatchChannel.java}
> public void clear() {
> synchronized (mutex) {
> for (int i = 0; i < MAX_PRIORITY; i++) {
> lists[i].clear();
> }
>   size = 0;
> }
> }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AMQ-4562) SimplePriorityMessageDispatchChannel.clear() needs to reset size attribute

2013-05-30 Thread Torsten Mielke (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13670159#comment-13670159
 ] 

Torsten Mielke commented on AMQ-4562:
-

I hope this fix is obvious as I am not sure yet how to test this in a unit 
test. 
If I get the ok, I will push the fix without a test.

> SimplePriorityMessageDispatchChannel.clear() needs to reset size attribute
> --
>
> Key: AMQ-4562
> URL: https://issues.apache.org/jira/browse/AMQ-4562
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: JMS client
>Affects Versions: 5.8.0
>Reporter: Torsten Mielke
>Assignee: Torsten Mielke
>
> SimplePriorityMessageDispatchChannel.clear() deletes all prefetched messages 
> but does not reset the size counter. The other method removeAll() does it 
> correctly.
> Propose to fix this as follows:
> {code:title=SimplePriorityMessageDispatchChannel.java}
> public void clear() {
> synchronized (mutex) {
> for (int i = 0; i < MAX_PRIORITY; i++) {
> lists[i].clear();
> }
>   size = 0;
> }
> }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira