[jira] [Updated] (AMQ-4433) Socket parameters are not validated
[
https://issues.apache.org/jira/browse/AMQ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hadrian Zbarcea updated AMQ-4433:
-
Fix Version/s: 5.9.1
> Socket parameters are not validated
> ---
>
> Key: AMQ-4433
> URL: https://issues.apache.org/jira/browse/AMQ-4433
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Transport
>Reporter: Christoffer Sawicki
>Assignee: Claus Ibsen
>Priority: Minor
> Fix For: 5.9.1, 5.10.0
>
> Attachments: 0001-Validate-socket-parameters.patch,
> 0002-Validate-connector-parameters.patch,
> 0003-Validate-transport-parameters.patch
>
>
> Connect parameters are validated in every transport factory with a statement
> like this:
> {noformat}
> if (!options.isEmpty()) {
> throw new IllegalArgumentException("Invalid connect parameters: " +
> options);
> }
> {noformat}
> Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
> however never validated.
> They are put away at
> {noformat}
> TcpTransportFactory.compositeConfigure(Transport, WireFormat, Map) line: 85
> {noformat}
> and then set at
> {noformat}
> TcpTransport.initialiseSocket(Socket) line: 428
> {noformat}
> where there is no check that {{socketOptions}} is empty after the call.
> I've attached a patch (#1) that rectifies this.
> Bonus: I found similar issues in the transport classes. See patch #2 and #3.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (AMQ-4433) Socket parameters are not validated
[
https://issues.apache.org/jira/browse/AMQ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claus Ibsen updated AMQ-4433:
-
Component/s: Transport
Fix Version/s: 5.10.0
Assignee: Claus Ibsen
Issue Type: Improvement (was: Bug)
> Socket parameters are not validated
> ---
>
> Key: AMQ-4433
> URL: https://issues.apache.org/jira/browse/AMQ-4433
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Transport
>Reporter: Christoffer Sawicki
>Assignee: Claus Ibsen
>Priority: Minor
> Fix For: 5.10.0
>
> Attachments: 0001-Validate-socket-parameters.patch,
> 0002-Validate-connector-parameters.patch,
> 0003-Validate-transport-parameters.patch
>
>
> Connect parameters are validated in every transport factory with a statement
> like this:
> {noformat}
> if (!options.isEmpty()) {
> throw new IllegalArgumentException("Invalid connect parameters: " +
> options);
> }
> {noformat}
> Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
> however never validated.
> They are put away at
> {noformat}
> TcpTransportFactory.compositeConfigure(Transport, WireFormat, Map) line: 85
> {noformat}
> and then set at
> {noformat}
> TcpTransport.initialiseSocket(Socket) line: 428
> {noformat}
> where there is no check that {{socketOptions}} is empty after the call.
> I've attached a patch (#1) that rectifies this.
> Bonus: I found similar issues in the transport classes. See patch #2 and #3.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (AMQ-4433) Socket parameters are not validated
[
https://issues.apache.org/jira/browse/AMQ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christoffer Sawicki updated AMQ-4433:
-
Description:
Connect parameters are validated in every transport factory with a statement
like this:
{noformat}
if (!options.isEmpty()) {
throw new IllegalArgumentException("Invalid connect parameters: " + options);
}
{noformat}
Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
however never validated.
They are put away at
{noformat}
TcpTransportFactory.compositeConfigure(Transport, WireFormat, Map) line: 85
{noformat}
and then set at
{noformat}
TcpTransport.initialiseSocket(Socket) line: 428
{noformat}
where there is no check that {{socketOptions}} is empty after the call.
I've attached a patch (#1) that rectifies this.
Bonus: I found similar issues in the transport classes. See patch #2 and #3.
was:
Connect parameters are validated in every transport factory with a statement
like this:
{noformat}
if (!options.isEmpty()) {
throw new IllegalArgumentException("Invalid connect parameters: " + options);
}
{noformat}
Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
however never validated.
They are put away at
{noformat}
TcpTransportFactory.compositeConfigure(Transport, WireFormat, Map) line: 85
{noformat}
and then set at
{noformat}
TcpTransport.initialiseSocket(Socket) line: 428
{noformat}
where there is no check that {{socketOptions}} is empty after the call.
I've attached a patch that rectifies this.
> Socket parameters are not validated
> ---
>
> Key: AMQ-4433
> URL: https://issues.apache.org/jira/browse/AMQ-4433
> Project: ActiveMQ
> Issue Type: Bug
>Reporter: Christoffer Sawicki
>Priority: Minor
> Attachments: 0001-Validate-socket-parameters.patch,
> 0002-Validate-connector-parameters.patch,
> 0003-Validate-transport-parameters.patch
>
>
> Connect parameters are validated in every transport factory with a statement
> like this:
> {noformat}
> if (!options.isEmpty()) {
> throw new IllegalArgumentException("Invalid connect parameters: " +
> options);
> }
> {noformat}
> Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
> however never validated.
> They are put away at
> {noformat}
> TcpTransportFactory.compositeConfigure(Transport, WireFormat, Map) line: 85
> {noformat}
> and then set at
> {noformat}
> TcpTransport.initialiseSocket(Socket) line: 428
> {noformat}
> where there is no check that {{socketOptions}} is empty after the call.
> I've attached a patch (#1) that rectifies this.
> Bonus: I found similar issues in the transport classes. See patch #2 and #3.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4433) Socket parameters are not validated
[
https://issues.apache.org/jira/browse/AMQ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christoffer Sawicki updated AMQ-4433:
-
Attachment: 0003-Validate-transport-parameters.patch
0002-Validate-connector-parameters.patch
> Socket parameters are not validated
> ---
>
> Key: AMQ-4433
> URL: https://issues.apache.org/jira/browse/AMQ-4433
> Project: ActiveMQ
> Issue Type: Bug
>Reporter: Christoffer Sawicki
>Priority: Minor
> Attachments: 0001-Validate-socket-parameters.patch,
> 0002-Validate-connector-parameters.patch,
> 0003-Validate-transport-parameters.patch
>
>
> Connect parameters are validated in every transport factory with a statement
> like this:
> {noformat}
> if (!options.isEmpty()) {
> throw new IllegalArgumentException("Invalid connect parameters: " +
> options);
> }
> {noformat}
> Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
> however never validated.
> They are put away at
> {noformat}
> TcpTransportFactory.compositeConfigure(Transport, WireFormat, Map) line: 85
> {noformat}
> and then set at
> {noformat}
> TcpTransport.initialiseSocket(Socket) line: 428
> {noformat}
> where there is no check that {{socketOptions}} is empty after the call.
> I've attached a patch (#1) that rectifies this.
> Bonus: I found similar issues in the transport classes. See patch #2 and #3.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4433) Socket parameters are not validated
[
https://issues.apache.org/jira/browse/AMQ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christoffer Sawicki updated AMQ-4433:
-
Description:
Connect parameters are validated in every transport factory with a statement
like this:
{noformat}
if (!options.isEmpty()) {
throw new IllegalArgumentException("Invalid connect parameters: " + options);
}
{noformat}
Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
however never validated.
They are put away at
{noformat}
TcpTransportFactory.compositeConfigure(Transport, WireFormat, Map) line: 85
{noformat}
and then set at
{noformat}
TcpTransport.initialiseSocket(Socket) line: 428
{noformat}
where there is no check that {{socketOptions}} is empty after the call.
I've attached a patch that rectifies this.
was:
Connect parameters are validated in every transport factory with a statement
like this:
{noformat}
if (!options.isEmpty()) {
throw new IllegalArgumentException("Invalid connect parameters: " + options);
}
{noformat}
Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
however never validated.
They are put away at
{noformat}
SslTransportFactory(TcpTransportFactory).compositeConfigure(Transport,
WireFormat, Map) line: 85
{noformat}
and then set at
{noformat}
SslTransport(TcpTransport).initialiseSocket(Socket) line: 428
{noformat}
where there is no check that {{socketOptions}} is empty after the call.
I've attached a patch that rectifies this.
> Socket parameters are not validated
> ---
>
> Key: AMQ-4433
> URL: https://issues.apache.org/jira/browse/AMQ-4433
> Project: ActiveMQ
> Issue Type: Bug
>Reporter: Christoffer Sawicki
>Priority: Minor
> Attachments: 0001-Validate-socket-parameters.patch
>
>
> Connect parameters are validated in every transport factory with a statement
> like this:
> {noformat}
> if (!options.isEmpty()) {
> throw new IllegalArgumentException("Invalid connect parameters: " +
> options);
> }
> {noformat}
> Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
> however never validated.
> They are put away at
> {noformat}
> TcpTransportFactory.compositeConfigure(Transport, WireFormat, Map) line: 85
> {noformat}
> and then set at
> {noformat}
> TcpTransport.initialiseSocket(Socket) line: 428
> {noformat}
> where there is no check that {{socketOptions}} is empty after the call.
> I've attached a patch that rectifies this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4433) Socket parameters are not validated
[
https://issues.apache.org/jira/browse/AMQ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christoffer Sawicki updated AMQ-4433:
-
Attachment: 0001-Validate-socket-parameters.patch
> Socket parameters are not validated
> ---
>
> Key: AMQ-4433
> URL: https://issues.apache.org/jira/browse/AMQ-4433
> Project: ActiveMQ
> Issue Type: Bug
>Reporter: Christoffer Sawicki
>Priority: Minor
> Attachments: 0001-Validate-socket-parameters.patch
>
>
> Connect parameters are validated in every transport factory with a statement
> like this:
> {noformat}
> if (!options.isEmpty()) {
> throw new IllegalArgumentException("Invalid connect parameters: " +
> options);
> }
> {noformat}
> Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are
> however never validated.
> They are put away at
> {noformat}
> SslTransportFactory(TcpTransportFactory).compositeConfigure(Transport,
> WireFormat, Map) line: 85
> {noformat}
> and then set at
> {noformat}
> SslTransport(TcpTransport).initialiseSocket(Socket) line: 428
> {noformat}
> where there is no check that {{socketOptions}} is empty after the call.
> I've attached a patch that rectifies this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
