[GitHub] [age] omaurel-socha opened a new issue, #1229: Python Driver's _nodeToJson() returns invalid JSON
omaurel-socha opened a new issue, #1229:
URL: https://github.com/apache/age/issues/1229
**Describe the bug**
I am trying some cypher queries using the python driver.
When iterating the results of a query, The function .toJson() returns a JSON
string containing a trailing comma in the "properties" field.
As a result, the JSON is invalid and it is not possible to convert it into a
dict using json.loads() for example.
**How are you accessing AGE (Command line, driver, etc.)?**
- Python Driver
**What data setup do we need to do?**
```
def testJson(self):
print("\n--")
print("Test 6: Testing JSON output.")
print("\n")
ag = self.ag
with ag.connection.cursor() as cursor:
try:
ag.cypher(cursor, "CREATE (n:Person {name: %s}) ",
params=('Joe',))
ag.cypher(cursor, "CREATE (n:Person {name: %s}) ",
params=('Jack',))
ag.cypher(cursor, "CREATE (n:Person {name: %s}) ",
params=('Andy',))
ag.cypher(cursor, "CREATE (n:Person {name: %s}) ",
params=('Smith',))
ag.cypher(cursor, "CREATE (n:Person {name: %s}) ",
params=('Tom',))
# You must commit explicitly
ag.commit()
except Exception as ex:
print(ex)
ag.rollback()
print(" TESTING JSON #1 ")
cursor = ag.execCypher("MATCH (n) RETURN n")
for row in cursor:
# json.loads will fail if the json str is not properly formatted
as_dict = json.loads(row[0].toJson())
print("Vertex.toJson() returns a correct json string.")
```
**What is the command that caused the error?**
```
for row in cursor:
as_dict = json.loads(row[0].toJson())
```
**Expected behavior**
The correct behavior would return valid JSON when calling .toJson().
**Additional context**
The problem originates in _nodeToJson(). The way the buffer writing
iteration is done in the properties field will always add a trailing comma.
[I have submitted a PR to fix the
issue](https://github.com/apache/age/pull/1228)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@age.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [VOTE] Apache AGE 1.4.0 Release for PostgreSQL 14
Dear Apache Community, We would like to thank everyone who participated in the voting process and are now closing this vote and will be sending out the results shortly. John Gemignani On Mon, Sep 11, 2023 at 8:37 AM Muhammad Shoaib wrote: > Dear Apache AGE Community, > > I hope this message finds you well. I am writing to formally cast my vote > for the approval of Apache AGE version 1.4.0 for PG14. > > My vote is as follows: > +1 (Binding) > > I have conducted a thorough review of the release candidate and have > ensured that the following criteria have been met: > > 1. Signature and hash - I have checked and verified the cryptographic > signature and hash of the release candidate. > 2. Links and tags - I have confirmed that all relevant links and tags in > the release are accurate and functional. > 3. License and Notice - I have reviewed the license and notice files to > ensure compliance with Apache licensing requirements. > 4. Release notes - I have examined the release notes and found them to be > comprehensive and accurate to the best of my knowledge. > 5. No unexpected binary files - I have confirmed that there are no > unexpected binary files in the release. > > Based on my assessment, I believe that Apache AGE version 1.4.0 meets the > necessary criteria for a successful release. I appreciate the hard work and > dedication of the contributors who have made this release possible. > > Thank you to everyone involved in this release, and I look forward to > seeing the continued progress of the Apache AGE project. > > Best regards, > Shoaib > > > On Mon, Sep 11, 2023 at 5:16 PM Eya Badal wrote: > > > +1(Binding) > > > > Checked the following: > > * Signature and hash - Verified > > * Links and tags - Verified > > * License and Notice - Verified > > * Release notes - Verified > > * No unexpected binary files - Verified > > > > Great job, and thank you!! > > > > > > On 2023/09/06 19:15:29 John Gemignani wrote: > > > Dear Apache Community, > > > > > > Please carefully read all instructions as they may have changed since > the > > > last vote thread. > > > > > > This is an official vote for Apache AGE release 1.4.0 for PostgreSQL > 14. > > > > > > To learn more about Apache AGE, please see http://age.apache.org/ > > > > > > Functionalities included and addressed in this release are: > > > > > > * > > > Release Notes for Apache AGE release v1.4.0 for PostgreSQL 14 > > > > > > NOTE: This is an initial release of PG14. There are no upgrade > > > scripts to this release. > > > > > > NOTE: Some of these reference the master branch PR that was > > > either applied to lower versions via a separate PR or > > > merged into a newly created branch. > > > > > > Added license in Python driver README.md (#956) > > > Added the toStringList() function (#1128) > > > Added toBooleanList() (#1165) > > > Added toFloatList() function (#1016) > > > Added toIntegerList() function (#1025) > > > Added regression tests for MATCH clause using labels only (#1019) > > > Added REGTYPEOID to toString function (#1036) > > > Added Dockerfile.dev & move docker-related files to "docker/" (#943) > > > Fixed complex MERGE causes crash (#897) (#961) > > > Fixed docker build files (#1104) > > > Fixed case sensitivity on label usage of reserved keyword (#1040) > > > Fixed issue 1000: Indexes created on WHERE (#1133) > > > Fixed issue 1002: Invalid reuse of variables in MATCH clause (#1003) > > > Fixed issue 1033: access operator on vle edge lists (#1037) > > > Fixed issue 1043: ERROR: container must be an array or object (#1046) > > > Fixed issue 1124: Segmentation fault when using specific tables (#1125) > > > Fixed issue 395: ERROR: container is not an agtype array (#1039) > > > Fixed issue 870: regarding orderability and added regression tests > (#994) > > > Fixed issue 876: column reference "_age_default_alias_0" is ambiguous > > (#931) > > > Fixed issue 975: Invalid reuse of variables in CREATE clause (#977) > > > Fixed issue 989: Impossible to create array with > 100 items (#1001) > > > Fixed memory leak issues with age_load (#1142) > > > Fixed memory leaks in MERGE (merge_edge & merge_vertex) (#958) > > > Fixed MERGE crashes due to incorrect label type (#957) > > > Fixed MERGE variable reuse (#997) > > > Fixed misspellings in many AGE files (#985) > > > Fixed warning messages in DockerHub builds. (#1075) > > > Modified test_agtypes to view useful testing message (#992) > > > Optimised Antlr4ResultHandler initialization (#1169) > > > Updated CIs to pull correct image based on branch (#1105) > > > Updated files, format, and version information (#1063) > > > Updated README. > > > > > > * > > > > > > !!! PLEASE VERIFY ALL of the below tags, hash, links, signatures, & > keys > > !!! > > > > > > The git tag to be discussed and voted on: > > > https://github.com/apache/age/releases/tag/PG14/v1.4
[RESULT][VOTE] Apache AGE 1.4.0 Release for PostgreSQL 14
Dear Apache Community, The vote successfully passed with 4 +1 (binding) and 3 +1 (non-binding) votes. There were no 0 or -1 votes. Following are the detailed results: Total of 7 (+1) votes. 4 BINDING (+1) VOTES Dehowe Feng Nicholas Sorrell Eya Badal Muhammad Shoaib 3 NON-BINDING (+1) VOTES Muhammad Taha Naveed Bhaskar Sharma Rafsun Masud VOTE thread: https://lists.apache.org/thread/wf7lr8x7mw19z9cygoknrwqzvqz5opwd Thank you all! John Gemignani
[GitHub] [age] jrgemignani commented on issue #1226: [Creating Table]Creating Table, Temporary Table, View from Graph in AGE
jrgemignani commented on issue #1226: URL: https://github.com/apache/age/issues/1226#issuecomment-1716617778 @cho2hhun Can you give the complete commands that caused an issue with creating a Table or Temporary Table? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@age.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [age-website] MatheusFarias03 opened a new pull request, #197: Modified guide/index.html
MatheusFarias03 opened a new pull request, #197: URL: https://github.com/apache/age-website/pull/197 Set the html file to be prettier and more organized, and also updated the coding style for AGE. Hope this is fine the way it is because it took quite a while to get everything set correctly in HTML format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@age.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
