Gantt chart broken on master?
Gantt chart is broken for me on master. I think it's due to this merge. https://github.com/apache/incubator-airflow/commit/868bc83137adca0ebfd5780f0dff5a7bfdfaadf9 Why is an end_date needed? [image: Inline image 1] This is the tree view: [image: Inline image 2] Sumit, as the merger/committer, can you confirm? -s
Re: Gantt chart broken on master?
I've installed airflow on a fresh virtualenv and I still have the issue above on the gantt chart. Anyone else notice the same. @Sumit, as the last person to merge a gantt chart change, can you repro on a fresh virtualenv? I notice a single "/" character on the page. -s On Sat, Nov 12, 2016 at 9:25 PM, siddharth anand wrote: > Gantt chart is broken for me on master. > > I think it's due to this merge. > https://github.com/apache/incubator-airflow/commit/ > 868bc83137adca0ebfd5780f0dff5a7bfdfaadf9 > > Why is an end_date needed? > > [image: Inline image 1] > > This is the tree view: > [image: Inline image 2] > > Sumit, as the merger/committer, can you confirm? > > -s >
Re: Gantt chart broken on master?
Found the issue.. it seems the gantt charts load from the most recent "running" DagRun, which in the example I provided (assuming you can see the attached screenshots in my original email), has not currently running tasks, hence the gantt charts look completely bare. If the Gantt chart instead defaulted to the most recent running DagRun with at least one task complete, it would be more useful IMHO. -s On Sun, Nov 13, 2016 at 9:53 PM, siddharth anand wrote: > I've installed airflow on a fresh virtualenv and I still have the issue > above on the gantt chart. Anyone else notice the same. @Sumit, as the last > person to merge a gantt chart change, can you repro on a fresh virtualenv? > > I notice a single "/" character on the page. > > -s > > On Sat, Nov 12, 2016 at 9:25 PM, siddharth anand > wrote: > >> Gantt chart is broken for me on master. >> >> I think it's due to this merge. >> https://github.com/apache/incubator-airflow/commit/868bc8313 >> 7adca0ebfd5780f0dff5a7bfdfaadf9 >> >> Why is an end_date needed? >> >> [image: Inline image 1] >> >> This is the tree view: >> [image: Inline image 2] >> >> Sumit, as the merger/committer, can you confirm? >> >> -s >> > >
Re: Gantt chart broken on master?
So we can say that its not broken, right? PS: link to screenshot https://www.dropbox.com/s/wql05icqgnewl0d/Screenshot%202016-11-14%2006.55.43.png?dl=0 On Mon, Nov 14, 2016 at 12:30 PM, siddharth anand wrote: > Found the issue.. it seems the gantt charts load from the most recent > "running" DagRun, which in the example I provided (assuming you can see the > attached screenshots in my original email), has not currently running > tasks, hence the gantt charts look completely bare. If the Gantt chart > instead defaulted to the most recent running DagRun with at least one task > complete, it would be more useful IMHO. > > -s > > On Sun, Nov 13, 2016 at 9:53 PM, siddharth anand > wrote: > >> I've installed airflow on a fresh virtualenv and I still have the issue >> above on the gantt chart. Anyone else notice the same. @Sumit, as the last >> person to merge a gantt chart change, can you repro on a fresh virtualenv? >> >> I notice a single "/" character on the page. >> >> -s >> >> On Sat, Nov 12, 2016 at 9:25 PM, siddharth anand >> wrote: >> >>> Gantt chart is broken for me on master. >>> >>> I think it's due to this merge. >>> https://github.com/apache/incubator-airflow/commit/868bc8313 >>> 7adca0ebfd5780f0dff5a7bfdfaadf9 >>> >>> Why is an end_date needed? >>> >>> [image: Inline image 1] >>> >>> This is the tree view: >>> [image: Inline image 2] >>> >>> Sumit, as the merger/committer, can you confirm? >>> >>> -s >>> >> >> >
Re: Gantt chart broken on master?
it's working as it always has, though this case (when a dag is behind several runs and needs to catch up) appears to result in an empty Gantt chart, which is not ideal. On Mon, Nov 14, 2016 at 12:43 AM Sumit Maheshwari wrote: > So we can say that its not broken, right? > > > PS: link to screenshot > > https://www.dropbox.com/s/wql05icqgnewl0d/Screenshot%202016-11-14%2006.55.43.png?dl=0 > > > > > On Mon, Nov 14, 2016 at 12:30 PM, siddharth anand > wrote: > > > Found the issue.. it seems the gantt charts load from the most recent > > "running" DagRun, which in the example I provided (assuming you can see > the > > attached screenshots in my original email), has not currently running > > tasks, hence the gantt charts look completely bare. If the Gantt chart > > instead defaulted to the most recent running DagRun with at least one > task > > complete, it would be more useful IMHO. > > > > -s > > > > On Sun, Nov 13, 2016 at 9:53 PM, siddharth anand > > wrote: > > > >> I've installed airflow on a fresh virtualenv and I still have the issue > >> above on the gantt chart. Anyone else notice the same. @Sumit, as the > last > >> person to merge a gantt chart change, can you repro on a fresh > virtualenv? > >> > >> I notice a single "/" character on the page. > >> > >> -s > >> > >> On Sat, Nov 12, 2016 at 9:25 PM, siddharth anand > >> wrote: > >> > >>> Gantt chart is broken for me on master. > >>> > >>> I think it's due to this merge. > >>> https://github.com/apache/incubator-airflow/commit/868bc8313 > >>> 7adca0ebfd5780f0dff5a7bfdfaadf9 > >>> > >>> Why is an end_date needed? > >>> > >>> [image: Inline image 1] > >>> > >>> This is the tree view: > >>> [image: Inline image 2] > >>> > >>> Sumit, as the merger/committer, can you confirm? > >>> > >>> -s > >>> > >> > >> > > >
