Re: Review Request 27870: Alerts: Remove Nagios Service From The Stack

2014-11-11 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27870/#review60805
---

Ship it!


Ship It!

- Alejandro Fernandez


On Nov. 11, 2014, 4:08 p.m., Jonathan Hurley wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/27870/
 ---
 
 (Updated Nov. 11, 2014, 4:08 p.m.)
 
 
 Review request for Ambari, Dmytro Sen, Nate Cole, Srimanth Gunturi, Tom 
 Beerbower, and Yusaku Sako.
 
 
 Bugs: AMBARI-8276
 https://issues.apache.org/jira/browse/AMBARI-8276
 
 
 Repository: ambari
 
 
 Description
 ---
 
 With the new alerting framework in place, the Nagios stack files can start to 
 be removed. This involves many different steps between the server, the web 
 client, and the agent.
 
 In this Jira, we will track the removal of the stack resources. This means:
 
 - Remove files in src/main/resources/stacks/*/services/NAGIOS
 - Remove files in test/main/resources/stacks/*/services/NAGIOS
 - Associated tests that depend on Nagios must be either removed if irrelevent 
 or rewritten
 
 This effort should leave Ambari in a state where the web client and 
 blueprints can still successfully install a non-Nagios cluster. Once 
 installed, the cluster will operate normally with the exception that alerts 
 will not be surfaced by the web client until they have switched over to the 
 new alert framework.
 
 
 Diffs
 -
 
   
 ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml
  c65a496 
   ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py 
 b7026e2 
   ambari-server/src/main/resources/custom_actions/validate_configs.py c245dbb 
   ambari-server/src/main/resources/properties.json 36cff96 
   ambari-server/src/main/resources/role_command_order.json c45ba07 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/blueprints/multinode-default.json
  642fcfa 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/blueprints/singlenode-default.json
  3c769dd 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/hooks/before-INSTALL/scripts/params.py
  01789a7 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/hooks/before-START/scripts/params.py
  ac8f1c8 
   ambari-server/src/main/resources/stacks/BIGTOP/0.8/role_command_order.json 
 69fcdac 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/GANGLIA/package/files/gmondLib.sh
  e7ea83f 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py
  83b2ed9 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/configuration/nagios-env.xml
  fad8374 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/metainfo.xml
  bebc7d6 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_aggregate.php
  792b25b 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_ambari_alerts.py
  833a798 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_checkpoint_time.py
  ab889d1 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_cpu.php
  0744e38 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_cpu.pl
  a5680f7 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_cpu_ha.php
  91a7c64 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_datanode_storage.php
  dee22b4 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_hdfs_blocks.php
  3693aa0 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_hdfs_capacity.php
  af72723 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_hive_metastore_status.sh
  640c077 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_hue_status.sh
  076d9b3 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_mapred_local_dir_used.sh
  3f9243a 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_name_dir_status.php
  186166d 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_namenodes_ha.sh
  83c1aca 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_nodemanager_health.sh
  eedcd62 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_oozie_status.sh
  820ee99 
   
 

Re: Review Request 27870: Alerts: Remove Nagios Service From The Stack

2014-11-11 Thread Nate Cole

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27870/#review60806
---

Ship it!


Ship It!

- Nate Cole


On Nov. 11, 2014, 11:08 a.m., Jonathan Hurley wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/27870/
 ---
 
 (Updated Nov. 11, 2014, 11:08 a.m.)
 
 
 Review request for Ambari, Dmytro Sen, Nate Cole, Srimanth Gunturi, Tom 
 Beerbower, and Yusaku Sako.
 
 
 Bugs: AMBARI-8276
 https://issues.apache.org/jira/browse/AMBARI-8276
 
 
 Repository: ambari
 
 
 Description
 ---
 
 With the new alerting framework in place, the Nagios stack files can start to 
 be removed. This involves many different steps between the server, the web 
 client, and the agent.
 
 In this Jira, we will track the removal of the stack resources. This means:
 
 - Remove files in src/main/resources/stacks/*/services/NAGIOS
 - Remove files in test/main/resources/stacks/*/services/NAGIOS
 - Associated tests that depend on Nagios must be either removed if irrelevent 
 or rewritten
 
 This effort should leave Ambari in a state where the web client and 
 blueprints can still successfully install a non-Nagios cluster. Once 
 installed, the cluster will operate normally with the exception that alerts 
 will not be surfaced by the web client until they have switched over to the 
 new alert framework.
 
 
 Diffs
 -
 
   
 ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml
  c65a496 
   ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py 
 b7026e2 
   ambari-server/src/main/resources/custom_actions/validate_configs.py c245dbb 
   ambari-server/src/main/resources/properties.json 36cff96 
   ambari-server/src/main/resources/role_command_order.json c45ba07 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/blueprints/multinode-default.json
  642fcfa 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/blueprints/singlenode-default.json
  3c769dd 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/hooks/before-INSTALL/scripts/params.py
  01789a7 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/hooks/before-START/scripts/params.py
  ac8f1c8 
   ambari-server/src/main/resources/stacks/BIGTOP/0.8/role_command_order.json 
 69fcdac 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/GANGLIA/package/files/gmondLib.sh
  e7ea83f 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py
  83b2ed9 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/configuration/nagios-env.xml
  fad8374 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/metainfo.xml
  bebc7d6 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_aggregate.php
  792b25b 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_ambari_alerts.py
  833a798 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_checkpoint_time.py
  ab889d1 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_cpu.php
  0744e38 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_cpu.pl
  a5680f7 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_cpu_ha.php
  91a7c64 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_datanode_storage.php
  dee22b4 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_hdfs_blocks.php
  3693aa0 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_hdfs_capacity.php
  af72723 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_hive_metastore_status.sh
  640c077 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_hue_status.sh
  076d9b3 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_mapred_local_dir_used.sh
  3f9243a 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_name_dir_status.php
  186166d 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_namenodes_ha.sh
  83c1aca 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_nodemanager_health.sh
  eedcd62 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_oozie_status.sh
  820ee99 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_rpcq_latency.php
  

Re: Review Request 27870: Alerts: Remove Nagios Service From The Stack

2014-11-11 Thread Tom Beerbower

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27870/#review60807
---

Ship it!


Ship It!

- Tom Beerbower


On Nov. 11, 2014, 4:08 p.m., Jonathan Hurley wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/27870/
 ---
 
 (Updated Nov. 11, 2014, 4:08 p.m.)
 
 
 Review request for Ambari, Dmytro Sen, Nate Cole, Srimanth Gunturi, Tom 
 Beerbower, and Yusaku Sako.
 
 
 Bugs: AMBARI-8276
 https://issues.apache.org/jira/browse/AMBARI-8276
 
 
 Repository: ambari
 
 
 Description
 ---
 
 With the new alerting framework in place, the Nagios stack files can start to 
 be removed. This involves many different steps between the server, the web 
 client, and the agent.
 
 In this Jira, we will track the removal of the stack resources. This means:
 
 - Remove files in src/main/resources/stacks/*/services/NAGIOS
 - Remove files in test/main/resources/stacks/*/services/NAGIOS
 - Associated tests that depend on Nagios must be either removed if irrelevent 
 or rewritten
 
 This effort should leave Ambari in a state where the web client and 
 blueprints can still successfully install a non-Nagios cluster. Once 
 installed, the cluster will operate normally with the exception that alerts 
 will not be surfaced by the web client until they have switched over to the 
 new alert framework.
 
 
 Diffs
 -
 
   
 ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml
  c65a496 
   ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py 
 b7026e2 
   ambari-server/src/main/resources/custom_actions/validate_configs.py c245dbb 
   ambari-server/src/main/resources/properties.json 36cff96 
   ambari-server/src/main/resources/role_command_order.json c45ba07 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/blueprints/multinode-default.json
  642fcfa 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/blueprints/singlenode-default.json
  3c769dd 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/hooks/before-INSTALL/scripts/params.py
  01789a7 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/hooks/before-START/scripts/params.py
  ac8f1c8 
   ambari-server/src/main/resources/stacks/BIGTOP/0.8/role_command_order.json 
 69fcdac 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/GANGLIA/package/files/gmondLib.sh
  e7ea83f 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py
  83b2ed9 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/configuration/nagios-env.xml
  fad8374 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/metainfo.xml
  bebc7d6 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_aggregate.php
  792b25b 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_ambari_alerts.py
  833a798 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_checkpoint_time.py
  ab889d1 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_cpu.php
  0744e38 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_cpu.pl
  a5680f7 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_cpu_ha.php
  91a7c64 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_datanode_storage.php
  dee22b4 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_hdfs_blocks.php
  3693aa0 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_hdfs_capacity.php
  af72723 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_hive_metastore_status.sh
  640c077 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_hue_status.sh
  076d9b3 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_mapred_local_dir_used.sh
  3f9243a 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_name_dir_status.php
  186166d 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_namenodes_ha.sh
  83c1aca 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_nodemanager_health.sh
  eedcd62 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_oozie_status.sh
  820ee99 
   
 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_rpcq_latency.php