Re: Review Request 38356: Upgrade AMS Phoenix + HBase to HDP-2.3.2.0

2015-09-16 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38356/
---

(Updated Сен. 16, 2015, 11:14 д.п.)


Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.


Bugs: AMBARI-13091
https://issues.apache.org/jira/browse/AMBARI-13091


Repository: ambari


Description
---

AMS still uses HDP-2.2 bits for HBase, Phoenix and Hadoop Common.
Several important fixes specially perf related went into Phoenix and HBase 
during HDP-2.3.2.0 time frame.


Diffs (updated)
-

  ambari-metrics/ambari-metrics-timelineservice/pom.xml 705ea0f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryClientService.java
 a12e373 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManager.java
 db25d29 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerImpl.java
 386a9f1 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
 24223a5 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/AHSWebApp.java
 8cff741 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/AHSWebServices.java
 2040f57 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java
 442dbf5 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TestAHSWebApp.java
 5f23f83 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TestAHSWebServices.java
 7ca5a03 
  ambari-metrics/pom.xml 27d8347 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metrics.json
 6131606 

Diff: https://reviews.apache.org/r/38356/diff/


Testing
---

In progress


Thanks,

Dmytro Sen

Re: Review Request 38356: Upgrade AMS Phoenix + HBase to HDP-2.3.2.0

2015-09-15 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38356/#review99043
---

Ship it!


Ship It!

- Sid Wagle


On Sept. 15, 2015, 11:52 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38356/
> ---
> 
> (Updated Sept. 15, 2015, 11:52 a.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-13091
> https://issues.apache.org/jira/browse/AMBARI-13091
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMS still uses HDP-2.2 bits for HBase, Phoenix and Hadoop Common.
> Several important fixes specially perf related went into Phoenix and HBase 
> during HDP-2.3.2.0 time frame.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 705ea0f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryClientService.java
>  a12e373 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManager.java
>  db25d29 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerImpl.java
>  386a9f1 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
>  24223a5 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/AHSWebApp.java
>  8cff741 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/AHSWebServices.java
>  2040f57 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java
>  442dbf5 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TestAHSWebApp.java
>  5f23f83 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TestAHSWebServices.java
>  7ca5a03 
>   ambari-metrics/pom.xml 27d8347 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metrics.json
>  6131606 
> 
> Diff: https://reviews.apache.org/r/38356/diff/
> 
> 
> Testing
> ---
> 
> In progress
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 38356: Upgrade AMS Phoenix + HBase to HDP-2.3.2.0

2015-09-15 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38356/
---

(Updated Сен. 15, 2015, 11:52 д.п.)


Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.


Bugs: AMBARI-13091
https://issues.apache.org/jira/browse/AMBARI-13091


Repository: ambari


Description
---

AMS still uses HDP-2.2 bits for HBase, Phoenix and Hadoop Common.
Several important fixes specially perf related went into Phoenix and HBase 
during HDP-2.3.2.0 time frame.


Diffs (updated)
-

  ambari-metrics/ambari-metrics-timelineservice/pom.xml 705ea0f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryClientService.java
 a12e373 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManager.java
 db25d29 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerImpl.java
 386a9f1 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
 24223a5 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/AHSWebApp.java
 8cff741 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/AHSWebServices.java
 2040f57 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java
 442dbf5 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TestAHSWebApp.java
 5f23f83 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TestAHSWebServices.java
 7ca5a03 
  ambari-metrics/pom.xml 27d8347 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metrics.json
 6131606 

Diff: https://reviews.apache.org/r/38356/diff/


Testing
---

In progress


Thanks,

Dmytro Sen

Re: Review Request 38356: Upgrade AMS Phoenix + HBase to HDP-2.3.2.0

2015-09-14 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38356/#review98873
---

Ship it!



ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
 (line 1)


Are these test ported over from YARN - ATS code?
The intention is to turn off any feature we do not use for AMS that could 
cause overhead. Unit tests are harmless but something like a TimelineStore 
would be. In the current impl we make sure to turn off the LevelDB store, is 
that still the case?


- Sid Wagle


On Sept. 14, 2015, 4:02 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38356/
> ---
> 
> (Updated Sept. 14, 2015, 4:02 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-13091
> https://issues.apache.org/jira/browse/AMBARI-13091
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMS still uses HDP-2.2 bits for HBase, Phoenix and Hadoop Common.
> Several important fixes specially perf related went into Phoenix and HBase 
> during HDP-2.3.2.0 time frame.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 705ea0f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryClientService.java
>  a12e373 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManager.java
>  db25d29 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerImpl.java
>  386a9f1 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
>  24223a5 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/AHSWebApp.java
>  8cff741 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/AHSWebServices.java
>  2040f57 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java
>  442dbf5 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TestAHSWebApp.java
>  5f23f83 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TestAHSWebServices.java
>  7ca5a03 
>   ambari-metrics/pom.xml 27d8347 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metrics.json
>  6131606 
> 
> Diff: https://reviews.apache.org/r/38356/diff/
> 
> 
> Testing
> ---
> 
> In progress
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>