Review Request 36551: Manual Stack Upgrade - Unable to set current after upgrade from 2.2 - 2.3. Additional changes

2015-07-16 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36551/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev Konar, 
and Nate Cole.


Bugs: AMBARI-12425
https://issues.apache.org/jira/browse/AMBARI-12425


Repository: ambari


Description
---

1) Ambari 2.0.0 + HDP 2.2.6, hdfs, yarn, mr, zk
2) upgrade to Ambari 2.1.0 build #1455
3) All looks good. Perform manual upgrade to HDP 2.3 #2557
4) All looks good. Go to finish and set-current. fails.
[root@c6401 conf]# ambari-server set-current --cluster-name=MyCluster 
--version-display-name=HDP-2.3.0.0
Using python  /usr/bin/python2.6
Setting current version...
Enter Ambari Admin login: admin
Enter Ambari Admin password: 
ERROR: Exiting with exit code 1. 
REASON: Error during setting current version. Http status code - 500. 
 {
  status : 500,
  message : org.apache.ambari.server.controller.spi.SystemException: 
Finalization failed. More details: \nSTDOUT: Begin finalizing the upgrade of 
cluster MyCluster to version 2.3.0.0-2557\n\nSTDERR: Cluster stack version 
2.3.0.0-2557 not found
}


Previous patch was not fully correct: it accessed ClusterEntity directly, not 
modifying our application-level cache (ClusterImplementation). I missed this 
issue when testing patch yesterday, because I redeployed jar and restarted 
server every time after jar replacement.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 8f50004 

Diff: https://reviews.apache.org/r/36551/diff/


Testing
---

I verified that my fix works without ambari-server restart (testing old version 
and new version on the same VM snapshot).

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views .. SUCCESS [2.924s]
[INFO] Ambari Metrics Common . SUCCESS [1.625s]
[INFO] Ambari Server . SUCCESS [48:46.490s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 48:54.697s
[INFO] Finished at: Thu Jul 16 21:31:04 EEST 2015
[INFO] Final Memory: 66M/1153M
[INFO] 


Thanks,

Dmitro Lisnichenko

Re: Review Request 36551: Manual Stack Upgrade - Unable to set current after upgrade from 2.2 - 2.3. Additional changes

2015-07-16 Thread Mahadev Konar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36551/#review91941
---

Ship it!


Ship It!

- Mahadev Konar


On July 16, 2015, 6:45 p.m., Dmitro Lisnichenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36551/
 ---
 
 (Updated July 16, 2015, 6:45 p.m.)
 
 
 Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev 
 Konar, and Nate Cole.
 
 
 Bugs: AMBARI-12425
 https://issues.apache.org/jira/browse/AMBARI-12425
 
 
 Repository: ambari
 
 
 Description
 ---
 
 1) Ambari 2.0.0 + HDP 2.2.6, hdfs, yarn, mr, zk
 2) upgrade to Ambari 2.1.0 build #1455
 3) All looks good. Perform manual upgrade to HDP 2.3 #2557
 4) All looks good. Go to finish and set-current. fails.
 [root@c6401 conf]# ambari-server set-current --cluster-name=MyCluster 
 --version-display-name=HDP-2.3.0.0
 Using python  /usr/bin/python2.6
 Setting current version...
 Enter Ambari Admin login: admin
 Enter Ambari Admin password: 
 ERROR: Exiting with exit code 1. 
 REASON: Error during setting current version. Http status code - 500. 
  {
   status : 500,
   message : org.apache.ambari.server.controller.spi.SystemException: 
 Finalization failed. More details: \nSTDOUT: Begin finalizing the upgrade of 
 cluster MyCluster to version 2.3.0.0-2557\n\nSTDERR: Cluster stack version 
 2.3.0.0-2557 not found
 }
 
 
 Previous patch was not fully correct: it accessed ClusterEntity directly, not 
 modifying our application-level cache (ClusterImplementation). I missed this 
 issue when testing patch yesterday, because I redeployed jar and restarted 
 server every time after jar replacement.
 
 
 Diffs
 -
 
   
 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
  8f50004 
 
 Diff: https://reviews.apache.org/r/36551/diff/
 
 
 Testing
 ---
 
 I verified that my fix works without ambari-server restart (testing old 
 version and new version on the same VM snapshot).
 
 [INFO] 
 
 [INFO] Reactor Summary:
 [INFO] 
 [INFO] Ambari Views .. SUCCESS [2.924s]
 [INFO] Ambari Metrics Common . SUCCESS [1.625s]
 [INFO] Ambari Server . SUCCESS 
 [48:46.490s]
 [INFO] 
 
 [INFO] BUILD SUCCESS
 [INFO] 
 
 [INFO] Total time: 48:54.697s
 [INFO] Finished at: Thu Jul 16 21:31:04 EEST 2015
 [INFO] Final Memory: 66M/1153M
 [INFO] 
 
 
 
 Thanks,
 
 Dmitro Lisnichenko