Re: Review Request 39524: Display sysctl and limits configuration on the HAWQ config UI screen

2015-10-22 Thread Alejandro Fernandez


> On Oct. 22, 2015, 1:07 a.m., Alejandro Fernandez wrote:
> > Ship It!
> 
> bhuvnesh chaudhary wrote:
> Thanks Alejandro

Please close the review as submitted


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39524/#review103502
---


On Oct. 21, 2015, 8:45 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39524/
> ---
> 
> (Updated Oct. 21, 2015, 8:45 p.m.)
> 
> 
> Review request for Ambari and jun aoki.
> 
> 
> Bugs: AMBARI-13510
> https://issues.apache.org/jira/browse/AMBARI-13510
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User should be able to see the values of sysctl and limits parameters which 
> are configured for HAWQ.
> Sysctl parameters except vm.overcommit.memory are editable only during 
> install, after install they are read only. overcommit parameter can be 
> changed as needed.
> limits for hawq user(gpadmin) are editable.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/hawq-limits-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/hawq-sysctl-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/common.py
>  defd87c 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/constants.py
>  78a636e 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqstatus.py
>  59742bd 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/master_helper.py
>  82a5168 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/params.py
>  df33d0b 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/utils.py
>  b42b3a6 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq.limits.conf.j2
>  93e027c 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq.sysctl.conf.j2
>  480228e 
> 
> Diff: https://reviews.apache.org/r/39524/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>



Re: Review Request 39524: Display sysctl and limits configuration on the HAWQ config UI screen

2015-10-21 Thread bhuvnesh chaudhary


> On Oct. 22, 2015, 1:07 a.m., Alejandro Fernandez wrote:
> > Ship It!

Thanks Alejandro


- bhuvnesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39524/#review103502
---


On Oct. 21, 2015, 8:45 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39524/
> ---
> 
> (Updated Oct. 21, 2015, 8:45 p.m.)
> 
> 
> Review request for Ambari and jun aoki.
> 
> 
> Bugs: AMBARI-13510
> https://issues.apache.org/jira/browse/AMBARI-13510
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User should be able to see the values of sysctl and limits parameters which 
> are configured for HAWQ.
> Sysctl parameters except vm.overcommit.memory are editable only during 
> install, after install they are read only. overcommit parameter can be 
> changed as needed.
> limits for hawq user(gpadmin) are editable.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/hawq-limits-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/hawq-sysctl-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/common.py
>  defd87c 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/constants.py
>  78a636e 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqstatus.py
>  59742bd 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/master_helper.py
>  82a5168 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/params.py
>  df33d0b 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/utils.py
>  b42b3a6 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq.limits.conf.j2
>  93e027c 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq.sysctl.conf.j2
>  480228e 
> 
> Diff: https://reviews.apache.org/r/39524/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>



Re: Review Request 39524: Display sysctl and limits configuration on the HAWQ config UI screen

2015-10-21 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39524/#review103502
---

Ship it!


Ship It!

- Alejandro Fernandez


On Oct. 21, 2015, 8:45 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39524/
> ---
> 
> (Updated Oct. 21, 2015, 8:45 p.m.)
> 
> 
> Review request for Ambari and jun aoki.
> 
> 
> Bugs: AMBARI-13510
> https://issues.apache.org/jira/browse/AMBARI-13510
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User should be able to see the values of sysctl and limits parameters which 
> are configured for HAWQ.
> Sysctl parameters except vm.overcommit.memory are editable only during 
> install, after install they are read only. overcommit parameter can be 
> changed as needed.
> limits for hawq user(gpadmin) are editable.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/hawq-limits-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/hawq-sysctl-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/common.py
>  defd87c 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/constants.py
>  78a636e 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqstatus.py
>  59742bd 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/master_helper.py
>  82a5168 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/params.py
>  df33d0b 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/utils.py
>  b42b3a6 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq.limits.conf.j2
>  93e027c 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq.sysctl.conf.j2
>  480228e 
> 
> Diff: https://reviews.apache.org/r/39524/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>



Re: Review Request 39524: Display sysctl and limits configuration on the HAWQ config UI screen

2015-10-21 Thread bhuvnesh chaudhary

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39524/
---

(Updated Oct. 21, 2015, 8:45 p.m.)


Review request for Ambari and jun aoki.


Changes
---

Updated jira number AMBARI-13510


Bugs: AMBARI-13510
https://issues.apache.org/jira/browse/AMBARI-13510


Repository: ambari


Description
---

User should be able to see the values of sysctl and limits parameters which are 
configured for HAWQ.
Sysctl parameters except vm.overcommit.memory are editable only during install, 
after install they are read only. overcommit parameter can be changed as needed.
limits for hawq user(gpadmin) are editable.


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/hawq-limits-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/hawq-sysctl-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/common.py
 defd87c 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/constants.py
 78a636e 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqstatus.py
 59742bd 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/master_helper.py
 82a5168 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/params.py
 df33d0b 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/utils.py
 b42b3a6 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq.limits.conf.j2
 93e027c 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq.sysctl.conf.j2
 480228e 

Diff: https://reviews.apache.org/r/39524/diff/


Testing
---

yes


Thanks,

bhuvnesh chaudhary



Re: Review Request 39524: Display sysctl and limits configuration on the HAWQ config UI screen

2015-10-21 Thread bhuvnesh chaudhary

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39524/
---

(Updated Oct. 21, 2015, 8:43 p.m.)


Review request for Ambari and jun aoki.


Repository: ambari


Description (updated)
---

User should be able to see the values of sysctl and limits parameters which are 
configured for HAWQ.
Sysctl parameters except vm.overcommit.memory are editable only during install, 
after install they are read only. overcommit parameter can be changed as needed.
limits for hawq user(gpadmin) are editable.


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/hawq-limits-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/hawq-sysctl-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/common.py
 defd87c 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/constants.py
 78a636e 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqstatus.py
 59742bd 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/master_helper.py
 82a5168 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/params.py
 df33d0b 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/utils.py
 b42b3a6 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq.limits.conf.j2
 93e027c 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq.sysctl.conf.j2
 480228e 

Diff: https://reviews.apache.org/r/39524/diff/


Testing
---

yes


Thanks,

bhuvnesh chaudhary



Review Request 39524: Display sysctl and limits configuration on the HAWQ config UI screen

2015-10-21 Thread bhuvnesh chaudhary

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39524/
---

Review request for Ambari and jun aoki.


Repository: ambari


Description
---

ser should be able to see the values of sysctl and limits parameters which are 
configured for HAWQ.
Sysctl parameters except vm.overcommit.memory are editable only during install, 
after install they are read only. overcommit parameter can be changed as needed.
limits for hawq user(gpadmin) are editable.


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/hawq-limits-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/hawq-sysctl-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/common.py
 defd87c 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/constants.py
 78a636e 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqstatus.py
 59742bd 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/master_helper.py
 82a5168 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/params.py
 df33d0b 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/utils.py
 b42b3a6 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq.limits.conf.j2
 93e027c 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq.sysctl.conf.j2
 480228e 

Diff: https://reviews.apache.org/r/39524/diff/


Testing
---

yes


Thanks,

bhuvnesh chaudhary