date:20200326

Re: Weekly calls/chats?

2020-03-26 Thread Gerben

Reminder: this call is in (less than) an hour.

On 19/03/2020 18:16, Gerben wrote:
> Notes from today’s call below.
>
> Next call, same time and place: Thursday 26 March 16:00 UTC
> , in
> 
>
> ===
>
> Present: Benjamin, Juan, Randall, Gerben, Nick
>
> Despite successful vote in the dev-list, the release failed because we
> forgot to add the Apache licence header to some source files. We will
> (l)earn it, some day.
>
> Discussed tasks:
> - add missing licence header and open a new vote — Randall
> - figure out what exactly to put in Licence and Notice file — Benjamin
> - document our processes in the repo: how to use Rat to check Apache’s
> requirements, how to create a release, and how to verify the
> contents/hashes the release objects — Randall
> - test & merge PR #62 to use highlighter in demo — (unassigned?)
> - Deduplicate the separate demos in the code repo and website repo — Gerben
> - add the logo to the website — anyone in a good mood
>
> On 19/03/2020 17:03, Benjamin Young wrote:
>> Ready when y'all are. ;)
>>
>> Also, there's an (old) #annotator channel on irc.freenode.net that several 
>> of us have hung out in (for years). Feel free to join there also!
>>
>> Talk soon,
>> Benjamin
>>
>>
>> --
>>
>> http://bigbluehat.com/
>>
>> http://linkedin.com/in/benjaminyoung
>>
>> 
>> From: Gerben 
>> Sent: Wednesday, March 18, 2020 6:22 PM
>> To: dev@annotator.incubator.apache.org 
>> Subject: Re: Weekly calls/chats?
>>
>> Reminder for tomorrow’s call.
>>
>> These days there is a risk that Jitsi is overloaded, let’s see if it
>> works and try find another instance/solution if necessary (and if so,
>> announce it on this list).
>>
>> 19 March 16:00 UTC: https://everytimezone.com/s/a02b29d3
>> Room: https://meet.jit.si/apache-annotator
>>
>> To join by phone dial one of these numbers and then enter the pin.
>>
>> PIN: 2527 1718 26
>>
>> Phone numbers:
>> US +1.512.402.2718
>> UK +44.121.468.3154
>> France +33.1.84.88.6478
>> Germany +49.89.380.38719
>> Spain +34.932.205.409
>> Canada +1.647.243.6108
>> Australia +61.8.7150.1136
>> Brazil +55.21.3500.0112
>> Japan +81.3.4510.2372
>> Switzerland +41.61.588.0496
>>
>>

Re: Weekly calls/chats?

2020-03-26 Thread TB Dinesh

Thanks. We are skipping today's call. Looking forward to minutes

On Thu, 26 Mar, 2020, 20:36 Gerben,  wrote:

> Reminder: this call is in (less than) an hour.
>
> On 19/03/2020 18:16, Gerben wrote:
> > Notes from today’s call below.
> >
> > Next call, same time and place: Thursday 26 March 16:00 UTC
> > , in
> > 
> >
> > ===
> >
> > Present: Benjamin, Juan, Randall, Gerben, Nick
> >
> > Despite successful vote in the dev-list, the release failed because we
> > forgot to add the Apache licence header to some source files. We will
> > (l)earn it, some day.
> >
> > Discussed tasks:
> > - add missing licence header and open a new vote — Randall
> > - figure out what exactly to put in Licence and Notice file — Benjamin
> > - document our processes in the repo: how to use Rat to check Apache’s
> > requirements, how to create a release, and how to verify the
> > contents/hashes the release objects — Randall
> > - test & merge PR #62 to use highlighter in demo — (unassigned?)
> > - Deduplicate the separate demos in the code repo and website repo —
> Gerben
> > - add the logo to the website — anyone in a good mood
> >
> > On 19/03/2020 17:03, Benjamin Young wrote:
> >> Ready when y'all are. ;)
> >>
> >> Also, there's an (old) #annotator channel on irc.freenode.net that
> several of us have hung out in (for years). Feel free to join there also!
> >>
> >> Talk soon,
> >> Benjamin
> >>
> >>
> >> --
> >>
> >> http://bigbluehat.com/
> >>
> >> http://linkedin.com/in/benjaminyoung
> >>
> >> 
> >> From: Gerben 
> >> Sent: Wednesday, March 18, 2020 6:22 PM
> >> To: dev@annotator.incubator.apache.org <
> dev@annotator.incubator.apache.org>
> >> Subject: Re: Weekly calls/chats?
> >>
> >> Reminder for tomorrow’s call.
> >>
> >> These days there is a risk that Jitsi is overloaded, let’s see if it
> >> works and try find another instance/solution if necessary (and if so,
> >> announce it on this list).
> >>
> >> 19 March 16:00 UTC: https://everytimezone.com/s/a02b29d3
> >> Room: https://meet.jit.si/apache-annotator
> >>
> >> To join by phone dial one of these numbers and then enter the pin.
> >>
> >> PIN: 2527 1718 26
> >>
> >> Phone numbers:
> >> US +1.512.402.2718
> >> UK +44.121.468.3154
> >> France +33.1.84.88.6478
> >> Germany +49.89.380.38719
> >> Spain +34.932.205.409
> >> Canada +1.647.243.6108
> >> Australia +61.8.7150.1136
> >> Brazil +55.21.3500.0112
> >> Japan +81.3.4510.2372
> >> Switzerland +41.61.588.0496
> >>
> >>
>

Re: Weekly calls/chats?

2020-03-26 Thread Gerben

>From next week, *one hour earlier* as the proposal was to jump along
with summertime / daylight saving time starting in (most of?) Europe.
So Thursday 2 April, 15:00 GMT 


== Today’s call notes ==
Present: Randall, Nick, Gerben
- Licensing nitty-gritty, Randall may follow up about this.
- Whether to import Randall’s dom-seek code into Annotator
; and whether then want to publish
it as a module (as people might have use for it), or just consider it
internal code we need for dom/text-quote.js (to keep a coherent set of
high-level packages, reduce maintenance&documentation effort). Probably
we will include and publish it for now, but we could decide to drop it
in the future.
- Using the highlighter package in the demo (= merge PR #62), then use
the demo in the website — but how best to depend on a lerna package
across the two repositories?


On 26/03/2020 16:36, TB Dinesh wrote:
> Thanks. We are skipping today's call. Looking forward to minutes
>
> On Thu, 26 Mar, 2020, 20:36 Gerben,  wrote:
>
>> Reminder: this call is in (less than) an hour.
>>
>> On 19/03/2020 18:16, Gerben wrote:
>>> Notes from today’s call below.
>>>
>>> Next call, same time and place: Thursday 26 March 16:00 UTC
>>> , in
>>> 
>>>
>>> ===
>>>
>>> Present: Benjamin, Juan, Randall, Gerben, Nick
>>>
>>> Despite successful vote in the dev-list, the release failed because we
>>> forgot to add the Apache licence header to some source files. We will
>>> (l)earn it, some day.
>>>
>>> Discussed tasks:
>>> - add missing licence header and open a new vote — Randall
>>> - figure out what exactly to put in Licence and Notice file — Benjamin
>>> - document our processes in the repo: how to use Rat to check Apache’s
>>> requirements, how to create a release, and how to verify the
>>> contents/hashes the release objects — Randall
>>> - test & merge PR #62 to use highlighter in demo — (unassigned?)
>>> - Deduplicate the separate demos in the code repo and website repo —
>> Gerben
>>> - add the logo to the website — anyone in a good mood
>>>
>>> On 19/03/2020 17:03, Benjamin Young wrote:
 Ready when y'all are. ;)

 Also, there's an (old) #annotator channel on irc.freenode.net that
>> several of us have hung out in (for years). Feel free to join there also!
 Talk soon,
 Benjamin


 --

 http://bigbluehat.com/

 http://linkedin.com/in/benjaminyoung

 
 From: Gerben 
 Sent: Wednesday, March 18, 2020 6:22 PM
 To: dev@annotator.incubator.apache.org <
>> dev@annotator.incubator.apache.org>
 Subject: Re: Weekly calls/chats?

 Reminder for tomorrow’s call.

 These days there is a risk that Jitsi is overloaded, let’s see if it
 works and try find another instance/solution if necessary (and if so,
 announce it on this list).

 19 March 16:00 UTC: https://everytimezone.com/s/a02b29d3
 Room: https://meet.jit.si/apache-annotator

 To join by phone dial one of these numbers and then enter the pin.

 PIN: 2527 1718 26

 Phone numbers:
 US +1.512.402.2718
 UK +44.121.468.3154
 France +33.1.84.88.6478
 Germany +49.89.380.38719
 Spain +34.932.205.409
 Canada +1.647.243.6108
 Australia +61.8.7150.1136
 Brazil +55.21.3500.0112
 Japan +81.3.4510.2372
 Switzerland +41.61.588.0496

Re: Weekly calls/chats?

2020-03-26 Thread Benjamin Young

Sorry I missed this one folks! The new time (starting next week) will be a 
better fit for me, so hopefully I'll miss less often. :-/

Also, looks like y'all got good stuff done! Thank you!!

And...in case you've missed it, Apache turned 21 today!
https://twitter.com/bigbluehat/status/1243203375988191232?s=20

Cheers!
Benjamin


--

http://bigbluehat.com/

http://linkedin.com/in/benjaminyoung


From: Gerben 
Sent: Thursday, March 26, 2020 1:10 PM
To: dev@annotator.incubator.apache.org 
Subject: Re: Weekly calls/chats?

From next week, *one hour earlier* as the proposal was to jump along
with summertime / daylight saving time starting in (most of?) Europe.
So Thursday 2 April, 15:00 GMT 


== Today’s call notes ==
Present: Randall, Nick, Gerben
- Licensing nitty-gritty, Randall may follow up about this.
- Whether to import Randall’s dom-seek code into Annotator
; and whether then want to publish
it as a module (as people might have use for it), or just consider it
internal code we need for dom/text-quote.js (to keep a coherent set of
high-level packages, reduce maintenance&documentation effort). Probably
we will include and publish it for now, but we could decide to drop it
in the future.
- Using the highlighter package in the demo (= merge PR #62), then use
the demo in the website — but how best to depend on a lerna package
across the two repositories?


On 26/03/2020 16:36, TB Dinesh wrote:
> Thanks. We are skipping today's call. Looking forward to minutes
>
> On Thu, 26 Mar, 2020, 20:36 Gerben,  wrote:
>
>> Reminder: this call is in (less than) an hour.
>>
>> On 19/03/2020 18:16, Gerben wrote:
>>> Notes from today’s call below.
>>>
>>> Next call, same time and place: Thursday 26 March 16:00 UTC
>>> , in
>>> 
>>>
>>> ===
>>>
>>> Present: Benjamin, Juan, Randall, Gerben, Nick
>>>
>>> Despite successful vote in the dev-list, the release failed because we
>>> forgot to add the Apache licence header to some source files. We will
>>> (l)earn it, some day.
>>>
>>> Discussed tasks:
>>> - add missing licence header and open a new vote — Randall
>>> - figure out what exactly to put in Licence and Notice file — Benjamin
>>> - document our processes in the repo: how to use Rat to check Apache’s
>>> requirements, how to create a release, and how to verify the
>>> contents/hashes the release objects — Randall
>>> - test & merge PR #62 to use highlighter in demo — (unassigned?)
>>> - Deduplicate the separate demos in the code repo and website repo —
>> Gerben
>>> - add the logo to the website — anyone in a good mood
>>>
>>> On 19/03/2020 17:03, Benjamin Young wrote:
 Ready when y'all are. ;)

 Also, there's an (old) #annotator channel on irc.freenode.net that
>> several of us have hung out in (for years). Feel free to join there also!
 Talk soon,
 Benjamin


 --

 http://bigbluehat.com/

 http://linkedin.com/in/benjaminyoung

 
 From: Gerben 
 Sent: Wednesday, March 18, 2020 6:22 PM
 To: dev@annotator.incubator.apache.org <
>> dev@annotator.incubator.apache.org>
 Subject: Re: Weekly calls/chats?

 Reminder for tomorrow’s call.

 These days there is a risk that Jitsi is overloaded, let’s see if it
 works and try find another instance/solution if necessary (and if so,
 announce it on this list).

 19 March 16:00 UTC: https://everytimezone.com/s/a02b29d3
 Room: https://meet.jit.si/apache-annotator

 To join by phone dial one of these numbers and then enter the pin.

 PIN: 2527 1718 26

 Phone numbers:
 US +1.512.402.2718
 UK +44.121.468.3154
 France +33.1.84.88.6478
 Germany +49.89.380.38719
 Spain +34.932.205.409
 Canada +1.647.243.6108
 Australia +61.8.7150.1136
 Brazil +55.21.3500.0112
 Japan +81.3.4510.2372
 Switzerland +41.61.588.0496

[GitHub] [incubator-annotator] Treora commented on a change in pull request #62: Use highlighter in demo

2020-03-26 Thread GitBox

Treora commented on a change in pull request #62: Use highlighter in demo
URL: https://github.com/apache/incubator-annotator/pull/62#discussion_r398861577
 
 

 ##
 File path: demo/index.js
 ##
 @@ -28,62 +28,18 @@ import {
   createRangeSelectorCreator,
   createTextQuoteSelector,
   describeTextQuote,
+  highlightRange,
 } from '@annotator/dom';
 import { makeRefinable } from '@annotator/selector';
 
-function clear() {
-  corpus.innerHTML = selectable.innerHTML;
-}
-
-function highlight(range) {
-  for (const node of textNodes(range)) {
-const mark = document.createElement('mark');
-const markRange = document.createRange();
-markRange.selectNode(node);
-markRange.surroundContents(mark);
-  }
-}
-
-function textNodes(range) {
-  const nodes = [];
-
-  if (range.collapsed) return nodes;
-
-  let startNode = range.startContainer;
-  let startOffset = range.startOffset;
-
-  if (startNode.nodeType === 3) {
-if (startOffset > 0 && startOffset < startNode.length) {
-  startNode = startNode.splitText(startOffset);
-  startOffset = 0;
-}
-  }
-
-  let endNode = range.endContainer;
-  let endOffset = range.endOffset;
-
-  if (endNode.nodeType === 3) {
-if (endOffset > 0 && endOffset < endNode.length) {
-  endNode = endNode.splitText(endOffset);
-  endOffset = 0;
-}
-  }
+const cleanupFunctions = [];
 
-  const walker = document.createTreeWalker(document.documentElement);
-  walker.currentNode = startNode;
-
-  while (walker.currentNode !== endNode) {
-if (walker.currentNode.nodeType === 3) {
-  nodes.push(walker.currentNode);
-}
-walker.nextNode();
-  }
-
-  if (endNode.nodeType === 3 && endOffset > 0) {
-nodes.push(endNode);
+function cleanup() {
+  let removeHighlight;
+  while (removeHighlight = cleanupFunctions.shift()) {
+removeHighlight();
   }
-
-  return nodes;
+  corpus.normalize();
 
 Review comment:
   @tilgovi I just added this `normalize()` for now, so the demo keeps working 
despite the anchoring bug that made the fourth example fail.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Weekly calls/chats?

Re: Weekly calls/chats?

Re: Weekly calls/chats?

Re: Weekly calls/chats?

[GitHub] [incubator-annotator] Treora commented on a change in pull request #62: Use highlighter in demo

5 matches

Site Navigation

Mail list logo

Footer information