Re: Weekly calls/chats?

2020-06-04 Thread Gerben
Notes of tasks discussed in today’s call (which lacked a reminder, but
the rhythm is unchanged):

- propose the release to the incubator mailing list
- create more welcoming documentation to help people understand what
Annotator does, what it does not (or not yet), and how to use it.
- make an example code showing how to use it; perhaps the current demo
would work for this, but we should add a link to its source code on the
website
- look into approaches for documentation going forward; perhaps use
tsdoc and publish its output on the website
- organise and label our open issues, use the issue tracker more
{in|ex}tensively
- try to provide more clarification about the relations and statuses of
related projects, especially AnnotatorJs.
- finish current PRs (typescript & dom-tests), keep on coding



Re: [VOTE] Release Apache Annotator (incubating) version 0.1.0 (-rc.4)

2020-06-04 Thread Christian von Uffel
+1

On 2020/06/04 12:52:16, Nick Kew  wrote:
>
> > On 31 May 2020, at 01:45, Randall Leeds  wrote:>
> > >
> > Dear community,>
> > >
> > I would like to propose we release Apache Annotator (incubating)
0.1.0.>
>
> +1 with reservations (things to consider before next-release):>
>
> > This is the fourth release candidate. Careful readers will note that
the>
> > third release candidate was never voted upon. Gerben found an issue
with>
> > Node.js 14 before voting began. Changes since the second release
candidate:>
>
> Talking of Node.js, the README might say something about prerequisites.>
> yarnpkg.com might be a good site to reference?>
>
> > - Remove references to the fragment identifier specification and parse>
> > grammar from NOTICE and LICENSE files>
>
> Those are looking very minimalist now.  I think that's fine.>
>
> >
https://dist.apache.org/repos/dist/dev/incubator/annotator/source/0.1.0/rc.4>

> > >
> > There you will find a tarball, a GPG signature, and SHA256/SHA512
checksums.>
>
> The signature lacks signatures.  I know that's not something you can>
> simply fix, but please bear it in mind!>
>
>
> >
https://github.com/apache/incubator-annotator/wiki/Testing-a-Source-Release>

>
> I still need to read that, but I don't want to delay you any longer!>
> I see no showstoppers, and ran your checks OK (macos/homebrew).>
>
> -- >
> Nick Kew>


[GitHub] [incubator-annotator] BigBlueHat commented on issue #78: Consider/monitor the new IntersectionObserver spec/work

2020-06-04 Thread GitBox


BigBlueHat commented on issue #78:
URL: 
https://github.com/apache/incubator-annotator/issues/78#issuecomment-638947031


   Closing in favor of #78.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-annotator] BigBlueHat closed issue #78: Consider/monitor the new IntersectionObserver spec/work

2020-06-04 Thread GitBox


BigBlueHat closed issue #78:
URL: https://github.com/apache/incubator-annotator/issues/78


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-annotator] BigBlueHat commented on issue #47: Interleaving selections within the DOM

2020-06-04 Thread GitBox


BigBlueHat commented on issue #47:
URL: 
https://github.com/apache/incubator-annotator/issues/47#issuecomment-638946715


   Originally posted this as a separate issue in #78 (but closing and moving 
here to keep @Treora sane πŸ˜‰):
   > https://www.w3.org/TR/intersection-observer/
   >
   > Might help with highlighter and other anchoring implementations in the DOM.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Re: [VOTE] Release Apache Annotator (incubating) version 0.1.0 (-rc.4)

2020-06-04 Thread TB Dinesh
+1

:)

On Thu, 4 Jun, 2020, 18:53 Suzan Uskudarli, 
wrote:

>
> All checks succeed:
>
> 1. gpg --verify apache-annotator-*.tar.gz.asc  --  OK (good sigs from
> Randall Leeds)
> 2. sha256sum  and sha512sum --  OK
> apache-annotator-0.1.0-rc.4-incubating.tar.gz: OK
> 3. git remote show origin -- OK
> 4. git describe  -- OK   (v0.1.0-rc.4)
> 5. git fetch --unshallow origin tag v0.1.0-rc.4 -- OK
> 6. git status --ignored  -- OK (On branch v0.1.x, no changes added to
> commit )
> 7. make check: OK
> 8. License - OK
>
> I am attaching all the results in case it may be useful
>
> I don't know if I am eligible to vote, if I am +1
>
> On Wed, Jun 3, 2020 at 9:26 PM Benjamin Young 
> wrote:
>
>> Just completed all the tests, and everything looks great!
>>
>> +1
>>
>> (sorry again for the delay!)
>> Benjamin
>>
>>
>> --
>>
>> http://bigbluehat.com/
>>
>> http://linkedin.com/in/benjaminyoung
>>
>> 
>> From: Benjamin Young 
>> Sent: Tuesday, June 2, 2020 5:06 PM
>> To: dev@annotator.incubator.apache.org <
>> dev@annotator.incubator.apache.org>
>> Subject: Re: [VOTE] Release Apache Annotator (incubating) version 0.1.0
>> (-rc.4)
>>
>> Started work on this today, but my day got eaten. πŸ˜• I'll try again
>> tomorrow...
>>
>> Apologies,
>> Benjamin
>>
>>
>>
>> --
>>
>> http://bigbluehat.com/
>>
>> http://linkedin.com/in/benjaminyoung
>>
>> 
>> From: Gerben 
>> Sent: Tuesday, June 2, 2020 7:49 AM
>> To: dev@annotator.incubator.apache.org <
>> dev@annotator.incubator.apache.org>
>> Subject: Re: [VOTE] Release Apache Annotator (incubating) version 0.1.0
>> (-rc.4)
>>
>> +1 indeed.
>>
>> I ran all checks except Rat.
>>
>> On 31/05/2020 02:52, Randall Leeds wrote:
>> > My test results:
>> >
>> > - Signature OK
>> > - Checksums OK
>> > - Local tag matches remote tag
>> > - Contents of the tarball are clean
>> > - Running "make check" passes (Node.js v10.19.0)
>> > - Apache Rat shows no files with license issues
>> >
>> > Vote: +1
>> >
>>
>


Re: [VOTE] Release Apache Annotator (incubating) version 0.1.0 (-rc.4)

2020-06-04 Thread Suzan Uskudarli
All checks succeed:

1. gpg --verify apache-annotator-*.tar.gz.asc  --  OK (good sigs from
Randall Leeds)
2. sha256sum  and sha512sum --  OK
apache-annotator-0.1.0-rc.4-incubating.tar.gz: OK
3. git remote show origin -- OK
4. git describe  -- OK   (v0.1.0-rc.4)
5. git fetch --unshallow origin tag v0.1.0-rc.4 -- OK
6. git status --ignored  -- OK (On branch v0.1.x, no changes added to
commit )
7. make check: OK
8. License - OK

I am attaching all the results in case it may be useful

I don't know if I am eligible to vote, if I am +1

On Wed, Jun 3, 2020 at 9:26 PM Benjamin Young  wrote:

> Just completed all the tests, and everything looks great!
>
> +1
>
> (sorry again for the delay!)
> Benjamin
>
>
> --
>
> http://bigbluehat.com/
>
> http://linkedin.com/in/benjaminyoung
>
> 
> From: Benjamin Young 
> Sent: Tuesday, June 2, 2020 5:06 PM
> To: dev@annotator.incubator.apache.org  >
> Subject: Re: [VOTE] Release Apache Annotator (incubating) version 0.1.0
> (-rc.4)
>
> Started work on this today, but my day got eaten. πŸ˜• I'll try again
> tomorrow...
>
> Apologies,
> Benjamin
>
>
>
> --
>
> http://bigbluehat.com/
>
> http://linkedin.com/in/benjaminyoung
>
> 
> From: Gerben 
> Sent: Tuesday, June 2, 2020 7:49 AM
> To: dev@annotator.incubator.apache.org  >
> Subject: Re: [VOTE] Release Apache Annotator (incubating) version 0.1.0
> (-rc.4)
>
> +1 indeed.
>
> I ran all checks except Rat.
>
> On 31/05/2020 02:52, Randall Leeds wrote:
> > My test results:
> >
> > - Signature OK
> > - Checksums OK
> > - Local tag matches remote tag
> > - Contents of the tarball are clean
> > - Running "make check" passes (Node.js v10.19.0)
> > - Apache Rat shows no files with license issues
> >
> > Vote: +1
> >
>





%%%

gpg --verify apache-annotator-*.tar.gz.asc
gpg: assuming signed data in 'apache-annotator-0.1.0-rc.4-incubating.tar.gz'
gpg: Signature made Sun 31 May 2020 03:28:30 AM +03
gpg:using RSA key 83CBD56B79A00C8693C0B919ED6455D90F33F0BB
gpg: Good signature from "Randall Leeds " [unknown]
gpg: aka "Randall Leeds " [unknown]
gpg: aka "Randall Leeds " [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:  There is no indication that the signature belongs to the owner.
Primary key fingerprint: 9255 5CDE B2C1 5E97 0AD8  FDE8 5994 A5A1 8F13 626A
 Subkey fingerprint: 83CB D56B 79A0 0C86 93C0  B919 ED64 55D9 0F33 F0BB


%%%

sha256sum --check apache-annotator-*.tar.gz.sha256
apache-annotator-0.1.0-rc.4-incubating.tar.gz: OK


%%%

sha512sum --check apache-annotator-*.tar.gz.sha512
apache-annotator-0.1.0-rc.4-incubating.tar.gz: OK

%%%

git remote show origin
* remote origin
  Fetch URL: https://github.com/apache/incubator-annotator.git
  Push  URL: https://github.com/apache/incubator-annotator.git
  HEAD branch: master
  Remote branch:
v0.1.x tracked
  Local branch configured for 'git pull':
v0.1.x merges with remote v0.1.x
  Local ref configured for 'git push':
v0.1.x pushes to v0.1.x (up to date)

%%%

git describe
v0.1.0-rc.4

%%%

git fetch --unshallow origin tag v0.1.0-rc.4
remote: Enumerating objects: 2183, done.
remote: Counting objects: 100% (2183/2183), done.
remote: Compressing objects: 100% (822/822), done.
remote: Total 2139 (delta 1294), reused 2101 (delta 1257), pack-reused 0
Receiving objects: 100% (2139/2139), 1.44 MiB | 1.08 MiB/s, done.  
Resolving deltas: 100% (1294/1294), completed with 25 local objects.


%%%

git status --ignored

On branch v0.1.x
Your branch is up to date with 'origin/v0.1.x'.

Changes not staged for commit:

no changes added to commit (use "git add" and/or "git commit -a")



%%%
make check

Ignored 0 lines in your exclusion files as comments or empty lines.

*
Summary
---
Generated at: 2020-06-04T16:03:13+03:00

Notes: 2
Binaries: 0
Archives: 0
Standards: 23

Apache Licensed: 23
Generated Documents: 0

JavaDocs are generated, thus a license header is optional.
Generated files do not require license headers.

0 Unknown Licenses

*
  Files with Apache License headers will be marked AL
  Binary files (whi

Re: [VOTE] Release Apache Annotator (incubating) version 0.1.0 (-rc.4)

2020-06-04 Thread Nick Kew


> On 31 May 2020, at 01:45, Randall Leeds  wrote:
> 
> Dear community,
> 
> I would like to propose we release Apache Annotator (incubating) 0.1.0.

+1 with reservations (things to consider before next-release):

> This is the fourth release candidate. Careful readers will note that the
> third release candidate was never voted upon. Gerben found an issue with
> Node.js 14 before voting began. Changes since the second release candidate:

Talking of Node.js, the README might say something about prerequisites.
yarnpkg.com might be a good site to reference?

> - Remove references to the fragment identifier specification and parse
> grammar from NOTICE and LICENSE files

Those are looking very minimalist now.  I think that's fine.

> https://dist.apache.org/repos/dist/dev/incubator/annotator/source/0.1.0/rc.4
> 
> There you will find a tarball, a GPG signature, and SHA256/SHA512 checksums.

The signature lacks signatures.  I know that's not something you can
simply fix, but please bear it in mind!


> https://github.com/apache/incubator-annotator/wiki/Testing-a-Source-Release

I still need to read that, but I don't want to delay you any longer!
I see no showstoppers, and ran your checks OK (macos/homebrew).

-- 
Nick Kew