DO NOT REPLY [Bug 39320] - [PATCH] Simple code cleanups

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39320


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Simple code cleanups|[PATCH] Simple code cleanups




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] removal of the test task based upon the org.apache.testlet framework

[Dominique Devienne]

+1. --DD

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] removal of Visual for Java based tasks

[Dominique Devienne]

+1. --DD

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] removal of icontract based task in ant

[Dominique Devienne]

+1. --DD

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] removal of dependency to xslp

[Dominique Devienne]

+1. --DD

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39320] - Simple code cleanups

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39320





--- Additional Comments From [EMAIL PROTECTED]  2006-04-15 14:45 ---
Created an attachment (id=18110)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18110&action=view)
simple code cleanups


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39320] New: - Simple code cleanups

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39320

   Summary: Simple code cleanups
   Product: Ant
   Version: 1.7Alpha (nightly)
  Platform: All
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P3
 Component: Core
AssignedTo: dev@ant.apache.org
ReportedBy: [EMAIL PROTECTED]


This patch represents some simple code cleanups. Not critical, but good ideas 
none the less.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r393996 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Launcher.java

[Dominique Devienne]

> ok, I think the consensus is that I shouldn't have committed this
> change ie -1 to this change from while -> for.

I'm also a proponent of using for loops rather than while loops for
Iterators. I picked up the idiom reading "The Java Programming
Language", and I like the added scope it provides, which is useful
since I tend to use just i (or j / k for nested loops) for the
iterator variable.

In this particular instance, it doesn't help much though, as the var
has an explicit name, the method is short, and the for loop itself is
broken down on 2 lines.

OTOH, I don't like Antoine's for loop ;-) I haven't tried, but I
wouldn't have thought it compiled either ;-))) -DD

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r394275 - /ant/core/trunk/check.xml

[jhm]

Author: jhm
Date: Sat Apr 15 03:04:10 2006
New Revision: 394275

URL: http://svn.apache.org/viewcvs?rev=394275&view=rev
Log:
New targets for fixing two checkstyle errors:
- fixTS:  deletes trailing spaces
- fixTab: converts TABs to 4 spaces

Modified:
ant/core/trunk/check.xml

Modified: ant/core/trunk/check.xml
URL: 
http://svn.apache.org/viewcvs/ant/core/trunk/check.xml?rev=394275&r1=394274&r2=394275&view=diff
==
--- ant/core/trunk/check.xml (original)
+++ ant/core/trunk/check.xml Sat Apr 15 03:04:10 2006
@@ -85,5 +85,21 @@
 
 
   
+   
+  
+
+  
+
+
+  
+
+  
 
+  
+
+  
+
+   
+  
+   
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r394274 - in /ant/core/trunk/src/main/org/apache/tools/ant: filters/FixCrLfFilter.java taskdefs/CopyPath.java taskdefs/optional/SchemaValidate.java taskdefs/optional/dotnet/DotnetResource.

[jhm]

Author: jhm
Date: Sat Apr 15 03:03:06 2006
New Revision: 394274

URL: http://svn.apache.org/viewcvs?rev=394274&view=rev
Log:
Checkstyle

Modified:
ant/core/trunk/src/main/org/apache/tools/ant/filters/FixCrLfFilter.java
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/CopyPath.java

ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/SchemaValidate.java

ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/DotnetResource.java

ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java

Modified: 
ant/core/trunk/src/main/org/apache/tools/ant/filters/FixCrLfFilter.java
URL: 
http://svn.apache.org/viewcvs/ant/core/trunk/src/main/org/apache/tools/ant/filters/FixCrLfFilter.java?rev=394274&r1=394273&r2=394274&view=diff
==
--- ant/core/trunk/src/main/org/apache/tools/ant/filters/FixCrLfFilter.java 
(original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/filters/FixCrLfFilter.java Sat 
Apr 15 03:03:06 2006
@@ -1,5 +1,5 @@
 /*
- * Copyright 2005 The Apache Software Foundation
+ * Copyright 2005-2006 The Apache Software Foundation
  *
  *  Licensed under the Apache License, Version 2.0 (the "License");
  *  you may not use this file except in compliance with the License.
@@ -23,9 +23,8 @@
 import org.apache.tools.ant.types.EnumeratedAttribute;
 
 /**
- * Converts text to local OS formatting conventions, as
- * well as repair text damaged by misconfigured or misguided editors or
- * file transfer programs.
+ * Converts text to local OS formatting conventions, as well as repair text
+ * damaged by misconfigured or misguided editors or file transfer programs.
  * 
  * This filter can take the following arguments:
  * 
@@ -38,42 +37,52 @@
  * 
  * None of which are required.
  * 
- * This version generalises the handling of EOL characters, and allows
- * for CR-only line endings (which I suspect is the standard on Macs.)
- * Tab handling has also been generalised to accommodate any tabwidth
- * from 2 to 80, inclusive.  Importantly, it can leave untouched any
- * literal TAB characters embedded within Java string or character constants.
+ * This version generalises the handling of EOL characters, and allows for
+ * CR-only line endings (which I suspect is the standard on Macs.) Tab handling
+ * has also been generalised to accommodate any tabwidth from 2 to 80,
+ * inclusive. Importantly, it can leave untouched any literal TAB characters
+ * embedded within Java string or character constants.
  * 
- * Caution: run with care on carefully formatted files.  This may
+ * Caution: run with care on carefully formatted files. This may
  * sound obvious, but if you don't specify asis, presume that your files are
- * going to be modified.  If "tabs" is "add" or "remove", whitespace
- * characters may be added or removed as necessary.  Similarly, for EOL's -
- * eol="asis" actually means convert to your native O/S EOL convention while
- * eol="crlf" or cr="add" can result in CR characters being removed in one
- * special case accommodated, i.e., CRCRLF is regarded as a single EOL to
- * handle cases where other programs have converted CRLF into CRCRLF.
+ * going to be modified. If "tabs" is "add" or "remove", whitespace characters
+ * may be added or removed as necessary. Similarly, for EOL's - eol="asis"
+ * actually means convert to your native O/S EOL convention while eol="crlf" or
+ * cr="add" can result in CR characters being removed in one special case
+ * accommodated, i.e., CRCRLF is regarded as a single EOL to handle cases where
+ * other programs have converted CRLF into CRCRLF.
  *
- * Example:
- * <
+ * 
+ * Example:
+ *
+ * 
+ * <
+ * 
  *
  * Or:
  *
- * 
- *  
- * 
+ * 
+ * 
+ *   
+ *  
+ * 
  *
  */
-public final class FixCrLfFilter
-extends BaseParamFilterReader
-implements ChainableReader {
+public final class FixCrLfFilter extends BaseParamFilterReader implements 
ChainableReader {
 private static final char CTRLZ = '\u001A';
 
 private int tabLength = 8;
+
 private CrLf eol;
+
 private AddAsisRemove ctrlz;
+
 private AddAsisRemove tabs;
+
 private boolean javafiles = false;
+
 private boolean fixlast = true;
+
 private boolean initialized = false;
 
 /**
@@ -88,14 +97,16 @@
 /**
  * Create a new filtered reader.
  *
- * @param in A Reader object providing the underlying stream.
- *   Must not be null.
+ * @param in
+ *A Reader object providing the underlying stream. Must not be
+ *null.
  */
 public FixCrLfFilter(final Reader in) throws IOException {
 super(in);
 }