AW: apache-ant-1.7.0: 115 * Java source code bugs

2008-09-11 Thread Jan.Materne
Thanks for trying out PMD on Ant's codebase.
But what we need is an integration into our build.

Could you open a Bugzilla request and attach a target which does the PMD checks?


Jan 

-Ursprüngliche Nachricht-
Von: d binderman [mailto:[EMAIL PROTECTED] 
Gesendet: Donnerstag, 11. September 2008 11:16
An: dev@ant.apache.org
Betreff: apache-ant-1.7.0: 115 * Java source code bugs




Hello there,

I just tried to analyse the package apache-ant-1.7.0 with the most
excellent Java static analysis tool pmd.

A subset of the results were

/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/DefaultLogger.java:249
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/input/DefaultInputHandler.java:107
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/Location.java:139
Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/Main.java:1032
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AbstractCvsTask.java:423
Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:285
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:292
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:314
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:322
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:324
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:327
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:342
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:346
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:359
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:399
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/Checksum.java:577
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/compilers/AptCompilerAdapter.java:141
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java:405
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/Copy.java:998
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/Javadoc.java:1487
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/KeySubst.java:192
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/MacroInstance.java:206
  Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/optional/Cab.java:254
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/optional/Cab.java:256
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/optional/Cab.java:256
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetEjbc.java:412
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs

apache-ant-1.7.0: 115 * Java source code bugs

2008-09-11 Thread d binderman



Hello there,

I just tried to analyse the package apache-ant-1.7.0 with the most
excellent Java static analysis tool pmd.

A subset of the results were

/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/DefaultLogger.java:249
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/input/DefaultInputHandler.java:107
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/Location.java:139
Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/Main.java:1032
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AbstractCvsTask.java:423
Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:285
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:292
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:314
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:322
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:324
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:327
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:342
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:346
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:359
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/AntStructure.java:399
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/Checksum.java:577
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/compilers/AptCompilerAdapter.java:141
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java:405
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/Copy.java:998
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/Javadoc.java:1487
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/KeySubst.java:192
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/MacroInstance.java:206
  Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/optional/Cab.java:254
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/optional/Cab.java:256
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/optional/Cab.java:256
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetEjbc.java:412
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WebsphereDeploymentTool.java:501
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WebsphereDeploymentTool.java:505
   Avoid appending characters as strings in StringBuffer.append.
/usr/src/packages/BUILD/apache-ant-1.7.0/src/main/org/apache/tools/ant/taskdefs/optiona