date:20090201

AW: svn commit: r739577 - /ant/core/trunk/src/main/org/apache/tools/ant/property/NullReturn.java

2009-02-01 Thread Jan.Materne

Very curious ...

Source of String.valueOf(Object) from JDK 1.4.2_15

/**
 * Returns the string representation of the codeObject/code argument.
 *
 * @param   obj   an codeObject/code.
 * @return  if the argument is codenull/code, then a string equal to
 *  codenull/code; otherwise, the value of
 *  codeobj.toString()/code is returned.
 * @see java.lang.Object#toString()
 */
public static String valueOf(Object obj) {
return (obj == null) ? null : obj.toString();
} 


The same for JDK 1.6.0_10

public static String valueOf(Object obj) {
return (obj == null) ? null : obj.toString();
}


But indeed:
Java 1.3.0-C : NPE
Java 1.4.2_15-b02: NPE
Java 1.5.0_12-b04: NPE
Java 1.6.0_02-b05: NPE

If I add a cast then it works
System.out.println(String.valueOf( (Object)null ));

So the compiler must bind that to another method than String.valueOf(Object) ...


But of course, simply returning null is much easier ;)



Jan



 -Ursprüngliche Nachricht-
 Von: Martijn Kruithof [mailto:j...@kruithof.xs4all.nl] 
 Gesendet: Samstag, 31. Januar 2009 22:14
 An: Ant Developers List
 Betreff: Re: svn commit: r739577 - 
 /ant/core/trunk/src/main/org/apache/tools/ant/property/NullReturn.java
 
 Doubted it, checked it and it returned NullPointerException.
 
 D:\type Test.java
 public class Test
 {
 public static void main(String[] args)
 {
 System.out.println(String.valueOf(null));
 }
 }
 
 D:\java Test
 Exception in thread main java.lang.NullPointerException
 at java.lang.String.init(Unknown Source)
 at java.lang.String.valueOf(Unknown Source)
 at Test.main(Test.java:6)
 
 br Martijn
 
 Matt Benson schreef:
  I always thought String.valueOf(null) returned null.
   Was I on crack?
 
  -Matt
 
  P.S.  Good to see you committing, Martijn...
 
  --- j...@apache.org wrote:
 

  Author: jkf
  Date: Sat Jan 31 17:10:50 2009
  New Revision: 739577
 
  URL:
  http://svn.apache.org/viewvc?rev=739577view=rev
  Log:
  Original toString would always throw a NPE.
 
  Modified:
 
 
  
  
 ant/core/trunk/src/main/org/apache/tools/ant/property/NullReturn.java

  Modified:
 
  
  
 ant/core/trunk/src/main/org/apache/tools/ant/property/NullReturn.java

  URL:
 
  
  
 http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apach
 e/tools/ant/property/NullReturn.java?rev=739577r1=739576r2=7
39577view=diff

  
 ==
 

  ---
 
  
  
 ant/core/trunk/src/main/org/apache/tools/ant/property/NullReturn.java

  (original)
  +++
 
  
  
 ant/core/trunk/src/main/org/apache/tools/ant/property/NullReturn.java

  Sat Jan 31 17:10:50 2009
  @@ -33,6 +33,6 @@
* {...@inheritdoc}
*/
   public String toString() {
  -return String.valueOf(null);
  +return null;
   }
   }
 
 
 
  
 
 
 

 
  
 -
  To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
  For additional commands, e-mail: dev-h...@ant.apache.org
 

 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 
 

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Bug report for Ant [2009/02/01]

2009-02-01 Thread bugzilla

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
| 1509|Opn|Enh|2001-04-25|Project object not fully functional in BuildEvents|
| 2743|New|Enh|2001-07-23|More sophisticated dependency analysis|
| 2811|New|Enh|2001-07-25|depend does not work when static final primitive|
| 3310|New|Enh|2001-08-28|Clear case files and directories  |
| 5748|New|Enh|2002-01-08|Filtering, Default Filter |
| 5789|New|Enh|2002-01-10|Enhanced PVCS task.   |
| 6606|Opn|Enh|2002-02-21|META-BUG problems with delegating classloaders|
| 6757|New|Enh|2002-02-28|adding visibility to tasks|
| 7546|New|Enh|2002-03-27|EjbJar:Borland Task doesn't allow alternate compil|
| 7712|New|Enh|2002-04-03|Provide patternset support for VSSGET task?   |
| 8294|New|Enh|2002-04-19|apply: Allow srcfile/ and targetfile/ to app|
| 8866|New|Enh|2002-05-07|Signal handling in java task  |
| 8895|New|Enh|2002-05-08|ant and/or antcall should support forking |
| 8972|New|Enh|2002-05-10|allow property expansion in filterset property v|
| 8981|New|Enh|2002-05-10|Tar task command additional features  |
| 9294|New|Enh|2002-05-21|[PATCH] optional/j2ee/ServerDeploy OC4J Support   |
| 9481|Ass|Enh|2002-05-29|Add a prefix attribute to ExpandProperties filte|
| 9784|New|Enh|2002-06-11|BuildNumber task: make more extendable... |
| 9995|Ass|Enh|2002-06-19|MKS Source Integrity tasks|
|10020|New|Enh|2002-06-19|ejbjar's dependency behaviour should be more con|
|10231|New|Enh|2002-06-25|Need access to current file in SQLExec|
|10283|New|Enh|2002-06-27|Add a destfile to the uptodate task   |
|10402|New|Enh|2002-07-02|adding the ability of html like whitespace preserv|
|3|New|Enh|2002-07-24|keytool task  |
|11143|New|Enh|2002-07-24|Javac should load build.compiler class from a defi|
|11560|Opn|Enh|2002-08-08|Taskdef does not apply reverseLoader policy on sta|
|12267|New|Enh|2002-09-03|Add ability to unzip into separate folders|
|12292|New|Enh|2002-09-04|[PATCH] enable depends target=/ tag inside tar|
|12334|New|Enh|2002-09-05|REQUEST: Ant task doesn't allow attachment of a bu|
|12518|New|Enh|2002-09-11|Gunzip  BUnZip2 add filesets, patternsets, and ov|
|12765|New|Enh|2002-09-18|rmdir and deltree patches for ftp task enhance|
|12964|New|Enh|2002-09-24|ANTLR only takes one input file at a time |
|13047|Inf|Enh|2002-09-26|Support for property environment and exec on O|
|13048|New|Enh|2002-09-26|Add an optional containsall attribute to LineConta|
|13371|New|Enh|2002-10-07|[PATCH] Contributed new CvsExportDiff task|
|13629|New|Enh|2002-10-15|RFE: mention dependset and selectors in delete pag|
|13847|New|Nor|2002-10-22|pvcs task: wrong option (-r) specified for get (sh|
|13934|New|Enh|2002-10-24|Translate task shouldn't load default locale prope|
|13939|New|Enh|2002-10-24|Translate task should have better key matching cap|
|14320|New|Enh|2002-11-06|copy fileset followsymlinks=false does not copy |
|14392|New|Enh|2002-11-08|Make version information more available   |
|14393|New|Enh|2002-11-08|Support use of jndi within ant|
|14512|New|Enh|2002-11-13|Allow creating database connection similar to pat|
|14525|New|Enh|2002-11-13|Add failonerror attribute to serverdeploy vendor-s|
|14901|New|Enh|2002-11-27|[PATCH] Stub Generation enhancement for Borland J2|
|15031|Opn|Nor|2002-12-03|ANT copy with fileset does not spot bad symlin|
|15093|New|Enh|2002-12-05|Would like to have support for States in the Starb|
|15149|New|Enh|2002-12-06|Replace task  |
|15241|New|Enh|2002-12-10|Enhance get to process a list of resources from a |
|15244|New|Enh|2002-12-10|tar task should be able to store symbolic links as|
|15430|New|Enh|2002-12-17|Enhancement to ReplaceRegExp.java |
|15596|New|Enh|2002-12-21|Identity

AW: svn commit: r739577 - /ant/core/trunk/src/main/org/apache/tools/ant/property/NullReturn.java

Bug report for Ant [2009/02/01]

2 matches

Site Navigation

Mail list logo

Footer information