Re: minor bug?

2010-04-06 Thread Maarten Coene
It should be ok now in SVN trunk.
Could you give it a try?

thanks,
Maarten




- Original Message 
From: Peter Karich 
To: Ant Developers List 
Sent: Mon, April 5, 2010 2:49:09 AM
Subject: Re: minor bug?

Why not:
URI uri = url.toURI();
which would fix the problem, I think.

Instead you are doing:

URI uri = new URI(url.getProtocol(), url.getUserInfo(), url.getHost(),
 url.getPort(), url.getPath(), url.getQuery(), 
url.getRef());


> Hi!
>
> In org/apache/*ivy*/util/url/AbstractURLHandler.java
> the method normalizeToString will fail in situations where urls have _
>
> E.g. try with http://peat_hal.users.sourceforge.net/m2repository/
> and you will get  Illegal character in hostname at index 11
>
> How can I nevertheless use that repository with the underscore?
> Renaming this awkward username is a bit complicated ...
>
> Regards,
> Peter.

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org


  

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Augment feature

2010-04-06 Thread Jean-Louis Boudart
I think the idea of implementing an augment features (idea initiated by Matt
Benson as described
https://issues.apache.org/bugzilla/show_bug.cgi?id=48798or in the
previous thread)  make sense.
This idea was to provide a task that allows augmentation of previously
declared references.
There is many places where it can be useful, and as far as i know nobody was
opposed on the main idea.

By the way there was one point still in discussion lost in the whole thread.
Many person was in favor of an opt-in approach to keep backward
compatibility.
I guess, you can only use  feature on references that as been
designed for extention (by adding an argument like final="false" on the
reference for example).

Antoine Levy Lamber was highlighting that ant datatypes are currently
de-facto mutable by default. And maybe we were complexifying too much this
feature.

The objective of this thread is to take a decision on :

   - restriction on augment feature
   - and if the vote is in favor to choose one implementation design to do
   it

So, What's your opinion ?
Should we introduce kind of restriction on the  feature  (like
"final=false") ? Or should we keep this usable on ALL existing reference ?


If the answer is yes How would you like to we restrict this ?
   - by adding a new attribute (like final="false") on datatype ?
   - by adding magic properties ?
   - taking in consideration that taks and types are java objects, can we
reuse a java property "final" as a configuration attribute?
Exemple:private final String myProperty;
   - with another alternative ?


IMHO the augment feature can live without any restriction.
As highlighted by Antoine, with current code base "reference can be modified
by user developed ant tasks or script fragments."

But, it could make sense to provide a way to make reference unmutable. Doing
this a given reference cannot be modified by  task (or by any user
developped ant task / script fragment).
For example :
- if you design a target (or a datatype) used in a multithread context
you probably don't want to make it extensible (because it's gonna be a hell
to maintain).
- if you are designing kind of generic build file, you may want to have
part of this generic stuff extensible but maybe you want to restrict
extension on some of your targets/datatypes that are deeply used internally.
Part of the generic script can be kind of "blackbox".

About implementation details, i would be in favor of adding a new attribute
to datatypes (like final="true"), cause it make it easy to understand /
read.

Considering that current code base allow to modify any references and to
avoid any side effect, i suggest to make the make this restriction optional
.
I guess if you want to make a reference unmuttable you should set it
explicitly (with a final="true").




In any case i really hope to use the  feature soon in easyant :).

My 2 cents


-- 
Jean Louis Boudart
Independent consultant
Project Lead http://www.easyant.org


Re: Dependency depending on OS

2010-04-06 Thread Karolis Petrauskas
I think you should use configurations for this purpose. I.e. create a
configuration for each OS, and assign corresponding  artifacts
(publications) and/or dependencies to these configurations. In the ant
script you can use os property as a configuration to be resolved.

On Tue, Apr 6, 2010 at 10:55 AM,   wrote:
> Hi,
>
> How I can check the dependency depending on the OS name.
>
> I want to check the artifact depending on the OS.
>
> If os=unix then abc.sh
>
> If os=windows then abc.bat.
>
> Thanks and Regards,
> Raghu.A.E
>
>



-- 
Karolis Petrauskas

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



AW: Dependency depending on OS

2010-04-06 Thread Jan.Materne
file.unix=abc.sh
file.windows=abc.bat 
file=file.${os.name}

Jan

p.s.
Exact values not tested, but you should get the idea.



> -Ursprüngliche Nachricht-
> Von: raghu.eswara...@nokia.com [mailto:raghu.eswara...@nokia.com] 
> Gesendet: Dienstag, 6. April 2010 09:56
> An: dev@ant.apache.org
> Betreff: Dependency depending on OS
> 
> Hi,
> 
> How I can check the dependency depending on the OS name.
> 
> I want to check the artifact depending on the OS.
> 
> If os=unix then abc.sh
> 
> If os=windows then abc.bat.
> 
> Thanks and Regards,
> Raghu.A.E
> 
> 

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Dependency depending on OS

2010-04-06 Thread raghu.eswaraiah
Hi,

How I can check the dependency depending on the OS name.

I want to check the artifact depending on the OS.

If os=unix then abc.sh

If os=windows then abc.bat.

Thanks and Regards,
Raghu.A.E