[GitHub] ant-ivy issue #39: first batch of SVG replacements

2017-06-03 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/39
  
Sorry about messing around, I removed execute bits on several test files 
and that ended up in #39, too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #39: first batch of SVG replacements

2017-06-03 Thread janmaterne
Github user janmaterne commented on the issue:

https://github.com/apache/ant-ivy/pull/39
  
Ok, license debate finished. I think its ok.
Merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #41: Checkstyle

2017-06-03 Thread twogee
Github user twogee closed the pull request at:

https://github.com/apache/ant-ivy/pull/41


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: PR-41: use of fonts

2017-06-03 Thread Gintautas Grigelionis
This is Adobe FAQ:
http://www.adobe.com/products/type/font-licensing/licensing-faq.html

Q. Can I use Adobe fonts for commercial projects and client work?

A: Yes, Adobe's standard font licensing agreement (EULA)

allows
for both personal and commercial use, sales, and distribution of designs
and documents which are created using the font software. This may include
printed materials, logos, and rendered content like photographs, film,
video and bitmap graphics.

If distributed, the design should not contain the original font, but can be
converted to vector outlines, rasterized, or subsetted and embedded in an
electronic document like a PDF or eBook.

I guess we're in compliance or do we need additional legal advice?

Gintas

2017-06-03 14:08 GMT+02:00 Gintautas Grigelionis :

> This is produced by yEd and refers to the fact that it wants Helvetica to
> be used there.
> However, there are no font outlines included and the renderer is free to
> substitute the font if it's not available.
> I can remove the comments if they're confusing. BTW Linotype AG was
> purchased by Monotype Imaging Inc in 2006,
> so the attribution is inaccurate. AFAIK Monotype owns the typeface and
> Adobe owns the font (program code)
> which is what we should worry about should we include the outlines in SVG.
>
> Gintas
>
> 2017-06-03 13:49 GMT+02:00 Jan Matèrne (jhm) :
>
>> https://github.com/apache/ant-ivy/pull/41
>>
>> I found a comment in hibgraph.svg: "Helvetica is a registered
>> trademark
>> of Linotype AG".
>> I am not sure about using that in an Apache project ...
>> I'll forward this to the dev llist. Maybe to legal@a.o later ...
>>
>> Does someone know if we are allowed to use helvetica font?
>>
>> Jan
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
>> For additional commands, e-mail: dev-h...@ant.apache.org
>>
>>
>


[GitHub] ant-ivy issue #41: Checkstyle

2017-06-03 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/41
  
Sorry about the mess, #41 got conflated with #39.
It's due my inexperience, #39 is on master and #41 is on a branch of it's 
own in my repo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: PR-41: use of fonts

2017-06-03 Thread Gintautas Grigelionis
This is produced by yEd and refers to the fact that it wants Helvetica to
be used there.
However, there are no font outlines included and the renderer is free to
substitute the font if it's not available.
I can remove the comments if they're confusing. BTW Linotype AG was
purchased by Monotype Imaging Inc in 2006,
so the attribution is inaccurate. AFAIK Monotype owns the typeface and
Adobe owns the font (program code)
which is what we should worry about should we include the outlines in SVG.

Gintas

2017-06-03 13:49 GMT+02:00 Jan Matèrne (jhm) :

> https://github.com/apache/ant-ivy/pull/41
>
> I found a comment in hibgraph.svg: "Helvetica is a registered trademark
> of Linotype AG".
> I am not sure about using that in an Apache project ...
> I'll forward this to the dev llist. Maybe to legal@a.o later ...
>
> Does someone know if we are allowed to use helvetica font?
>
> Jan
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>
>


PR-41: use of fonts

2017-06-03 Thread jhm
https://github.com/apache/ant-ivy/pull/41
  
I found a comment in hibgraph.svg: "Helvetica is a registered trademark
of Linotype AG".
I am not sure about using that in an Apache project ...
I'll forward this to the dev llist. Maybe to legal@a.o later ...

Does someone know if we are allowed to use helvetica font?

Jan


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #41: Checkstyle

2017-06-03 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/41
  
Some of the SVGs are produced by directly by yEd. I guess they're the ones 
that miss "Generator". I'll check them and amend accordingly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #41: Checkstyle

2017-06-03 Thread janmaterne
Github user janmaterne commented on the issue:

https://github.com/apache/ant-ivy/pull/41
  
I found a comment in hibgraph.svg: "Helvetica is a registered trademark of 
Linotype AG".
I am not sure about using that in an Apache project ...
I'll forward this to the dev llist. Maybe to legal@a.o later ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #41: Checkstyle

2017-06-03 Thread janmaterne
Github user janmaterne commented on the issue:

https://github.com/apache/ant-ivy/pull/41
  
There a bunch of new image files (svg, ...) I dont think that this is 
related to 'checkstyle'.

The other files:
- remove trailing spaces
- add required 'final' to parameters
- add javadoc
- ordering of modifiers

Have to think about the images. The rest is fine for merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



AW: Ivy nightly builds - Generate a full .zip/.tar.gz snapshots?

2017-06-03 Thread jhm
merged.
We'll see the next nightly ...

Jan

> -Ursprüngliche Nachricht-
> Von: J Pai [mailto:jai.forums2...@gmail.com]
> Gesendet: Samstag, 3. Juni 2017 04:07
> An: Ant Developers List
> Betreff: Re: Ivy nightly builds - Generate a full .zip/.tar.gz
> snapshots?
> 
> Here’s the PR to fix the tutorial regressions
> https://github.com/apache/ant-ivy/pull/40
> 
> -Jaikiran
> On 03-Jun-2017, at 7:09 AM, J Pai  wrote:
> 
> Looked at the job logs. This indeed caught a genuine compilation error.
> Given that we don’t run these tutorials build daily, it wasn’t noticed
> this far. It looks like this might have been introduced by some of our
> recent changes. I’ll  take a look to fix it today.
> 
> -Jaikiran
> On 03-Jun-2017, at 1:28 AM, Jan Matèrne (jhm) 
> wrote:
> 
> > Would it be feasible to have a Jenkins daily job (runs once at a
> > schedule) for Ivy which publishes the complete binary zip/tar.gz of
> > Ivy nightly snapshots? I know we have a daily job currently here[1]
> > which generates a jar as the artifact output of the job. Maybe this
> > job itself can be changed to generate the full distributable binary
> > .zip/.tar.gz?
> >
> > Where I plan to use such a job is, to have Ivy users have quick
> access
> > to our nightly builds so that they can use those binaries just like
> > they would for released versions. That way, we can ask the users to
> > test out/verify any bug fixes we have pushed, in their own
> > environments by installing those snapshots. Especially in cases where
> > it’s hard to reproduce some bugs in first place (Windows OS for
> > example). I understand they could probably do it even now using those
> > jars we publish, but I would prefer the process of “installation” to
> > be almost the same as what we would do with released binaries - i.e.
> > use a .zip/.tar.gz with all relevant files in them.
> >
> > [1] https://builds.apache.org/job/Ivy/
> 
> 
> Not sure if that is that the right.
> I set up a job which runs @daily, starts "ant -f build-release.xml
> snapshot-bin" and publishes build/distrib/dist/**.
> https://builds.apache.org/view/A/view/Ant/job/Ivy-NightlyDistribution/
> 
> 
> Jan
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> commands, e-mail: dev-h...@ant.apache.org
> 
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> commands, e-mail: dev-h...@ant.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #40: Fix regression in tutorials

2017-06-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/ant-ivy/pull/40


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #41: Checkstyle

2017-06-03 Thread twogee
GitHub user twogee opened a pull request:

https://github.com/apache/ant-ivy/pull/41

Checkstyle

Now that checkstyle rules are sync'ed with Ant, here come the consequences 
😃 
I guess the famous https://issues.apache.org/jira/browse/IVY-511 is due for 
an update...

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twogee/ant-ivy checkstyle

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #41


commit 838aa1bd37ff2f60a51c60969204964839937eb9
Author: twogee 
Date:   2017-06-02T15:37:04Z

first batch of SVG replacements

commit 57ee0f2d15768efd10c15c7ef14da8a7db94deaa
Author: twogee 
Date:   2017-06-03T07:58:10Z

Inline warning icon

commit 1ca5f08e25401ad9861d6de333f8e53791384be6
Author: twogee 
Date:   2017-06-03T09:42:00Z

Checkstyle-driven cleanup (whitespace, javadoc, JLS)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #39: first batch of SVG replacements

2017-06-03 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/39
  
I inlined warning icon; ideally, it should go into CSS as a data URI, but 
that belongs to xooki now...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #40: Fix regression in tutorials

2017-06-03 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/40
  
Thanks, I forgot to rebuild the snapshot before pushing the changes 😊
Perhaps it's worth mentioning in developer doc, which sorely needs revision 
now (another regression on my part there).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org