[GitHub] ant issue #50: Use newer third party libraries

2017-12-13 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/50
  
I intended it for 1.9.x in particular. I will open a new request for master 
later (with commons-net 3.6, for example).


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #50: Use newer third party libraries

2017-12-13 Thread bodewig
Github user bodewig commented on the issue:

https://github.com/apache/ant/pull/50
  
Thanks, looks good to me.

Unless you want to port it to the 1.9.x branch you don't need to care about 
Java5 compatibility.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Build failed in Jenkins: Ant-Build-Matrix-1.9.x-Linux » JDK 1.6 (latest) #134

2017-12-13 Thread Jaikiran Pai
It's back to normal [1], so the crash seems to be specific to certain 
nodes on Jenkins, for Java 6. I don't plan to look more into this.


[1] 
https://builds.apache.org/job/Ant-Build-Matrix-1.9.x-Linux/jdk=JDK%201.6%20(latest)/135/


-Jaikiran


On 13/12/17 8:40 PM, Jaikiran Pai wrote:


So we have now had 2 runs of this job failing with a JVM crash:

Run 133
[exec] [au:antunit] Build 
File:
  [exec] [au:antunit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 
0.804 sec
  [exec] [au:antunit] Target: testWithNonFileResourceToDir took 0.462 sec
  [exec] [au:antunit] Target: testWithNonFileResourceToFile took 0.305 sec
  [exec] [au:antunit] Target: testWithFileResourceToFile took 0.018 sec
  [exec] [au:antunit] Target: testWithFileResourceToDirectory took 0.003 sec
  [exec] [au:antunit] Build 
File:
*[exec] *** Error in `/home/jenkins/tools/java/latest1.6/jre/bin/java': 
free(): invalid next size (fast): 0x7f90ec35b630 *** *  [exec] [au:antunit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.01 sec

  [exec] [au:antunit] Target: testFailNone took 0.003 sec
  [exec] [au:antunit] Target: testFailTwo took 0.001 sec
  [exec] [au:antunit] Build 
File:
and run 134

See

--
[...truncated 101.33 KB...]
  
  [exec] [au:antunit] Build File:

  [exec] [au:antunit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 
0.087 sec
  [exec] [au:antunit] Target: testWithNonFileResourceToDir took 0.041 sec
  [exec] [au:antunit] Target: testWithNonFileResourceToFile took 0.028 sec
  [exec] [au:antunit] Target: testWithFileResourceToFile took 0.002 sec
  [exec] [au:antunit] Target: testWithFileResourceToDirectory took 0.001 sec
  [exec] [au:antunit] Build 
File:
  [exec] [au:antunit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 
0.01 sec
  [exec] [au:antunit] Target: testFailNone took 0.003 sec
  [exec] [au:antunit] Target: testFailTwo took 0.001 sec
  [exec] [au:antunit] Build 
File:
  *[exec] *** Error in 
`/home/jenkins/tools/java/latest1.6/jre/bin/java': malloc(): memory 
corruption: 0x7f57b0325620 

  [exec] Aborted



both seem to have happened when the gzip antunit test was in 
progress/ended. Plus, I just committed a Zip class related change to 
this branch[1]. So most likely _not_ a coincidence. But given this a 
JVM crash (in Java 6), it most likely is a JVM issue. I'll see if I 
can find something on this, before we decide if at all we need to 
rollback that commit.


[1] 
https://github.com/apache/ant/commit/0fd2a86369aab41db316b1064a559bae08afae0f


-Jaikiran




[GitHub] ant issue #50: Use newer third party libraries

2017-12-13 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/50
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Windows/13/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #50: Use newer third party libraries

2017-12-13 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/50
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Linux/7/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #50: Use newer third party libraries

2017-12-13 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/50
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Windows/12/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #50: Use newer third party libraries

2017-12-13 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/50
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Linux/6/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/50
  
I reviewed third party libraries that could be updated; the documentation 
could be more emphatic about jspc being deprecated.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/50
  
SLF4J was written by the [author of 
Log4j](https://en.wikipedia.org/wiki/Log4j) who wrote [an 
article](https://articles.qos.ch/classloader.html) cataloguing the problems 
with Commons Logging. When upgrading Jasper, one gets various versions of 
commons-logging as dependencies; the latest versions depend on slf4j-nop in 
runtime, though 😄 Log4j is EOL and the latest versions add dependencies on 
J2EE (see the removed comment in libraries.properties ;-)


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread bodewig
Github user bodewig commented on the issue:

https://github.com/apache/ant/pull/50
  
Actually I do not agree with the slf4j change ;-)

What problem are you trying to solve? To me both existing logging backends 
are legacy and we maintain them for people who want to use them - they'd be 
disrupted if we switched to different dependencies. I'd be OK with SLF4J or 
log4j2 integrations as additional components.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/50
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Windows/11/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/50
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Linux/5/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Github ant repo now integrated with Jenkins for pull request testing

2017-12-13 Thread Jaikiran Pai



On 12/12/17 8:05 PM, Jaikiran Pai wrote:



The next few days, I'll probably try and see if I can get a Linux 
based job to run alongside this Windows job for PRs.
We now have a Linux one too for the PRs 
https://builds.apache.org/job/Ant%20Github-PR-Linux/. It has the same 
characteristics as the Windows one, except that this one runs on Linux.


-Jaikiran

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/50
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Windows/10/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/50
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Linux/4/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread bodewig
Github user bodewig commented on the issue:

https://github.com/apache/ant/pull/50
  
I don't really think you need a PR - I've upgraded BCEL last week and did 
so directly. Ant tends to use a "commit then review" model where people look at 
the commits and things get amended later.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/50
  
I updated WHATSNEW and added a replacement for all legacy logging 
frameworks. There are more potential updates: Java Mail API, Rhino, Jasper; 
perhaps they deserve a separate PR?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/50
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Windows/9/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/50
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Linux/3/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Build failed in Jenkins: Ant-Build-Matrix-1.9.x-Linux » JDK 1.6 (latest) #134

2017-12-13 Thread Jaikiran Pai

So we have now had 2 runs of this job failing with a JVM crash:

Run 133

[exec] [au:antunit] Build 
File:
 [exec] [au:antunit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 
0.804 sec
 [exec] [au:antunit] Target: testWithNonFileResourceToDir took 0.462 sec
 [exec] [au:antunit] Target: testWithNonFileResourceToFile took 0.305 sec
 [exec] [au:antunit] Target: testWithFileResourceToFile took 0.018 sec
 [exec] [au:antunit] Target: testWithFileResourceToDirectory took 0.003 sec
 [exec] [au:antunit] Build 
File:
*[exec] *** Error in `/home/jenkins/tools/java/latest1.6/jre/bin/java': 
free(): invalid next size (fast): 0x7f90ec35b630 *** *  [exec] [au:antunit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.01 sec

 [exec] [au:antunit] Target: testFailNone took 0.003 sec
 [exec] [au:antunit] Target: testFailTwo took 0.001 sec
 [exec] [au:antunit] Build 
File:

and run 134

See 


--
[...truncated 101.33 KB...]
  
  [exec] [au:antunit] Build File: 

  [exec] [au:antunit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 
0.087 sec
  [exec] [au:antunit] Target: testWithNonFileResourceToDir took 0.041 sec
  [exec] [au:antunit] Target: testWithNonFileResourceToFile took 0.028 sec
  [exec] [au:antunit] Target: testWithFileResourceToFile took 0.002 sec
  [exec] [au:antunit] Target: testWithFileResourceToDirectory took 0.001 sec
  [exec] [au:antunit] Build File: 

  [exec] [au:antunit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 
0.01 sec
  [exec] [au:antunit] Target: testFailNone took 0.003 sec
  [exec] [au:antunit] Target: testFailTwo took 0.001 sec
  [exec] [au:antunit] Build File: 

  *[exec] *** Error in `/home/jenkins/tools/java/latest1.6/jre/bin/java': 
malloc(): memory corruption: 0x7f57b0325620 

  [exec] Aborted



both seem to have happened when the gzip antunit test was in 
progress/ended. Plus, I just committed a Zip class related change to 
this branch[1]. So most likely _not_ a coincidence. But given this a JVM 
crash (in Java 6), it most likely is a JVM issue. I'll see if I can find 
something on this, before we decide if at all we need to rollback that 
commit.


[1] 
https://github.com/apache/ant/commit/0fd2a86369aab41db316b1064a559bae08afae0f


-Jaikiran


[GitHub] ant issue #51: [master] Changes for BZ-19516

2017-12-13 Thread jaikiran
Github user jaikiran commented on the issue:

https://github.com/apache/ant/pull/51
  
Thanks for reviewing. Merged to master branch. Will backport it to 1.9.x 
too.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #51: [master] Changes for BZ-19516

2017-12-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/ant/pull/51


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #51: [master] Changes for BZ-19516

2017-12-13 Thread bodewig
Github user bodewig commented on the issue:

https://github.com/apache/ant/pull/51
  
Looks good to me.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Build Script Templates

2017-12-13 Thread Stefan Bodewig
On 2017-12-12, Jochen Wiedmann wrote:

> What I came up with, instead, was a set of conventions, which closely
> resemble the Maven projects, and a "Maven Jar Template" (MJT). The MJT
> is an Ant build script, which is generic, and shared by all our
> subprojects. The actual build scripts typically specify a small set of
> properties (project.name, project.version,
> project.java.source.version, and the like), and import the MJT. As the
> project follows the MJT conventions, that's it in most cases, apart
> from things like a uber jar, etc., which aren't handled by the MJT.
> However, these are mostly resolved by "overwriting" one of the
> imported tasks.

Sounds a lot like the thing we've done for the antlibs where we've got a
template build system in https://github.com/apache/ant-antlibs-common
and the individual antlibs come down to



  
  

  
  

  
  

  


(that's AntUnit, the one for compress is even shorter).

> The experiemce is so good, that I wonder, if we couldn't start
> distributing some of these templates with Ant Core, or as a separate
> ant-templates.jar? If so, a build script could look like below,

I'd see this as a collection separate from Ant's core. In a way EasyAnt
(and Krysalis years before that) tried to do something like this but may
have been too ambitious.

Having some sort of best practice template(s) without any additional
tooling required might be enough.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org