Re: [PATCH]

2018-01-24 Thread Jaikiran Pai 

Hi Adam,

The mailing list strips off the attachments, so your patch didn't come 
through. In general, can you instead please create a bugzilla issue here 
https://bz.apache.org/bugzilla/enter_bug.cgi?product=Ant and explain the 
issue you were running into (including the version of Ant you are using 
and the exception stacktrace that you got) and attach the proposed patch 
there?


-Jaikiran


On 24/01/18 4:57 PM, Adam Retter wrote:

If you previously used the Saxon XSLT Processor within
 you would get an error as the XSLT stylesheets
provided with Ant do not work with Saxon, they in fact rely on Xalan2
specific extensions.

The attached patch adds Saxon compatible stylesheets and selects the
Saxon stylesheets if the Saxon processor is specified, e.g. the
following now works:



 
 
 

 
 
 
 
 
 
 
 




Hope this can make it into the next Ant release? Let me know if you
need any changes...

Cheers Adam.



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #55: Use valueOf method instead of constructor since valueOf has h...

2018-01-24 Thread asfgit 
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/55
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Windows/35/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #55: Use valueOf method instead of constructor since valueOf has h...

2018-01-24 Thread asfgit 
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/55
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Linux/29/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #55: Use valueOf method instead of constructor since valueOf has h...

2018-01-24 Thread jaikiran 
Github user jaikiran commented on the issue:

https://github.com/apache/ant/pull/55
  
this is ok to test


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #55: Use valueOf method instead of constructor since valueOf has h...

2018-01-24 Thread asfgit 
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/55
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #55: Use valueOf method instead of constructor since valueO...

2018-01-24 Thread reudismam 
GitHub user reudismam opened a pull request:

https://github.com/apache/ant/pull/55

Use valueOf method instead of constructor since valueOf has higher pe…

…rformance.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/reudismam/ant master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #55


commit 51acedc82ee0bb7472041825937c4c139c93195e
Author: reudismam 
Date:   2018-01-24T13:57:12Z

Use valueOf method instead of constructor since valueOf has higher 
performance.




---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #55: Use valueOf method instead of constructor since valueOf has h...

2018-01-24 Thread asfgit 
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/55
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[PATCH]

2018-01-24 Thread Adam Retter 
If you previously used the Saxon XSLT Processor within
 you would get an error as the XSLT stylesheets
provided with Ant do not work with Saxon, they in fact rely on Xalan2
specific extensions.

The attached patch adds Saxon compatible stylesheets and selects the
Saxon stylesheets if the Saxon processor is specified, e.g. the
following now works:



















Hope this can make it into the next Ant release? Let me know if you
need any changes...

Cheers Adam.

-- 
Adam Retter

skype: adam.retter
tweet: adamretter
http://www.adamretter.org.uk


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org