[GitHub] ant-ivy issue #70: IVY-1321 Make Main.run() public
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/70 Thanks for bearing with me ðplease see the revised commit. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #70: IVY-1321 Make Main.run() public
Github user supertick commented on the issue:
https://github.com/apache/ant-ivy/pull/70
I would make a default overload which took only a String[] arg to model
**exactly** the Main.main input, but all the rest is perfect, including the
better isCli boolean vs silly cli option
ResolveReport report = Main.run(new String[]{ exact standalone api ...
})
I would leave the Exception throws signature in the overloaded run method...
Thanks for your consideration, work, and mention ;) !
Cheers !
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #70: IVY-1321 Make Main.run() public
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/70 @supertick if you're fine with this PR, please close #69. I will merge this one later. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: Snapshot access to regular users of Ant
2018-03-20 18:03 GMT+01:00 Stefan Bodewig : > On 2018-03-19, Gintautas Grigelionis wrote: > > > Maybe Ant Task Guidelines could be exposed under under "Contributing" > > as a landing page, and the relevant information could be moved into > > the manual? > > The tutorials as well as the Ant task guidelines have always been only > attachments to the manual to me, YMMV. I for one am completely on the > fence with whatever anybody wants to do with them. > It would be easier to have the site in Git, too. What we need is 1. contribution guidelines 2. task guidelines (that refer to 1) 3. tutorials that refer to 1 & 2 For starters, we need to decide whether both guidelines should be a part of the manual or of the site. Sorry for passing the buck, but I believe you have the authority to put the fence in the right place ;-) Gintas
Re: Snapshot access to regular users of Ant
On 2018-03-19, Gintautas Grigelionis wrote: > Maybe Ant Task Guidelines could be exposed under under "Contributing" > as a landing page, and the relevant information could be moved into > the manual? The tutorials as well as the Ant task guidelines have always been only attachments to the manual to me, YMMV. I for one am completely on the fence with whatever anybody wants to do with them. Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: junitlauncher dependency on JUnit4?
2018-03-20 16:43 GMT+01:00 Stefan Bodewig : > On 2018-03-20, Gintautas Grigelionis wrote: > > > My understanding is that junitlauncher has a dependency on JUnit 4 > through > > vintage engine. I guess pom should provide profiles for engine choice. > See > > my earlier questions re the task classpath. > > Only when running the tests. The launcher task itself doesn't depend on > any of the engines at compile time. > At least in pom there is a clear distinction between compile and runtime. I wish there was Ivy 2.5 out there so that we could have a unified ivy.xml; until then -- sorry for thinking as an end user in terms of dependencies. Gintas
Re: junitlauncher dependency on JUnit4?
On 2018-03-20, Jaikiran Pai wrote: > This looks like some odd merge or squashing issue when I pushed that > task changes. I have fixed it. The task itself doesn't need any JUnit > test engine specific dependencies like this one. I just pushed the > commit upstream which should fix this. Looks good, building from POMs now works on master. Thanks. Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: junitlauncher dependency on JUnit4?
Hi Stefan, This looks like some odd merge or squashing issue when I pushed that task changes. I have fixed it. The task itself doesn't need any JUnit test engine specific dependencies like this one. I just pushed the commit upstream which should fix this. P.S: I haven't responded to some other mails due to limited internet connectivity this few days. I'll respond to them soon. -Jaikiran On 20/03/18 8:57 PM, Stefan Bodewig wrote: Hi I've just added a POM for ant-junitlauncher and it currently fails to build as org.apache.tools.ant.taskdefs.optional.junitlauncher.SingleTestClass has a dependency on org.junit.Test and I haven't declared any dependency on JUnit4 inside the POM (only transitively with scope test). The class has an @Test annotation inside of the main build tree, is this intentional? To me it looks as if the annotation and the import of org.junit.Test could be removed. Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: junitlauncher dependency on JUnit4?
On 2018-03-20, Gintautas Grigelionis wrote: > My understanding is that junitlauncher has a dependency on JUnit 4 through > vintage engine. I guess pom should provide profiles for engine choice. See > my earlier questions re the task classpath. Only when running the tests. The launcher task itself doesn't depend on any of the engines at compile time. > Den tis 20 mars 2018 16:28Stefan Bodewig skrev: >> I've just added a POM for ant-junitlauncher and it currently fails to >> build as >> org.apache.tools.ant.taskdefs.optional.junitlauncher.SingleTestClass has >> a dependency on org.junit.Test and I haven't declared any dependency on >> JUnit4 inside the POM (only transitively with scope test). This class is in src/main and the test works fine even if I remove the @Test annotation. Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: junitlauncher dependency on JUnit4?
My understanding is that junitlauncher has a dependency on JUnit 4 through vintage engine. I guess pom should provide profiles for engine choice. See my earlier questions re the task classpath. Gintas Den tis 20 mars 2018 16:28Stefan Bodewig skrev: > Hi > > I've just added a POM for ant-junitlauncher and it currently fails to > build as > org.apache.tools.ant.taskdefs.optional.junitlauncher.SingleTestClass has > a dependency on org.junit.Test and I haven't declared any dependency on > JUnit4 inside the POM (only transitively with scope test). > > The class has an @Test annotation inside of the main build tree, is this > intentional? To me it looks as if the annotation and the import of > org.junit.Test could be removed. > > Stefan > > - > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org > >
junitlauncher dependency on JUnit4?
Hi I've just added a POM for ant-junitlauncher and it currently fails to build as org.apache.tools.ant.taskdefs.optional.junitlauncher.SingleTestClass has a dependency on org.junit.Test and I haven't declared any dependency on JUnit4 inside the POM (only transitively with scope test). The class has an @Test annotation inside of the main build tree, is this intentional? To me it looks as if the annotation and the import of org.junit.Test could be removed. Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: signjar-test failures in Jenkins
On 2018-03-20, Stefan Bodewig wrote: > it looks as if I had broken every single Jenkins build. Of course the > test pass on my machine with all JDKs I've got installed. No, it fails on Java10 for me, because jarsigner -verify now dies for a self-signed certificate. I'll try to figure out when this changed and if there is a way to get the test to pass. Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
signjar-test failures in Jenkins
Hi all it looks as if I had broken every single Jenkins build. Of course the test pass on my machine with all JDKs I've got installed. Can anybody who gets test errors in his/her local environment please run ./build.sh -f src/tests/antunit/taskdefs/signjar-test.xml testVerifyJarStrictPKCS12 -v and post the results? AntUnit's "jarsigner returned 1" is not really helpful for me right now :-) Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #70: IVY-1321 Make Main.run() public
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/70 I'm a bit surprised that StackOverflow does not refer to Apache [Confluence](https://cwiki.apache.org/confluence/display/IVY/Programmatic+use+of+Ivy) --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
