date:20180429

Re: ant git commit: Inline buildfile names, make search easier

2018-04-29 Thread Jaikiran Pai



On 30/04/18 11:12 AM, Gintautas Grigelionis wrote:

Names of buildfiles used in tests can be found by "grep configureProject"?

Why is that even a requirement?

I think I am just repeating myself again and again in different mails. 
Changes like these are random personal preferences. The fact that these 
are being done even after the mail discussions we recently had, 
indicates that the request to not do such changes have been ignored. 
This is going down the route of a being some kind of a personal 
individual hobby project. So I'm just going to stop bothering looking 
into these commits anymore and just stay away from them and stop sending 
this frustrated and rude sounding mails.


-Jaikiran


The point is that these names are used exactly once, and need not to be put
in a field which is named inconsistently.
Deviations from this rule of thumb indicate that tests are parameterized in
a manner where each test has its own buildfile.

Gintas

2018-04-30 4:43 GMT+00:00 Jaikiran Pai :


What purpose is this change serving?

-Jaikiran


On 30/04/18 10:08 AM, gin...@apache.org wrote:


Repository: ant
Updated Branches:
refs/heads/master 0add85310 -> f3dfb7779


Inline buildfile names, make search easier

Project: http://git-wip-us.apache.org/repos/asf/ant/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/f3dfb777
Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/f3dfb777
Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/f3dfb777




-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: ant git commit: Inline buildfile names, make search easier

2018-04-29 Thread Gintautas Grigelionis

Names of buildfiles used in tests can be found by "grep configureProject"?
The point is that these names are used exactly once, and need not to be put
in a field which is named inconsistently.
Deviations from this rule of thumb indicate that tests are parameterized in
a manner where each test has its own buildfile.

Gintas

2018-04-30 4:43 GMT+00:00 Jaikiran Pai :

> What purpose is this change serving?
>
> -Jaikiran
>
>
> On 30/04/18 10:08 AM, gin...@apache.org wrote:
>
>> Repository: ant
>> Updated Branches:
>>refs/heads/master 0add85310 -> f3dfb7779
>>
>>
>> Inline buildfile names, make search easier
>>
>> Project: http://git-wip-us.apache.org/repos/asf/ant/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/f3dfb777
>> Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/f3dfb777
>> Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/f3dfb777
>>
>

Re: ant git commit: Inline buildfile names, make search easier

2018-04-29 Thread Jaikiran Pai


What purpose is this change serving?

-Jaikiran


On 30/04/18 10:08 AM, gin...@apache.org wrote:

Repository: ant
Updated Branches:
   refs/heads/master 0add85310 -> f3dfb7779


Inline buildfile names, make search easier

Project: http://git-wip-us.apache.org/repos/asf/ant/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/f3dfb777
Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/f3dfb777
Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/f3dfb777

Branch: refs/heads/master
Commit: f3dfb7779a528439a390ab09383cd8cb6b7e8307
Parents: 0add853
Author: Gintas Grigelionis 
Authored: Mon Apr 30 06:38:27 2018 +0200
Committer: Gintas Grigelionis 
Committed: Mon Apr 30 06:38:27 2018 +0200

--
  .../apache/tools/ant/taskdefs/ExecTaskTest.java |  4 +---
  .../apache/tools/ant/taskdefs/JavadocTest.java  |  6 +-
  .../apache/tools/ant/taskdefs/ParallelTest.java |  5 +
  .../tools/ant/taskdefs/PathConvertTest.java |  4 +---
  .../tools/ant/taskdefs/RmicAdvancedTest.java|  4 +---
  .../apache/tools/ant/taskdefs/SleepTest.java|  3 +--
  .../org/apache/tools/ant/taskdefs/WarTest.java  |  4 +---
  .../tools/ant/taskdefs/optional/ANTLRTest.java  |  4 +---
  .../taskdefs/optional/EchoPropertiesTest.java   | 21 ++--
  .../tools/ant/taskdefs/optional/JavahTest.java  |  4 +---
  .../tools/ant/taskdefs/optional/JspcTest.java   |  4 +---
  .../ant/taskdefs/optional/Native2AsciiTest.java |  5 +
  .../taskdefs/optional/ReplaceRegExpTest.java|  3 +--
  .../taskdefs/optional/RhinoReferenceTest.java   |  3 +--
  .../taskdefs/optional/SchemaValidateTest.java   |  7 +--
  .../optional/XmlValidateCatalogTest.java|  7 +--
  .../ant/taskdefs/optional/XmlValidateTest.java  |  7 +--
  .../taskdefs/optional/depend/DependTest.java|  5 +
  .../ant/taskdefs/optional/image/ImageTest.java  |  3 +--
  .../junit/XMLFormatterWithCDATAOnSystemOut.java |  3 +--
  20 files changed, 25 insertions(+), 81 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/ant/blob/f3dfb777/src/tests/junit/org/apache/tools/ant/taskdefs/ExecTaskTest.java
--
diff --git a/src/tests/junit/org/apache/tools/ant/taskdefs/ExecTaskTest.java 
b/src/tests/junit/org/apache/tools/ant/taskdefs/ExecTaskTest.java
index fd92ded..cf30955 100644
--- a/src/tests/junit/org/apache/tools/ant/taskdefs/ExecTaskTest.java
+++ b/src/tests/junit/org/apache/tools/ant/taskdefs/ExecTaskTest.java
@@ -44,8 +44,6 @@ public class ExecTaskTest {
  @Rule
  public BuildFileRule buildRule = new BuildFileRule();
  
-private static final String BUILD_PATH = "src/etc/testcases/taskdefs/exec/";

-private static final String BUILD_FILE = BUILD_PATH + "exec.xml";
  private static final int TIME_TO_WAIT = 1;
  /** maximum time allowed for the build in milliseconds */
  private static final int MAX_BUILD_TIME = 6000;
@@ -60,7 +58,7 @@ public class ExecTaskTest {
  
  @Before

  public void setUp() {
-buildRule.configureProject(BUILD_FILE);
+buildRule.configureProject("src/etc/testcases/taskdefs/exec/exec.xml");
  }
  
  @Test


http://git-wip-us.apache.org/repos/asf/ant/blob/f3dfb777/src/tests/junit/org/apache/tools/ant/taskdefs/JavadocTest.java
--
diff --git a/src/tests/junit/org/apache/tools/ant/taskdefs/JavadocTest.java 
b/src/tests/junit/org/apache/tools/ant/taskdefs/JavadocTest.java
index f7a287d..cae8620 100644
--- a/src/tests/junit/org/apache/tools/ant/taskdefs/JavadocTest.java
+++ b/src/tests/junit/org/apache/tools/ant/taskdefs/JavadocTest.java
@@ -28,13 +28,9 @@ public class JavadocTest {
  @Rule
  public final BuildFileRule buildRule = new BuildFileRule();
  
-private static final String BUILD_PATH = "src/etc/testcases/taskdefs/javadoc/";

-private static final String BUILD_FILENAME = "javadoc.xml";
-private static final String BUILD_FILE = BUILD_PATH + BUILD_FILENAME;
-
  @Before
  public void setUp() {
-buildRule.configureProject(BUILD_FILE);
+
buildRule.configureProject("src/etc/testcases/taskdefs/javadoc/javadoc.xml");
  }
  
  // PR 38370


http://git-wip-us.apache.org/repos/asf/ant/blob/f3dfb777/src/tests/junit/org/apache/tools/ant/taskdefs/ParallelTest.java
--
diff --git a/src/tests/junit/org/apache/tools/ant/taskdefs/ParallelTest.java 
b/src/tests/junit/org/apache/tools/ant/taskdefs/ParallelTest.java
index eba49c9..c08564e 100644
--- a/src/tests/junit/org/apache/tools/ant/taskdefs/ParallelTest.java
+++ b/src/tests/junit/org/apache/tools/ant/taskdefs/ParallelTest.java
@@ -52,14 +52,11 @@ public class ParallelTest {
  /** Standard property value for the fail test

Bug report for Ant [2018/04/29]

2018-04-29 Thread bugzilla

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
| 5003|Opn|Blk|2001-11-21|exec task does not return after executed command f|
| 6606|Opn|Enh|2002-02-21|META-BUG problems with delegating classloaders|
| 7552|Opn|Cri|2002-03-28|Invalid task cache in targets |
| 7712|New|Enh|2002-04-03|Provide patternset support for VSSGET task?   |
| 8294|New|Enh|2002-04-19|: Allow  and  to app|
| 8866|New|Enh|2002-05-07|Signal handling in java task  |
| 8895|New|Enh|2002-05-08|ant and/or antcall should support forking |
| 8972|New|Enh|2002-05-10|allow property expansion in  property v|
| 8981|New|Enh|2002-05-10|Tar task command additional features  |
| 9294|New|Enh|2002-05-21|[PATCH] optional/j2ee/ServerDeploy OC4J Support   |
| 9995|Ass|Enh|2002-06-19|MKS Source Integrity tasks|
|10020|New|Enh|2002-06-19|'s dependency behaviour should be more con|
|10231|New|Enh|2002-06-25|Need access to current file in SQLExec|
|10283|New|Enh|2002-06-27|Add a destfile to the uptodate task   |
|10402|New|Enh|2002-07-02|adding the ability of html like whitespace preserv|
|3|New|Enh|2002-07-24|keytool task  |
|11560|Opn|Enh|2002-08-08|Taskdef does not apply reverseLoader policy on sta|
|12267|New|Enh|2002-09-03|Add ability to unzip into separate folders|
|12292|New|Enh|2002-09-04|[PATCH] enable  tag inside tar|
|12334|New|Enh|2002-09-05|REQUEST: Ant task doesn't allow attachment of a bu|
|12518|New|Enh|2002-09-11|Gunzip & BUnZip2 add filesets, patternsets, and ov|
|12765|New|Enh|2002-09-18|"rmdir" and "deltree" patches for ftp task enhance|
|12964|New|Enh|2002-09-24|ANTLR only takes one input file at a time |
|13047|Inf|Enh|2002-09-26|Support for  and  on O|
|13371|New|Enh|2002-10-07|[PATCH] Contributed new CvsExportDiff task|
|13847|New|Nor|2002-10-22|pvcs task: wrong option (-r) specified for get (sh|
|13934|New|Enh|2002-10-24|Translate task shouldn't load default locale prope|
|13939|New|Enh|2002-10-24|Translate task should have better key matching cap|
|14320|New|Enh|2002-11-06|copy fileset followsymlinks="false" does not copy |
|14393|New|Enh|2002-11-08|Support use of jndi within ant|
|14512|New|Enh|2002-11-13|Allow creating database connection similar to  with  does not spot bad symlin|
|15149|New|Enh|2002-12-06|Replace task  |
|15244|New|Enh|2002-12-10|tar task should be able to store symbolic links as|
|15430|New|Enh|2002-12-17|Enhancement to ReplaceRegExp.java |
|15596|New|Enh|2002-12-21|Identity mapper in uptodate task. |
|15747|New|Enh|2003-01-01|change tasks (e.g. Ant) to take urls as well as fi|
|15853|New|Enh|2003-01-07|Allow to plug-in different XML Catalog resolver in|
|15949|Opn|Enh|2003-01-10|please provide links to docs.xml and jakarta-site2|
|16131|New|Enh|2003-01-15|not possible to suppress "BUILD SUCCESSFUL" messag|
|16427|New|Enh|2003-01-26|Output return value of setLastModified/document be|
|16469|New|Enh|2003-01-27|Apply task should allow parallel execution on diff|
|16494|New|Enh|2003-01-28|[PATCH] accessibility of Ant documentation|
|16562|New|Enh|2003-01-29|Can not accept characters  from keyboard in a thre|
|16860|New|Enh|2003-02-06|Silent or Debug a single target   |
|16896|New|Enh|2003-02-07|Support in ProjectHelper / ProjectHelperImpl to op|
|17074|New|Enh|2003-02-14|Contribution for WLSTOP   |
|17181|New|Nor|2003-02-18|Build fails while trying to get VSS files by label|
|17372|New|Enh|2003-02-25|Enhancement of replace Task   |
|17742|New|Maj|2003-03-06|PVCS task generates GET with promotion group incor|
|17781|New|Enh|2003-03-07|name attribute of record task is not relative to b|
|17829|New|Enh|2003-03-10|Allow ejbjar task to accept nested manifest   |
|17850|New|Nor|2003-03-10|PVCS task dont work with promotion group  |

Re: ant git commit: Inline buildfile names, make search easier

Re: ant git commit: Inline buildfile names, make search easier

Re: ant git commit: Inline buildfile names, make search easier

Bug report for Ant [2018/04/29]

4 matches

Site Navigation

Mail list logo

Footer information