Re: [GitHub] ant pull request #:
I did plan to addit yesterday, but my local tests did not trigger the package-info constant pool entry for some reason. So I decided to not rush it in and spend some time to get the test right, to make sure it works fine. I'll add it in either tonight or tomorrow once I get to see what's going on. -Jaikiran On 12/05/18 9:19 PM, twogee wrote: Github user twogee commented on the pull request: https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb#commitcomment-28953469 In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java: In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java on line 77: Please add 20 (package), too --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #:
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb#commitcomment-28953469 In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java: In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java on line 77: Please add 20 (package), too --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: ant depends task fails for JDK10 module-info.class
On 12/05/18 8:29 PM, Simon IJskes wrote: I went ahead and pushed a commit[1] to fix this. We have our nightly Jenkins job which generates a nightly build. So if you would like to test it, you can pick up a distribution which contains this commit, whenever the next job runs. The artifact should be available here[2]. [1] https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb [2] https://builds.apache.org/job/Ant_Nightly/lastSuccessfulBuild/artifact/distribution/ it works! Glad to hear that :) -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: ant depends task fails for JDK10 module-info.class
I went ahead and pushed a commit[1] to fix this. We have our nightly Jenkins job which generates a nightly build. So if you would like to test it, you can pick up a distribution which contains this commit, whenever the next job runs. The artifact should be available here[2]. [1] https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb [2] https://builds.apache.org/job/Ant_Nightly/lastSuccessfulBuild/artifact/distribution/ it works! thanks for the quick response. i've integrated it in my netbeans installation and will do some more testing in the coming week. Groeten Simon P.S. i'm reading the mail via the webarchive. - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: ant depends task fails for JDK10 module-info.class
I went ahead and pushed a commit[1] to fix this. We have our nightly Jenkins job which generates a nightly build. So if you would like to test it, you can pick up a distribution which contains this commit, whenever the next job runs. The artifact should be available here[2]. [1] https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb [2] https://builds.apache.org/job/Ant_Nightly/lastSuccessfulBuild/artifact/distribution/ -Jaikiran On 12/05/18 5:30 PM, Jaikiran Pai wrote: Looks like a bug. Can you file a bug in the Ant bugzilla? I can take a look at it later tonight. -Jaikiran On 12/05/18 4:45 PM, Simon IJskes wrote: Hi, Just checking if this bug is known? I could not find it in bugzilla. https://issues.apache.org/jira/browse/NETBEANS-781 Groeten, Simon - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: ant depends task fails for JDK10 module-info.class
Looks like a bug. Can you file a bug in the Ant bugzilla? I can take a look at it later tonight. -Jaikiran On 12/05/18 4:45 PM, Simon IJskes wrote: Hi, Just checking if this bug is known? I could not find it in bugzilla. https://issues.apache.org/jira/browse/NETBEANS-781 Groeten, Simon - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
ant depends task fails for JDK10 module-info.class
Hi, Just checking if this bug is known? I could not find it in bugzilla. https://issues.apache.org/jira/browse/NETBEANS-781 Groeten, Simon - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
