[GitHub] ant issue #76: bz-43144 - Improve the performance of the tar task when it us...
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/76 Quite a bit of code :-) Looks as if you had found a solution with minimal API impact that can be extended to cases other than just `tar` although I'm afraid we are using resource collections wrapping resource collections in some places. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #76: bz-43144 - Improve the performance of the tar task when it us...
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/76 Quite a bit of code :-) Looks as if you had found a solution with minimal API impact that can be extended to cases other than just `tar` although I'm afraid we are using resource collections wrapping resource collections in some places. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #77: Avoid FileInputStream and FileOutputStream.
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/77 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/83/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #77: Avoid FileInputStream and FileOutputStream.
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/77 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/89/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #77: Avoid FileInputStream and FileOutputStream.
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/77 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #77: Avoid FileInputStream and FileOutputStream.
GitHub user reudismam opened a pull request: https://github.com/apache/ant/pull/77 Avoid FileInputStream and FileOutputStream. Avoid FileInputStream and FileOutputStream. These classes override the finalize method. As a result, their objects are only cleaned when the garbage collector performs a sweep. Since Java 7, programmers can use Files.newInputStream and Files.newOutputStream instead of FileInputStream and FileOutputStream to improve performance as recommended in this Java JDK bug-report. You can merge this pull request into a Git repository by running: $ git pull https://github.com/reudismam/ant newstream Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant/pull/77.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #77 commit 0950db58654ff0f853dcfd7110f7d27500acbf5b Author: = Date: 2018-11-04T16:31:37Z Avoid FileInputStream and FileOutputStream. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #77: Avoid FileInputStream and FileOutputStream.
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/77 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #77: Avoid FileInputStream and FileOutputStream.
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/77 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [1/2] ant git commit: Checkstyle: dangling operators
-1 Gintas please revert this and the three following SonarQube commits. They are to big, add no value at all and introduce regressions (you've already found one and revertd it and I fear there are more of them). Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org