[GitHub] ant issue #78: A new CharSet type to hold available Charset names

2018-11-13 Thread bodewig
Github user bodewig commented on the issue:

https://github.com/apache/ant/pull/78
  
looks good.

The imageio tasks haven't been part of any release, yet, no reason to 
deprecate methods, just change them before we cut the next release IMHO.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #78: A new CharSet type to hold available Charset names

2018-11-12 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/78
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Windows/95/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #78: A new CharSet type to hold available Charset names

2018-11-12 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/78
  
License headers added. Yes, it should be used with `setEncoding` (or in 
some tasks `setCharset`). Now that I think about it image/imageio tasks have an 
"encoding" attribute which is a misnomer. I'd like to deprecate it in imageio 
and use a "format" instead (with a proper Enumerated Attribute to boot 😁).


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #78: A new CharSet type to hold available Charset names

2018-11-12 Thread bodewig
Github user bodewig commented on the issue:

https://github.com/apache/ant/pull/78
  
Both files need license headers. Other than that, looks good to me. 

You envision this type to be used as argument type in `setEncoding` 
overloads?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #78: A new CharSet type to hold available Charset names

2018-11-08 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/78
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Linux/86/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #78: A new CharSet type to hold available Charset names

2018-11-08 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/78
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Windows/92/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #78: A new CharSet type to hold available Charset names

2018-11-06 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/78
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Linux/84/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #78: A new CharSet type to hold available Charset names

2018-11-06 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/78
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Windows/90/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org