Re: includeantruntime warning (was: [VOTE] release of ant 1.8.1)

[Peter Reilly]

Just did not like the presence of the warning,since
it will hit nearly every ant build file out there.

Still it is in ant 1.8.0 so no need to change it now.


Peter
On Wed, May 5, 2010 at 5:28 PM, Jesse Glick  wrote:
> Peter Reilly wrote:
>>
>> I am not too sure that I like the warning:
>>
>> 'includeantruntime' was not set, defaulting to build.sysclasspath=last;
>> set to false for repeatable builds
>
> You don't like the text of the warning message, or the fact that there is a
> warning at all?
>
> I have just seen a lot of build scripts which used the historical default of
> true, thus including ant.jar etc. in the classpath of quite unrelated code.
> (In the unusual case that you are in fact compiling Ant tasks, adding
> ${ant.core.lib} to the classpath makes this explicit.) Besides permitting
> code to compile against classes it might not have accessible at runtime, I
> found that this interfered with dynamic analysis of the compile-time
> classpath for purposes of .
>
> Since changing the default would be incompatible, it seemed better to warn
> about what was almost always a mistake. This is analogous to the warning
> printed when you neglect to set a source level and Ant defaults to the
> version of the executing JDK.
>
>> (not too sure if this was added in ant 1.8 or ant 1.8.1)
>
> 1.8.0.
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: includeantruntime warning (was: [VOTE] release of ant 1.8.1)

[Jesse Glick]

Peter Reilly wrote:

I am not too sure that I like the warning:

'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to 
false for repeatable builds


You don't like the text of the warning message, or the fact that there is a 
warning at all?

I have just seen a lot of build scripts which used the historical default of true, thus including ant.jar etc. in the classpath of quite unrelated code. (In the unusual 
case that you are in fact compiling Ant tasks, adding ${ant.core.lib} to the classpath makes this explicit.) Besides permitting code to compile against classes it might 
not have accessible at runtime, I found that this interfered with dynamic analysis of the compile-time classpath for purposes of .


Since changing the default would be incompatible, it seemed better to warn about what was almost always a mistake. This is analogous to the warning printed when you 
neglect to set a source level and Ant defaults to the version of the executing JDK.



(not too sure if this was added in ant 1.8 or ant 1.8.1)


1.8.0.


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] release of ant 1.8.1

[Peter Reilly]

ok, scratch that, the warning happens for ant 1.8.0 as well :-(

So +1 for the 1.8.1 release.

Peter


On Wed, May 5, 2010 at 4:01 PM, Peter Reilly
 wrote:
> I am not too sure that I like the warning:
>
> /home/preilly/scm/svn/nft-trunk/build.xml:61: warning:
> 'includeantruntime' was not set, defaulting to
> build.sysclasspath=last; set to false for repeatable builds
> when using  without setting the includeantruntime attribute.
> (not too sure if this was added in ant 1.8 or ant 1.8.1)
>
> Peter
>
> On Wed, May 5, 2010 at 3:43 PM, Jean-Louis Boudart
>  wrote:
>> +1 no issue here with easyant
>>
>> Regards,
>>
>> 2010/5/1 Antoine Levy-Lambert 
>>
>>> Hi,
>>>
>>> I have uploaded a candidate for ant 1.8.1 under
>>> http://people.apache.org/~antoine/dist/
>>>
>>> Also a label ANT_181 has been created in the repository.
>>>
>>> Vote to release this build as ant 1.8.1
>>>
>>> [ ]  Yes
>>>
>>> [ ]  No
>>>
>>> Regards,
>>>
>>> Antoine
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
>>> For additional commands, e-mail: dev-h...@ant.apache.org
>>>
>>>
>>
>>
>> --
>> Jean Louis Boudart
>> Independent consultant
>> Project Lead http://www.easyant.org
>>
>

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] release of ant 1.8.1

[Peter Reilly]

I am not too sure that I like the warning:

/home/preilly/scm/svn/nft-trunk/build.xml:61: warning:
'includeantruntime' was not set, defaulting to
build.sysclasspath=last; set to false for repeatable builds
when using  without setting the includeantruntime attribute.
(not too sure if this was added in ant 1.8 or ant 1.8.1)

Peter

On Wed, May 5, 2010 at 3:43 PM, Jean-Louis Boudart
 wrote:
> +1 no issue here with easyant
>
> Regards,
>
> 2010/5/1 Antoine Levy-Lambert 
>
>> Hi,
>>
>> I have uploaded a candidate for ant 1.8.1 under
>> http://people.apache.org/~antoine/dist/
>>
>> Also a label ANT_181 has been created in the repository.
>>
>> Vote to release this build as ant 1.8.1
>>
>> [ ]  Yes
>>
>> [ ]  No
>>
>> Regards,
>>
>> Antoine
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
>> For additional commands, e-mail: dev-h...@ant.apache.org
>>
>>
>
>
> --
> Jean Louis Boudart
> Independent consultant
> Project Lead http://www.easyant.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] release of ant 1.8.1

[Jean-Louis Boudart]

+1 no issue here with easyant

Regards,

2010/5/1 Antoine Levy-Lambert 

> Hi,
>
> I have uploaded a candidate for ant 1.8.1 under
> http://people.apache.org/~antoine/dist/
>
> Also a label ANT_181 has been created in the repository.
>
> Vote to release this build as ant 1.8.1
>
> [ ]  Yes
>
> [ ]  No
>
> Regards,
>
> Antoine
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>
>


-- 
Jean Louis Boudart
Independent consultant
Project Lead http://www.easyant.org

Re: [VOTE] release of ant 1.8.1

[Martijn Kruithof]

On 4-5-2010 14:53, Stefan Bodewig wrote:

On 2010-05-01, Antoine Levy-Lambert  wrote:

   

Vote to release this build as ant 1.8.1
 
   

[X]  Yes
 
   

[ ]  No
 



+1 martijn

No problems observed

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] release of ant 1.8.1

[Jesse Glick]

Maarten Coene wrote:

I did had one minor regression when running the Ivy junit tests where the test 
summary is printed twice


I think I have seen the topmost stack trace element before the failure 
duplicated, but not sure.


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] release of ant 1.8.1

[Maarten Coene]

No problem detected with the buildscripts @ work.

I did had one minor regression when running the Ivy junit tests where the test 
summary is printed twice:


[junit] Running org.apache.ivy.ant.IvyArtifactReportTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 1,154 sec
[junit] Running org.apache.ivy.ant.IvyBuildListTest
[junit] Tests run: 15, Failures: 0, Errors: 0, Time elapsed: 3,183 sec
[junit] Tests run: 15, Failures: 0, Errors: 0, Time elapsed: 3,183 sec
[junit] Running org.apache.ivy.ant.IvyBuildNumberTest
[junit] Tests run: 12, Failures: 0, Errors: 0, Time elapsed: 0,858 sec


I don't think this should block the release though, so here is my vote:

+1

Maarten



- Original Message 
From: Antoine Levy-Lambert 
To: Ant Developers List 
Sent: Sat, May 1, 2010 6:41:46 AM
Subject: [VOTE] release of ant 1.8.1

Hi,

I have uploaded a candidate for ant 1.8.1 under
http://people.apache.org/~antoine/dist/

Also a label ANT_181 has been created in the repository.

Vote to release this build as ant 1.8.1

[ ]  Yes

[ ]  No

Regards,

Antoine

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org


  

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] release of ant 1.8.1

[Greg Roodt]

+1

I see no issues here with the fairly complex build I manage.







On Tue, May 4, 2010 at 1:53 PM, Stefan Bodewig  wrote:

> On 2010-05-01, Antoine Levy-Lambert  wrote:
>
> > Vote to release this build as ant 1.8.1
>
> > [X]  Yes
>
> > [ ]  No
>
> +1
>
> Stefan
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>
>

Re: [VOTE] release of ant 1.8.1

[Stefan Bodewig]

On 2010-05-01, Antoine Levy-Lambert  wrote:

> Vote to release this build as ant 1.8.1

> [X]  Yes

> [ ]  No

+1

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] release of ant 1.8.1

[Jesse Glick]

Antoine Levy-Lambert wrote:

Vote to release this build as ant 1.8.1

[X]  Yes


Have not found any issues with it yet. Plan to bundle it in NetBeans IDE 6.9.


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[VOTE] release of ant 1.8.1

[Antoine Levy-Lambert]

Hi,

I have uploaded a candidate for ant 1.8.1 under
http://people.apache.org/~antoine/dist/

Also a label ANT_181 has been created in the repository.

Vote to release this build as ant 1.8.1

[ ]  Yes

[ ]  No

Regards,

Antoine

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org