DO NOT REPLY [Bug 17871] - war task's webxml attrib no longer is able to use value with a starting backslash for the path in Windows

2003-03-14 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17871

war task's webxml attrib no longer is able to use value with a starting 
backslash for the path in Windows

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-03-14 15:15 ---
Thanks.


DO NOT REPLY [Bug 17871] - war task's webxml attrib no longer is able to use value with a starting backslash for the path in Windows

2003-03-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17871

war task's webxml attrib no longer is able to use value with a starting 
backslash for the path in Windows





--- Additional Comments From [EMAIL PROTECTED]  2003-03-13 17:51 ---
After deleting the "test?.war" files and re-running the "test" target with the 
http://cvs.apache.org/~bodewig/ant.jar JAR, it now appears that the "test3.war" 
file is generated with the appropriate "web.xml" file within it.

Thanks!


DO NOT REPLY [Bug 17871] - war task's webxml attrib no longer is able to use value with a starting backslash for the path in Windows

2003-03-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17871

war task's webxml attrib no longer is able to use value with a starting 
backslash for the path in Windows





--- Additional Comments From [EMAIL PROTECTED]  2003-03-13 16:25 ---
Could you please either try the next nightly build (i.e. 2003-03-14) or replace
the 1.5.2 ant.jar with the one from 
and see whether it fixes the problem?


DO NOT REPLY [Bug 17871] - war task's webxml attrib no longer is able to use value with a starting backslash for the path in Windows

2003-03-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17871

war task's webxml attrib no longer is able to use value with a starting 
backslash for the path in Windows

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
 AssignedTo|[EMAIL PROTECTED]  |[EMAIL PROTECTED]
   Target Milestone|--- |1.5.3
Version|1.6Alpha (nightly)  |1.5.2



--- Additional Comments From [EMAIL PROTECTED]  2003-03-13 08:54 ---
Hmm,  I see.

I don't think using the canonical path is the correct solution (we'll 
technically
the solution is correct, but probably not in terms of how it should be
addressed in Ant).

deploymentDescriptor should probably get the drive letter added to it in the
first place - I'll look into it.


DO NOT REPLY [Bug 17871] - war task's webxml attrib no longer is able to use value with a starting backslash for the path in Windows

2003-03-12 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17871

war task's webxml attrib no longer is able to use value with a starting 
backslash for the path in Windows





--- Additional Comments From [EMAIL PROTECTED]  2003-03-12 22:38 ---
Created an attachment (id=5298)
fixes the problem in War.java


DO NOT REPLY [Bug 17871] - war task's webxml attrib no longer is able to use value with a starting backslash for the path in Windows

2003-03-12 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17871

war task's webxml attrib no longer is able to use value with a starting 
backslash for the path in Windows





--- Additional Comments From [EMAIL PROTECTED]  2003-03-12 22:28 ---
I can confirm the existence of this bug.


I have done a test of this bug under Win2000 and  JDK 1.4.1_01-b01


I think I also have found the origin of this bug :


1)War.java#zipFile(File file, ZipOutputStream zOut, String vPath, 


   int mode)


contains a line saying ... !deploymentDescriptor.equals(file) ...


in test3 deploymentDescriptor = \Xxx\Yyy\Zzz.xml


 file = D:\Xxx\Yyy\Zzz.xml


therefore War.java#zipFile refuses to include \Xxx\Yyy\Zzz.xml into the war file






2) AbstractFileSet.java does this


   public void setFile(File file) {


...


setDir(fileUtils.getParentFile(file));


...


}


getParentFile returns D:\Xxx\Yyy\ always, independently of whether file 
contains 
the drive specification or not


DO NOT REPLY [Bug 17871] - war task's webxml attrib no longer is able to use value with a starting backslash for the path in Windows

2003-03-12 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17871

war task's webxml attrib no longer is able to use value with a starting 
backslash for the path in Windows





--- Additional Comments From [EMAIL PROTECTED]  2003-03-12 17:48 ---
One clarification about the "test3" and "test4" tasks are that there are no 
files to be included in the war file except for the "web.xml" file.  So it is 
weird to get the "war" warning for the "test3" task.

Also note that in both cases, the "destfile" attrib of the "war" task does not 
include the drive -- yet the "war" task was able to output both war files at 
the correct location.


DO NOT REPLY [Bug 17871] - war task's webxml attrib no longer is able to use value with a starting backslash for the path in Windows

2003-03-12 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17871

war task's webxml attrib no longer is able to use value with a starting 
backslash for the path in Windows





--- Additional Comments From [EMAIL PROTECTED]  2003-03-12 17:37 ---
For the following "test" task:



  




  

  

  


${foo-as-prop}
  

  

  


${foo-as-prop}
  

  


  

  


  




Here is the output:



Buildfile: D:\Stoehr\cincro\src\build.xml

test:

test1:
 [echo] D:\Xxx\Yyy\Zzz.xml

test2:
 [echo] D:\Xxx\Yyy\Zzz.xml

test3:
  [war] Building war: D:\test3.war
  [war] Warning: selected war files include a WEB-INF/web.xml which will be 
ignored (please use webxml attribute to war task)

test4:
  [war] Building war: D:\test4.war

BUILD SUCCESSFUL
Total time: 1 second




DO NOT REPLY [Bug 17871] - war task's webxml attrib no longer is able to use value with a starting backslash for the path in Windows

2003-03-12 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17871

war task's webxml attrib no longer is able to use value with a starting 
backslash for the path in Windows





--- Additional Comments From [EMAIL PROTECTED]  2003-03-12 17:04 ---
Hmm,

the main change is that the webxml attribute now uses 's file
attribute internally.  I don't have Windows around, could you please try this
snippet and port the result?


  


${foo-as-prop}

and compare it to


  


${foo-as-prop}

they are supposed to echo the same file name.


DO NOT REPLY [Bug 17871] - war task's webxml attrib no longer is able to use value with a starting backslash for the path in Windows

2003-03-12 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17871

war task's webxml attrib no longer is able to use value with a starting 
backslash for the path in Windows





--- Additional Comments From [EMAIL PROTECTED]  2003-03-12 16:45 ---
I verified that it gets ignored.  I used both UnZip 5.41 and jar (JDK1.4.1_02) 
[both on Windows].

(Besides, when the "war" task runs, it just so happens that there is a "WEB-
INF/web.xml" file in the selected war files of the task, so the task 
displays "[war] Warning: selected war files include a WEB-INF/web.xml which 
will be ignored (please use webxml attribute to war task)" when the "webxml" 
attrib of the task has something like "\Xxx\Yyy\Zzz.xml" -- presumably because 
the task was not able to find "\Xxx\Yyy\Zzz.xml" to use as the "web.xml" file; 
but when the "webxml" attrib is "D:\Xxx\Yyy\Zzz.xml", then all is well.  Keep 
in mind that Ant is invoked on the Windows command line at the "D:" drive, the 
build file is also located on the "D:" drive, and all the files that the task 
uses are also on the "D:" drive.)

So I believe that this issue is NOT a duplicate of bug 17648.


DO NOT REPLY [Bug 17871] - war task's webxml attrib no longer is able to use value with a starting backslash for the path in Windows

2003-03-12 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17871

war task's webxml attrib no longer is able to use value with a starting 
backslash for the path in Windows





--- Additional Comments From [EMAIL PROTECTED]  2003-03-12 16:26 ---
Are you sure it gets ignored?  How do you check the resulting war archive?

WinZIP?  Does your web.xml show up if you run "jar tf" against the war file?

If you answer yes to the last two questions, please mark this bug as a duplicate
of bug 17648.