Re: [PATCH] Next round of typo fixes
"Shatzer, Larry" wrote: > Ooops. Thanks. I usually read the sentence for double words twice to make > sure it made sense, this must have slipped past me. > > I think the sentence might be changed to: "Timestamps are not at all looked > at." to avoid the double word. Ah, the problem of perfective verbs in English, "to look at" :-) Why not simply, "Timestamps are not considered." -- Jack J. Woehr # You measure democracy by the freedom it Senior Consultant # gives its dissidents, not the freedom Purematrix, Inc. # it gives its assimilated conformists. www.purematrix.com # - Abbie Hoffman - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [PATCH] Next round of typo fixes
Ooops. Thanks. I usually read the sentence for double words twice to make sure it made sense, this must have slipped past me. I think the sentence might be changed to: "Timestamps are not at all looked at." to avoid the double word. New patch to supercede previous patch with this change to correct. -- Larry > -Original Message- > From: Martijn Kruithof [mailto:[EMAIL PROTECTED] > Sent: Tuesday, September 16, 2003 1:23 PM > To: Ant Developers List > Subject: Re: [PATCH] Next round of typo fixes > > > Hi, > > nice work, though this set seems to contain a wrong > correction (prefixed > with ) > > Kind Regards, Martijn > Index: src/main/org/apache/tools/ant/taskdefs/condition/FilesMatch.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/condition/FilesMatch.java,v retrieving revision 1.11 diff -u -r1.11 FilesMatch.java --- src/main/org/apache/tools/ant/taskdefs/condition/FilesMatch.java6 Jul 2003 09:03:17 - 1.11 +++ src/main/org/apache/tools/ant/taskdefs/condition/FilesMatch.java16 Sep 2003 20:43:17 - @@ -1,7 +1,7 @@ /* * The Apache Software License, Version 1.1 * - * Copyright (c) 2002 The Apache Software Foundation. All rights + * Copyright (c) 2002-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -60,7 +60,7 @@ /** * Compares two files for bitwise equality based on size and - * content. Timestamps are not looked at at all. + * content. Timestamps are not at all looked at. * * @author Steve Loughran * @version $Revision: 1.11 $ @@ -99,7 +99,7 @@ } /** - * comparision method of the interface + * comparison method of the interface * * @return true if the files are equal * @exception BuildException if it all went pear-shaped Index: src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogParser.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogParser.java,v retrieving revision 1.21 diff -u -r1.21 ChangeLogParser.java --- src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogParser.java 14 Aug 2003 07:04:40 - 1.21 +++ src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogParser.java 16 Sep 2003 18:03:25 - @@ -97,9 +97,9 @@ private final Hashtable m_entries = new Hashtable(); /** - * Get a list of rcs entrys as an array. + * Get a list of rcs entries as an array. * - * @return a list of rcs entrys as an array + * @return a list of rcs entries as an array */ CVSEntry[] getEntrySetAsArray() { final CVSEntry[] array = new CVSEntry[ m_entries.size() ]; Index: src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java,v retrieving revision 1.24 diff -u -r1.24 ChangeLogTask.java --- src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java25 Jul 2003 12:14:42 - 1.24 +++ src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java16 Sep 2003 18:03:25 - @@ -117,14 +117,14 @@ /** Output file */ private File m_destfile; -/** The earliest date at which to start processing entrys. */ +/** The earliest date at which to start processing entries. */ private Date m_start; -/** The latest date at which to stop processing entrys. */ +/** The latest date at which to stop processing entries. */ private Date m_stop; /** - * Filesets containting list of files against which the cvs log will be + * Filesets containing list of files against which the cvs log will be * performed. If empty then all files will in the working directory will * be checked. */ @@ -359,7 +359,7 @@ } /** - * Filter the specified entrys accoridn to an appropriate rule. + * Filter the specified entries according to an appropriate rule. * * @param entrySet the entry set to filter * @return the filtered entry set @@ -406,7 +406,7 @@ * Print changelog to file specified in task. * * @param entrySet the entry set to write. - * @throws BuildException if theres an error writing changelog. + * @throws BuildException if there is an error writing changelog. */ private void writeChangeLog(final CVSEntry[] entrySet) throws BuildException { Index: src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogWriter.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogWriter.java,v retrieving revision 1.9 dif
Re: [PATCH] Next round of typo fixes
Hi, nice work, though this set seems to contain a wrong correction (prefixed with ) Kind Regards, Martijn Shatzer, Larry wrote: Thanks, here is the next set. src/main/org/apache/tools/ant/util/UnPackageNameMapper.java still has messed up line endings. -- Larry -Original Message- From: peter reilly [mailto:[EMAIL PROTECTED] Sent: Tuesday, September 16, 2003 2:11 AM To: Ant Developers List Subject: Re: [PATCH] Next round of typo fixes Committed, Peter. Index: src/main/org/apache/tools/ant/taskdefs/condition/FilesMatch.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/condition/FilesMatch.java,v retrieving revision 1.11 diff -u -r1.11 FilesMatch.java --- src/main/org/apache/tools/ant/taskdefs/condition/FilesMatch.java 6 Jul 2003 09:03:17 - 1.11 +++ src/main/org/apache/tools/ant/taskdefs/condition/FilesMatch.java 16 Sep 2003 18:03:25 - @@ -1,7 +1,7 @@ /* * The Apache Software License, Version 1.1 * - * Copyright (c) 2002 The Apache Software Foundation. All rights + * Copyright (c) 2002-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -60,7 +60,7 @@ /** * Compares two files for bitwise equality based on size and > - * content. Timestamps are not looked at at all. > + * content. Timestamps are not looked at all. * * @author Steve Loughran * @version $Revision: 1.11 $ @@ -99,7 +99,7 @@ } /** - * comparision method of the interface + * comparison method of the interface * * @return true if the files are equal * @exception BuildException if it all went pear-shaped - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [PATCH] Next round of typo fixes
Thanks, here is the next set. src/main/org/apache/tools/ant/util/UnPackageNameMapper.java still has messed up line endings. -- Larry > -Original Message- > From: peter reilly [mailto:[EMAIL PROTECTED] > Sent: Tuesday, September 16, 2003 2:11 AM > To: Ant Developers List > Subject: Re: [PATCH] Next round of typo fixes > > > Committed, > > Peter. Index: src/main/org/apache/tools/ant/taskdefs/condition/FilesMatch.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/condition/FilesMatch.java,v retrieving revision 1.11 diff -u -r1.11 FilesMatch.java --- src/main/org/apache/tools/ant/taskdefs/condition/FilesMatch.java6 Jul 2003 09:03:17 - 1.11 +++ src/main/org/apache/tools/ant/taskdefs/condition/FilesMatch.java16 Sep 2003 18:03:25 - @@ -1,7 +1,7 @@ /* * The Apache Software License, Version 1.1 * - * Copyright (c) 2002 The Apache Software Foundation. All rights + * Copyright (c) 2002-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -60,7 +60,7 @@ /** * Compares two files for bitwise equality based on size and - * content. Timestamps are not looked at at all. + * content. Timestamps are not looked at all. * * @author Steve Loughran * @version $Revision: 1.11 $ @@ -99,7 +99,7 @@ } /** - * comparision method of the interface + * comparison method of the interface * * @return true if the files are equal * @exception BuildException if it all went pear-shaped Index: src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogParser.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogParser.java,v retrieving revision 1.21 diff -u -r1.21 ChangeLogParser.java --- src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogParser.java 14 Aug 2003 07:04:40 - 1.21 +++ src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogParser.java 16 Sep 2003 18:03:25 - @@ -97,9 +97,9 @@ private final Hashtable m_entries = new Hashtable(); /** - * Get a list of rcs entrys as an array. + * Get a list of rcs entries as an array. * - * @return a list of rcs entrys as an array + * @return a list of rcs entries as an array */ CVSEntry[] getEntrySetAsArray() { final CVSEntry[] array = new CVSEntry[ m_entries.size() ]; Index: src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java,v retrieving revision 1.24 diff -u -r1.24 ChangeLogTask.java --- src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java25 Jul 2003 12:14:42 - 1.24 +++ src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java16 Sep 2003 18:03:25 - @@ -117,14 +117,14 @@ /** Output file */ private File m_destfile; -/** The earliest date at which to start processing entrys. */ +/** The earliest date at which to start processing entries. */ private Date m_start; -/** The latest date at which to stop processing entrys. */ +/** The latest date at which to stop processing entries. */ private Date m_stop; /** - * Filesets containting list of files against which the cvs log will be + * Filesets containing list of files against which the cvs log will be * performed. If empty then all files will in the working directory will * be checked. */ @@ -359,7 +359,7 @@ } /** - * Filter the specified entrys accoridn to an appropriate rule. + * Filter the specified entries according to an appropriate rule. * * @param entrySet the entry set to filter * @return the filtered entry set @@ -406,7 +406,7 @@ * Print changelog to file specified in task. * * @param entrySet the entry set to write. - * @throws BuildException if theres an error writing changelog. + * @throws BuildException if there is an error writing changelog. */ private void writeChangeLog(final CVSEntry[] entrySet) throws BuildException { Index: src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogWriter.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogWriter.java,v retrieving revision 1.9 diff -u -r1.9 ChangeLogWriter.java --- src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogWriter.java 19 Jul 2003 08:11:02 - 1.9 +++ src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogWriter.java 16 Sep 2003 18:03:25 - @@ -1,7 +1,7 @@ /* * The Apache Software License, Version 1.1 * - *
Re: [PATCH] Next round of typo fixes
Committed, Peter. On Monday 15 September 2003 23:32, Shatzer, Larry wrote: > More typos and misspellings... > > -- Larry - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]