RE: [GUMP] Test Failure - Ant

[Jan . Materne]

> -Original Message-
> From: Stefan Bodewig [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, September 10, 2003 9:25 AM
> To: [EMAIL PROTECTED]
> Subject: Re: [GUMP] Test Failure - Ant
> 
> 
> On Wed, 10 Sep 2003, Jan Materne <[EMAIL PROTECTED]> wrote:
> 
> > During development of StyleTest.testNewStylesheet() I got this
> > error, too.  The xsl stylesheet wasn´t right. Maybe GUMP has not
> > used the latest version.
> 
> It still failed last night on my machine.

I uploaded the file yesterday.
http://cvs.apache.org/viewcvs.cgi/ant/src/etc/testcases/taskdefs/style/testN
ewerStylesheet.xsl

The build.xml seems to be ok ... (copy with overwrite enabled, right param´s
for replacement).

So wait until tomorrow ...


> The CommanlineJavaTest fails as ant.home hasn't been defined within
> Gump (Gump doesn't use our wrapper script), I'll look into fixing
> that.
> 
> Stefan

Ok.


Jan

Re: [GUMP] Test Failure - Ant

[Stefan Bodewig]

On Wed, 10 Sep 2003, Jan Materne <[EMAIL PROTECTED]> wrote:

> During development of StyleTest.testNewStylesheet() I got this
> error, too.  The xsl stylesheet wasn´t right. Maybe GUMP has not
> used the latest version.

It still failed last night on my machine.

The CommanlineJavaTest fails as ant.home hasn't been defined within
Gump (Gump doesn't use our wrapper script), I'll look into fixing
that.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: [GUMP] Test Failure - Ant

[Jan . Materne]

> -Original Message-
> From: Gump Integration Build [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, September 09, 2003 3:13 PM
> To: [EMAIL PROTECTED]
> Subject: [GUMP] Test Failure - Ant
> 
> 
> 
> This email is autogenerated from the output from:
> 
> 

Errors on GUMP:

[junit] Testcase:
testNewerStylesheet(org.apache.tools.ant.taskdefs.StyleTest):   FAILED
[junit] expecting file out/out.xml to contain new-value but got 
[junit] old-value
[junit] junit.framework.AssertionFailedError: expecting file out/out.xml to
contain new-value but got 
[junit] old-value
[junit] at junit.framework.Assert.fail(Assert.java:47)
[junit] at junit.framework.Assert.assertTrue(Assert.java:20)
[junit] at
org.apache.tools.ant.taskdefs.StyleTest.expectFileContains(StyleTest.java:15
5)
[junit] at
org.apache.tools.ant.taskdefs.StyleTest.testNewerStylesheet(StyleTest.java:1
17)

...

[junit] Testsuite: org.apache.tools.ant.types.CommandlineJavaTest
[junit] Tests run: 3, Failures: 1, Errors: 0, Time elapsed: 0.022 sec
[junit] Testcase:
testGetCommandline(org.apache.tools.ant.types.CommandlineJavaTest):
FAILED
[junit] junit.jar contained
[junit] junit.framework.AssertionFailedError: junit.jar contained



On my machine (W2K, JDK 1.4.2) with lates CVS HEAD I get only:

[junit] Testcase: test9(org.apache.tools.ant.taskdefs.ReplaceTest): FAILED
[junit] expected:<10> but was:<13>
[junit] junit.framework.AssertionFailedError: expected:<10> but was:<13>



During development of StyleTest.testNewStylesheet() I got this error, too. 
The xsl stylesheet wasn´t right. Maybe GUMP has not used the latest version.



Jan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [GUMP] Test Failure - Ant

[Antoine Levy-Lambert]

Yes, the failure of the exec test might be a timing issue, the testcase
contains a hard-coded maximum time to start a small shell script. I am going
to increase this time.
Cheers, Antoine
- Original Message -
From: <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Wednesday, September 03, 2003 9:31 AM
Subject: RE: [GUMP] Test Failure - Ant


> I followed the link provided in the first mail
> <http://cvs.apache.org/builds/gump/2003-09-03/test-ant.html>
> and there the test failed ...
>
>
> Jan
>
>
>
> > -Original Message-
> > From: Stefan Bodewig [mailto:[EMAIL PROTECTED]
> > Sent: Wednesday, September 03, 2003 9:23 AM
> > To: [EMAIL PROTECTED]
> > Subject: Re: [GUMP] Test Failure - Ant
> >
> >
> > On Wed, 3 Sep 2003, Jan Materne <[EMAIL PROTECTED]> wrote:
> >
> > > Which one? There failed more than one:
> >
> > The exec test didn't fail on my machine last night, I assumed (without
> > cross-checking) the failures on Sam's machine would be the same as on
> > mine.
> >
> > May be a timing issue.
> >
> > Stefan
> >
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
>



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: [GUMP] Test Failure - Ant

[Jan . Materne]

I followed the link provided in the first mail
<http://cvs.apache.org/builds/gump/2003-09-03/test-ant.html>
and there the test failed ...


Jan



> -Original Message-
> From: Stefan Bodewig [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, September 03, 2003 9:23 AM
> To: [EMAIL PROTECTED]
> Subject: Re: [GUMP] Test Failure - Ant
> 
> 
> On Wed, 3 Sep 2003, Jan Materne <[EMAIL PROTECTED]> wrote:
> 
> > Which one? There failed more than one:
> 
> The exec test didn't fail on my machine last night, I assumed (without
> cross-checking) the failures on Sam's machine would be the same as on
> mine.
> 
> May be a timing issue.
> 
> Stefan
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 

Re: [GUMP] Test Failure - Ant

[Stefan Bodewig]

On Wed, 3 Sep 2003, Jan Materne <[EMAIL PROTECTED]> wrote:

> Which one? There failed more than one:

The exec test didn't fail on my machine last night, I assumed (without
cross-checking) the failures on Sam's machine would be the same as on
mine.

May be a timing issue.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: [GUMP] Test Failure - Ant

[Jan . Materne]

Which one? There failed more than one:


Testsuite: org.apache.tools.ant.taskdefs.ExecTaskTest
Testcase: testspawn(org.apache.tools.ant.taskdefs.ExecTaskTest):
FAILED
log file found after spawn
...
at
org.apache.tools.ant.taskdefs.ExecTaskTest.testspawn(ExecTaskTest.java:134)


Testsuite: org.apache.tools.ant.taskdefs.StyleTest
Testcase: testTransferParameterSet(org.apache.tools.ant.taskdefs.StyleTest):
Caused an ERROR
javax.xml.transform.TransformerFactoryConfigurationError: Provider for
javax.xml.transform.TransformerFactory cannot be found
...
(4 of 5 testcases there requires xslt; the 5th asserts a thrown
BuildException :-)


Testsuite: org.apache.tools.ant.taskdefs.optional.junit.JUnitReportTest
Testcase:
testNoFileJUnitNoFrames(org.apache.tools.ant.taskdefs.optional.junit.JUnitRe
portTest):  Caused an ERROR
javax.xml.transform.TransformerFactoryConfigurationError: Provider for
javax.xml.transform.TransformerFactory cannot be found



I think you are right with the last two. But what about the ?



Jan


> -Original Message-
> From: Stefan Bodewig [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, September 03, 2003 9:09 AM
> To: [EMAIL PROTECTED]
> Subject: Re: [GUMP] Test Failure - Ant
> 
> 
> jakarta-regexp has changed it jar location (Gump knows about that now)
> so Xalan didn't build.  The failing test is a test that requires Xalan
> but isn't excluded in case it cannot be found.
> 
> Stefan
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 

Re: [GUMP] Test Failure - Ant

[Stefan Bodewig]

jakarta-regexp has changed it jar location (Gump knows about that now)
so Xalan didn't build.  The failing test is a test that requires Xalan
but isn't excluded in case it cannot be found.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [GUMP] Test Failure - Ant

[Antoine Levy-Lambert]

This failure (PermissionsTest) is already fixed in CVS (checked with Stefan
Bodewig).

Antoine
- Original Message -
From: "Gump Integration Build" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Thursday, August 28, 2003 3:25 PM
Subject: [GUMP] Test Failure - Ant


>
> [junit] Testsuite: org.apache.tools.ant.types.PermissionsTest
> [junit] Tests run: 6, Failures: 0, Errors: 1, Time elapsed: 0.032 sec
>
> [junit] Testcase:
testExit(org.apache.tools.ant.types.PermissionsTest): Caused an ERROR
> [junit] Permission (java.util.PropertyPermission file.encoding read)
was not granted.
> [junit] java.lang.SecurityException: Permission
(java.util.PropertyPermission file.encoding read) was not granted.
> [junit] at
org.apache.tools.ant.types.Permissions$MySM.checkPermission(Permissions.java
:201)
> [junit] at
java.lang.SecurityManager.checkPropertyAccess(SecurityManager.java:1291)
> [junit] at java.lang.System.getProperty(System.java:572)
> [junit] at
sun.security.action.GetPropertyAction.run(GetPropertyAction.java:66)
> [junit] at java.security.AccessController.doPrivileged(Native Method)
> [junit] at
sun.io.Converters.getDefaultEncodingName(Converters.java:66)
> [junit] at java.lang.StringCoding.decode(StringCoding.java:226)
> [junit] at java.lang.String.(String.java:383)
> [junit] at
java.io.ByteArrayOutputStream.toString(ByteArrayOutputStream.java:160)
> [junit] at
org.apache.tools.ant.DemuxOutputStream.processBuffer(DemuxOutputStream.java:
208)
> [junit] at
org.apache.tools.ant.DemuxOutputStream.write(DemuxOutputStream.java:184)
> [junit] at
org.apache.tools.ant.DemuxOutputStream.write(DemuxOutputStream.java:278)
> [junit] at java.io.PrintStream.write(PrintStream.java:258)
> [junit] at
sun.nio.cs.StreamEncoder$CharsetSE.writeBytes(StreamEncoder.java:334)
> [junit] at
sun.nio.cs.StreamEncoder$CharsetSE.implFlushBuffer(StreamEncoder.java:402)
> [junit] at
sun.nio.cs.StreamEncoder.flushBuffer(StreamEncoder.java:113)
> [junit] at
java.io.OutputStreamWriter.flushBuffer(OutputStreamWriter.java:169)
> [junit] at java.io.PrintStream.newLine(PrintStream.java:324)
> [junit] at java.io.PrintStream.println(PrintStream.java:586)
> [junit] at
org.apache.tools.ant.types.PermissionsTest.testExit(PermissionsTest.java:170
)
> [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [junit] at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
)
> [junit] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
.java:25)
> [junit] at java.lang.reflect.Method.invoke(Method.java:324)
> [junit] at junit.framework.TestCase.runTest(TestCase.java:154)
> [junit] at junit.framework.TestCase.runBare(TestCase.java:127)
> [junit] at junit.framework.TestResult$1.protect(TestResult.java:106)
> [junit] at
junit.framework.TestResult.runProtected(TestResult.java:124)
> [junit] at junit.framework.TestResult.run(TestResult.java:109)
> [junit] at junit.framework.TestCase.run(TestCase.java:118)
> [junit] at junit.framework.TestSuite.runTest(TestSuite.java:208)
> [junit] at junit.framework.TestSuite.run(TestSuite.java:203)
> [junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRu
nner.java:328)
> [junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.executeInVM(JUnitTask
.java:973)
> [junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitTask.jav
a:659)
> [junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitTask.jav
a:633)
> [junit] at
org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:295)
> [junit] at org.apache.tools.ant.Task.perform(Task.java:401)
> [junit] at org.apache.tools.ant.Target.execute(Target.java:347)
> [junit] at org.apache.tools.ant.Target.performTasks(Target.java:374)
> [junit] at
org.apache.tools.ant.Project.executeTarget(Project.java:1237)
> [junit] at
org.apache.tools.ant.Project.executeTargets(Project.java:1094)
> [junit] at org.apache.tools.ant.Main.runBuild(Main.java:665)
> [junit] at org.apache.tools.ant.Main.startAnt(Main.java:220)
> [junit] at org.apache.tools.ant.Main.start(Main.java:184)
> [junit] at org.apache.tools.ant.Main.main(Main.java:267)
>
>
>
> [junit] TEST org.apache.tools.ant.types.PermissionsTest FAILED
> [junit] Testsuite: org.apache.tools.ant.types.PolyTest
> [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 0.295 sec
>
> [junit] - Standard Output ---
> [junit] If this is the last line on standard out the testExit
f.a.i.l.e.d
> [junit] -  ---
>



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [GUMP] Test Failure - Ant

[Stefan Bodewig]

On Fri, 01 Aug 2003, Steve Loughran <[EMAIL PROTECTED]> wrote:
> Stefan Bodewig wrote:
> 
>> On Fri, 1 Aug 2003, Antoine Levy-Lambert <[EMAIL PROTECTED]>
>> wrote:
>>
>>>I do not know why the ExecTaskTest failed. It ran successfully on
>>>July 30th.
>> It has been constantly failing for my personal Gump installation

It started to pass after Antoine's patch of last Friday.

> Maybe its too timing dependent.

Seemed to be that way.

> Does gump run niced BTW?

Not on my system.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [GUMP] Test Failure - Ant

[Antoine Levy-Lambert]

I will try it (ExecTaskTest) on cvs.apache.org tomorrow.
I had ran it successfully on Solaris, so it is not necessarily failing on
Unix.

Cheers,

Antoine



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [GUMP] Test Failure - Ant

[Steve Loughran]

Stefan Bodewig wrote:
On Fri, 1 Aug 2003, Antoine Levy-Lambert <[EMAIL PROTECTED]> wrote:

I do not know why the ExecTaskTest failed. It ran successfully on
July 30th.

It has been constantly failing for my personal Gump installation (also
running on Linux) since you've added it.  I just cannot find the time
to debug it, sorry.  It passes when I do a "normal" ant test.
Maybe its too timing dependent. I can imagine this having fun on a 
multiprocessor system. Does gump run niced BTW?


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [GUMP] Test Failure - Ant

[Stefan Bodewig]

On Fri, 1 Aug 2003, Antoine Levy-Lambert <[EMAIL PROTECTED]> wrote:

> I do not know why the ExecTaskTest failed. It ran successfully on
> July 30th.

It has been constantly failing for my personal Gump installation (also
running on Linux) since you've added it.  I just cannot find the time
to debug it, sorry.  It passes when I do a "normal" ant test.

Unfortunately I'm not in the position to give you an account on my
machine either.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [GUMP] Test Failure - Ant

[Antoine Levy-Lambert]

I do not know why the ExecTaskTest failed. It ran successfully on July 30th.
Since then, I changed slightly the code of the test to suppress logging,
that's all.
I think I need to allocate one second instead of 1/10th of a second as a
margin between the end of the build triggering the spawn and the time when
the log file is expected.
I am going to change this now. (in CVS)
Cheers,
Antoine.

- Original Message -
From: "Diane Holt" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Friday, August 01, 2003 2:45 PM
Subject: [GUMP] Test Failure - Ant


> [junit] Testsuite: org.apache.tools.ant.taskdefs.ExecTaskTest
> [junit] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 4.212 sec
>
> [junit] Testcase:
testspawn(org.apache.tools.ant.taskdefs.ExecTaskTest): FAILED
> [junit] log file found after spawn
> [junit] junit.framework.AssertionFailedError: log file found after
spawn
> [junit] at junit.framework.Assert.fail(Assert.java:47)
> [junit] at junit.framework.Assert.assertTrue(Assert.java:20)
> [junit] at
org.apache.tools.ant.taskdefs.ExecTaskTest.testspawn(ExecTaskTest.java:133)
> [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [junit] at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
)
> [junit] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
.java:25)
> [junit] at java.lang.reflect.Method.invoke(Method.java:324)
> [junit] at junit.framework.TestCase.runTest(TestCase.java:154)
> [junit] at junit.framework.TestCase.runBare(TestCase.java:127)
> [junit] at junit.framework.TestResult$1.protect(TestResult.java:106)
> [junit] at
junit.framework.TestResult.runProtected(TestResult.java:124)
> [junit] at junit.framework.TestResult.run(TestResult.java:109)
> [junit] at junit.framework.TestCase.run(TestCase.java:118)
> [junit] at junit.framework.TestSuite.runTest(TestSuite.java:208)
> [junit] at junit.framework.TestSuite.run(TestSuite.java:203)
> [junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRu
nner.java:316)
> [junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.executeInVM(JUnitTask
.java:943)
> [junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitTask.jav
a:635)
> [junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitTask.jav
a:609)
> [junit] at
org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:272)
> [junit] at org.apache.tools.ant.Task.perform(Task.java:401)
> [junit] at org.apache.tools.ant.Target.execute(Target.java:347)
> [junit] at org.apache.tools.ant.Target.performTasks(Target.java:374)
> [junit] at
org.apache.tools.ant.Project.executeTarget(Project.java:1228)
> [junit] at
org.apache.tools.ant.Project.executeTargets(Project.java:1085)
> [junit] at org.apache.tools.ant.Main.runBuild(Main.java:661)
> [junit] at org.apache.tools.ant.Main.startAnt(Main.java:220)
> [junit] at org.apache.tools.ant.Main.start(Main.java:184)
> [junit] at org.apache.tools.ant.Main.main(Main.java:267)
>
>
>
> [junit] TEST org.apache.tools.ant.taskdefs.ExecTaskTest FAILED



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [GUMP] Test Failure - Ant

[Stefan Bodewig]

The CVS tasks failed because cvs exited with 1.  A temporary network
problem, I'd guess.

Stefan

Re: [GUMP] Test Failure - Ant

[Stefan Bodewig]

On Tue, 22 Apr 2003, Antoine Levy-Lambert <[EMAIL PROTECTED]>
wrote:
> From: "Stefan Bodewig" <[EMAIL PROTECTED]>

>> Which documentation?
> I meant the ant manual page under docs/manual/CoreTasks/war.html
> Nested elements lib
> 
> The nested lib element specifies a FileSet.

Well, yes.  This doesn't rule out zipfileset, I'd call it an
implementation detail that the user shouldn't have to be aware of.
Which also measn that using a reference to a plain fileset must work.

> What about changing the method signature of War#addLib from
> addLib(ZipFileSet fs) to addLib(FileSet fs) ?

Would break this here


  


which should work right now (and in Ant 1.3+).

> Yes this is new, it was possible to do 
> 
> 
> 
> 
> before I did my changes.

Yes, I've seen Gianugo's post as well 8-)

Stefan

Re: [GUMP] Test Failure - Ant

[Antoine Levy-Lambert]

- Original Message -
From: "Stefan Bodewig" <[EMAIL PROTECTED]>
Sent: Tuesday, April 22, 2003 5:50 PM
>
> > * In the code of the War.java task, the lib attribute is defined as
> > a ZipFileSet.  In the documentation, the same lib attribute is
> > defined as a FileSet.  Should we fix the code or the documentation
> > of the War task ?
>
> Which documentation?
I meant the ant manual page under docs/manual/CoreTasks/war.html


Nested elements
lib

The nested lib element specifies a FileSet. All files included in this
fileset will end up in the WEB-INF/lib directory of the war file.

--
> We don't tell people that  is a zipfileset because they may get
> confused when they try to use the prefix attribute then.  It must be a
> zipfileset, so that it can get mapped to prefix="/WEB-INF/lib".
>
What about changing the method signature of War#addLib  from
addLib(ZipFileSet fs) to addLib(FileSet fs) ?
This would also require changing the access of ZipFileSet#ZipFileSet(FileSet
fs) from protected to public too.


> >   c) or write in WHATSNEW something like : - only references to
> >   zipfileset(s) are accepted by tasks using zipfileset(s) as
> >   attributes or nested elements.

> Is this really new?

Yes this is new, it was possible to do 




before I did my changes.

Cheers

Antoine

Re: [GUMP] Test Failure - Ant

[Stefan Bodewig]

On Sat, 19 Apr 2003, Antoine Levy-Lambert <[EMAIL PROTECTED]>
wrote:

> * In the code of the War.java task, the lib attribute is defined as
> a ZipFileSet.  In the documentation, the same lib attribute is
> defined as a FileSet.  Should we fix the code or the documentation
> of the War task ?

Which documentation?

We don't tell people that  is a zipfileset because they may get
confused when they try to use the prefix attribute then.  It must be a
zipfileset, so that it can get mapped to prefix="/WEB-INF/lib".

> 
> * the failure of the test was due to :
> 
> - this code in ZipFileSet#getRef(Project p)

which is good in situations where you really have to be sure that you
are dealing with a zipfileset - and bad when you don't care.  There is
no good implementation that works in both cases, I'm afraid.

>   a) remove the ZipFileSet#getRef method , which means a fall back
>   on
> AbstractFileSet#getRef (status-quo ante), which should work too.

I think this is what Conor had to do for  to work.  Not
sure whether it is the correct solution, though.

But then again, you can always cast the returned object, when you
really must be sure that you are dealing with - say - a zipfileset.

>   c) or write in WHATSNEW something like : - only references to
>   zipfileset(s) are accepted by tasks using zipfileset(s) as
>   attributes or nested elements.

Is this really new?

Stefan

Re: [GUMP] Test Failure - Ant

[Antoine Levy-Lambert]

Sorry :(
* I have just changed the testcase war.xml so that the lib fileset is now
defined as a ZipFileSet in the build file, which is a first application of
having zipfileset having refids.

* In the code of the War.java task, the lib attribute is defined as a
ZipFileSet.
In the documentation, the same lib attribute is defined as a FileSet.
Should we fix the code or the documentation of the War task ?

* the failure of the test was due to :

- this code in ZipFileSet#getRef(Project p)

 if (!(o instanceof ZipFileSet)) {
String msg = getRefid().getRefId() + " doesn\'t denote a
zipfileset";
throw new BuildException(msg);
} else {
return (AbstractFileSet) o;
}

- the fact that the lib attribute of the war task in the testcase was
defined as a , not as a 

* shall I
  a) remove the ZipFileSet#getRef method , which means a fall back on
AbstractFileSet#getRef (status-quo ante), which should work too.

  or

  b) relax this ZipFileSet#getRef method and only make sure that we return
an instance of AbstractFileSet, so that other builds are not blown up

  or

  c) or write in WHATSNEW something like :
- only references to zipfileset(s) are accepted by tasks using zipfileset(s)
as attributes or nested elements. Definitions should therefore be changed to
zipfileset(s)

Antoine


- Original Message -
From: "Diane Holt" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Saturday, April 19, 2003 11:11 AM
Subject: [GUMP] Test Failure - Ant


> 
> This email is autogenerated from the output from:
> 
> 
>
>
> [junit] Testsuite: org.apache.tools.ant.taskdefs.WarTest
> [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0.06 sec
>
> [junit] Testcase: testLibRefs(org.apache.tools.ant.taskdefs.WarTest):
Caused an ERROR
> [junit] test doesn't denote a zipfileset
> [junit] /home/rubys/jakarta/ant/src/etc/testcases/taskdefs/war.xml:16:
test doesn't denote a zipfileset
> [junit] at
org.apache.tools.ant.types.ZipFileSet.getRef(ZipFileSet.java:299)
> [junit] at
org.apache.tools.ant.types.ZipFileSet.getDirectoryScanner(ZipFileSet.java:22
2)
> [junit] at
org.apache.tools.ant.taskdefs.Zip.grabResources(Zip.java:842)
> [junit] at
org.apache.tools.ant.taskdefs.Zip.getResourcesToAdd(Zip.java:706)
> [junit] at
org.apache.tools.ant.taskdefs.Jar.getResourcesToAdd(Jar.java:637)
> [junit] at org.apache.tools.ant.taskdefs.Zip.executeMain(Zip.java:388)
> [junit] at org.apache.tools.ant.taskdefs.Zip.execute(Zip.java:322)
> [junit] at
org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:231)
> [junit] at org.apache.tools.ant.Task.perform(Task.java:399)
> [junit] at org.apache.tools.ant.Target.execute(Target.java:309)
> [junit] at org.apache.tools.ant.Target.performTasks(Target.java:336)
> [junit] at
org.apache.tools.ant.Project.executeTarget(Project.java:1404)
> [junit] at
org.apache.tools.ant.BuildFileTest.executeTarget(BuildFileTest.java:265)
> [junit] at
org.apache.tools.ant.taskdefs.WarTest.testLibRefs(WarTest.java:84)
> [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [junit] at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
)
> [junit] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
.java:25)
> [junit] at java.lang.reflect.Method.invoke(Method.java:324)
> [junit] at junit.framework.TestCase.runTest(TestCase.java:154)
> [junit] at junit.framework.TestCase.runBare(TestCase.java:127)
> [junit] at junit.framework.TestResult$1.protect(TestResult.java:106)
> [junit] at
junit.framework.TestResult.runProtected(TestResult.java:124)
> [junit] at junit.framework.TestResult.run(TestResult.java:109)
> [junit] at junit.framework.TestCase.run(TestCase.java:118)
> [junit] at junit.framework.TestSuite.runTest(TestSuite.java:208)
> [junit] at junit.framework.TestSuite.run(TestSuite.java:203)
> [junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRu
nner.java:318)
> [junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.executeInVM(JUnitTask
.java:872)
> [junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitTask.jav
a:562)
> [junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitTask.jav
a:538)
> [junit] at
org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:231)
> [junit] at org.apache.tools.ant.Task.perform(Task.java:399)
> [junit] at org.apache.tools.ant.Target.execute(Target.java:309)
> [junit] at org.apache.tools.ant.Target.performTasks(Target.java:336)
> [junit] at
org.apache.tools.ant.Project.executeTarget(Project.java:1404)
> [junit] at
org.apache.tools.ant.P

Re: [GUMP] Test Failure - Ant

[Stefan Bodewig]

On 16 Apr 2003, Diane Holt <[EMAIL PROTECTED]> wrote:

> [junit] Testcase:
> 
> testCheckoutCommandLine(org.apache.tools.ant.taskdefs.optional.vss.MSVSSTest):
> FAILED 
> [junit] extra args
> [junit] junit.framework.AssertionFailedError: extra args
> [junit] at junit.framework.Assert.fail(Assert.java:47)
> [junit] at
> 
> org.apache.tools.ant.taskdefs.optional.vss.MSVSSTest.checkCommandLines(MSVSSTest.java:455)
> [junit] at
> 
> org.apache.tools.ant.taskdefs.optional.vss.MSVSSTest.testCheckoutCommandLine(MSVSSTest.java:323)

happens on my machine (Linux, in case this is important) as well.

Stefan

Re: [GUMP] Test Failure - Ant

[Stefan Bodewig]

This is bug 17807, I knew it would happen, I'll take care of it


Stefan

Re: [GUMP] Test Failure - Ant

[Stefan Bodewig]

On Tue, 11 Mar 2003, Steve Loughran <[EMAIL PROTECTED]> wrote:

> OK, this is me, I need to set up the build to exclude DotnetTest

I've already taken care of it.

Stefan

Re: [GUMP] Test Failure - Ant

[Steve Loughran]

- Original Message -
From: "Diane Holt" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Tuesday, March 11, 2003 08:17
Subject: [GUMP] Test Failure - Ant


OK, this is me, I need to set up the build to exclude DotnetTest


> [junit] Testcase:
testCSC(org.apache.tools.ant.taskdefs.optional.DotnetTest): Caused an ERROR
> [junit] Needed .net apps are missing
> [junit]
file:///home/rubys/jakarta/ant/src/etc/testcases/taskdefs/optional/dotnet.xm
l:51: Needed .net apps are missing
> [junit] at org.apache.tools.ant.taskdefs.Exit.execute(Exit.java:104)
> [junit] at
org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:227)
> [junit] at org.apache.tools.ant.Task.perform(Task.java:388)
> [junit] at org.apache.tools.ant.Target.execute(Target.java:309)
> [junit] at org.apache.tools.ant.Target.performTasks(Target.java:336)
> [junit] at
org.apache.tools.ant.Project.executeTarget(Project.java:1394)
> [junit] at
org.apache.tools.ant.BuildFileTest.executeTarget(BuildFileTest.java:265)
> [junit] at
org.apache.tools.ant.taskdefs.optional.DotnetTest.testCSC(DotnetTest.java:10
5)
> [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [junit] at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
)
> [junit] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
.java:25)
> [junit] at java.lang.reflect.Method.invoke(Method.java:324)
> [junit] at junit.framework.TestCase.runTest(TestCase.java:154)
> [junit] at junit.framework.TestCase.runBare(TestCase.java:127)
> [junit] at junit.framework.TestResult$1.protect(TestResult.java:106)
> [junit] at
junit.framework.TestResult.runProtected(TestResult.java:124)
> [junit] at junit.framework.TestResult.run(TestResult.java:109)
> [junit] at junit.framework.TestCase.run(TestCase.java:118)
> [junit] at junit.framework.TestSuite.runTest(TestSuite.java:208)
> [junit] at junit.framework.TestSuite.run(TestSuite.java:203)
> [junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRu
nner.java:323)
> [junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.executeInVM(JUnitTask
.java:861)
> [junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitTask.jav
a:552)
> [junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitTask.jav
a:528)
> [junit] at
org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:227)
> [junit] at org.apache.tools.ant.Task.perform(Task.java:388)
> [junit] at org.apache.tools.ant.Target.execute(Target.java:309)
> [junit] at org.apache.tools.ant.Target.performTasks(Target.java:336)
> [junit] at
org.apache.tools.ant.Project.executeTarget(Project.java:1394)
> [junit] at
org.apache.tools.ant.Project.executeTargets(Project.java:1268)
> [junit] at org.apache.tools.ant.Main.runBuild(Main.java:611)
> [junit] at org.apache.tools.ant.Main.start(Main.java:198)
> [junit] at org.apache.tools.ant.Main.main(Main.java:245)
>
>
> [junit] Testcase:
testILASM(org.apache.tools.ant.taskdefs.optional.DotnetTest): Caused an
ERROR
> [junit] Needed .net apps are missing
> [junit]
file:///home/rubys/jakarta/ant/src/etc/testcases/taskdefs/optional/dotnet.xm
l:51: Needed .net apps are missing
> [junit] at org.apache.tools.ant.taskdefs.Exit.execute(Exit.java:104)
> [junit] at
org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:227)
> [junit] at org.apache.tools.ant.Task.perform(Task.java:388)
> [junit] at org.apache.tools.ant.Target.execute(Target.java:309)
> [junit] at org.apache.tools.ant.Target.performTasks(Target.java:336)
> [junit] at
org.apache.tools.ant.Project.executeTarget(Project.java:1394)
> [junit] at
org.apache.tools.ant.BuildFileTest.executeTarget(BuildFileTest.java:265)
> [junit] at
org.apache.tools.ant.taskdefs.optional.DotnetTest.testILASM(DotnetTest.java:
111)
> [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [junit] at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
)
> [junit] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
.java:25)
> [junit] at java.lang.reflect.Method.invoke(Method.java:324)
> [junit] at junit.framework.TestCase.runTest(TestCase.java:154)
> [junit] at junit.framework.TestCase.runBare(TestCase.java:127)
> [junit] at junit.framework.TestResult$1.protect(TestResult.java:106)
> [junit] at
junit.framework.TestResult.runProtected(TestResult.java:124)
> [junit] at junit.framework.TestResult.run(TestResult.java:109)
> [junit] at junit.framework.TestCase.run(TestCase.java:118)
> [junit] at junit.framework.TestSuite.runTest(TestSuite.java:208)
> [junit] at junit.framework.TestSuite.run(TestSuite.java:203)
> [junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUni