Re: cvs commit: ant/src/main/org/apache/tools/ant Project.java

2005-01-28 Thread Matt Benson 
--- Peter Reilly <[EMAIL PROTECTED]> wrote:

> Not wanting to sound like a whining ninny, but there
> is no
> need to change " to " as the text is not placed
> in an attribute.
>
That's okay, I thought I had seen somebody change one
of mine to the entity version in the past, but I won't
bother if there's no (even theoretical) reason to do
it.

Thanks,
Matt
 
> Peter
> 




__ 
Do you Yahoo!? 
The all-new My Yahoo! - What will yours do?
http://my.yahoo.com 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: ant/src/main/org/apache/tools/ant Project.java

2005-01-28 Thread Peter Reilly 
Not wanting to sound like a whining ninny, but there is no
need to change " to " as the text is not placed in an attribute.
Peter
[EMAIL PROTECTED] wrote:
mbenson 2005/01/28 10:18:37
 Modified:src/main/org/apache/tools/ant Project.java
 Log:
 Javadoc
 
 Revision  ChangesPath
 1.185 +175 -181  ant/src/main/org/apache/tools/ant/Project.java
 
 Index: Project.java
 ===
 RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/Project.java,v
 retrieving revision 1.184
 retrieving revision 1.185
 diff -u -r1.184 -r1.185
 --- Project.java	25 Jan 2005 14:48:08 -	1.184
 +++ Project.java	28 Jan 2005 18:18:36 -	1.185
 @@ -59,54 +59,54 @@
   */
  
  public class Project {
 -/** Message priority of "error". */
 +/** Message priority of "error". */
  public static final int MSG_ERR = 0;
 -/** Message priority of "warning". */
 +/** Message priority of "warning". */
  public static final int MSG_WARN = 1;
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: ant/src/main/org/apache/tools/ant Project.java

2005-01-14 Thread Jeffrey E Care 
Would it not be better to do something like this:

if (loggingMessage) {

  PrintStream tempErr = new PrintStream (new FileOutputStream 
(FileDescriptor.err));
  tempErr.println (message);
}

That way the message is not swallowed & lost?

-- 
Jeffrey E. Care ([EMAIL PROTECTED])
WebSphere Build SWAT Team Lead
WebSphere Build Tooling Lead (Project Mantis)
https://w3.opensource.ibm.com/projects/mantis


[EMAIL PROTECTED] wrote on 01/14/2005 05:09:23 AM:

> bodewig 2005/01/14 02:09:23
> 
>   Modified:src/main/org/apache/tools/ant Project.java
>   Log:
>   Silently ignore messages being written to System.err/out while a 
> Listener is processing a different message
> 
>   Revision  ChangesPath
>   1.183 +15 -5 ant/src/main/org/apache/tools/ant/Project.java
> 
>   Index: Project.java
>   ===
>   RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/Project.java,v
>   retrieving revision 1.182
>   retrieving revision 1.183
>   diff -u -r1.182 -r1.183
>   --- Project.java   10 Jan 2005 23:44:57 -   1.182
>   +++ Project.java   14 Jan 2005 10:09:23 -   1.183
>   @@ -1982,10 +1982,20 @@
>}
>synchronized (this) {
>if (loggingMessage) {
>   -throw new BuildException("Listener attempted to 
access "
>   -+ (priority == MSG_ERR ? "System.err" : 
"System.out")
>   -+ " with message [" + message
>   -+ "] - infinite loop terminated");
>   +/* 
>   + * One of the Listeners has attempted to access
>   + * System.err or System.out.
>   + *
>   + * We used to throw an exception in this case, but
>   + * sometimes Listeners can't prevent it(like our own
>   + * Log4jListener which invokes getLogger() which in
>   + * turn wants to write to the console).
>   + *
>   + * @see http://marc.theaimsgroup.com/?
> t=11053862426&r=1&w=2
>   + *
>   + * We now (Ant 1.7 and 1.6.3) simply swallow the 
message.
>   + */
>   +return;
>}
>try {
>loggingMessage = true;
> 
> 
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>

Re: cvs commit: ant/src/main/org/apache/tools/ant Project.java

2003-08-25 Thread Stefan Bodewig 
On Mon, 25 Aug 2003, Dominique Devienne <[EMAIL PROTECTED]> wrote:
> For optimum performance, shouldn't an array be used instead of an
> iterator?

Could, yes.  Probably even should.

One step after the other.  8-)

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: cvs commit: ant/src/main/org/apache/tools/ant Project.java

2003-08-25 Thread Dominique Devienne 
For optimum performance, shouldn't an array be used instead of an iterator?
It's easy and small to keep it in sync with the Listener vector...

Just wondering. --DD

> -Original Message-
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
> Sent: Monday, August 25, 2003 3:28 AM
> To: [EMAIL PROTECTED]
> Subject: cvs commit: ant/src/main/org/apache/tools/ant Project.java
> 
> bodewig 2003/08/25 01:28:27
> 
>   Modified:src/main/org/apache/tools/ant Project.java
>   Log:
>   Switch BuildListener management from "copy on each event" to "copy on
>   add/remove".
> 
>   Suggested by:   Sylvain Wallez  dot com>
> 
...

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]