Re: svn commit: r292276 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/ExecuteOn.java

2005-09-28 Thread Matt Benson 
--- [EMAIL PROTECTED] wrote:

 Author: bodewig
 Date: Wed Sep 28 12:28:39 2005
 New Revision: 292276
 
 URL:
 http://svn.apache.org/viewcvs?rev=292276view=rev
 Log:
 No, not necessary

:) Hmm, why not?

-Matt

 
 Modified:

ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/ExecuteOn.java
 Wed Sep 28 12:28:39 2005
 @@ -112,11 +112,7 @@
   * @since Ant 1.7
   */
  public void add(ResourceCollection rc) {
 -if (rc instanceof FileSet) {
 -addFileset((FileSet) rc);
 -} else {
 -resources.add(rc);
 -}
 +resources.add(rc);
  }




__ 
Yahoo! Mail - PC Magazine Editors' Choice 2005 
http://mail.yahoo.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r292276 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/ExecuteOn.java

2005-09-28 Thread Stefan Bodewig 
On Wed, 28 Sep 2005, Matt Benson [EMAIL PROTECTED] wrote:

 No, not necessary
 
 :) Hmm, why not?

Because IntrospectionHelper will always use the more specific
addFileset instead of add.  During development I had a bug where I
suspected a fileset was added as a resource collection and I wanted to
be sure it wasn't - it wasn't 8-)

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]