[GitHub] [ant] bodewig commented on pull request #134: [WIP] Add the possibility to specify a custom filename mapper when creating an INDEX.LIST

2020-09-04 Thread GitBox


bodewig commented on pull request #134:
URL: https://github.com/apache/ant/pull/134#issuecomment-687081344


   Looks good to me, @maartenc . You may want to undo the glob import of 
`org.apache.tools.ant.types.*`, though :-)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] [ant] maartenc commented on pull request #134: [WIP] Add the possibility to specify a custom filename mapper when creating an INDEX.LIST

2020-09-04 Thread GitBox


maartenc commented on pull request #134:
URL: https://github.com/apache/ant/pull/134#issuecomment-687093433


   Oops, fixed! :-)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] [ant] bodewig commented on pull request #134: [WIP] Add the possibility to specify a custom filename mapper when creating an INDEX.LIST

2020-09-04 Thread GitBox


bodewig commented on pull request #134:
URL: https://github.com/apache/ant/pull/134#issuecomment-687096390


   you should be able to merge this PR yourself.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org