[jira] [Commented] (ANY23-131) Nested Microdata are not extracted
[ https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288857#comment-14288857 ] Hudson commented on ANY23-131: -- SUCCESS: Integrated in Any23-trunk #1246 (See [https://builds.apache.org/job/Any23-trunk/1246/]) ANY23-131 Nested Microdata are not extracted (lewis.j.mcgibbney: rev 19abecc58c064cd388d3dcfe29ac90f1b7750ae0) * core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java > Nested Microdata are not extracted > -- > > Key: ANY23-131 > URL: https://issues.apache.org/jira/browse/ANY23-131 > Project: Apache Any23 > Issue Type: Bug > Components: microdata >Affects Versions: 0.7.0 >Reporter: Sebastien Richard >Assignee: Lewis John McGibbney > Fix For: 1.2 > > > Proposed patch: > core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java: > remove incorrect optim: > L166 > - return getUnnestedNodes( topLevelItemScopes ); > + return topLevelItemScopes; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ANY23-246) Add Open Graph Protocol and Facebook prefixes to popular.prefixes
[ https://issues.apache.org/jira/browse/ANY23-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288858#comment-14288858 ] Hudson commented on ANY23-246: -- SUCCESS: Integrated in Any23-trunk #1246 (See [https://builds.apache.org/job/Any23-trunk/1246/]) ANY23-246 Add Open Graph Protocol and Facebook prefixes to popular.prefixes (lewis.j.mcgibbney: rev 403a8631ed7e9fd4f15968eb94ab736157e72d8f) * api/src/main/resources/default-configuration.properties * core/src/test/java/org/apache/any23/Any23Test.java * core/src/main/resources/org/apache/any23/prefixes/prefixes.properties > Add Open Graph Protocol and Facebook prefixes to popular.prefixes > - > > Key: ANY23-246 > URL: https://issues.apache.org/jira/browse/ANY23-246 > Project: Apache Any23 > Issue Type: Improvement > Components: core >Affects Versions: 1.2 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney > Fix For: 1.2 > > > We have recently discussed problems with the extraction of some data > relationships from both OGP and FB prefixes (in particular). > This issue should quite simply add these two prefixes to the current list of > popular.prefixes we maintain [0] and should also review the accuracy of > existing prefixes within this list. > [0] > https://github.com/apache/any23/blob/master/core/src/main/resources/org/apache/any23/prefixes/prefixes.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] any23 pull request: ANY23-246 Add Open Graph Protocol and Facebook...
GitHub user lewismc opened a pull request: https://github.com/apache/any23/pull/11 ANY23-246 Add Open Graph Protocol and Facebook prefixes to popular.prefixes Pull request bundled with ANY23-131 I am getting better results here with more triples being extracted hence bumping the expected OG triples from 9 --> 12 in core/src/test/java/org/apache/any23/Any23Test#testExtractionParameters You can merge this pull request into a Git repository by running: $ git pull https://github.com/lewismc/any23 ANY23-246 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/any23/pull/11.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11 commit 19abecc58c064cd388d3dcfe29ac90f1b7750ae0 Author: Lewis John McGibbney Date: 2015-01-23T04:37:04Z ANY23-131 Nested Microdata are not extracted commit 403a8631ed7e9fd4f15968eb94ab736157e72d8f Author: Lewis John McGibbney Date: 2015-01-23T06:06:47Z ANY23-246 Add Open Graph Protocol and Facebook prefixes to popular.prefixes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] any23 pull request: ANY23-131 Nested Microdata are not extracted
Github user asfgit closed the pull request at: https://github.com/apache/any23/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ANY23-247) FIX Attribute name "itemscope" associated with an element type "html" must be followed by the ' = ' character.
Lewis John McGibbney created ANY23-247: -- Summary: FIX Attribute name "itemscope" associated with an element type "html" must be followed by the ' = ' character. Key: ANY23-247 URL: https://issues.apache.org/jira/browse/ANY23-247 Project: Apache Any23 Issue Type: Improvement Affects Versions: 1.1 Reporter: Lewis John McGibbney Fix For: 1.2 In the following markup {code} http://www.w3.org/TR/html4/loose.dtd";> http://www.w3.org/1999/xhtml"; xmlns:og="http://opengraphprotocol.org/schema/"; xmlns:fb="http://www.facebook.com/2008/fbml"; version="HTML+RDFa 1.0" xml:lang="en" itemscope itemtype="http://schema.org/Product";> ... {code} Due to the absence of any subsequent value for *itemscope*, we get the following error in our web server logs {code} [Fatal Error] :2:185: Attribute name "itemscope" associated with an element type "html" must be followed by the ' = ' character. {code} Although the markup semantics are incorrect, Any23 should simply perform a check for the itemscope value being null, if this is the case then add *=""*, there is a precedent for us doing something like this before, I just cant find the ticket right now! The code we need to add is present within either core/src/main/java/org/apache/any23/extractor/microdata/ItemScope.java core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ANY23-131) Nested Microdata are not extracted
[ https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lewis John McGibbney resolved ANY23-131. Resolution: Fixed commit 403a8631ed7e9fd4f15968eb94ab736157e72d8f Author: Lewis John McGibbney Date: Thu Jan 22 22:06:47 2015 -0800 ANY23-246 Add Open Graph Protocol and Facebook prefixes to popular.prefixes commit 19abecc58c064cd388d3dcfe29ac90f1b7750ae0 Author: Lewis John McGibbney Date: Thu Jan 22 20:37:04 2015 -0800 ANY23-131 Nested Microdata are not extracted > Nested Microdata are not extracted > -- > > Key: ANY23-131 > URL: https://issues.apache.org/jira/browse/ANY23-131 > Project: Apache Any23 > Issue Type: Bug > Components: microdata >Affects Versions: 0.7.0 >Reporter: Sebastien Richard >Assignee: Lewis John McGibbney > Fix For: 1.2 > > > Proposed patch: > core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java: > remove incorrect optim: > L166 > - return getUnnestedNodes( topLevelItemScopes ); > + return topLevelItemScopes; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ANY23-131) Nested Microdata are not extracted
[ https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288839#comment-14288839 ] ASF GitHub Bot commented on ANY23-131: -- Github user asfgit closed the pull request at: https://github.com/apache/any23/pull/10 > Nested Microdata are not extracted > -- > > Key: ANY23-131 > URL: https://issues.apache.org/jira/browse/ANY23-131 > Project: Apache Any23 > Issue Type: Bug > Components: microdata >Affects Versions: 0.7.0 >Reporter: Sebastien Richard >Assignee: Lewis John McGibbney > Fix For: 1.2 > > > Proposed patch: > core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java: > remove incorrect optim: > L166 > - return getUnnestedNodes( topLevelItemScopes ); > + return topLevelItemScopes; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ANY23-246) Add Open Graph Protocol and Facebook prefixes to popular.prefixes
[ https://issues.apache.org/jira/browse/ANY23-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288838#comment-14288838 ] ASF GitHub Bot commented on ANY23-246: -- Github user asfgit closed the pull request at: https://github.com/apache/any23/pull/11 > Add Open Graph Protocol and Facebook prefixes to popular.prefixes > - > > Key: ANY23-246 > URL: https://issues.apache.org/jira/browse/ANY23-246 > Project: Apache Any23 > Issue Type: Improvement > Components: core >Affects Versions: 1.2 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney > Fix For: 1.2 > > > We have recently discussed problems with the extraction of some data > relationships from both OGP and FB prefixes (in particular). > This issue should quite simply add these two prefixes to the current list of > popular.prefixes we maintain [0] and should also review the accuracy of > existing prefixes within this list. > [0] > https://github.com/apache/any23/blob/master/core/src/main/resources/org/apache/any23/prefixes/prefixes.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ANY23-246) Add Open Graph Protocol and Facebook prefixes to popular.prefixes
[ https://issues.apache.org/jira/browse/ANY23-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lewis John McGibbney resolved ANY23-246. Resolution: Fixed commit 403a8631ed7e9fd4f15968eb94ab736157e72d8f Author: Lewis John McGibbney Date: Thu Jan 22 22:06:47 2015 -0800 ANY23-246 Add Open Graph Protocol and Facebook prefixes to popular.prefixes commit 19abecc58c064cd388d3dcfe29ac90f1b7750ae0 Author: Lewis John McGibbney Date: Thu Jan 22 20:37:04 2015 -0800 ANY23-131 Nested Microdata are not extracted > Add Open Graph Protocol and Facebook prefixes to popular.prefixes > - > > Key: ANY23-246 > URL: https://issues.apache.org/jira/browse/ANY23-246 > Project: Apache Any23 > Issue Type: Improvement > Components: core >Affects Versions: 1.2 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney > Fix For: 1.2 > > > We have recently discussed problems with the extraction of some data > relationships from both OGP and FB prefixes (in particular). > This issue should quite simply add these two prefixes to the current list of > popular.prefixes we maintain [0] and should also review the accuracy of > existing prefixes within this list. > [0] > https://github.com/apache/any23/blob/master/core/src/main/resources/org/apache/any23/prefixes/prefixes.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (ANY23-131) Nested Microdata are not extracted
[ https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lewis John McGibbney reassigned ANY23-131: -- Assignee: Lewis John McGibbney > Nested Microdata are not extracted > -- > > Key: ANY23-131 > URL: https://issues.apache.org/jira/browse/ANY23-131 > Project: Apache Any23 > Issue Type: Bug > Components: microdata >Affects Versions: 0.7.0 >Reporter: Sebastien Richard >Assignee: Lewis John McGibbney > Fix For: 1.2 > > > Proposed patch: > core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java: > remove incorrect optim: > L166 > - return getUnnestedNodes( topLevelItemScopes ); > + return topLevelItemScopes; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ANY23-246) Add Open Graph Protocol and Facebook prefixes to popular.prefixes
[ https://issues.apache.org/jira/browse/ANY23-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lewis John McGibbney updated ANY23-246: --- Issue Type: Improvement (was: Bug) > Add Open Graph Protocol and Facebook prefixes to popular.prefixes > - > > Key: ANY23-246 > URL: https://issues.apache.org/jira/browse/ANY23-246 > Project: Apache Any23 > Issue Type: Improvement > Components: core >Affects Versions: 1.2 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney > Fix For: 1.2 > > > We have recently discussed problems with the extraction of some data > relationships from both OGP and FB prefixes (in particular). > This issue should quite simply add these two prefixes to the current list of > popular.prefixes we maintain [0] and should also review the accuracy of > existing prefixes within this list. > [0] > https://github.com/apache/any23/blob/master/core/src/main/resources/org/apache/any23/prefixes/prefixes.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ANY23-246) Add Open Graph Protocol and Facebook prefixes to popular.prefixes
[ https://issues.apache.org/jira/browse/ANY23-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288836#comment-14288836 ] ASF GitHub Bot commented on ANY23-246: -- GitHub user lewismc opened a pull request: https://github.com/apache/any23/pull/11 ANY23-246 Add Open Graph Protocol and Facebook prefixes to popular.prefixes Pull request bundled with ANY23-131 I am getting better results here with more triples being extracted hence bumping the expected OG triples from 9 --> 12 in core/src/test/java/org/apache/any23/Any23Test#testExtractionParameters You can merge this pull request into a Git repository by running: $ git pull https://github.com/lewismc/any23 ANY23-246 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/any23/pull/11.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11 commit 19abecc58c064cd388d3dcfe29ac90f1b7750ae0 Author: Lewis John McGibbney Date: 2015-01-23T04:37:04Z ANY23-131 Nested Microdata are not extracted commit 403a8631ed7e9fd4f15968eb94ab736157e72d8f Author: Lewis John McGibbney Date: 2015-01-23T06:06:47Z ANY23-246 Add Open Graph Protocol and Facebook prefixes to popular.prefixes > Add Open Graph Protocol and Facebook prefixes to popular.prefixes > - > > Key: ANY23-246 > URL: https://issues.apache.org/jira/browse/ANY23-246 > Project: Apache Any23 > Issue Type: Bug > Components: core >Affects Versions: 1.2 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney > Fix For: 1.2 > > > We have recently discussed problems with the extraction of some data > relationships from both OGP and FB prefixes (in particular). > This issue should quite simply add these two prefixes to the current list of > popular.prefixes we maintain [0] and should also review the accuracy of > existing prefixes within this list. > [0] > https://github.com/apache/any23/blob/master/core/src/main/resources/org/apache/any23/prefixes/prefixes.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ANY23-246) Add Open Graph Protocol and Facebook prefixes to popular.prefixes
[ https://issues.apache.org/jira/browse/ANY23-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288837#comment-14288837 ] Lewis John McGibbney commented on ANY23-246: https://github.com/apache/any23/pull/11 > Add Open Graph Protocol and Facebook prefixes to popular.prefixes > - > > Key: ANY23-246 > URL: https://issues.apache.org/jira/browse/ANY23-246 > Project: Apache Any23 > Issue Type: Bug > Components: core >Affects Versions: 1.2 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney > Fix For: 1.2 > > > We have recently discussed problems with the extraction of some data > relationships from both OGP and FB prefixes (in particular). > This issue should quite simply add these two prefixes to the current list of > popular.prefixes we maintain [0] and should also review the accuracy of > existing prefixes within this list. > [0] > https://github.com/apache/any23/blob/master/core/src/main/resources/org/apache/any23/prefixes/prefixes.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ANY23-246) Add Open Graph Protocol and Facebook prefixes to popular.prefixes
Lewis John McGibbney created ANY23-246: -- Summary: Add Open Graph Protocol and Facebook prefixes to popular.prefixes Key: ANY23-246 URL: https://issues.apache.org/jira/browse/ANY23-246 Project: Apache Any23 Issue Type: Bug Components: core Affects Versions: 1.2 Reporter: Lewis John McGibbney Assignee: Lewis John McGibbney Fix For: 1.2 We have recently discussed problems with the extraction of some data relationships from both OGP and FB prefixes (in particular). This issue should quite simply add these two prefixes to the current list of popular.prefixes we maintain [0] and should also review the accuracy of existing prefixes within this list. [0] https://github.com/apache/any23/blob/master/core/src/main/resources/org/apache/any23/prefixes/prefixes.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ANY23-131) Nested Microdata are not extracted
[ https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288730#comment-14288730 ] Lewis John McGibbney commented on ANY23-131: Please see https://github.com/apache/any23/pull/10 > Nested Microdata are not extracted > -- > > Key: ANY23-131 > URL: https://issues.apache.org/jira/browse/ANY23-131 > Project: Apache Any23 > Issue Type: Bug > Components: microdata >Affects Versions: 0.7.0 >Reporter: Sebastien Richard > Fix For: 1.2 > > > Proposed patch: > core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java: > remove incorrect optim: > L166 > - return getUnnestedNodes( topLevelItemScopes ); > + return topLevelItemScopes; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ANY23-131) Nested Microdata are not extracted
[ https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288729#comment-14288729 ] ASF GitHub Bot commented on ANY23-131: -- GitHub user lewismc opened a pull request: https://github.com/apache/any23/pull/10 ANY23-131 Nested Microdata are not extracted Trivial patch which addresses a recent mailing list item http://www.mail-archive.com/user%40any23.apache.org/msg00166.html You can merge this pull request into a Git repository by running: $ git pull https://github.com/lewismc/any23 ANY23-131 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/any23/pull/10.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10 commit 19abecc58c064cd388d3dcfe29ac90f1b7750ae0 Author: Lewis John McGibbney Date: 2015-01-23T04:37:04Z ANY23-131 Nested Microdata are not extracted > Nested Microdata are not extracted > -- > > Key: ANY23-131 > URL: https://issues.apache.org/jira/browse/ANY23-131 > Project: Apache Any23 > Issue Type: Bug > Components: microdata >Affects Versions: 0.7.0 >Reporter: Sebastien Richard > Fix For: 1.2 > > > Proposed patch: > core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java: > remove incorrect optim: > L166 > - return getUnnestedNodes( topLevelItemScopes ); > + return topLevelItemScopes; -- This message was sent by Atlassian JIRA (v6.3.4#6332)