[jira] [Commented] (ANY23-131) Nested Microdata are not extracted
[ https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085632#comment-15085632 ] Daniel Sachse commented on ANY23-131: - Hey folks, I tried using any23 with this page (https://www.otto.de/p/aeg-waschmaschine-lavamat-l14as7-aplusplusplus-7-kg-1400-u-min-508571361/#variationId=504747671-M48) and it did for example extract the itemprop "aggregateRating" but not the nested "ratingValue" and "reviewCount" - neither in 1.1 nor 1.2-SNAPSHOT. Any ideas? Best Daniel > Nested Microdata are not extracted > -- > > Key: ANY23-131 > URL: https://issues.apache.org/jira/browse/ANY23-131 > Project: Apache Any23 > Issue Type: Bug > Components: microdata >Affects Versions: 0.7.0 >Reporter: Sebastien Richard >Assignee: Lewis John McGibbney > Fix For: 1.2 > > > Proposed patch: > core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java: > remove incorrect optim: > L166 > - return getUnnestedNodes( topLevelItemScopes ); > + return topLevelItemScopes; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (ANY23-131) Nested Microdata are not extracted
[
https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085638#comment-15085638
]
Daniel Sachse edited comment on ANY23-131 at 1/6/16 3:13 PM:
-
I also modified the 1.1 version locally and edited the MicrodataParser by
commenting this code:
{code:java}
// if (attributes.getNamedItem(ITEMSCOPE_ATTRIBUTE) != null) {
//// Don't visit descendants of nodes that
define a new scope
//return FILTER_REJECT;
//}
{code}
Afterwards the mentioned itemprops are found, but the node value is used and
not the content attribute.
was (Author: danielsachse):
I also modified the 1.1 version locally and edited the MicrodataParser by
commenting this code:
// if (attributes.getNamedItem(ITEMSCOPE_ATTRIBUTE) != null) {
//// Don't visit descendants of nodes that
define a new scope
//return FILTER_REJECT;
//}
Afterwards the mentioned itemprops are found, but the node value is used and
not the content attribute.
> Nested Microdata are not extracted
> --
>
> Key: ANY23-131
> URL: https://issues.apache.org/jira/browse/ANY23-131
> Project: Apache Any23
> Issue Type: Bug
> Components: microdata
>Affects Versions: 0.7.0
>Reporter: Sebastien Richard
>Assignee: Lewis John McGibbney
> Fix For: 1.2
>
>
> Proposed patch:
> core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java:
> remove incorrect optim:
> L166
> - return getUnnestedNodes( topLevelItemScopes );
> + return topLevelItemScopes;
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ANY23-131) Nested Microdata are not extracted
[
https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085638#comment-15085638
]
Daniel Sachse commented on ANY23-131:
-
I also modified the 1.1 version locally and edited the MicrodataParser by
commenting this code:
// if (attributes.getNamedItem(ITEMSCOPE_ATTRIBUTE) != null) {
//// Don't visit descendants of nodes that
define a new scope
//return FILTER_REJECT;
//}
Afterwards the mentioned itemprops are found, but the node value is used and
not the content attribute.
> Nested Microdata are not extracted
> --
>
> Key: ANY23-131
> URL: https://issues.apache.org/jira/browse/ANY23-131
> Project: Apache Any23
> Issue Type: Bug
> Components: microdata
>Affects Versions: 0.7.0
>Reporter: Sebastien Richard
>Assignee: Lewis John McGibbney
> Fix For: 1.2
>
>
> Proposed patch:
> core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java:
> remove incorrect optim:
> L166
> - return getUnnestedNodes( topLevelItemScopes );
> + return topLevelItemScopes;
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
