[jira] [Commented] (ANY23-367) latest.stable.released property is never used and out of date

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ANY23-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564755#comment-16564755
 ] 

ASF GitHub Bot commented on ANY23-367:
--

Github user lewismc commented on the issue:

https://github.com/apache/any23/pull/102
  
+1 thank you @HansBrende 


> latest.stable.released property is never used and out of date
> -
>
> Key: ANY23-367
> URL: https://issues.apache.org/jira/browse/ANY23-367
> Project: Apache Any23
>  Issue Type: Bug
>Affects Versions: 2.3
>Reporter: Hans Brende
>Priority: Minor
> Fix For: 2.3
>
>
> The {{latest.stable.released}} property was introduced in the following 
> commit: [Improved download page generation. Added release id 
> property|https://github.com/apache/any23/commit/c5f8c07e621984e2aafb07febc40264d11a8feae]
>  by [~michele.mostarda] in 2012 and later all of its usages were replaced by 
> hardcoded constants in the following commit: [Updates to all Website 
> documentation to reflect 2.0 
> release|https://github.com/apache/any23/commit/d67bdff9a477bac5aa4c38ec2c4c8d63d0da179a#diff-3509ce2aacdd62ac31a376fbf804deba]
>  by [~lewismc] in 2017. 
> We should either delete this property or update it (as it currently indicates 
> version 2.1) and add it back into the src/site/xdoc/download.xml.vm file.
> Lewis, do you have any insight on this?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] any23 issue #102: ANY23-367 update 'latest.stable.released' property

2018-07-31 Thread lewismc
Github user lewismc commented on the issue:

https://github.com/apache/any23/pull/102
  
+1 thank you @HansBrende 


---


[jira] [Commented] (ANY23-375) LGPL-licensed transitive dependency in OpenIE module

2018-07-31 Thread Lewis John McGibbney (JIRA)


[ 
https://issues.apache.org/jira/browse/ANY23-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564685#comment-16564685
 ] 

Lewis John McGibbney commented on ANY23-375:


[~HansBrende] can we make an explicit exclusion?
https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html
Sorry I don't pick these notices up immediately. I am extremely busy these 
days. :(

> LGPL-licensed transitive dependency in OpenIE module
> 
>
> Key: ANY23-375
> URL: https://issues.apache.org/jira/browse/ANY23-375
> Project: Apache Any23
>  Issue Type: Bug
>  Components: openie, service
>Affects Versions: 2.2
>Reporter: Hans Brende
>Priority: Major
> Fix For: 2.3
>
>
> The LGPL-licensed trove4j library is a transitive dependency of our OpenIE 
> dependency via the {{edu.washington.cs.knowitall:reverb-core}} dependency via 
> the {{cc.mallet:mallet}} dependency. The LGPL license is [not 
> compatible|https://www.apache.org/legal/resolved.html#category-x] with the 
> Apache license.
> In addition, the reverb-core dependency depends on 
> {{edu.washington.cs.knowitall:common-java}}, which is GPL-licensed, and on 
> {{edu.washington.cs.knowitall:openregex}}, which is LGPL-licensed, and 
> transitively (via  {{cc.mallet:mallet}}) on 
> {{com.googlecode.matrix-toolkits-java:mtj}}, which is LGPL-licensed, 
> {{jgrapht:jgrapht}}, which is LGPL-licensed, and {{org.beanshell:bsh}}, which 
> is LGPL-licensed. 
> Cf. ANY23-372



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ANY23-378) JsonParseException

2018-07-31 Thread Hans Brende (JIRA)


 [ 
https://issues.apache.org/jira/browse/ANY23-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Brende updated ANY23-378:
--
Description: 
On the page http://golfavisen.dk/golfavisen-award-2018/ I'm getting a 
JsonParseException in the EmbeddedJSONLDExtractor:
{noformat}
org.apache.any23.extractor.ExtractionException: Error while parsing RDF 
document.
at 
org.apache.any23.extractor.rdf.BaseRDFExtractor.run(BaseRDFExtractor.java:175)
at 
org.apache.any23.extractor.html.EmbeddedJSONLDExtractor.extractJSONLDScript(EmbeddedJSONLDExtractor.java:149)
at 
org.apache.any23.extractor.html.EmbeddedJSONLDExtractor.run(EmbeddedJSONLDExtractor.java:83)
at 
org.apache.any23.extractor.html.EmbeddedJSONLDExtractor.run(EmbeddedJSONLDExtractor.java:54)
at 
org.apache.any23.extractor.SingleDocumentExtraction.runExtractor(SingleDocumentExtraction.java:480)
at 
org.apache.any23.extractor.SingleDocumentExtraction.run(SingleDocumentExtraction.java:259)
at 
org.apache.any23.extractor.SingleDocumentExtraction.run(SingleDocumentExtraction.java:323)
at 
org.apache.any23.extractor.html.AbstractExtractorTestCase.extract(AbstractExtractorTestCase.java:189)
at 
org.apache.any23.extractor.html.AbstractExtractorTestCase.assertExtract(AbstractExtractorTestCase.java:204)
... 28 more
Caused by: org.eclipse.rdf4j.rio.RDFParseException: Could not parse JSONLD
at org.eclipse.rdf4j.rio.jsonld.JSONLDParser.parse(JSONLDParser.java:77)
at 
org.apache.any23.extractor.rdf.BaseRDFExtractor.run(BaseRDFExtractor.java:171)
... 36 more
Caused by: com.fasterxml.jackson.core.JsonParseException: Unexpected character 
('}' (code 125)): was expecting double-quote to start field name
 at [Source: (BufferedReader); line: 9, column: 10]
at 
com.fasterxml.jackson.core.JsonParser._constructError(JsonParser.java:1804)
at 
com.fasterxml.jackson.core.base.ParserMinimalBase._reportError(ParserMinimalBase.java:663)
at 
com.fasterxml.jackson.core.base.ParserMinimalBase._reportUnexpectedChar(ParserMinimalBase.java:561)
at 
com.fasterxml.jackson.core.json.ReaderBasedJsonParser._handleOddName(ReaderBasedJsonParser.java:1757)
at 
com.fasterxml.jackson.core.json.ReaderBasedJsonParser.nextFieldName(ReaderBasedJsonParser.java:907)
at 
com.fasterxml.jackson.databind.deser.std.MapDeserializer._readAndBindStringKeyMap(MapDeserializer.java:512)
at 
com.fasterxml.jackson.databind.deser.std.MapDeserializer.deserialize(MapDeserializer.java:364)
at 
com.fasterxml.jackson.databind.deser.std.MapDeserializer.deserialize(MapDeserializer.java:29)
at 
com.fasterxml.jackson.databind.ObjectMapper._readValue(ObjectMapper.java:3972)
at 
com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:2264)
at 
com.fasterxml.jackson.core.JsonParser.readValueAs(JsonParser.java:1729)
at 
com.github.jsonldjava.utils.JsonUtils.fromJsonParser(JsonUtils.java:196)
at com.github.jsonldjava.utils.JsonUtils.fromReader(JsonUtils.java:173)
at 
com.github.jsonldjava.utils.JsonUtils.fromInputStream(JsonUtils.java:154)
at 
com.github.jsonldjava.utils.JsonUtils.fromInputStream(JsonUtils.java:111)
at org.eclipse.rdf4j.rio.jsonld.JSONLDParser.parse(JSONLDParser.java:71)
... 37 more

{noformat}


caused by the following json:

{noformat}
{   "@context": "http://schema.org";,
"@type": "Event",
"name": "PINNACLE BANK CHAMPIONSHIP",
"startDate": "2018-7-19T00-00-00-00",
"endDate": "2018-7-19T23-23-59-00",
"image":"http://golfavisen.dk/wp-content/uploads/2017/03/WEB.png";,
"description":"PINNACLE BANK CHAMPIONSHIP",
}
{noformat}

  was:
On the page http://golfavisen.dk/golfavisen-award-2018/ I'm getting a 
JsonParseException in the EmbeddedJSONLDExtractor:
{noformat}
java.lang.RuntimeException: org.apache.any23.extractor.ExtractionException: 
Error while parsing RDF document.

at 
org.apache.any23.extractor.html.AbstractExtractorTestCase.assertExtract(AbstractExtractorTestCase.java:208)
at 
org.apache.any23.extractor.html.AbstractExtractorTestCase.assertExtract(AbstractExtractorTestCase.java:221)
at 
org.apache.any23.extractor.html.EmbeddedJSONLDExtractorTest.testJSONLD(EmbeddedJSONLDExtractorTest.java:68)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.run

[jira] [Created] (ANY23-378) JsonParseException

2018-07-31 Thread Hans Brende (JIRA)
Hans Brende created ANY23-378:
-

 Summary: JsonParseException
 Key: ANY23-378
 URL: https://issues.apache.org/jira/browse/ANY23-378
 Project: Apache Any23
  Issue Type: Bug
  Components: extractors
Affects Versions: 2.3
Reporter: Hans Brende
 Fix For: 2.3


On the page http://golfavisen.dk/golfavisen-award-2018/ I'm getting a 
JsonParseException in the EmbeddedJSONLDExtractor:
{noformat}
java.lang.RuntimeException: org.apache.any23.extractor.ExtractionException: 
Error while parsing RDF document.

at 
org.apache.any23.extractor.html.AbstractExtractorTestCase.assertExtract(AbstractExtractorTestCase.java:208)
at 
org.apache.any23.extractor.html.AbstractExtractorTestCase.assertExtract(AbstractExtractorTestCase.java:221)
at 
org.apache.any23.extractor.html.EmbeddedJSONLDExtractorTest.testJSONLD(EmbeddedJSONLDExtractorTest.java:68)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at 
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at 
com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
at 
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
at 
com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
Caused by: org.apache.any23.extractor.ExtractionException: Error while parsing 
RDF document.
at 
org.apache.any23.extractor.rdf.BaseRDFExtractor.run(BaseRDFExtractor.java:175)
at 
org.apache.any23.extractor.html.EmbeddedJSONLDExtractor.extractJSONLDScript(EmbeddedJSONLDExtractor.java:149)
at 
org.apache.any23.extractor.html.EmbeddedJSONLDExtractor.run(EmbeddedJSONLDExtractor.java:83)
at 
org.apache.any23.extractor.html.EmbeddedJSONLDExtractor.run(EmbeddedJSONLDExtractor.java:54)
at 
org.apache.any23.extractor.SingleDocumentExtraction.runExtractor(SingleDocumentExtraction.java:480)
at 
org.apache.any23.extractor.SingleDocumentExtraction.run(SingleDocumentExtraction.java:259)
at 
org.apache.any23.extractor.SingleDocumentExtraction.run(SingleDocumentExtraction.java:323)
at 
org.apache.any23.extractor.html.AbstractExtractorTestCase.extract(AbstractExtractorTestCase.java:189)
at 
org.apache.any23.extractor.html.AbstractExtractorTestCase.assertExtract(AbstractExtractorTestCase.java:204)
... 28 more
Caused by: org.eclipse.rdf4j.rio.RDFParseException: Could not parse JSONLD
at org.eclipse.rdf4j.rio.jsonld.JSONLDParser.parse(JSONLDParser.java:77)
at 
org.apache.any23.extractor.rdf.BaseRDFExtractor.run(BaseRDFExtractor.java:171)
... 36 more
Caused by: com.fasterxml.jackson.core.JsonParseException: Unexpected character 
('}' (code 125)): was expecting double-quote to start field name
 at [Source: (BufferedReader); line: 9, column: 10]
at 
com.fasterxml.jackson.core.JsonParser._constructError(JsonParser.java:1804)
at 
com.fasterxml.jackson.core.base.ParserMinimalBase._reportError(ParserMinimalBase.java:663)
at 
com.fasterxml.jackson.core.base.ParserMinimalBase._repor

[jira] [Commented] (ANY23-377) Microdata extractor replaces empty strings with "Null"

2018-07-31 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/ANY23-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564450#comment-16564450
 ] 

Hudson commented on ANY23-377:
--

SUCCESS: Integrated in Jenkins build Any23-trunk #1604 (See 
[https://builds.apache.org/job/Any23-trunk/1604/])
ANY23-377 don't replace empty strings with 'Null' (Hans: rev 
a07d1f058fcdc2d994dcd220759310737fe68965)
* (edit) 
core/src/main/java/org/apache/any23/extractor/microdata/ItemPropValue.java
* (edit) 
test-resources/src/test/resources/microdata/microdata-bad-properties-expected.nquads


> Microdata extractor replaces empty strings with "Null"
> --
>
> Key: ANY23-377
> URL: https://issues.apache.org/jira/browse/ANY23-377
> Project: Apache Any23
>  Issue Type: Bug
>  Components: microdata
>Affects Versions: 2.3
>Reporter: Hans Brende
>Assignee: Hans Brende
>Priority: Major
> Fix For: 2.3
>
>
> The microdata extractor replaces empty string property values with the string 
> "Null". This behavior is nonstandard and unexpected. Cf. ANY23-115.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ANY23-377) Microdata extractor replaces empty strings with "Null"

2018-07-31 Thread Hans Brende (JIRA)


 [ 
https://issues.apache.org/jira/browse/ANY23-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Brende resolved ANY23-377.
---
Resolution: Fixed

> Microdata extractor replaces empty strings with "Null"
> --
>
> Key: ANY23-377
> URL: https://issues.apache.org/jira/browse/ANY23-377
> Project: Apache Any23
>  Issue Type: Bug
>  Components: microdata
>Affects Versions: 2.3
>Reporter: Hans Brende
>Assignee: Hans Brende
>Priority: Major
> Fix For: 2.3
>
>
> The microdata extractor replaces empty string property values with the string 
> "Null". This behavior is nonstandard and unexpected. Cf. ANY23-115.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ANY23-377) Microdata extractor replaces empty strings with "Null"

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ANY23-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564411#comment-16564411
 ] 

ASF GitHub Bot commented on ANY23-377:
--

Github user asfgit closed the pull request at:

https://github.com/apache/any23/pull/107


> Microdata extractor replaces empty strings with "Null"
> --
>
> Key: ANY23-377
> URL: https://issues.apache.org/jira/browse/ANY23-377
> Project: Apache Any23
>  Issue Type: Bug
>  Components: microdata
>Affects Versions: 2.3
>Reporter: Hans Brende
>Assignee: Hans Brende
>Priority: Major
> Fix For: 2.3
>
>
> The microdata extractor replaces empty string property values with the string 
> "Null". This behavior is nonstandard and unexpected. Cf. ANY23-115.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] any23 pull request #107: ANY23-377 don't replace empty strings with 'Null'

2018-07-31 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/any23/pull/107


---


[jira] [Commented] (ANY23-376) IllegalArgumentException: invalid property name ''

2018-07-31 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/ANY23-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564410#comment-16564410
 ] 

Hudson commented on ANY23-376:
--

SUCCESS: Integrated in Jenkins build Any23-trunk #1603 (See 
[https://builds.apache.org/job/Any23-trunk/1603/])
ANY23-376 fix IllegalArgumentException in microdata extractor (Hans: rev 
6173637bb801da62b07b69be64fa2c75f8d54904)
* (add) 
test-resources/src/test/resources/microdata/microdata-bad-properties-expected.nquads
* (edit) 
core/src/test/java/org/apache/any23/extractor/microdata/MicrodataExtractorTest.java
* (edit) 
core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java
* (add) 
test-resources/src/test/resources/microdata/microdata-bad-properties.html


> IllegalArgumentException: invalid property name ''
> --
>
> Key: ANY23-376
> URL: https://issues.apache.org/jira/browse/ANY23-376
> Project: Apache Any23
>  Issue Type: Bug
>  Components: microdata
>Affects Versions: 2.3
>Reporter: Hans Brende
>Assignee: Hans Brende
>Priority: Major
> Fix For: 2.3
>
>
> In the microdata extractor, I'm occasionally getting the following error:
> {noformat}
> java.lang.IllegalArgumentException: invalid property name ''
>   at 
> org.apache.any23.extractor.microdata.ItemProp.(ItemProp.java:51)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getItemProps(MicrodataParser.java:410)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getItemScope(MicrodataParser.java:486)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getPropertyValue(MicrodataParser.java:346)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getItemProps(MicrodataParser.java:403)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getItemScope(MicrodataParser.java:486)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getMicrodata(MicrodataParser.java:197)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getMicrodata(MicrodataParser.java:214)
>   at 
> org.apache.any23.extractor.microdata.MicrodataExtractor.run(MicrodataExtractor.java:89)
>   at 
> org.apache.any23.extractor.microdata.MicrodataExtractor.run(MicrodataExtractor.java:60)
>   at 
> org.apache.any23.extractor.SingleDocumentExtraction.runExtractor(SingleDocumentExtraction.java:480)
>   at 
> org.apache.any23.extractor.SingleDocumentExtraction.run(SingleDocumentExtraction.java:259)
>   at 
> org.apache.any23.extractor.SingleDocumentExtraction.run(SingleDocumentExtraction.java:323)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ANY23-377) Microdata extractor replaces empty strings with "Null"

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ANY23-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564403#comment-16564403
 ] 

ASF GitHub Bot commented on ANY23-377:
--

GitHub user HansBrende opened a pull request:

https://github.com/apache/any23/pull/107

ANY23-377 don't replace empty strings with 'Null'

mvn clean test -> all tests passed

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HansBrende/any23 ANY23-377

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/any23/pull/107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #107


commit a07d1f058fcdc2d994dcd220759310737fe68965
Author: Hans 
Date:   2018-07-31T21:37:25Z

ANY23-377 don't replace empty strings with 'Null'




> Microdata extractor replaces empty strings with "Null"
> --
>
> Key: ANY23-377
> URL: https://issues.apache.org/jira/browse/ANY23-377
> Project: Apache Any23
>  Issue Type: Bug
>  Components: microdata
>Affects Versions: 2.3
>Reporter: Hans Brende
>Assignee: Hans Brende
>Priority: Major
> Fix For: 2.3
>
>
> The microdata extractor replaces empty string property values with the string 
> "Null". This behavior is nonstandard and unexpected. Cf. ANY23-115.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] any23 pull request #107: ANY23-377 don't replace empty strings with 'Null'

2018-07-31 Thread HansBrende
GitHub user HansBrende opened a pull request:

https://github.com/apache/any23/pull/107

ANY23-377 don't replace empty strings with 'Null'

mvn clean test -> all tests passed

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HansBrende/any23 ANY23-377

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/any23/pull/107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #107


commit a07d1f058fcdc2d994dcd220759310737fe68965
Author: Hans 
Date:   2018-07-31T21:37:25Z

ANY23-377 don't replace empty strings with 'Null'




---


[jira] [Created] (ANY23-377) Microdata extractor replaces empty strings with "Null"

2018-07-31 Thread Hans Brende (JIRA)
Hans Brende created ANY23-377:
-

 Summary: Microdata extractor replaces empty strings with "Null"
 Key: ANY23-377
 URL: https://issues.apache.org/jira/browse/ANY23-377
 Project: Apache Any23
  Issue Type: Bug
  Components: microdata
Affects Versions: 2.3
Reporter: Hans Brende
Assignee: Hans Brende
 Fix For: 2.3


The microdata extractor replaces empty string property values with the string 
"Null". This behavior is nonstandard and unexpected. Cf. ANY23-115.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ANY23-376) IllegalArgumentException: invalid property name ''

2018-07-31 Thread Hans Brende (JIRA)


 [ 
https://issues.apache.org/jira/browse/ANY23-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Brende resolved ANY23-376.
---
Resolution: Fixed

> IllegalArgumentException: invalid property name ''
> --
>
> Key: ANY23-376
> URL: https://issues.apache.org/jira/browse/ANY23-376
> Project: Apache Any23
>  Issue Type: Bug
>  Components: microdata
>Affects Versions: 2.3
>Reporter: Hans Brende
>Assignee: Hans Brende
>Priority: Major
> Fix For: 2.3
>
>
> In the microdata extractor, I'm occasionally getting the following error:
> {noformat}
> java.lang.IllegalArgumentException: invalid property name ''
>   at 
> org.apache.any23.extractor.microdata.ItemProp.(ItemProp.java:51)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getItemProps(MicrodataParser.java:410)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getItemScope(MicrodataParser.java:486)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getPropertyValue(MicrodataParser.java:346)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getItemProps(MicrodataParser.java:403)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getItemScope(MicrodataParser.java:486)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getMicrodata(MicrodataParser.java:197)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getMicrodata(MicrodataParser.java:214)
>   at 
> org.apache.any23.extractor.microdata.MicrodataExtractor.run(MicrodataExtractor.java:89)
>   at 
> org.apache.any23.extractor.microdata.MicrodataExtractor.run(MicrodataExtractor.java:60)
>   at 
> org.apache.any23.extractor.SingleDocumentExtraction.runExtractor(SingleDocumentExtraction.java:480)
>   at 
> org.apache.any23.extractor.SingleDocumentExtraction.run(SingleDocumentExtraction.java:259)
>   at 
> org.apache.any23.extractor.SingleDocumentExtraction.run(SingleDocumentExtraction.java:323)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] any23 pull request #106: ANY23-376 fix IllegalArgumentException in microdata...

2018-07-31 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/any23/pull/106


---


[jira] [Commented] (ANY23-376) IllegalArgumentException: invalid property name ''

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ANY23-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564347#comment-16564347
 ] 

ASF GitHub Bot commented on ANY23-376:
--

Github user asfgit closed the pull request at:

https://github.com/apache/any23/pull/106


> IllegalArgumentException: invalid property name ''
> --
>
> Key: ANY23-376
> URL: https://issues.apache.org/jira/browse/ANY23-376
> Project: Apache Any23
>  Issue Type: Bug
>  Components: microdata
>Affects Versions: 2.3
>Reporter: Hans Brende
>Assignee: Hans Brende
>Priority: Major
> Fix For: 2.3
>
>
> In the microdata extractor, I'm occasionally getting the following error:
> {noformat}
> java.lang.IllegalArgumentException: invalid property name ''
>   at 
> org.apache.any23.extractor.microdata.ItemProp.(ItemProp.java:51)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getItemProps(MicrodataParser.java:410)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getItemScope(MicrodataParser.java:486)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getPropertyValue(MicrodataParser.java:346)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getItemProps(MicrodataParser.java:403)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getItemScope(MicrodataParser.java:486)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getMicrodata(MicrodataParser.java:197)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getMicrodata(MicrodataParser.java:214)
>   at 
> org.apache.any23.extractor.microdata.MicrodataExtractor.run(MicrodataExtractor.java:89)
>   at 
> org.apache.any23.extractor.microdata.MicrodataExtractor.run(MicrodataExtractor.java:60)
>   at 
> org.apache.any23.extractor.SingleDocumentExtraction.runExtractor(SingleDocumentExtraction.java:480)
>   at 
> org.apache.any23.extractor.SingleDocumentExtraction.run(SingleDocumentExtraction.java:259)
>   at 
> org.apache.any23.extractor.SingleDocumentExtraction.run(SingleDocumentExtraction.java:323)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] any23 pull request #106: ANY23-376 fix IllegalArgumentException in microdata...

2018-07-31 Thread HansBrende
GitHub user HansBrende opened a pull request:

https://github.com/apache/any23/pull/106

ANY23-376 fix IllegalArgumentException in microdata extractor

mvn clean test -> all tests passed

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HansBrende/any23 ANY23-376

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/any23/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #106


commit 6173637bb801da62b07b69be64fa2c75f8d54904
Author: Hans 
Date:   2018-07-31T20:35:55Z

ANY23-376 fix IllegalArgumentException in microdata extractor




---


[jira] [Commented] (ANY23-376) IllegalArgumentException: invalid property name ''

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ANY23-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564346#comment-16564346
 ] 

ASF GitHub Bot commented on ANY23-376:
--

GitHub user HansBrende opened a pull request:

https://github.com/apache/any23/pull/106

ANY23-376 fix IllegalArgumentException in microdata extractor

mvn clean test -> all tests passed

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HansBrende/any23 ANY23-376

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/any23/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #106


commit 6173637bb801da62b07b69be64fa2c75f8d54904
Author: Hans 
Date:   2018-07-31T20:35:55Z

ANY23-376 fix IllegalArgumentException in microdata extractor




> IllegalArgumentException: invalid property name ''
> --
>
> Key: ANY23-376
> URL: https://issues.apache.org/jira/browse/ANY23-376
> Project: Apache Any23
>  Issue Type: Bug
>  Components: microdata
>Affects Versions: 2.3
>Reporter: Hans Brende
>Assignee: Hans Brende
>Priority: Major
> Fix For: 2.3
>
>
> In the microdata extractor, I'm occasionally getting the following error:
> {noformat}
> java.lang.IllegalArgumentException: invalid property name ''
>   at 
> org.apache.any23.extractor.microdata.ItemProp.(ItemProp.java:51)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getItemProps(MicrodataParser.java:410)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getItemScope(MicrodataParser.java:486)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getPropertyValue(MicrodataParser.java:346)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getItemProps(MicrodataParser.java:403)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getItemScope(MicrodataParser.java:486)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getMicrodata(MicrodataParser.java:197)
>   at 
> org.apache.any23.extractor.microdata.MicrodataParser.getMicrodata(MicrodataParser.java:214)
>   at 
> org.apache.any23.extractor.microdata.MicrodataExtractor.run(MicrodataExtractor.java:89)
>   at 
> org.apache.any23.extractor.microdata.MicrodataExtractor.run(MicrodataExtractor.java:60)
>   at 
> org.apache.any23.extractor.SingleDocumentExtraction.runExtractor(SingleDocumentExtraction.java:480)
>   at 
> org.apache.any23.extractor.SingleDocumentExtraction.run(SingleDocumentExtraction.java:259)
>   at 
> org.apache.any23.extractor.SingleDocumentExtraction.run(SingleDocumentExtraction.java:323)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ANY23-374) Invalid nested item takes out everything

2018-07-31 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/ANY23-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564189#comment-16564189
 ] 

Hudson commented on ANY23-374:
--

SUCCESS: Integrated in Jenkins build Any23-trunk #1602 (See 
[https://builds.apache.org/job/Any23-trunk/1602/])
ANY23-374 fix schemeless microdata urls (Hans: rev 
d283d70ceb692cacb1f31659ee5d5c987822028f)
* (edit) 
core/src/test/java/org/apache/any23/extractor/microdata/MicrodataExtractorTest.java
* (add) 
test-resources/src/test/resources/microdata/microdata-missing-scheme.html
* (edit) core/src/main/java/org/apache/any23/extractor/microdata/ItemScope.java


> Invalid nested item takes out everything
> 
>
> Key: ANY23-374
> URL: https://issues.apache.org/jira/browse/ANY23-374
> Project: Apache Any23
>  Issue Type: Improvement
>  Components: extractors, microdata
>Affects Versions: 2.2
>Reporter: Anthony Pessy
>Assignee: Hans Brende
>Priority: Minor
> Fix For: 2.3
>
>
> I encountered an item such as:
> {code:java}
> http://schema.org/Question";>
>     Name
>     
>       Text
>    
> 
> {code}
>  
> Because of the invalid answer, it throws an `IllegalArgumentException` (not a 
> `MicrodataParserException` !) and I do not even have the Question available.
> Now, because I let the default `FULL_REPORT` as `ErrorMode` I was expecting 
> to have the question and `getErrors()` returning eventual encountered errors.
> Am I missing something?
>  
> Edit:
>  
> Note that Google testing tool is somehow not complaining (maybe it should?):
>   
> https://search.google.com/structured-data/testing-tool/u/0/#url=https%3A%2F%2Froams.es%2Ffreedompop%2F
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ANY23-376) IllegalArgumentException: invalid property name ''

2018-07-31 Thread Hans Brende (JIRA)
Hans Brende created ANY23-376:
-

 Summary: IllegalArgumentException: invalid property name ''
 Key: ANY23-376
 URL: https://issues.apache.org/jira/browse/ANY23-376
 Project: Apache Any23
  Issue Type: Bug
  Components: microdata
Affects Versions: 2.3
Reporter: Hans Brende
Assignee: Hans Brende
 Fix For: 2.3


In the microdata extractor, I'm occasionally getting the following error:

{noformat}
java.lang.IllegalArgumentException: invalid property name ''

at 
org.apache.any23.extractor.microdata.ItemProp.(ItemProp.java:51)
at 
org.apache.any23.extractor.microdata.MicrodataParser.getItemProps(MicrodataParser.java:410)
at 
org.apache.any23.extractor.microdata.MicrodataParser.getItemScope(MicrodataParser.java:486)
at 
org.apache.any23.extractor.microdata.MicrodataParser.getPropertyValue(MicrodataParser.java:346)
at 
org.apache.any23.extractor.microdata.MicrodataParser.getItemProps(MicrodataParser.java:403)
at 
org.apache.any23.extractor.microdata.MicrodataParser.getItemScope(MicrodataParser.java:486)
at 
org.apache.any23.extractor.microdata.MicrodataParser.getMicrodata(MicrodataParser.java:197)
at 
org.apache.any23.extractor.microdata.MicrodataParser.getMicrodata(MicrodataParser.java:214)
at 
org.apache.any23.extractor.microdata.MicrodataExtractor.run(MicrodataExtractor.java:89)
at 
org.apache.any23.extractor.microdata.MicrodataExtractor.run(MicrodataExtractor.java:60)
at 
org.apache.any23.extractor.SingleDocumentExtraction.runExtractor(SingleDocumentExtraction.java:480)
at 
org.apache.any23.extractor.SingleDocumentExtraction.run(SingleDocumentExtraction.java:259)
at 
org.apache.any23.extractor.SingleDocumentExtraction.run(SingleDocumentExtraction.java:323)
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ANY23-374) Invalid nested item takes out everything

2018-07-31 Thread Hans Brende (JIRA)


 [ 
https://issues.apache.org/jira/browse/ANY23-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Brende resolved ANY23-374.
---
   Resolution: Fixed
 Assignee: Hans Brende
Fix Version/s: 2.3

> Invalid nested item takes out everything
> 
>
> Key: ANY23-374
> URL: https://issues.apache.org/jira/browse/ANY23-374
> Project: Apache Any23
>  Issue Type: Improvement
>  Components: extractors, microdata
>Affects Versions: 2.2
>Reporter: Anthony Pessy
>Assignee: Hans Brende
>Priority: Minor
> Fix For: 2.3
>
>
> I encountered an item such as:
> {code:java}
> http://schema.org/Question";>
>     Name
>     
>       Text
>    
> 
> {code}
>  
> Because of the invalid answer, it throws an `IllegalArgumentException` (not a 
> `MicrodataParserException` !) and I do not even have the Question available.
> Now, because I let the default `FULL_REPORT` as `ErrorMode` I was expecting 
> to have the question and `getErrors()` returning eventual encountered errors.
> Am I missing something?
>  
> Edit:
>  
> Note that Google testing tool is somehow not complaining (maybe it should?):
>   
> https://search.google.com/structured-data/testing-tool/u/0/#url=https%3A%2F%2Froams.es%2Ffreedompop%2F
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] any23 pull request #105: ANY23-374 fix schemeless microdata urls

2018-07-31 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/any23/pull/105


---


[jira] [Commented] (ANY23-374) Invalid nested item takes out everything

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ANY23-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564052#comment-16564052
 ] 

ASF GitHub Bot commented on ANY23-374:
--

Github user asfgit closed the pull request at:

https://github.com/apache/any23/pull/105


> Invalid nested item takes out everything
> 
>
> Key: ANY23-374
> URL: https://issues.apache.org/jira/browse/ANY23-374
> Project: Apache Any23
>  Issue Type: Improvement
>  Components: extractors, microdata
>Affects Versions: 2.2
>Reporter: Anthony Pessy
>Priority: Minor
>
> I encountered an item such as:
> {code:java}
> http://schema.org/Question";>
>     Name
>     
>       Text
>    
> 
> {code}
>  
> Because of the invalid answer, it throws an `IllegalArgumentException` (not a 
> `MicrodataParserException` !) and I do not even have the Question available.
> Now, because I let the default `FULL_REPORT` as `ErrorMode` I was expecting 
> to have the question and `getErrors()` returning eventual encountered errors.
> Am I missing something?
>  
> Edit:
>  
> Note that Google testing tool is somehow not complaining (maybe it should?):
>   
> https://search.google.com/structured-data/testing-tool/u/0/#url=https%3A%2F%2Froams.es%2Ffreedompop%2F
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ANY23-374) Invalid nested item takes out everything

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ANY23-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564046#comment-16564046
 ] 

ASF GitHub Bot commented on ANY23-374:
--

GitHub user HansBrende opened a pull request:

https://github.com/apache/any23/pull/105

ANY23-374 fix schemeless microdata urls

Fixes microdata itemtype urls that are lacking a scheme by using a default 
scheme of "http".

mvn clean test -> all tests passed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HansBrende/any23 ANY23-374

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/any23/pull/105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #105


commit d283d70ceb692cacb1f31659ee5d5c987822028f
Author: Hans 
Date:   2018-07-31T17:21:26Z

ANY23-374 fix schemeless microdata urls




> Invalid nested item takes out everything
> 
>
> Key: ANY23-374
> URL: https://issues.apache.org/jira/browse/ANY23-374
> Project: Apache Any23
>  Issue Type: Improvement
>  Components: extractors, microdata
>Affects Versions: 2.2
>Reporter: Anthony Pessy
>Priority: Minor
>
> I encountered an item such as:
> {code:java}
> http://schema.org/Question";>
>     Name
>     
>       Text
>    
> 
> {code}
>  
> Because of the invalid answer, it throws an `IllegalArgumentException` (not a 
> `MicrodataParserException` !) and I do not even have the Question available.
> Now, because I let the default `FULL_REPORT` as `ErrorMode` I was expecting 
> to have the question and `getErrors()` returning eventual encountered errors.
> Am I missing something?
>  
> Edit:
>  
> Note that Google testing tool is somehow not complaining (maybe it should?):
>   
> https://search.google.com/structured-data/testing-tool/u/0/#url=https%3A%2F%2Froams.es%2Ffreedompop%2F
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] any23 pull request #105: ANY23-374 fix schemeless microdata urls

2018-07-31 Thread HansBrende
GitHub user HansBrende opened a pull request:

https://github.com/apache/any23/pull/105

ANY23-374 fix schemeless microdata urls

Fixes microdata itemtype urls that are lacking a scheme by using a default 
scheme of "http".

mvn clean test -> all tests passed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HansBrende/any23 ANY23-374

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/any23/pull/105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #105


commit d283d70ceb692cacb1f31659ee5d5c987822028f
Author: Hans 
Date:   2018-07-31T17:21:26Z

ANY23-374 fix schemeless microdata urls




---


[jira] [Commented] (ANY23-374) Invalid nested item takes out everything

2018-07-31 Thread Hans Brende (JIRA)


[ 
https://issues.apache.org/jira/browse/ANY23-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564044#comment-16564044
 ] 

Hans Brende commented on ANY23-374:
---

The {{FULL_REPORT}} and {{IllegalArgumentException}} issue was fixed in 
ANY23-348. However, there is work we could do to also fix scheme-less urls.

> Invalid nested item takes out everything
> 
>
> Key: ANY23-374
> URL: https://issues.apache.org/jira/browse/ANY23-374
> Project: Apache Any23
>  Issue Type: Improvement
>  Components: extractors, microdata
>Affects Versions: 2.2
>Reporter: Anthony Pessy
>Priority: Minor
>
> I encountered an item such as:
> {code:java}
> http://schema.org/Question";>
>     Name
>     
>       Text
>    
> 
> {code}
>  
> Because of the invalid answer, it throws an `IllegalArgumentException` (not a 
> `MicrodataParserException` !) and I do not even have the Question available.
> Now, because I let the default `FULL_REPORT` as `ErrorMode` I was expecting 
> to have the question and `getErrors()` returning eventual encountered errors.
> Am I missing something?
>  
> Edit:
>  
> Note that Google testing tool is somehow not complaining (maybe it should?):
>   
> https://search.google.com/structured-data/testing-tool/u/0/#url=https%3A%2F%2Froams.es%2Ffreedompop%2F
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)