[jira] [Commented] (ANY23-131) Nested Microdata are not extracted
[ https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316303#comment-16316303 ] Hudson commented on ANY23-131: -- UNSTABLE: Integrated in Jenkins build Any23-trunk #1523 (See [https://builds.apache.org/job/Any23-trunk/1523/]) ANY23-320 Address @Ignore tests in Any23 and ANY23-131 Nested Microdata (lewis.mcgibbney: rev 60e93a76748e53c413529409fb545e2245013639) * (edit) core/src/test/java/org/apache/any23/extractor/html/AbstractExtractorTestCase.java * (edit) core/src/main/java/org/apache/any23/extractor/html/EmbeddedJSONLDExtractor.java * (edit) test-resources/src/test/resources/microdata/microdata-nested-expected.nquads * (edit) core/src/main/java/org/apache/any23/extractor/csv/CSVExtractor.java * (edit) core/src/main/java/org/apache/any23/extractor/xpath/QuadTemplate.java * (edit) core/src/test/java/org/apache/any23/writer/JSONWriterTest.java * (edit) test-resources/src/test/resources/microdata/5.2.1-non-normative-example-1-expected.nquads * (edit) core/src/test/java/org/apache/any23/extractor/xpath/TemplateXPathExtractorRuleImplTest.java * (edit) test-resources/src/test/resources/microdata/microdata-itemref-expected.properties * (edit) cli/src/test/java/org/apache/any23/cli/RoverTest.java * (edit) core/src/main/java/org/apache/any23/rdf/RDFUtils.java * (edit) core/src/test/java/org/apache/any23/extractor/html/HListingExtractorTest.java * (edit) core/src/main/java/org/apache/any23/validator/rule/AboutNotURIRule.java * (edit) core/src/main/java/org/apache/any23/vocab/RDFSchemaUtils.java * (edit) core/src/main/java/org/apache/any23/extractor/yaml/ElementsProcessor.java * (edit) core/src/test/java/org/apache/any23/filter/IgnoreAccidentalRDFaTest.java * (edit) core/src/test/java/org/apache/any23/extractor/html/HCardExtractorTest.java * (edit) core/src/main/java/org/apache/any23/extractor/xpath/TemplateObject.java * (edit) cli/src/test/java/org/apache/any23/cli/SimpleRoverTest.java * (edit) test-resources/src/test/resources/microdata/microdata-json-serialization.json * (edit) test-resources/src/test/resources/microdata/microdata-nested.html * (edit) test-resources/src/test/resources/microdata/5.2.1-non-normative-example-2-expected.nquads * (edit) test-resources/src/test/resources/microdata/microdata-basic-expected.properties * (edit) core/src/main/java/org/apache/any23/validator/XMLValidationReportSerializer.java * (edit) test-resources/src/test/resources/microdata/microdata-itemref.html * (edit) core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java * (edit) core/src/main/java/org/apache/any23/validator/rule/MetaNameMisuseRule.java * (edit) core/src/main/java/org/apache/any23/rdf/Any23ValueFactoryWrapper.java * (edit) core/src/main/java/org/apache/any23/extractor/microdata/ItemPropValue.java * (edit) core/src/test/java/org/apache/any23/extractor/csv/CSVExtractorTest.java * (edit) cli/src/test/java/org/apache/any23/cli/ExtractorDocumentationTest.java * (edit) core/src/main/java/org/apache/any23/extractor/microdata/Item.java * (edit) test-resources/src/test/resources/microdata/5.2.1-non-normative-example-1.html * (edit) core/src/test/java/org/apache/any23/extractor/rdfa/RDFaExtractorTest.java * (edit) test-resources/src/test/resources/microdata/microdata-nested-expected.properties * (edit) core/src/main/java/org/apache/any23/extractor/microdata/ItemScope.java * (edit) core/src/main/java/org/apache/any23/extractor/microdata/MicrodataExtractor.java * (edit) core/src/main/java/org/apache/any23/extractor/xpath/TemplateSubject.java * (edit) core/src/test/java/org/apache/any23/extractor/microdata/MicrodataParserTest.java * (edit) test-resources/src/test/resources/microdata/5.2.1-non-normative-example-2.html * (edit) service/src/test/java/org/apache/any23/servlet/ServletTest.java * (edit) core/src/main/java/org/apache/any23/extractor/html/HTMLMetaExtractor.java * (edit) test-resources/src/test/resources/microdata/microdata-basic.html * (edit) test-resources/src/test/resources/microdata/microdata-richsnippet-expected.nquads > Nested Microdata are not extracted > -- > > Key: ANY23-131 > URL: https://issues.apache.org/jira/browse/ANY23-131 > Project: Apache Any23 > Issue Type: Bug > Components: microdata >Affects Versions: 0.7.0 >Reporter: Sebastien Richard >Assignee: Lewis John McGibbney > Fix For: 2.2 > > > Proposed patch: > core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java: > remove incorrect optim: > L166 > - return getUnnestedNodes( topLevelItemScopes ); > + return topLevelItemScopes; -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ANY23-131) Nested Microdata are not extracted
[ https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143922#comment-15143922 ] Lewis John McGibbney commented on ANY23-131: bq. Any news on this? Well I logged ANY23-273 as the service at any23.org is failing to extract the content of the bogus comment element... I realized that once I fixed that one (locally) I had well and truly opened a can of worms! I've just finished manually stepping through the webpage source and dealing with exceptions thrown by Any23. The Markup on this webpage is nothing short of hellish!!! Anyways, I've attached a JSON prettyprint of the extracted structure once everything has been cleaned. Your right, Any23 is not extracting relationships from nested elements. We need to reopen this issue and address it for this new use case. Sorry it took me so bloody long to get around to this. > Nested Microdata are not extracted > -- > > Key: ANY23-131 > URL: https://issues.apache.org/jira/browse/ANY23-131 > Project: Apache Any23 > Issue Type: Bug > Components: microdata >Affects Versions: 0.7.0 >Reporter: Sebastien Richard >Assignee: Lewis John McGibbney > Fix For: 1.2 > > > Proposed patch: > core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java: > remove incorrect optim: > L166 > - return getUnnestedNodes( topLevelItemScopes ); > + return topLevelItemScopes; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ANY23-131) Nested Microdata are not extracted
[ https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140928#comment-15140928 ] Daniel Sachse commented on ANY23-131: - [~lewismc] Any news on this? > Nested Microdata are not extracted > -- > > Key: ANY23-131 > URL: https://issues.apache.org/jira/browse/ANY23-131 > Project: Apache Any23 > Issue Type: Bug > Components: microdata >Affects Versions: 0.7.0 >Reporter: Sebastien Richard >Assignee: Lewis John McGibbney > Fix For: 1.2 > > > Proposed patch: > core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java: > remove incorrect optim: > L166 > - return getUnnestedNodes( topLevelItemScopes ); > + return topLevelItemScopes; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ANY23-131) Nested Microdata are not extracted
[ https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15096520#comment-15096520 ] Lewis John McGibbney commented on ANY23-131: [~danielsachse] apologies for late reply... I get the dev@ messages in a bath request so only just for this. I'll reply later on once I've looked into the code. Thank you > Nested Microdata are not extracted > -- > > Key: ANY23-131 > URL: https://issues.apache.org/jira/browse/ANY23-131 > Project: Apache Any23 > Issue Type: Bug > Components: microdata >Affects Versions: 0.7.0 >Reporter: Sebastien Richard >Assignee: Lewis John McGibbney > Fix For: 1.2 > > > Proposed patch: > core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java: > remove incorrect optim: > L166 > - return getUnnestedNodes( topLevelItemScopes ); > + return topLevelItemScopes; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ANY23-131) Nested Microdata are not extracted
[ https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085632#comment-15085632 ] Daniel Sachse commented on ANY23-131: - Hey folks, I tried using any23 with this page (https://www.otto.de/p/aeg-waschmaschine-lavamat-l14as7-aplusplusplus-7-kg-1400-u-min-508571361/#variationId=504747671-M48) and it did for example extract the itemprop "aggregateRating" but not the nested "ratingValue" and "reviewCount" - neither in 1.1 nor 1.2-SNAPSHOT. Any ideas? Best Daniel > Nested Microdata are not extracted > -- > > Key: ANY23-131 > URL: https://issues.apache.org/jira/browse/ANY23-131 > Project: Apache Any23 > Issue Type: Bug > Components: microdata >Affects Versions: 0.7.0 >Reporter: Sebastien Richard >Assignee: Lewis John McGibbney > Fix For: 1.2 > > > Proposed patch: > core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java: > remove incorrect optim: > L166 > - return getUnnestedNodes( topLevelItemScopes ); > + return topLevelItemScopes; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ANY23-131) Nested Microdata are not extracted
[
https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085638#comment-15085638
]
Daniel Sachse commented on ANY23-131:
-
I also modified the 1.1 version locally and edited the MicrodataParser by
commenting this code:
// if (attributes.getNamedItem(ITEMSCOPE_ATTRIBUTE) != null) {
//// Don't visit descendants of nodes that
define a new scope
//return FILTER_REJECT;
//}
Afterwards the mentioned itemprops are found, but the node value is used and
not the content attribute.
> Nested Microdata are not extracted
> --
>
> Key: ANY23-131
> URL: https://issues.apache.org/jira/browse/ANY23-131
> Project: Apache Any23
> Issue Type: Bug
> Components: microdata
>Affects Versions: 0.7.0
>Reporter: Sebastien Richard
>Assignee: Lewis John McGibbney
> Fix For: 1.2
>
>
> Proposed patch:
> core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java:
> remove incorrect optim:
> L166
> - return getUnnestedNodes( topLevelItemScopes );
> + return topLevelItemScopes;
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ANY23-131) Nested Microdata are not extracted
[ https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288729#comment-14288729 ] ASF GitHub Bot commented on ANY23-131: -- GitHub user lewismc opened a pull request: https://github.com/apache/any23/pull/10 ANY23-131 Nested Microdata are not extracted Trivial patch which addresses a recent mailing list item http://www.mail-archive.com/user%40any23.apache.org/msg00166.html You can merge this pull request into a Git repository by running: $ git pull https://github.com/lewismc/any23 ANY23-131 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/any23/pull/10.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10 commit 19abecc58c064cd388d3dcfe29ac90f1b7750ae0 Author: Lewis John McGibbney lewis.j.mcgibb...@jpl.nasa.gov Date: 2015-01-23T04:37:04Z ANY23-131 Nested Microdata are not extracted Nested Microdata are not extracted -- Key: ANY23-131 URL: https://issues.apache.org/jira/browse/ANY23-131 Project: Apache Any23 Issue Type: Bug Components: microdata Affects Versions: 0.7.0 Reporter: Sebastien Richard Fix For: 1.2 Proposed patch: core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java: remove incorrect optim: L166 - return getUnnestedNodes( topLevelItemScopes ); + return topLevelItemScopes; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ANY23-131) Nested Microdata are not extracted
[ https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288730#comment-14288730 ] Lewis John McGibbney commented on ANY23-131: Please see https://github.com/apache/any23/pull/10 Nested Microdata are not extracted -- Key: ANY23-131 URL: https://issues.apache.org/jira/browse/ANY23-131 Project: Apache Any23 Issue Type: Bug Components: microdata Affects Versions: 0.7.0 Reporter: Sebastien Richard Fix For: 1.2 Proposed patch: core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java: remove incorrect optim: L166 - return getUnnestedNodes( topLevelItemScopes ); + return topLevelItemScopes; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ANY23-131) Nested Microdata are not extracted
[ https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288839#comment-14288839 ] ASF GitHub Bot commented on ANY23-131: -- Github user asfgit closed the pull request at: https://github.com/apache/any23/pull/10 Nested Microdata are not extracted -- Key: ANY23-131 URL: https://issues.apache.org/jira/browse/ANY23-131 Project: Apache Any23 Issue Type: Bug Components: microdata Affects Versions: 0.7.0 Reporter: Sebastien Richard Assignee: Lewis John McGibbney Fix For: 1.2 Proposed patch: core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java: remove incorrect optim: L166 - return getUnnestedNodes( topLevelItemScopes ); + return topLevelItemScopes; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ANY23-131) Nested Microdata are not extracted
[ https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288857#comment-14288857 ] Hudson commented on ANY23-131: -- SUCCESS: Integrated in Any23-trunk #1246 (See [https://builds.apache.org/job/Any23-trunk/1246/]) ANY23-131 Nested Microdata are not extracted (lewis.j.mcgibbney: rev 19abecc58c064cd388d3dcfe29ac90f1b7750ae0) * core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java Nested Microdata are not extracted -- Key: ANY23-131 URL: https://issues.apache.org/jira/browse/ANY23-131 Project: Apache Any23 Issue Type: Bug Components: microdata Affects Versions: 0.7.0 Reporter: Sebastien Richard Assignee: Lewis John McGibbney Fix For: 1.2 Proposed patch: core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java: remove incorrect optim: L166 - return getUnnestedNodes( topLevelItemScopes ); + return topLevelItemScopes; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ANY23-131) Nested Microdata are not extracted
[ https://issues.apache.org/jira/browse/ANY23-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552383#comment-13552383 ] Lewis John McGibbney commented on ANY23-131: Or would it be a better solution to make this configurable? This is NOT a bug. The behaviour is as expected, however it is obviously not the behaviour you want. Nested Microdata are not extracted -- Key: ANY23-131 URL: https://issues.apache.org/jira/browse/ANY23-131 Project: Apache Any23 Issue Type: Bug Components: core Affects Versions: 0.7.0 Reporter: Sebastien Richard Fix For: 0.7.1 Proposed patch: core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java: remove incorrect optim: L166 - return getUnnestedNodes( topLevelItemScopes ); + return topLevelItemScopes; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
