Re: [api-dev] uno-skeletonmaker hacks
Hi Juergen, Le lundi 19 mai 2008 à 23:05 +0200, Juergen Schmidt a écrit : > > Are talking of the -propertysetmixin option ? Why not making it a > > default ? If it's the helper to use its fine but the default case is > > still buggy in C++. > maybe it's a bug i have to check it and will provide tests for the > future. Making the propertysetmixin as default is no option. People > should explicitly think about it. Ok, then I'll simply fix the bug. However I think that it should be much better to add some todo comments in the body of the default implementation for the getters and setters. Regards, -- Cédric Bosdonnat OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [api-dev] uno-skeletonmaker hacks
Hi Cédric, Cédric Bosdonnat wrote: Hi Juergen, Le mardi 13 mai 2008 à 10:38 +0200, Juergen Schmidt - Sun Germany - ham02 - Hamburg a écrit : + the implementation for the interfaces attributes (to have a private member for the attribute and use it in the getters and setters) well, i have to check the implementation but as far as i remember i do that if no property helper is used. But if somebody wants to implement the typical property interfaces i use a special helper base class. Are talking of the -propertysetmixin option ? Why not making it a default ? If it's the helper to use its fine but the default case is still buggy in C++. maybe it's a bug i have to check it and will provide tests for the future. Making the propertysetmixin as default is no option. People should explicitly think about it. Juergen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [api-dev] uno-skeletonmaker hacks
Hi Juergen, Le mardi 13 mai 2008 à 10:38 +0200, Juergen Schmidt - Sun Germany - ham02 - Hamburg a écrit : > > + the implementation for the interfaces attributes (to have a private > > member for the attribute and use it in the getters and setters) > well, i have to check the implementation but as far as i remember i do > that if no property helper is used. But if somebody wants to implement > the typical property interfaces i use a special helper base class. Are talking of the -propertysetmixin option ? Why not making it a default ? If it's the helper to use its fine but the default case is still buggy in C++. Regards, -- Cédric Bosdonnat OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [api-dev] uno-skeletonmaker hacks
Hi Juergen, Le mardi 13 mai 2008 à 10:38 +0200, Juergen Schmidt - Sun Germany - ham02 - Hamburg a écrit : > > + the implementation for the interfaces attributes (to have a private > > member for the attribute and use it in the getters and setters) > well, i have to check the implementation but as far as i remember i do > that if no property helper is used. But if somebody wants to implement > the typical property interfaces i use a special helper base class. Could you be a little bit more precise ? What it the helper base class to use ? I tried with the following calls: uno-skeletonmaker -env:BOOTSTRAPINI="/path/to/bootstraprc" component --java4 -o ./source -l file:path/to/oo/types.rdb -l types.rdb -n org.openoffice.example.comp.TestImpl -t org.openoffice.example.Test # Generate CPP class uno-skeletonmaker -env:BOOTSTRAPINI="/path/to/bootstraprc" component --cpp -o ./source-cpp -l file:////path/to/oo/types.rdb -l types.rdb -n org.openoffice.example.comp.TestImpl -t org.openoffice.example.Test The test service here only has a Name attribute in its interface. The getter and setter body were correct in C++, but the field wasn't declared. In Java the getter and setter are simply empty. > > That's all for the moment. I'll send you the patch after having > > double-checked it. > yes and please check if it matches with the different command line options Do you have some test scripts or data for me to test all the other options ? Thanks, -- Cédric Bosdonnat OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [api-dev] uno-skeletonmaker hacks
Cédric Bosdonnat wrote: Hi Juergen, Le mercredi 07 mai 2008 à 16:24 +0200, Juergen Schmidt a écrit : send me patches. What do you have changed? Ok, I'll send you patches ASAP. I have changed: + the implementation for the supportsService method to have only one return call. will see what you have changed + the implementation for the interfaces attributes (to have a private member for the attribute and use it in the getters and setters) well, i have to check the implementation but as far as i remember i do that if no property helper is used. But if somebody wants to implement the typical property interfaces i use a special helper base class. That's all for the moment. I'll send you the patch after having double-checked it. yes and please check if it matches with the different command line options Juergen Thanks, - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [api-dev] uno-skeletonmaker hacks
Hi Juergen, Le mercredi 07 mai 2008 à 16:24 +0200, Juergen Schmidt a écrit : > send me patches. What do you have changed? Ok, I'll send you patches ASAP. I have changed: + the implementation for the supportsService method to have only one return call. + the implementation for the interfaces attributes (to have a private member for the attribute and use it in the getters and setters) That's all for the moment. I'll send you the patch after having double-checked it. Thanks, -- Cédric Bosdonnat OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [api-dev] uno-skeletonmaker hacks
Hi Cedric, send me patches. What do you have changed? Juergen Bosdonnat wrote: Hi all, I've started to hack the uno-skeletonmaker and would like to provide my changes. How should I do it ? Thanks, -- Cédric Bosdonnat OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[api-dev] uno-skeletonmaker hacks
Hi all, I've started to hack the uno-skeletonmaker and would like to provide my changes. How should I do it ? Thanks, -- Cédric Bosdonnat OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
