[GitHub] [apisix-ingress-docker] tao12345666333 opened a new pull request #3: chore: bump alpine image version

[GitBox]

tao12345666333 opened a new pull request #3:
URL: https://github.com/apache/apisix-ingress-docker/pull/3


   `alpine:3.12.1` has many vulnerabilities.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] wangxiaochuang opened a new pull request #752: bugfix: fix issue #750

[GitBox]

wangxiaochuang opened a new pull request #752: bugfix: fix issue #750
URL: https://github.com/apache/incubator-apisix/pull/752
 
 
   ## Summary
   
   fix the wrong "method" restriction in plugin's inner api
   
   ### Issues resolved
   
   Fix #750 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] wangxiaochuang closed pull request #751: fix wrong plugin method name

[GitBox]

wangxiaochuang closed pull request #751: fix wrong plugin method name
URL: https://github.com/apache/incubator-apisix/pull/751
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #752: bugfix: fix issue #750

[GitBox]

juzhiyuan commented on a change in pull request #752: bugfix: fix issue #750
URL: https://github.com/apache/incubator-apisix/pull/752#discussion_r339879892
 
 

 ##
 File path: t/plugin/jwt-auth.t
 ##
 @@ -148,7 +148,14 @@ qr/eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.\w+.\w+/
 
 
 
-=== TEST 6: verify, missing token
+=== TEST 6: test for unsupport method
 
 Review comment:
   `unsupported` would be better


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] wangxiaochuang commented on a change in pull request #752: bugfix: fix issue #750

[GitBox]

wangxiaochuang commented on a change in pull request #752: bugfix: fix issue 
#750
URL: https://github.com/apache/incubator-apisix/pull/752#discussion_r339881615
 
 

 ##
 File path: t/plugin/jwt-auth.t
 ##
 @@ -148,7 +148,14 @@ qr/eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.\w+.\w+/
 
 
 
-=== TEST 6: verify, missing token
+=== TEST 6: test for unsupport method
 
 Review comment:
   I agree with you, and I have corrected the description


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] ygm521 opened a new issue #753: apisix和openresty对比几大优势。欢迎补充！

[GitBox]

ygm521 opened a new issue #753: apisix和openresty对比几大优势。欢迎补充！
URL: https://github.com/apache/incubator-apisix/issues/753
 
 
   1, etcd 解决分布式配置存储一致性问题,解决了配置变更推送问题;
   2, 路由和真实服务配置可以动态调整;
   3, nginx配置变更需要reload，worker进程缓存失效问题;


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] Tinywan commented on issue #753: apisix和openresty对比几大优势。欢迎补充！

[GitBox]

Tinywan commented on issue #753: apisix和openresty对比几大优势。欢迎补充！
URL: 
https://github.com/apache/incubator-apisix/issues/753#issuecomment-547263525
 
 
   This is not the same, can't compare


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] Miss-you commented on issue #753: apisix和openresty对比几大优势。欢迎补充！

[GitBox]

Miss-you commented on issue #753: apisix和openresty对比几大优势。欢迎补充！
URL: 
https://github.com/apache/incubator-apisix/issues/753#issuecomment-547267714
 
 
   Openresty is a full-fledged web platform
   APISIX is an high-performance API-Gateway
   
   You can compare APISIX to other API-gateways, like tyk, kong, orange, and
   so on.
   
   ShaoBo Wan(无极)  于2019年10月29日周二 下午1:32写道：
   
   > This is not the same, can't compare
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or unsubscribe
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] nic-chen commented on a change in pull request #691: feat grpc proxy doc && test case

[GitBox]

nic-chen commented on a change in pull request #691: feat grpc proxy doc && 
test case
URL: https://github.com/apache/incubator-apisix/pull/691#discussion_r339911227
 
 

 ##
 File path: doc/grpc-proxy-cn.md
 ##
 @@ -0,0 +1,53 @@
+[English](grpc-proxy.md)
+# grpc-proxy
+
+通过APISIX代理gRPC连接，并使用APISIX的大部分特性管理你的grpc服务。 
+
+
+
+### 参数
+
+* `service_protocol": "`:  这个 route 的属性`service_protocal` 必须设置为 `grpc`
+* `uri`:   格式为 /service/method 如：/helloworld.Greeter/SayHello
+
+
+
+### 示例
+
+ 创建代理grpc的route 
+
+在指定 route 中，代理 gRPC 服务接口:
+
+* 注意： 这个 route 的属性`service_protocal` 必须设置为 `grpc`
+* 注意： APISIX 使用TLS加密的HTTP/2暴露gRPC服务, 
所以需要先[配置SSL证书](https://github.com/iresty/apisix/blob/master/doc/https-cn.md)
+* 例子所代理的 gRPC 
服务可参考：[grpc_server_example](https://github.com/nic-chen/grpc_server_example)
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -X PUT -d '
+{
+"methods": ["POST", "GET"],
 
 Review comment:
   > for a mini test case, we can remove `"methods": ["POST", "GET"],` this line
   
   can't remove..


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on issue #753: apisix和openresty对比几大优势。欢迎补充！

[GitBox]

membphis commented on issue #753: apisix和openresty对比几大优势。欢迎补充！
URL: 
https://github.com/apache/incubator-apisix/issues/753#issuecomment-547302066
 
 
   @ygm521 I think we can close this issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] ygm521 commented on issue #753: apisix和openresty对比几大优势。欢迎补充！

[GitBox]

ygm521 commented on issue #753: apisix和openresty对比几大优势。欢迎补充！
URL: 
https://github.com/apache/incubator-apisix/issues/753#issuecomment-547304628
 
 
   希望院生补充补充吧，许多入门者都不清楚apisix和nginx有啥区别？ @moonming @membphis 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] Tinywan commented on issue #753: apisix和openresty对比几大优势。欢迎补充！

[GitBox]

Tinywan commented on issue #753: apisix和openresty对比几大优势。欢迎补充！
URL: 
https://github.com/apache/incubator-apisix/issues/753#issuecomment-547309567
 
 
   @Miss-you  I agree


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] idevz commented on issue #753: apisix和openresty对比几大优势。欢迎补充！

[GitBox]

idevz commented on issue #753: apisix和openresty对比几大优势。欢迎补充！
URL: 
https://github.com/apache/incubator-apisix/issues/753#issuecomment-547309765
 
 
   @ygm521 we'd better using English here, on account of we're in the 
apache-incubator now.
   
   For your question, apisix is a Cloud Native Api GateWay, but Nginx or 
OpenResty are web Servers, 
   Apisix now is based on Nginx and Luajit(ngx_lua), there’re totally different 
things.
   
   I think maybe your experience of Nginx using made you're  confused. Such as 
using Nginx as a revers Proxy,
   Or a simple web server.
   
   As a Cloud Native Api GateWay ApiSix not only provider a proxy ability, but 
also the ability of Service governance for your Cloud Native Micro services.
   
   If you want some Chinese communication, you can discuss those questions in 
QQ group(552030619).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] idevz edited a comment on issue #753: apisix和openresty对比几大优势。欢迎补充！

[GitBox]

idevz edited a comment on issue #753: apisix和openresty对比几大优势。欢迎补充！
URL: 
https://github.com/apache/incubator-apisix/issues/753#issuecomment-547309765
 
 
   @ygm521 we'd better using English here, on account of we're in the 
apache-incubator now.
   
   For your question, apisix is a Cloud Native Api GateWay, but Nginx or 
OpenResty are web Servers, 
   Apisix now is based on Nginx and Luajit(ngx_lua), there’re totally different 
things.
   
   I think maybe your experience of Nginx using made you're  confused. Such as 
using Nginx as a revers Proxy, or as a simple web server.
   
   As a Cloud Native Api GateWay ApiSix not only provider a proxy ability, but 
also the ability of Service governance for your Cloud Native Micro services.
   
   If you want some Chinese communication, you can discuss those questions in 
QQ group(552030619).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] ygm521 commented on issue #753: apisix和openresty对比几大优势。欢迎补充！

[GitBox]

ygm521 commented on issue #753: apisix和openresty对比几大优势。欢迎补充！
URL: 
https://github.com/apache/incubator-apisix/issues/753#issuecomment-547313192
 
 
   I am based on nginx to write related c language modules. As far as I know, 
   1, apisix is nothing more than using the etcd storage configuration to 
implement dynamic configuration changes; 
   2, instead of nginx's location{} matching
   3, using a large number of worker process caches.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] lilien1010 opened a new pull request #754: doc: change all ` iresty/apisix` link in documents into `apache/incubator-apisix`

[GitBox]

lilien1010 opened a new pull request #754: doc: change all ` iresty/apisix` 
link in documents into `apache/incubator-apisix`
URL: https://github.com/apache/incubator-apisix/pull/754
 
 

   ### Summary
   
   change all ` iresty/apisix` link in documents into `apache/incubator-apisix`
   
   ### Full changelog

   ### Issues resolved

   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] wziww opened a new pull request #755: Doc update

[GitBox]

wziww opened a new pull request #755: Doc update
URL: https://github.com/apache/incubator-apisix/pull/755
 
 
   ### Summary
   
   Add `TEST_NGINX_BINARY`  environment variables description for dev-manual doc
   
   ### Full changelog
   
   
   ### Issues resolved
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] YazaiHu opened a new pull request #756: add restart apisix server command

[GitBox]

YazaiHu opened a new pull request #756: add restart apisix server command
URL: https://github.com/apache/incubator-apisix/pull/756
 
 
   NOTE: Please read the Contributing.md guidelines before submitting your 
patch:
   
   
https://github.com/iresty/apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
   
   ### Summary
   
   SUMMARY_HERE
   
   ### Full changelog
   
   * [Implement ...]
   * [Add related tests]
   * ...
   
   ### Issues resolved
   
   Fix #XXX
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #756: add restart apisix server command

[GitBox]

juzhiyuan commented on a change in pull request #756: add restart apisix server 
command
URL: https://github.com/apache/incubator-apisix/pull/756#discussion_r340002152
 
 

 ##
 File path: bin/apisix
 ##
 @@ -450,6 +450,7 @@ init:   initialize the local nginx.conf
 init_etcd:  initialize the data of etcd
 start:  start the apisix server
 stop:   stop the apisix server
+restart:stop the apisix server and then start the apisix server
 
 Review comment:
   `restart the apisix server` would be better.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #755: Doc update

[GitBox]

juzhiyuan commented on a change in pull request #755: Doc update
URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340003132
 
 

 ##
 File path: doc/dev-manual-cn.md
 ##
 @@ -99,3 +99,4 @@ Makefile rules:
 2. 然后通过 cpanm 来安装 test-gninx：`sudo cpanm --notest Test::Nginx IPC::Run > 
build.log 2>&1 || (cat build.log && exit 1)`
 3. 然后 clone 最新的源码：`git clone https://github.com/openresty/test-nginx.git`
 4. 通过 perl 的 `prove` 命令来加载 test-nginx 的库，并运行 `/t` 目录下的测试案例集:`prove 
-Itest-nginx/lib -r t`
+>可通过 TEST_NGINX_BINARY 环境变量来设置执行的 nginx 路径 , 如 
TEST_NGINX_BINARY=/usr/local/bin/openresty prove -Itest-nginx/lib -r t
 
 Review comment:
   Please remove the whitespace between `路径` & `，`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] juzhiyuan commented on issue #755: Doc update

[GitBox]

juzhiyuan commented on issue #755: Doc update
URL: https://github.com/apache/incubator-apisix/pull/755#issuecomment-547361159
 
 
   Thanks for your contribution!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #755: Doc update

[GitBox]

juzhiyuan commented on a change in pull request #755: Doc update
URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340003619
 
 

 ##
 File path: doc/dev-manual.md
 ##
 @@ -99,4 +99,5 @@ Makefile rules:
 2. Then install `test-gninx` via `cpanm`:：`sudo cpanm --notest Test::Nginx 
IPC::Run > build.log 2>&1 || (cat build.log && exit 1)`
 3. clone source code：`git clone https://github.com/openresty/test-nginx.git`;
 4. Load the `test-nginx` library with perl's `prove` command and run the test 
cases in the `/t` directory: `prove -Itest-nginx/lib -r t`
+>The environment variables TEST_NGINX_BINARY can set the execution path of 
nginx , such as TEST_NGINX_BINARY=/usr/local/bin/openresty prove 
-Itest-nginx/lib -r t
 
 Review comment:
   `The environment variables` --> `The environment variable`
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] wziww commented on a change in pull request #755: Doc update

[GitBox]

wziww commented on a change in pull request #755: Doc update
URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340006282
 
 

 ##
 File path: doc/dev-manual.md
 ##
 @@ -99,4 +99,5 @@ Makefile rules:
 2. Then install `test-gninx` via `cpanm`:：`sudo cpanm --notest Test::Nginx 
IPC::Run > build.log 2>&1 || (cat build.log && exit 1)`
 3. clone source code：`git clone https://github.com/openresty/test-nginx.git`;
 4. Load the `test-nginx` library with perl's `prove` command and run the test 
cases in the `/t` directory: `prove -Itest-nginx/lib -r t`
+>The environment variables TEST_NGINX_BINARY can set the execution path of 
nginx , such as TEST_NGINX_BINARY=/usr/local/bin/openresty prove 
-Itest-nginx/lib -r t
 
 Review comment:
   
https://github.com/apache/incubator-apisix/pull/755/commits/eea2d0dde30c1c9c1bd821e0102d3fb847d5fa30


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] wziww commented on a change in pull request #755: Doc update

[GitBox]

wziww commented on a change in pull request #755: Doc update
URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340006462
 
 

 ##
 File path: doc/dev-manual-cn.md
 ##
 @@ -99,3 +99,4 @@ Makefile rules:
 2. 然后通过 cpanm 来安装 test-gninx：`sudo cpanm --notest Test::Nginx IPC::Run > 
build.log 2>&1 || (cat build.log && exit 1)`
 3. 然后 clone 最新的源码：`git clone https://github.com/openresty/test-nginx.git`
 4. 通过 perl 的 `prove` 命令来加载 test-nginx 的库，并运行 `/t` 目录下的测试案例集:`prove 
-Itest-nginx/lib -r t`
+>可通过 TEST_NGINX_BINARY 环境变量来设置执行的 nginx 路径 , 如 
TEST_NGINX_BINARY=/usr/local/bin/openresty prove -Itest-nginx/lib -r t
 
 Review comment:
   
https://github.com/apache/incubator-apisix/pull/755/commits/2ef4e0d428b222f261bcf5bfad3dac4f642eb26f


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #755: Doc update

[GitBox]

juzhiyuan commented on a change in pull request #755: Doc update
URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340006968
 
 

 ##
 File path: doc/dev-manual-cn.md
 ##
 @@ -99,3 +99,4 @@ Makefile rules:
 2. 然后通过 cpanm 来安装 test-gninx：`sudo cpanm --notest Test::Nginx IPC::Run > 
build.log 2>&1 || (cat build.log && exit 1)`
 3. 然后 clone 最新的源码：`git clone https://github.com/openresty/test-nginx.git`
 4. 通过 perl 的 `prove` 命令来加载 test-nginx 的库，并运行 `/t` 目录下的测试案例集:`prove 
-Itest-nginx/lib -r t`
+>可通过 TEST_NGINX_BINARY 环境变量来设置执行的 nginx 路径,如 
TEST_NGINX_BINARY=/usr/local/bin/openresty prove -Itest-nginx/lib -r t
 
 Review comment:
   
![image](https://user-images.githubusercontent.com/2106987/67760965-4bbc5300-fa7d-11e9-9298-4c0da0629f73.png)
   
   The comma character should be in tradition Chinese version.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #755: Doc update

[GitBox]

juzhiyuan commented on a change in pull request #755: Doc update
URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340006968
 
 

 ##
 File path: doc/dev-manual-cn.md
 ##
 @@ -99,3 +99,4 @@ Makefile rules:
 2. 然后通过 cpanm 来安装 test-gninx：`sudo cpanm --notest Test::Nginx IPC::Run > 
build.log 2>&1 || (cat build.log && exit 1)`
 3. 然后 clone 最新的源码：`git clone https://github.com/openresty/test-nginx.git`
 4. 通过 perl 的 `prove` 命令来加载 test-nginx 的库，并运行 `/t` 目录下的测试案例集:`prove 
-Itest-nginx/lib -r t`
+>可通过 TEST_NGINX_BINARY 环境变量来设置执行的 nginx 路径,如 
TEST_NGINX_BINARY=/usr/local/bin/openresty prove -Itest-nginx/lib -r t
 
 Review comment:
   
![image](https://user-images.githubusercontent.com/2106987/67760965-4bbc5300-fa7d-11e9-9298-4c0da0629f73.png)
   
   The comma character should be in traditional Chinese version.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] YazaiHu commented on a change in pull request #756: add restart apisix server command

[GitBox]

YazaiHu commented on a change in pull request #756: add restart apisix server 
command
URL: https://github.com/apache/incubator-apisix/pull/756#discussion_r340008024
 
 

 ##
 File path: bin/apisix
 ##
 @@ -450,6 +450,7 @@ init:   initialize the local nginx.conf
 init_etcd:  initialize the data of etcd
 start:  start the apisix server
 stop:   stop the apisix server
+restart:stop the apisix server and then start the apisix server
 
 Review comment:
   okay


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] wziww commented on a change in pull request #755: Doc update

[GitBox]

wziww commented on a change in pull request #755: Doc update
URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340009105
 
 

 ##
 File path: doc/dev-manual-cn.md
 ##
 @@ -99,3 +99,4 @@ Makefile rules:
 2. 然后通过 cpanm 来安装 test-gninx：`sudo cpanm --notest Test::Nginx IPC::Run > 
build.log 2>&1 || (cat build.log && exit 1)`
 3. 然后 clone 最新的源码：`git clone https://github.com/openresty/test-nginx.git`
 4. 通过 perl 的 `prove` 命令来加载 test-nginx 的库，并运行 `/t` 目录下的测试案例集:`prove 
-Itest-nginx/lib -r t`
+>可通过 TEST_NGINX_BINARY 环境变量来设置执行的 nginx 路径,如 
TEST_NGINX_BINARY=/usr/local/bin/openresty prove -Itest-nginx/lib -r t
 
 Review comment:
   Also fix the semicolon character. 
https://github.com/apache/incubator-apisix/pull/755/commits/8550ed24d6992bac84524fd9353319878d242a53
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] YazaiHu closed pull request #756: add restart apisix server command

[GitBox]

YazaiHu closed pull request #756: add restart apisix server command
URL: https://github.com/apache/incubator-apisix/pull/756
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] YazaiHu opened a new pull request #757: add restart apisix server command

[GitBox]

YazaiHu opened a new pull request #757: add restart apisix server command
URL: https://github.com/apache/incubator-apisix/pull/757
 
 
   NOTE: Please read the Contributing.md guidelines before submitting your 
patch:
   
   
https://github.com/iresty/apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
   
   ### Summary
   
   SUMMARY_HERE
   
   ### Full changelog
   
   * [Implement ...]
   * [Add related tests]
   * ...
   
   ### Issues resolved
   
   Fix #XXX
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] idevz commented on issue #753: apisix和openresty对比几大优势。欢迎补充！

[GitBox]

idevz commented on issue #753: apisix和openresty对比几大优势。欢迎补充！
URL: 
https://github.com/apache/incubator-apisix/issues/753#issuecomment-547419102
 
 
   APISIX is not only implement dynamic configuration changes; 
   I think The most import things which APISIX have done are:
   
   1. Provider a high performance route to mange your business traffic.
   2. Provider a flexible mechanism(plugins) to add your custom logic about 
your own business.
   3. Based on the upon second point, APISIX bring us many good plugins out of 
the box, such as rate-limit, trace, server-less and so on.
   
   All in one world APISIX is a API Gateway Not a Web Server.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-docker] Tinywan opened a new pull request #29: Simplify the docker run documentation and run quickly with docker-compose

[GitBox]

Tinywan opened a new pull request #29: Simplify the docker run documentation 
and run quickly with docker-compose
URL: https://github.com/apache/incubator-apisix-docker/pull/29
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] juzhiyuan opened a new pull request #5: Update README.md

[GitBox]

juzhiyuan opened a new pull request #5: Update README.md
URL: https://github.com/apache/incubator-apisix-website/pull/5
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on a change in pull request #755: Doc update

[GitBox]

membphis commented on a change in pull request #755: Doc update
URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340174432
 
 

 ##
 File path: doc/dev-manual-cn.md
 ##
 @@ -98,4 +98,5 @@ Makefile rules:
 1. 先安装 perl 的包管理器 cpanminus
 2. 然后通过 cpanm 来安装 test-gninx：`sudo cpanm --notest Test::Nginx IPC::Run > 
build.log 2>&1 || (cat build.log && exit 1)`
 3. 然后 clone 最新的源码：`git clone https://github.com/openresty/test-nginx.git`
-4. 通过 perl 的 `prove` 命令来加载 test-nginx 的库，并运行 `/t` 目录下的测试案例集:`prove 
-Itest-nginx/lib -r t`
+4. 通过 perl 的 `prove` 命令来加载 test-nginx 的库，并运行 `/t` 目录下的测试案例集：`prove 
-Itest-nginx/lib -r t`
+>可通过 TEST_NGINX_BINARY 环境变量来设置执行的 nginx 路径，如 
TEST_NGINX_BINARY=/usr/local/bin/openresty prove -Itest-nginx/lib -r t
 
 Review comment:
   how about this style? I think it is more clear.
   
   ```
   ... ...
   3. 
   4. , 并运行 `/t` 目录下的测试案例集:
   * 直接运行：`prove -Itest-nginx/lib -r t`
   * 指定 Ningx 二进制路径：`TEST_NGINX_BINARY=/usr/local/bin/openresty prove 
-Itest-nginx/lib -r t`
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] membphis opened a new issue #6: bug: wrong link

[GitBox]

membphis opened a new issue #6: bug: wrong link
URL: https://github.com/apache/incubator-apisix-website/issues/6
 
 
   change to new apache link.
   
   
![image](https://user-images.githubusercontent.com/6814606/67786809-75d83a00-faaa-11e9-8ee5-129447b64681.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] membphis opened a new issue #7: wrong ico, we need to use the logo of Apache APISIX

[GitBox]

membphis opened a new issue #7: wrong ico, we need to use the logo of Apache 
APISIX
URL: https://github.com/apache/incubator-apisix-website/issues/7
 
 
   
![image](https://user-images.githubusercontent.com/6814606/67788072-986b5280-faac-11e9-9a23-ae50760e95cf.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] membphis commented on issue #6: bug: wrong link

[GitBox]

membphis commented on issue #6: bug: wrong link
URL: 
https://github.com/apache/incubator-apisix-website/issues/6#issuecomment-547517315
 
 
   
![image](https://user-images.githubusercontent.com/6814606/67788861-02382c00-faae-11e9-8690-cba7df123196.png)
   
   ditto


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] Miss-you commented on a change in pull request #739: doc: redirect-cn.md

[GitBox]

Miss-you commented on a change in pull request #739: doc: redirect-cn.md
URL: https://github.com/apache/incubator-apisix/pull/739#discussion_r340240178
 
 

 ##
 File path: doc/plugins/redirect-cn.md
 ##
 @@ -0,0 +1,96 @@
+[English](plugins/redirect.md)
 
 Review comment:
   
https://github.com/apache/incubator-apisix/blob/master/doc/plugins/plugins/redirect.md
   It looks like a wrong link.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] lilien1010 commented on issue #37: UI improvement: When the upstream load balancing algorithm is chash, the choice of key can be made into a drop-down list.

[GitBox]

lilien1010 commented on issue #37:  UI improvement: When the upstream load 
balancing algorithm is chash, the choice of key can be made into a drop-down 
list. 
URL: 
https://github.com/apache/incubator-apisix-dashboard/issues/37#issuecomment-547700534
 
 
   @juzhiyuan  how is the work about this feature going on？
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] lilien1010 commented on issue #37: UI improvement: When the upstream load balancing algorithm is chash, the choice of key can be made into a drop-down list.

[GitBox]

lilien1010 commented on issue #37:  UI improvement: When the upstream load 
balancing algorithm is chash, the choice of key can be made into a drop-down 
list. 
URL: 
https://github.com/apache/incubator-apisix-dashboard/issues/37#issuecomment-547702086
 
 
   @juzhiyuan
   https://github.com/apache/incubator-apisix/pull/719
   after the PR is merged 
   I think it support nginx built-in variables like 
`uri,server_name,server_addr,request_uri,remote_port,remote_addr,query_string,host,hostname,arg_***`
 , `arg_***` ，so the droplist should be editable & selectable


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] wziww commented on a change in pull request #755: Doc update

[GitBox]

wziww commented on a change in pull request #755: Doc update
URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340399289
 
 

 ##
 File path: doc/dev-manual-cn.md
 ##
 @@ -98,4 +98,5 @@ Makefile rules:
 1. 先安装 perl 的包管理器 cpanminus
 2. 然后通过 cpanm 来安装 test-gninx：`sudo cpanm --notest Test::Nginx IPC::Run > 
build.log 2>&1 || (cat build.log && exit 1)`
 3. 然后 clone 最新的源码：`git clone https://github.com/openresty/test-nginx.git`
-4. 通过 perl 的 `prove` 命令来加载 test-nginx 的库，并运行 `/t` 目录下的测试案例集:`prove 
-Itest-nginx/lib -r t`
+4. 通过 perl 的 `prove` 命令来加载 test-nginx 的库，并运行 `/t` 目录下的测试案例集：`prove 
-Itest-nginx/lib -r t`
+>可通过 TEST_NGINX_BINARY 环境变量来设置执行的 nginx 路径，如 
TEST_NGINX_BINARY=/usr/local/bin/openresty prove -Itest-nginx/lib -r t
 
 Review comment:
   nice suggestion,if we have other recommendations,we can also list them in 
this way.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on a change in pull request #755: Doc update

[GitBox]

membphis commented on a change in pull request #755: Doc update
URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340402297
 
 

 ##
 File path: doc/dev-manual-cn.md
 ##
 @@ -98,4 +98,6 @@ Makefile rules:
 1. 先安装 perl 的包管理器 cpanminus
 2. 然后通过 cpanm 来安装 test-gninx：`sudo cpanm --notest Test::Nginx IPC::Run > 
build.log 2>&1 || (cat build.log && exit 1)`
 3. 然后 clone 最新的源码：`git clone https://github.com/openresty/test-nginx.git`
-4. 通过 perl 的 `prove` 命令来加载 test-nginx 的库，并运行 `/t` 目录下的测试案例集:`prove 
-Itest-nginx/lib -r t`
+4. 通过 perl 的 `prove` 命令来加载 test-nginx 的库，并运行 `/t` 目录下的测试案例集：`prove 
-Itest-nginx/lib -r t`
 
 Review comment:
   We can remove  `prove -Itest-nginx/lib -r t`, it is duplicated.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #37: UI improvement: When the upstream load balancing algorithm is chash, the choice of key can be made into a drop-down list.

[GitBox]

juzhiyuan commented on issue #37:  UI improvement: When the upstream load 
balancing algorithm is chash, the choice of key can be made into a drop-down 
list. 
URL: 
https://github.com/apache/incubator-apisix-dashboard/issues/37#issuecomment-547707912
 
 
   @lilien1010 Not implemented yet, welcome to send a PR if you could help.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming commented on a change in pull request #757: add restart apisix server command

[GitBox]

moonming commented on a change in pull request #757: add restart apisix server 
command
URL: https://github.com/apache/incubator-apisix/pull/757#discussion_r340405133
 
 

 ##
 File path: bin/apisix
 ##
 @@ -450,6 +450,7 @@ init:   initialize the local nginx.conf
 init_etcd:  initialize the data of etcd
 start:  start the apisix server
 stop:   stop the apisix server
+restart:restart the apisix server
 
 Review comment:
   please add document: 
https://github.com/apache/incubator-apisix/blob/master/doc/dev-manual.md#manage-startstop-apisix-server


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #739: doc: redirect-cn.md

[GitBox]

juzhiyuan commented on a change in pull request #739: doc: redirect-cn.md
URL: https://github.com/apache/incubator-apisix/pull/739#discussion_r340405454
 
 

 ##
 File path: doc/plugins/redirect-cn.md
 ##
 @@ -0,0 +1,96 @@
+[English](plugins/redirect.md)
 
 Review comment:
   It's correct :)
   
   
https://github.com/apache/incubator-apisix/blob/doc-plugins-redirect/doc/plugins-cn.md


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #739: doc: redirect-cn.md

[GitBox]

juzhiyuan commented on a change in pull request #739: doc: redirect-cn.md
URL: https://github.com/apache/incubator-apisix/pull/739#discussion_r340405454
 
 

 ##
 File path: doc/plugins/redirect-cn.md
 ##
 @@ -0,0 +1,96 @@
+[English](plugins/redirect.md)
 
 Review comment:
   The link here is correct :)
   
   
https://github.com/apache/incubator-apisix/blob/doc-plugins-redirect/doc/plugins-cn.md


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #739: doc: redirect-cn.md

[GitBox]

juzhiyuan commented on a change in pull request #739: doc: redirect-cn.md
URL: https://github.com/apache/incubator-apisix/pull/739#discussion_r340405696
 
 

 ##
 File path: doc/plugins/redirect-cn.md
 ##
 @@ -0,0 +1,96 @@
+[English](plugins/redirect.md)
 
 Review comment:
   Sorry for my mistakes, I will fix it now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #739: doc: redirect-cn.md

[GitBox]

juzhiyuan commented on a change in pull request #739: doc: redirect-cn.md
URL: https://github.com/apache/incubator-apisix/pull/739#discussion_r340406196
 
 

 ##
 File path: doc/plugins/redirect-cn.md
 ##
 @@ -0,0 +1,96 @@
+[English](plugins/redirect.md)
 
 Review comment:
   Sufficient permission is pending now, I will fix it once it works.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] juzhiyuan merged pull request #5: Update README.md

[GitBox]

juzhiyuan merged pull request #5: Update README.md
URL: https://github.com/apache/incubator-apisix-website/pull/5
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming merged pull request #704: doc: Update jwt-auth.md

[GitBox]

moonming merged pull request #704: doc: Update jwt-auth.md
URL: https://github.com/apache/incubator-apisix/pull/704
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming merged pull request #715: bugfix:zipkin plugin not set tracing data to request header.

[GitBox]

moonming merged pull request #715: bugfix:zipkin plugin not set tracing data to 
request header.
URL: https://github.com/apache/incubator-apisix/pull/715
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming merged pull request #742: Added Authing into Idp(CN)

[GitBox]

moonming merged pull request #742: Added Authing into Idp(CN)
URL: https://github.com/apache/incubator-apisix/pull/742
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming merged pull request #740: Update README.md - Add AWS deployment tutorial link

[GitBox]

moonming merged pull request #740: Update README.md - Add AWS deployment 
tutorial link
URL: https://github.com/apache/incubator-apisix/pull/740
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming merged pull request #752: bugfix: fix issue #750

[GitBox]

moonming merged pull request #752: bugfix: fix issue #750
URL: https://github.com/apache/incubator-apisix/pull/752
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming closed issue #750: bug: plugin's method definition is invalid

[GitBox]

moonming closed issue #750: bug: plugin's method definition is invalid
URL: https://github.com/apache/incubator-apisix/issues/750
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming merged pull request #755: Doc update

[GitBox]

moonming merged pull request #755: Doc update
URL: https://github.com/apache/incubator-apisix/pull/755
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming merged pull request #754: doc: change all ` iresty/apisix` link in documents into `apache/incubator-apisix`

[GitBox]

moonming merged pull request #754: doc: change all ` iresty/apisix` link in 
documents into `apache/incubator-apisix`
URL: https://github.com/apache/incubator-apisix/pull/754
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming closed issue #753: apisix和openresty对比几大优势。欢迎补充！

[GitBox]

moonming closed issue #753: apisix和openresty对比几大优势。欢迎补充！
URL: https://github.com/apache/incubator-apisix/issues/753
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming closed issue #744: todo: will merge this PR manually after `apisix` -> `apache apisix`

[GitBox]

moonming closed issue #744: todo: will merge this PR manually after `apisix` -> 
`apache apisix`
URL: https://github.com/apache/incubator-apisix/issues/744
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] juzhiyuan closed issue #6: bug: wrong link

[GitBox]

juzhiyuan closed issue #6: bug: wrong link
URL: https://github.com/apache/incubator-apisix-website/issues/6
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming commented on issue #707: doc: fix 404 link when link to install-dependencies

[GitBox]

moonming commented on issue #707: doc: fix 404 link when link to 
install-dependencies
URL: https://github.com/apache/incubator-apisix/pull/707#issuecomment-547717029
 
 
   fixed by https://github.com/apache/incubator-apisix/pull/754


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] juzhiyuan commented on issue #6: bug: wrong link

[GitBox]

juzhiyuan commented on issue #6: bug: wrong link
URL: 
https://github.com/apache/incubator-apisix-website/issues/6#issuecomment-547716975
 
 
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming closed pull request #707: doc: fix 404 link when link to install-dependencies

[GitBox]

moonming closed pull request #707: doc: fix 404 link when link to 
install-dependencies
URL: https://github.com/apache/incubator-apisix/pull/707
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] juzhiyuan commented on issue #7: wrong ico, we need to use the logo of Apache APISIX

[GitBox]

juzhiyuan commented on issue #7: wrong ico, we need to use the logo of Apache 
APISIX
URL: 
https://github.com/apache/incubator-apisix-website/issues/7#issuecomment-547719801
 
 
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] juzhiyuan closed issue #7: wrong ico, we need to use the logo of Apache APISIX

[GitBox]

juzhiyuan closed issue #7: wrong ico, we need to use the logo of Apache APISIX
URL: https://github.com/apache/incubator-apisix-website/issues/7
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] membphis opened a new issue #8: wrong link in README.md

[GitBox]

membphis opened a new issue #8: wrong link in README.md
URL: https://github.com/apache/incubator-apisix-website/issues/8
 
 
   
![image](https://user-images.githubusercontent.com/6814606/67826009-1c055d80-fb06-11e9-9ada-8e383ed6d6b9.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] juzhiyuan edited a comment on issue #8: wrong link in README.md

[GitBox]

juzhiyuan edited a comment on issue #8: wrong link in README.md
URL: 
https://github.com/apache/incubator-apisix-website/issues/8#issuecomment-547721186
 
 
   Please see `dev` or `asf-site` branch. @moonming I think we may set master 
branch as Dev branch to reduce confusion.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] juzhiyuan commented on issue #8: wrong link in README.md

[GitBox]

juzhiyuan commented on issue #8: wrong link in README.md
URL: 
https://github.com/apache/incubator-apisix-website/issues/8#issuecomment-547721186
 
 
   Please see `dev` or `asf-site` branch. @moonming I think we may set master 
branch as Dev branch to reduce confustion.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] juzhiyuan edited a comment on issue #8: wrong link in README.md

[GitBox]

juzhiyuan edited a comment on issue #8: wrong link in README.md
URL: 
https://github.com/apache/incubator-apisix-website/issues/8#issuecomment-547721186
 
 
   @membphis Please see `dev` or `asf-site` branch. @moonming I think we may 
set master branch as Dev branch to reduce confusion.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] moonming commented on issue #8: wrong link in README.md

[GitBox]

moonming commented on issue #8: wrong link in README.md
URL: 
https://github.com/apache/incubator-apisix-website/issues/8#issuecomment-547722599
 
 
   ok


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] moonming closed issue #8: wrong link in README.md

[GitBox]

moonming closed issue #8: wrong link in README.md
URL: https://github.com/apache/incubator-apisix-website/issues/8
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] juzhiyuan opened a new issue #9: update repo settings

[GitBox]

juzhiyuan opened a new issue #9: update repo settings
URL: https://github.com/apache/incubator-apisix-website/issues/9
 
 
   @moonming Please help set `asf-site` branch under-protected, and remove 
`dev` branch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on issue #732: feature: supported `redirect` plugin.

[GitBox]

membphis commented on issue #732: feature: supported `redirect` plugin.
URL: https://github.com/apache/incubator-apisix/pull/732#issuecomment-547726770
 
 
   Rebased this branch and added new comments, please take a look.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on a change in pull request #732: feature: supported `redirect` plugin.

[GitBox]

membphis commented on a change in pull request #732: feature: supported 
`redirect` plugin.
URL: https://github.com/apache/incubator-apisix/pull/732#discussion_r340420182
 
 

 ##
 File path: lua/apisix/plugins/redirect.lua
 ##
 @@ -0,0 +1,121 @@
+local core = require("apisix.core")
+local tab_insert = table.insert
+local tab_concat = table.concat
+local re_gmatch = ngx.re.gmatch
+local ipairs = ipairs
+
+local lrucache = core.lrucache.new({
+ttl = 300, count = 100
+})
+
+
+local schema = {
+type = "object",
+properties = {
+ret_code = {type = "integer", minimum = 200, default = 302},
+uri = {type = "string", minLength = 2},
+},
+required = {"uri"},
+}
+
+
+local plugin_name = "rewrite"
+
+local _M = {
+version = 0.1,
+priority = 900,
+name = plugin_name,
+schema = schema,
+}
+
+
+local function parse_uri(uri)
+
+local reg = [[ (\\\$[0-9a-zA-Z_]+) | ]] -- \$host
+.. [[ \$\{([0-9a-zA-Z_]+)\} | ]]-- ${host}
+.. [[ \$([0-9a-zA-Z_]+) | ]]-- $host
+.. [[ (\$|[^$\\]+) ]]   -- $ or others
+local iterator, err = re_gmatch(uri, reg, "jiox")
+if not iterator then
+return nil, err
+end
+
+local t = {}
+while true do
+local m, err = iterator()
+if err then
+return nil, err
+end
+
+if not m then
+break
+end
+
+tab_insert(t, m)
+end
+
+return t
+end
+
+
+function _M.check_schema(conf)
+local ok, err = core.schema.check(schema, conf)
+if not ok then
+return false, err
+end
+
+local uri_segs, err = parse_uri(conf.uri)
+if not uri_segs then
+return false, err
+end
+core.log.info(core.json.delay_encode(uri_segs))
+
+return true
+end
+
+
+local tmp = {}
+local function concat_new_uri(uri, ctx)
+local pased_uri_segs, err = lrucache(uri, nil, parse_uri, uri)
+if not pased_uri_segs then
+return nil, err
+end
+
+core.table.clear(tmp)
+
+for _, uri_segs in ipairs(pased_uri_segs) do
+local pat1 = uri_segs[1]
 
 Review comment:
   I added some comments.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] moonming commented on issue #9: update repo settings

[GitBox]

moonming commented on issue #9: update repo settings
URL: 
https://github.com/apache/incubator-apisix-website/issues/9#issuecomment-547727284
 
 
   my permissions are the same as you, so if you want to do this, you need to 
create a ticket for the infra team.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-website] juzhiyuan commented on issue #9: update repo settings

[GitBox]

juzhiyuan commented on issue #9: update repo settings
URL: 
https://github.com/apache/incubator-apisix-website/issues/9#issuecomment-547729863
 
 
   Ticket created here https://issues.apache.org/jira/browse/INFRA-19356 , I 
will close this issues once the settings have been updated.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] juzhiyuan commented on issue #679: bug: apisix/dashboard don't support array type for the schema in plugins

[GitBox]

juzhiyuan commented on issue #679: bug: apisix/dashboard don't support array 
type for the schema in plugins
URL: 
https://github.com/apache/incubator-apisix/issues/679#issuecomment-547739110
 
 
   It will be like this.
   
   
![image](https://user-images.githubusercontent.com/2106987/67830251-e4ea7880-fb14-11e9-8917-217ada812518.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on issue #679: bug: apisix/dashboard don't support array type for the schema in plugins

[GitBox]

membphis commented on issue #679: bug: apisix/dashboard don't support array 
type for the schema in plugins
URL: 
https://github.com/apache/incubator-apisix/issues/679#issuecomment-547740306
 
 
   > It will be like this.
   > 
   
   How to add new ones? We need an 'add' button.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis opened a new pull request #758: doc: added a new speech link and dropped `node-status` api doc.

[GitBox]

membphis opened a new pull request #758: doc: added a new speech link and 
dropped `node-status` api doc.
URL: https://github.com/apache/incubator-apisix/pull/758
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis opened a new issue #759: doc: typo

[GitBox]

membphis opened a new issue #759: doc: typo
URL: https://github.com/apache/incubator-apisix/issues/759
 
 
   
![image](https://user-images.githubusercontent.com/6814606/67833580-fe44f200-fb1f-11e9-9faf-5df509627de7.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming edited a comment on issue #743: license: add ASF header.

[GitBox]

moonming edited a comment on issue #743: license: add ASF header.
URL: https://github.com/apache/incubator-apisix/pull/743#issuecomment-547719058
 
 
   > > index.html
   > 
   > So this file is using an incorrect ASF header?
   > 
https://github.com/iresty/apisix_dashboard_built/blob/fde8c24f536659e33e899d4adc3d6b48d658a6a2/index.html
   
   @juzhiyuan  can you change to this style: 
https://github.com/apache/incubator-apisix/pull/743/files#diff-1fe3647ec3125ba1bcdbd7c830ada01d？
.travis/ASFLicenseHeaderMarkdown.txt


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] moonming opened a new pull request #51: change the style of html license.

[GitBox]

moonming opened a new pull request #51: change the style of html license.
URL: https://github.com/apache/incubator-apisix-dashboard/pull/51
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] toruneko opened a new issue #760: bug: wildcard certificates cannot match multi-level subdomains.

[GitBox]

toruneko opened a new issue #760: bug: wildcard certificates cannot match 
multi-level subdomains.
URL: https://github.com/apache/incubator-apisix/issues/760
 
 
   ### Issue description
   *.test.com certificate cannot match a.b.test.com domain,
   because the wildcard only covers one level of subdomains
   https://en.wikipedia.org/wiki/Wildcard_certificate
   
   ### Environment
   
   * apisix version (cmd: `apisix version`):
   * OS:
   
   ### Minimal test code / Steps to reproduce the issue
   1.
   2.
   3.
   
   ### What's the actual result? (including assertion message & call stack if 
applicable)
   
   
   
   ### What's the expected result?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming commented on a change in pull request #758: doc: added a new speech link and dropped `node-status` api doc.

[GitBox]

moonming commented on a change in pull request #758: doc: added a new speech 
link and dropped `node-status` api doc.
URL: https://github.com/apache/incubator-apisix/pull/758#discussion_r340447631
 
 

 ##
 File path: README_CN.md
 ##
 @@ -177,9 +177,10 @@ Dashboard 默认允许任何 IP 访问。你可以自行修改 `conf/config.yaml
 
 ## 视频和幻灯片
 
-- [APISIX 的选型、测试和持续集成](https://www.upyun.com/opentalk/432.html)
-
-- [APISIX 高性能实践](https://www.upyun.com/opentalk/429.html)
+- 2019.10.30 [Apache APISIX 
微服务架构极致性能架构解析](https://www.upyun.com/opentalk/440.html) .
+- 2019.8.31 [APISIX 技术选型、测试和持续集成](https://www.upyun.com/opentalk/433.html) .
+- 2019.8.31 [APISIX 高性能实战2](https://www.upyun.com/opentalk/437.html) .
+- 2019.7.6 [APISIX 高性能实战(Chinese)](https://www.upyun.com/opentalk/429.html) .
 
 Review comment:
   do you have the text version?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming commented on a change in pull request #758: doc: added a new speech link and dropped `node-status` api doc.

[GitBox]

moonming commented on a change in pull request #758: doc: added a new speech 
link and dropped `node-status` api doc.
URL: https://github.com/apache/incubator-apisix/pull/758#discussion_r340447159
 
 

 ##
 File path: doc/admin-api-cn.md
 ##
 @@ -3,7 +3,6 @@
 ===
 
 * [Route](#route)
 
 Review comment:
   why leave this empty file?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on a change in pull request #758: doc: added a new speech link and dropped `node-status` api doc.

[GitBox]

membphis commented on a change in pull request #758: doc: added a new speech 
link and dropped `node-status` api doc.
URL: https://github.com/apache/incubator-apisix/pull/758#discussion_r340448902
 
 

 ##
 File path: README_CN.md
 ##
 @@ -177,9 +177,10 @@ Dashboard 默认允许任何 IP 访问。你可以自行修改 `conf/config.yaml
 
 ## 视频和幻灯片
 
-- [APISIX 的选型、测试和持续集成](https://www.upyun.com/opentalk/432.html)
-
-- [APISIX 高性能实践](https://www.upyun.com/opentalk/429.html)
+- 2019.10.30 [Apache APISIX 
微服务架构极致性能架构解析](https://www.upyun.com/opentalk/440.html) .
+- 2019.8.31 [APISIX 技术选型、测试和持续集成](https://www.upyun.com/opentalk/433.html) .
+- 2019.8.31 [APISIX 高性能实战2](https://www.upyun.com/opentalk/437.html) .
+- 2019.7.6 [APISIX 高性能实战(Chinese)](https://www.upyun.com/opentalk/429.html) .
 
 Review comment:
   I think I can find some of them. If you have a list, please paste it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] moonming merged pull request #51: change the style of html license.

[GitBox]

moonming merged pull request #51: change the style of html license.
URL: https://github.com/apache/incubator-apisix-dashboard/pull/51
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on a change in pull request #758: doc: added a new speech link and dropped `node-status` api doc.

[GitBox]

membphis commented on a change in pull request #758: doc: added a new speech 
link and dropped `node-status` api doc.
URL: https://github.com/apache/incubator-apisix/pull/758#discussion_r340450814
 
 

 ##
 File path: README_CN.md
 ##
 @@ -177,9 +177,10 @@ Dashboard 默认允许任何 IP 访问。你可以自行修改 `conf/config.yaml
 
 ## 视频和幻灯片
 
-- [APISIX 的选型、测试和持续集成](https://www.upyun.com/opentalk/432.html)
-
-- [APISIX 高性能实践](https://www.upyun.com/opentalk/429.html)
+- 2019.10.30 [Apache APISIX 
微服务架构极致性能架构解析](https://www.upyun.com/opentalk/440.html) .
+- 2019.8.31 [APISIX 技术选型、测试和持续集成](https://www.upyun.com/opentalk/433.html) .
+- 2019.8.31 [APISIX 高性能实战2](https://www.upyun.com/opentalk/437.html) .
+- 2019.7.6 [APISIX 高性能实战(Chinese)](https://www.upyun.com/opentalk/429.html) .
 
 Review comment:
   These links already contain text content ^_^


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] juzhiyuan commented on issue #679: bug: apisix/dashboard don't support array type for the schema in plugins

[GitBox]

juzhiyuan commented on issue #679: bug: apisix/dashboard don't support array 
type for the schema in plugins
URL: 
https://github.com/apache/incubator-apisix/issues/679#issuecomment-547784074
 
 
   
![image](https://user-images.githubusercontent.com/2106987/67840080-073dbf80-fb30-11e9-9703-cb1bd43f226f.png)
   
   create succeed :) Dashboard will be updated today.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis merged pull request #758: doc: added a new speech link and dropped `node-status` api doc.

[GitBox]

membphis merged pull request #758: doc: added a new speech link and dropped 
`node-status` api doc.
URL: https://github.com/apache/incubator-apisix/pull/758
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] juzhiyuan opened a new pull request #52: Fix plugin has oneOf prop

[GitBox]

juzhiyuan opened a new pull request #52: Fix plugin has oneOf prop
URL: https://github.com/apache/incubator-apisix-dashboard/pull/52
 
 
   resolve https://github.com/apache/incubator-apisix/issues/679


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] juzhiyuan closed issue #679: bug: apisix/dashboard don't support array type for the schema in plugins

[GitBox]

juzhiyuan closed issue #679: bug: apisix/dashboard don't support array type for 
the schema in plugins
URL: https://github.com/apache/incubator-apisix/issues/679
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #52: Fix plugin has oneOf prop

[GitBox]

juzhiyuan merged pull request #52: Fix plugin has oneOf prop
URL: https://github.com/apache/incubator-apisix-dashboard/pull/52
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on issue #679: bug: apisix/dashboard don't support array type for the schema in plugins

[GitBox]

membphis commented on issue #679: bug: apisix/dashboard don't support array 
type for the schema in plugins
URL: 
https://github.com/apache/incubator-apisix/issues/679#issuecomment-547792714
 
 
   Cool, nice job!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] yy8866 opened a new issue #761: bug: 三级泛解析路由规则无法匹配

[GitBox]

yy8866 opened a new issue #761: bug: 三级泛解析路由规则无法匹配
URL: https://github.com/apache/incubator-apisix/issues/761
 
 
   ### Issue description
   
   
   ### Environment
   
   * apisix version (cmd: `apisix version`):master
   * OS:docker
   
   ### Minimal test code / Steps to reproduce the issue
   `
   {"node":{"nodes":[
   
{"value":{"host":"lnp-admin.test.com","plugins":{},"uri":"\/*","service_id":"0070","desc":"lap-admin-test"},"createdIndex":77,"key":"\/apisix\/routes\/0077","modifiedIndex":77},
   
{"value":{"host":"apisix.test.com","plugins":{},"uri":"\/apisix\/*","service_id":"0035","desc":"apisix.zhu"},"createdIndex":47,"key":"\/apisix\/routes\/0038","modifiedIndex":47},
   
{"value":{"host":"lap.test.com","plugins":{},"uri":"\/*","service_id":"0065","desc":"lap-test"},"createdIndex":74,"key":"\/apisix\/routes\/0074","modifiedIndex":74},
   
{"value":{"host":"lnp.test.com","plugins":{},"uri":"\/*","service_id":"0066","desc":"lnp-test"},"createdIndex":75,"key":"\/apisix\/routes\/0075","modifiedIndex":75},
   
{"value":{"host":"lap-admin.test.com","plugins":{},"uri":"\/*","service_id":"0071","desc":"lap-admin-test"},"createdIndex":76,"key":"\/apisix\/routes\/0076","modifiedIndex":76},
   
   ## 下面2条是可以匹配到的 ##
   
{"value":{"host":"yhs.demo.test.com","plugins":{},"uri":"\/*","service_id":"0065","desc":"yhs-demo-test-com"},"createdIndex":80,"key":"\/apisix\/routes\/0080","modifiedIndex":80},
   
{"value":{"host":"pma.demo.test.com","plugins":{},"uri":"\/*","service_id":"0066","desc":"pma-demo-test-com"},"createdIndex":98,"key":"\/apisix\/routes\/0097","modifiedIndex":98},
   ##
   
   ##注意这里（匹配不上）:如果试用test2.demo.test.comq去访问，匹配不到，直接用cdnserver那条路由了##
   
{"value":{"host":"*.demo.test.com","plugins":{},"uri":"\/*","service_id":"0066","desc":"*-demo-test-com"},"createdIndex":98,"key":"\/apisix\/routes\/0098","modifiedIndex":99},
   ##
   
   
{"value":{"host":"apisix.fu-miao-jupincu-sh.zihao.gs","plugins":{},"uri":"\/apisix\/*","service_id":"0035","desc":"apisix-fu"},"createdIndex":48,"key":"\/apisix\/routes\/0046","modifiedIndex":48},
   
{"value":{"host":"portainer.test.com","plugins":{},"uri":"\/*","service_id":"0058","desc":"portainer-test"},"createdIndex":59,"key":"\/apisix\/routes\/0059","modifiedIndex":59},
   
   ##上面没又匹配到转到cdnserver##
   
{"value":{"plugins":{},"service_id":"0092","desc":"cdnserver","uri":"\/*"},"createdIndex":93,"key":"\/apisix\/routes\/0067","modifiedIndex":93}]
   ##
   
,"modifiedIndex":10,"createdIndex":10,"key":"\/apisix\/routes","dir":true},"action":"get"}
   
   
   `
   
   ### What's the actual result? (including assertion message & call stack if 
applicable)
   
   
   
   ### What's the expected result?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] yy8866 commented on issue #761: bug: 三级泛解析路由规则无法匹配

[GitBox]

yy8866 commented on issue #761: bug: 三级泛解析路由规则无法匹配
URL: 
https://github.com/apache/incubator-apisix/issues/761#issuecomment-547808383
 
 
   ## ps： 
   router:
   http: 'radixtree_host_uri'   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] yy8866 commented on issue #761: bug: 三级泛解析路由规则无法匹配

[GitBox]

yy8866 commented on issue #761: bug: 三级泛解析路由规则无法匹配
URL: 
https://github.com/apache/incubator-apisix/issues/761#issuecomment-547809455
 
 
   理论上*.xxx.xxx.com的优先级是应该大于host为空的那条路由的。实际使用中上优先匹配了空host的那条路由


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] lilien1010 opened a new pull request #762: Bugfix: change dir apisix into incubator-apisix

[GitBox]

lilien1010 opened a new pull request #762: Bugfix: change dir  apisix into 
incubator-apisix
URL: https://github.com/apache/incubator-apisix/pull/762
 
 
   Bugfix: change dir  apisix into incubator-apisix
   
   ### Summary

   Makefile



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] lilien1010 opened a new issue #763: bug: luarocks install apisix fail due to dirname error

[GitBox]

lilien1010 opened a new issue #763: bug: luarocks install apisix fail  due to 
dirname error
URL: https://github.com/apache/incubator-apisix/issues/763
 
 
   ### Issue description
when I install apisix from luarocks ,it failed,
   ```shell
   cd `mktemp -d /tmp/apisix.XX` && \
   git clone https://github.com/apache/incubator-apisix.git && \
   cd apisix && \
   git submodule update --init --recursive && \
   cp -r dashboard/* /usr/local/apisix/dashboard
   Cloning into 'incubator-apisix'...
   ^H/bin/sh: cd: line 3: can't cd to apisix: No such file or directory
   make: *** [Makefile:93: install] Error 2
   ```
   ### Environment
   
   * apisix version (cmd: `apisix version`): master

   
   ### What's the expected result?
   install sucess


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] lilien1010 commented on issue #762: Bugfix: change dir apisix into incubator-apisix

[GitBox]

lilien1010 commented on issue #762: Bugfix: change dir  apisix into 
incubator-apisix
URL: https://github.com/apache/incubator-apisix/pull/762#issuecomment-547831572
 
 
   fix bug: https://github.com/apache/incubator-apisix/issues/763


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services