Some Small Potential Changes
Hi
My name is Christian Gross and I would like to submit a couple of
small changes to the APR. (That is of course if my changes are
correct.)
APR_Pools.c starting line 217
#ifdef ALLOC_STATS
// *** start changes
#ifdef _WIN32
static unsigned __int64 num_free_blocks_calls;
static unsigned __int64 num_blocks_freed;
#else
static unsigned long long num_free_blocks_calls;
static unsigned long long num_blocks_freed;
#endif
// *** end changes
I made the changes because the VC++ 6.0 compiler does not understand
long long, but understands the __int64 data type.
win32\threadpriv.c line 62
APR_DECLARE(apr_status_t) apr_threadkey_private_create(apr_threadkey_t
**key,
void (*dest)(void
*),
apr_pool_t *cont)
{
// start changes *
(*key) = (apr_threadkey_t *)apr_palloc(cont,
sizeof(apr_threadkey_t));
(*key)-cntxt = cont;
// end changes *
if (((*key)-key = TlsAlloc()) != 0x) {
return APR_SUCCESS;
}
return apr_get_os_error();
}
I made the above changes because from having looked at the source code
the pattern is to allocate the pointer in a apr_***_create routine.
I would also like to offer some help in the win32 part of the APR.
For example I noticed that win32 does not have any shared memory
support. And since our company uses processes and not threads on W2K
we have used another open source package.
Christian Gross
Re: cvs commit: apr configure.in
On Saturday, April 7, 2001, at 07:31 AM, Jeff Trawick wrote: But APR_FLAG_HEADERS() can't handle that header file because the variable name it generates is invalid. We're getting this on stderr from configure: /home/trawick/apache/httpd-2.0/srclib/apr/configure: mach-o_dyldh=0: command not found Surely you're getting this error too on Darwin and APR still doesn't realize that you have this header file. Nope, I didn't get that error; my build went just fine. This sounds like an autoconf bug... It's certainly a legal header name. Mine generated HAVE_MACH_O_DYLD_H (replaced the - with _). I didn't notice this lowercase variable. What verion of autoconf are you using? I have 2.13. -Fred
[PATCH] --with-libtool option not specified error
On FreeBSD-4.2-RELEASE (possibly more), it looks like the case when --with-libtool is not specified (should implictly use libtool in this case) is out of sync with the --with-libtool case. This patch makes the case when --with-libtool is not specified identical to when it is specified. Otherwise, libapr.a is never built and nothing builds properly. -- justin Index: configure.in === RCS file: /home/cvspublic/apr/configure.in,v retrieving revision 1.280 diff -u -r1.280 configure.in --- configure.in2001/04/07 01:02:31 1.280 +++ configure.in2001/04/07 18:29:52 @@ -108,8 +108,9 @@ so_ext=o fi ], [ lt_compile=\$(LIBTOOL) --mode=compile \$(LTFLAGS) \$(COMPILE) -c \$ touch $@ - link=\$(LIBTOOL) --mode=link \$(LTFLAGS) \$(COMPILE) \$(LDFLAGS) -o \$@ + link=\$(LIBTOOL) --mode=link \$(LTFLAGS) \$(COMPILE) \$(LDFLAGS) -o \$@ -rpath \$(libdir) \$\$objects so_ext=lo + lib_target=\$(libdir) \$\$objects ] ) AC_SUBST(lt_compile) AC_SUBST(link)
Re: cvs commit: apr configure.in
Wilfredo Sanchez [EMAIL PROTECTED] writes: But APR_FLAG_HEADERS() can't handle that header file because the variable name it generates is invalid. We're getting this on stderr from configure: /home/trawick/apache/httpd-2.0/srclib/apr/configure: mach-o_dyldh=0: command not found Actually, the difference is probably my shell being wonky and not autoconf. Does this patch fix your problem? What you committed is great. Thanks! -- Jeff Trawick | [EMAIL PROTECTED] | PGP public key at web site: http://www.geocities.com/SiliconValley/Park/9289/ Born in Roswell... married an alien...
Re: resolver issues
jean-frederic clere [EMAIL PROTECTED] writes: Hi, I have some problems with PHP3 because of res_search, dn_skipname and dn_expand. My first idea was to search for apr_res_search, apr_dn_skipname and apr_dn_expand, but it did not help. Is there a place in APR for these resolver things? These resolver things bring with them a resolver in order to work on systems that don't have res_search() et al already. Ouch! -- Jeff Trawick | [EMAIL PROTECTED] | PGP public key at web site: http://www.geocities.com/SiliconValley/Park/9289/ Born in Roswell... married an alien...
